Summary: Taking on the feedback from the demo yesterday, I've improved the required parameter's dialog by showing where specific errors occur in the form and adding live editing to the URI displayed.
Reviewed By: danielbuechele
Differential Revision: D16802921
fbshipit-source-id: 2e729549306a8efb79ca76d3da6f70632ccd9212
Summary:
Here I've added the LocationsButton to the TitleBar in Flipper. This allows the user to navigate to saved bookmarks, or display the current page URI without ever opening the Navigation Plugin (Except to add bookmarks). The challenge of this diff was having a TitleBar child be controlled by a plugin.
The LocationsButton pulls bookmarks straight from the database whenever a mouseDown event is called on the button. (The Electron popup menu does not respond to props changes, so the menu is opened on mouse up and getting the bookmarks from the database occurs on mouse down... This seems to work fine).
The nav plugin on the Android side will now also send a welcome message alerting the app to created a persisted state for the navigation plugin, which shows the button in the TitleBar.
Let me know if I can answer any questions.
Reviewed By: danielbuechele
Differential Revision: D16786330
fbshipit-source-id: afc95348d9b7ec4ee041f42bb4d022f58c6bb969
Summary:
Had to mess with the tagged union we had, to distinguish based on
a string rather a bool which is a bit rubbish.
Reviewed By: danielbuechele
Differential Revision: D16764797
fbshipit-source-id: c33536f17b0705ca40abef8448802f9961c4c114
Summary:
Initial commit for Flipper API for JS apps:
1) Plugin, Connection, Client
2) a bridge to work with WebView proxy app
3) examples of ported plugins: AnalyticsLogging and Fury
Reviewed By: danielbuechele
Differential Revision: D16753405
fbshipit-source-id: cdd4b863db236b2043f09833aed130035f6738de
Summary: These get generated by VSCode if you have java installed and open the flipper project.
Reviewed By: danielbuechele
Differential Revision: D16763411
fbshipit-source-id: 40c7d943ee2ee32cf70f9aea080f5e44716e5651
Summary: N.B. There was one duplicate definition which TS rightfully complained about.
Reviewed By: danielbuechele
Differential Revision: D16764036
fbshipit-source-id: 498e4703c2363b19a3bdfa44527bde5000034095
Summary: Currently cancelling the flipper export logs the event as a failure. This diff introduces one more event log type called cancelled.
Reviewed By: jknoxville
Differential Revision: D16711110
fbshipit-source-id: 308b7e64974610dbb17bd14b2425f6d939c99313
Summary:
When a user enters a uri with optional parameters in the nav bar, I chose to automatically filter these out, yet still show the parameters in the nav bar.
The device receive uri's with no optional parameters, but the user will still see the parameters in the UI.
Reviewed By: danielbuechele
Differential Revision: D16762529
fbshipit-source-id: e3bbdf886dca7fba793b140b5fb303c4a77926ba
Summary:
Pritesh and I both decided to re-add these functions without knowing that the other person had already re-added them.
Got through to master and now master won't build.
Reviewed By: priteshrnandgaonkar
Differential Revision: D16762774
fbshipit-source-id: 4a05d9e03cb043a6f398f57f2652a3ec15bd8985
Summary: Fixed issue with the timeline not having a key prop, and added some text when there are no navigation events.
Reviewed By: jknoxville, passy
Differential Revision: D16762034
fbshipit-source-id: 8f4618c8365c1a8b5a18b6176e1d80fc401f3ca5
Summary:
This isn't used anywher at the moment but I plan to add it in once we are finished with TS migration.
Migrated this file from LocationsButton.js to LocationsButton.ts
Reviewed By: jknoxville
Differential Revision: D16730904
fbshipit-source-id: d357785c462b1f5f6017b4c00a2d2467d905b895
Summary: This file is not used in the project and has been replaced by different logic in the DevicesButton.
Reviewed By: passy
Differential Revision: D16730618
fbshipit-source-id: b41c9dcef44690fee1331da2e3d66aa9e1394bad
Summary:
Some uris parsed from the device contain required parameters. Here we parse the uri and check if there is a required parameter on navigation. If there is we alert the user to correct the error.
In the next diff, I will strip away non-required parameters if they are present but not filled in.
Reviewed By: danielbuechele
Differential Revision: D16710944
fbshipit-source-id: ea32cfe60e2bb5e4f395caebf585ba1b220dcefe
