Summary:
When an operation fails, we have an error message. This was being displayed in the diagnostic screen output, but not included in the debug log.
This makes them both have same bahaviour, so they both include the error messages.
Reviewed By: passy
Differential Revision: D17181847
fbshipit-source-id: 823f73d641d2315da86a0019479716852950f9a5
Summary:
I've added in a timeline line. Getting the CSS for this to work perfectly was tricky, but in the end this result looks pretty good. I've opted for the unknown events to have a smaller circle.
Edit:
I have fixed the border radius issue with the img element:
{F206482232}
And Unknown events are better aligned:
{F206482255}
Reviewed By: jknoxville
Differential Revision: D17180819
fbshipit-source-id: c318d2721adde758494267095524961c796f7a54
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/538
Upgrades libevent to the August release 2.1.11.
Some notable things:
- The CMake file they ship with is actually broken. It contains a reference to an "uninstall.cmake" script that they don't include in the archive.
- There is some git magic in the CMake script which throws very annoying warnings if you're not in a git repository and if you are, it's still super useless because it assumes it's the libevent repo.
- I've removed the uninstall reference and replaced version detection magic with hardcoded values. The result is the "CMakeLists.txt" in the overrides folder. For future upgraders: You'll have to either remove the override or apply similar steps to the next release.
- The `event-config.h` is simply one of the outputs I found under `android/build/libevent/x86/include/event2/event-config.h`. They seem to be stable across architectures so it's easier to just copy it over than to fix the CMake logic that should actually pick it up from the Android build path.
- The cmake target names have changed and have an underscore in them, now.
- Verified with an SDK 28 x86_64 that this does fix https://github.com/facebook/flipper/issues/482.
Fixes GH482.
Reviewed By: jknoxville
Differential Revision: D17164731
fbshipit-source-id: 642744118065bea2674dbb0e1af91a11598066cc
Summary:
Seems to be a new thing from the Android Build system
and it's quite annoying.
Reviewed By: jknoxville
Differential Revision: D17163339
fbshipit-source-id: 938264d301e7546a4a6e3276e91184ab5498a833
Summary:
Don't fatal when trying to send a message to flipper that is too large.
Instead just continue to throw an exception, so the plugin will still be aware of the failure.
Reviewed By: cpojer, danielbuechele
Differential Revision: D17180334
fbshipit-source-id: 49c341a7cee579158be3878639083c6d19b3eaa3
Summary: You need to use a type guard when narrowing types in a filter.
Reviewed By: danielbuechele
Differential Revision: D17163782
fbshipit-source-id: aa78bdd392653ebf1080a04e62e131b607e5181b
Summary:
This is a UI ovehaul for the Navigation plugin, taking inspiration from the Notifications page in Flipper.
We now display a timestamp, open page and bookmark are more clearly identified, screenshots are organized more neatly, and parameters are displayed in a table.
If the class name of the ViewController is available, that will also be displayed.
Edit:
Adding in some of the requested changes.
Improved UI:
https://pxl.cl/K0h9
Scroll on opening a page:
https://pxl.cl/K0hQ
Reviewed By: danielbuechele
Differential Revision: D17161734
fbshipit-source-id: e5e054bf87f540964e90da3a798fd0c23df86540
Summary:
This makes the implementation of static view generic. Right now the only non-plugin view which is shown is the WelcomeScreen. The implementation it is hardcoded. I want to make it generic, so that we can show the bug request screen too.
This diff sets the default value of the `staticView` to `WelcomeScreen`, which will be set to null when the `selectedDevice` is set. And viceversa, it will be assigned back to `WelcomScreen`, when the `selectedDevice` is set to `null`
Reviewed By: danielbuechele
Differential Revision: D16965734
fbshipit-source-id: 69d700184f44d4e5ab531f5f8fc0e23bafa07e72
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/530
Use the pre-release of fbjni instead of our bundled copy. I hope this can be made a little less awkward, but it works for now.
Reviewed By: jknoxville
Differential Revision: D16988077
fbshipit-source-id: 936e414f9b2bf82ccb54b107228d79d01acdbf14
Summary: Android Studio suggests this in order to continue working properly.
Reviewed By: danielbuechele
Differential Revision: D17160910
fbshipit-source-id: fac638495d6aa194dca54ef72c1c9dca5ad42b73
Summary: Flipper should not depend on Yoga, since it already depends on Yogakit. Yogakit itself depends on Yoga anyway. Also, Flipper seems to use Yogakit APIs anyway.
Reviewed By: shergin
Differential Revision: D7185089
fbshipit-source-id: 69f7e030999041be7a007b9ca56c529f8c1ae121
Summary: Migrate CPU plugin to use TypeScript
Reviewed By: danielbuechele
Differential Revision: D17072709
fbshipit-source-id: d9acf172af08d764216e7b79b79994199dc83f5c
Summary:
It's not obvious how to run the headless tests at the moment, and requires manual steps this adds a script to do it.
It still does not start an emulator or the sample app, but it's an improvement.
Reviewed By: passy
Differential Revision: D17155308
fbshipit-source-id: 846b87389823f422030470807aa4aabacce69179
Summary:
Generics on static methods don't seem to work the way we are using them.
I looked into how react types getDerivedStateFromProps as this is a very similar concept, and they don't seem to type it at all. For that reason I've given up and just type the persistedState passed to our static methods as `Object`.
Reviewed By: passy
Differential Revision: D17152767
fbshipit-source-id: d9c2159be26fa341c5411dd0b40895d4c8ddf71e
Summary:
Logs plugin expected the default icons size to be 16 and therefor didn't set it explicitly. However, with the TS migration we lost the default size.
This adds back the default size for icons.
Reviewed By: jknoxville
Differential Revision: D17156747
fbshipit-source-id: a37f3a2bd189a56019aee1939618caf21122a397
Summary: Added a wiki page with some more strict mode info.
Reviewed By: danielbuechele
Differential Revision: D17112391
fbshipit-source-id: 53b9e8d417eb9f41adecab42fbf912b999a0c9c3
Summary: I've made some slight changes to how bookmarks are displayed in the app, and added the ability to remove them from the tab.
Reviewed By: danielbuechele
Differential Revision: D17154083
fbshipit-source-id: 587e1e0f6f79f461c92e4866f4a59608a6173ccb
Summary:
Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2.
<details>
<summary>Commits</summary>
- [`754f0c2`](754f0c20e1) 1.3.2
- [`90ee1fa`](90ee1fab37) ensure keys are valid when mixing in values
- See full diff in [compare view](https://github.com/jonschlinkert/mixin-deep/compare/1.3.1...1.3.2)
</details>
<details>
<summary>Maintainer changes</summary>
This version was pushed to npm by [doowb](https://www.npmjs.com/~doowb), a new releaser for mixin-deep since your current version.
</details>
<br />
[](https://help.github.com/articles/configuring-automated-security-fixes)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/flipper/network/alerts).
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/529
Reviewed By: danielbuechele
Differential Revision: D17095288
Pulled By: passy
fbshipit-source-id: 6433300f18828c7e7c117e25821b69c6b6fb5def
Summary: This functionality already existed in FlexColumn by adding the prop grow.
Reviewed By: danielbuechele
Differential Revision: D17132219
fbshipit-source-id: d284f2c5e219beff743525abd344a8b9d1955d0b
Summary: Luckily I put all my types in one file, so this was very easy to convert over.
Reviewed By: danielbuechele
Differential Revision: D17132226
fbshipit-source-id: cacd0d66e15504d6f82ccc4aaaa4e27339e513f1
