Summary: Migrate to new server event which allows troubleshoot
Reviewed By: passy
Differential Revision: D47875977
fbshipit-source-id: 2549bef6ebb26660176747d44e3f535ad9f1d213
Summary: Reuse the function that was refactored on previous diff.
Reviewed By: antonk52
Differential Revision: D47873752
fbshipit-source-id: 71e12cd34d1826080487297e308450cb2a2a5c26
Summary:
Extract notification creation from inside the existing function.
This will be reused to display connection notifications from the server event.
Reviewed By: antonk52
Differential Revision: D47873728
fbshipit-source-id: c01dc93dfef28135ecf7e77e92d4d517af082125
Summary:
There's a generic notification server event.
This change introduces a new notification server event dedicated for connection troubleshoot.
The difference is, this notification will have a button to troubleshoot the issue. Additionally, in the future, we may even be able to add a payload so that we can troubleshoot the exact problem.
Reviewed By: antonk52
Differential Revision: D47873697
fbshipit-source-id: 28843a08836d0054909f6b9ab7a88b14b8a1b868
Summary: Add key for server error notifications as to prevent duplicates.
Reviewed By: antonk52
Differential Revision: D47869240
fbshipit-source-id: 7c826ab07a8f92bd053200786ed990ad78bbfa67
Summary: If the notification is shown, allow engineers to switch to the connectivity troubleshooting view as it may highlight where the problem is.
Reviewed By: antonk52
Differential Revision: D47869154
fbshipit-source-id: f4154bb230d891dc4ac108b5acbe7e6541ffed1a
Summary:
The intention was to fine tune everything, internally, before making it available.
Because we can immediately benefit from having it, for troubleshooting, then remove the GK
Reviewed By: LukeDefeo, antonk52
Differential Revision: D47868827
fbshipit-source-id: 4d6356081a4abeea8912f20aad065523e7183da8
Summary:
Intention of this change is to simplify and standardise the way top level selection is done.
Top level selection is now part of the state, and thus setting it is done in the reducer instead.
Reviewed By: antonk52
Differential Revision: D47844742
fbshipit-source-id: 8e5aad8975f0046b85098b988cca40228316c249
Summary: Add a key such that the same notification does not appear again for the same device/app.
Reviewed By: antonk52
Differential Revision: D47835045
fbshipit-source-id: 78237b4102aa199ebea23b7c5726b567fc4de91e
Summary: This is needed on Windows, otherwise it just throws an error when using spawn.
Reviewed By: passy
Differential Revision: D47832379
fbshipit-source-id: c1a5094c2e72683a695949cd99b2a1054f01aced
Summary: Just adds a function stub that will add the necessary run script for windows.
Reviewed By: passy
Differential Revision: D47627532
fbshipit-source-id: 09b6a203c2a5def20e586b5753d95ca58797852a
Summary: Refactor was going to happen, but it was required at this stage as to fix a selection problem.
Reviewed By: LukeDefeo
Differential Revision: D47831239
fbshipit-source-id: 87ce6250721f6d3df3e826e779409625ddc85660
Summary: Once an item is selected, more details can be shown to our users.
Reviewed By: antonk52
Differential Revision: D47797390
fbshipit-source-id: 1bf98f81df32d103f7c0fc332f819507dcf84cc2
Summary:
Some commands are run without a ClientQuery i.e. fetching devices.
Nevertheless, this can be provide insights when problems take place.
Reviewed By: antonk52
Differential Revision: D47795358
fbshipit-source-id: 0b7dc34475ae061f1b72843a087a798d305ed1c8
Summary:
Now that we have panels for tree visualiser separately we can have visualiser specific controls. There is a dedicated button for focus mode which should make that more discoverable and a better implementation of target mode which uses a slider. This has several benefits:
1. more discoverable
2. more obvious what is going on with the text prompts and a real slider control instead of mouse enter
3. there is no context menu getting in the way of the content
Changelog: UIDebugger Add visualizer target mode feature for selecting views in the z stack easily
Changelog: UIDebugger Add FocusMode button to visualiser toolbar
Reviewed By: mweststrate
Differential Revision: D47671658
fbshipit-source-id: 6f657f9d417280627457624660b934c9898cda58
Summary: This isnt very discoverable and we can put functionality in the toolbar
Reviewed By: mweststrate
Differential Revision: D47670683
fbshipit-source-id: 8426ba05135f9a56f0a0952e94ac80480cd30a48
Summary: This looks a lot neater and allows us to have separate dedicated visualiser header
Reviewed By: mweststrate
Differential Revision: D47626867
fbshipit-source-id: 843721853e0ff88837afbb9bf3f510a908160d12
Summary:
1. Add indent guidess to all tree depths
2. Monospaced font
3. cleaned up alignment of icons
4. Gave everything a bit more space to breathe
Changelog: UI Debugger Tree UI refresh, added indent guides and fixed alignment
Reviewed By: mweststrate
Differential Revision: D47626869
fbshipit-source-id: e4509621cda6c254f7dd5a7ec9b99c13efb577f4
Summary:
The old layout plugins target mode would ask you which view you wanted to select when you clicked, the visualiser currently chooses for you based on size of the element.
Sometimes this isnt what you want so I have added a context menu with all the intersecting nodes from which you can select or focus
Reviewed By: lblasa
Differential Revision: D47589789
fbshipit-source-id: 9c9d0d7587b830aa72089267d9bcf2b687142574
Summary:
With a lot of virtual devices it can be confusing to remember which one contains your builds. This allows user to favourite certain ones to avoid this
Changelog: Added ability to favourite emulators / simulators in the launch virtual devices dialog
Reviewed By: mweststrate
Differential Revision: D47724521
fbshipit-source-id: aaec56608ad6ba23634797315f6f9fd77fc8b258
Summary:
1. fixed state when no connectivity by using a disabled button, now its styled correctly, (before it was tiny)
2. No need to show the user profile button as its own icon since log in is forced by flipper, so move log out into the more menu
Reviewed By: mweststrate
Differential Revision: D47720740
fbshipit-source-id: c7531a2a2897627c2627080179fd77adfed5c30c
Summary:
1. improved the disabled state, no longer shows persistant border
2. made the right sidebar button always visible again since the disabled state is less distracting
3. Made the toggle state be on when the side bar is open
4. Fixed issue where where it would say toggled when sidebar not visible
5. Shortened the names to be less verbose
Reviewed By: mweststrate
Differential Revision: D47720739
fbshipit-source-id: df27e688c7a66e8dee07c4db675851c4355b41db
Summary: Similar treatment to troubleshoot problem
Reviewed By: lblasa
Differential Revision: D47720741
fbshipit-source-id: 6875988a9a0763cb4ed473d6e8522581fc27bef3
Summary: Exception showed up in our monitoring. The only `.sort` that happens in that request/response sequence is the one updated. Didn't get to the root of this, but likely the plugin returns nothing rather than an empty array when no databases present?
Reviewed By: LukeDefeo
Differential Revision: D47665268
fbshipit-source-id: 3f8dea591db3e6cb5d4e0d09f893a177ad4f642e
Summary:
I introduced this to stop the visualiser going off while the framework events modal was open. However on mouse leave fires when the context menu is open. and if you click to focus then it never refires.
Also renamed the ref to make it clearer
Reviewed By: lblasa
Differential Revision: D47550672
fbshipit-source-id: 62e108e55e5c42a37d3aebded6467ececdc458df
Summary:
Previously we were registering a click handler with every single div in the visualiser. This is somewhat wasteful as well as was causing issues since i needed to call stop propagation to prevent the click bubbling and selecting all the parents too.
as a result of stop propagation the context menu behaviour was weird, when left clicking elsewhere to close the context menu it wouldnt work as the click was swallowed by the click handlers for the nodes.
Now we have a much simpler system. The hovered overlay is the click handler. Thats it.
Another benefit of this is the visualisation nodes under the overlays are all interaction less so they can be moved to canvas one day if need be
Reviewed By: lblasa
Differential Revision: D47550673
fbshipit-source-id: 1a607059c68f0b936f0184bd98a6a1492703d41b
Summary: The previous names made no sense after they drifted over time
Reviewed By: lblasa
Differential Revision: D47550916
fbshipit-source-id: fa7df17b090c52b68ab4af9388d87365da6e8ff3
Summary: preparing to split this up a bit
Reviewed By: lblasa
Differential Revision: D47548840
fbshipit-source-id: 907b9cd6a7a044e4aad97f9755fd9b43b81768f1
Summary:
This file was huge and was hard to understand what was going on. changes:
1. UIActions moved out to separate file
2. create UIstate moved out
3. All declared state (atoms or plain js objects) moved to the top of the function like a class
4. utilities moved out
Reviewed By: lblasa
Differential Revision: D47547844
fbshipit-source-id: e7fa705a14a23bff2415016a488147bed7ad9e91
Summary:
Currently state writes can either go through a named handler that is easy to find and debug or they can directly modify the state.
By exposing readonly atoms only we ensure that all state writes go through a UIACtions. This adds consistency and ease of future debugging.
E.g We could add a utility to wrap all ui actions with logging statements
Reviewed By: antonk52
Differential Revision: D47547531
fbshipit-source-id: f88651169d8e7c5f7e31068d64f9aa5b6b573647
