Summary:
This diff updates the sidebar to show the recommended and all build types.
Also there is error handling in place along with tests. Right now the download happens by opening browser and the build gets downloaded in the download folder. But later in the diffs I will improve this flow to do that in the Flipper with a UX showing status updates.
Reviewed By: mweststrate
Differential Revision: D21556383
fbshipit-source-id: 6de9a00fe416c22cae7bacf91828a2221644eac7
Summary: FileSelector was added in D19743998, but it was not exported to be used by other. This diff exports it so that developers can use.
Reviewed By: mweststrate
Differential Revision: D21653870
fbshipit-source-id: 062247fa7a14c7ddf87c927205880a695598928d
Summary: Flipper website contains some trash unused test webpages which are not accessible from the root page and can be removed.
Reviewed By: jknoxville
Differential Revision: D21642872
fbshipit-source-id: 3d1f9f1d8591fc0ad3b3b18e8fd54bd92a13db59
Summary:
Bumps [jest-fetch-mock](https://github.com/jefflau/jest-fetch-mock) from 3.0.0 to 3.0.3.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/jefflau/jest-fetch-mock/commits">compare view</a></li>
</ul>
</details>
<br />
[](https://dependabot.com/compatibility-score/?dependency-name=jest-fetch-mock&package-manager=npm_and_yarn&previous-version=3.0.0&new-version=3.0.3)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.
You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme
Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1173
Reviewed By: mweststrate
Differential Revision: D21625501
Pulled By: cekkaewnumchai
fbshipit-source-id: ded86d46fca24265d09b6f7ec8b77f9cb845a825
Summary:
Bumps [chalk](https://github.com/chalk/chalk) from 3.0.0 to 4.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/chalk/chalk/releases">chalk's releases</a>.</em></p>
<blockquote>
<h2>v4.0.0</h2>
<h3>Breaking</h3>
<ul>
<li>Require Node.js 10 61999a4</li>
<li>Change the <code>Level</code> TypeScript type to be a union instead of enum f0f4638</li>
</ul>
<pre lang="diff"><code>-if (chalk.level > Level.None) {}
+if (chalk.level > 0) {}
</code></pre>
<h3>Improvements</h3>
<ul>
<li>Use <code>Object.setPrototypeOf</code> as <code>__proto__</code> could potentially be disabled (<a href="https://github-redirect.dependabot.com/chalk/chalk/issues/387">https://github.com/facebook/flipper/issues/387</a>) 63469d3</li>
</ul>
<p><a href="https://github.com/chalk/chalk/compare/v3.0.0...v4.0.0">https://github.com/chalk/chalk/compare/v3.0.0...v4.0.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="31fa942080"><code>31fa942</code></a> 4.0.0</li>
<li><a href="61999a4e77"><code>61999a4</code></a> Require Node.js 10</li>
<li><a href="f0f4638a92"><code>f0f4638</code></a> Change the TypeScript <code>Level</code> type to be a union instead of enum</li>
<li><a href="7f21f209da"><code>7f21f20</code></a> Properly check if <code>level</code> is an integer (<a href="https://github-redirect.dependabot.com/chalk/chalk/issues/393">https://github.com/facebook/flipper/issues/393</a>)</li>
<li><a href="63469d30e4"><code>63469d3</code></a> Use <code>Object.setPrototypeOf</code> as <code>__proto__</code> could potentially be disabled (<a href="https://github-redirect.dependabot.com/chalk/chalk/issues/387">https://github.com/facebook/flipper/issues/387</a>)</li>
<li><a href="797461ee32"><code>797461e</code></a> Meta tweaks</li>
<li><a href="0e6fecc7f7"><code>0e6fecc</code></a> Add link to replit run (<a href="https://github-redirect.dependabot.com/chalk/chalk/issues/379">https://github.com/facebook/flipper/issues/379</a>)</li>
<li>See full diff in <a href="https://github.com/chalk/chalk/compare/v3.0.0...v4.0.0">compare view</a></li>
</ul>
</details>
<br />
[](https://dependabot.com/compatibility-score/?dependency-name=chalk&package-manager=npm_and_yarn&previous-version=3.0.0&new-version=4.0.0)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.
You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme
Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1176
Reviewed By: mweststrate
Differential Revision: D21625536
Pulled By: cekkaewnumchai
fbshipit-source-id: 88a174f4db562b397ad9d70b73909e5eb70cfce5
Summary:
Fixed the layout usage in QPL, the `horizontal` was correct, but the elements where swapped (the table was supposed to take all remaining size, and sidebar it's needed space, rather than the reverse).
Made this more explicit in the Layout component, by splitting it up in `Layout.(Top|Left|Right|Bottom)`, so that one has to make an explicit choice here, making it less error prone.
Reviewed By: passy
Differential Revision: D21572438
fbshipit-source-id: 29aa3462a3c96d048825be3157730e26182cb2fa
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1177
Reviewed By: passy
Differential Revision: D21642302
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 7019861e07e0a467eb40cb5d1cf1e109466e38f9
Summary: Discovered in https://fburl.com/h6eczhr2; the highlight didn't get removed correctly. This was from [this method](https://fburl.com/diffusion/twur28gt), which must be called on main thread to be executed completely.
Reviewed By: jknoxville
Differential Revision: D21629318
fbshipit-source-id: cfc52ac755a1ddfe92e675aac1a81066ce338bd7
Summary:
Encountered when trying to build the sample app on iOS. Seemed `initWithComponentProvider` is now for Swift only and cannot be called in Objective-C.
Change to call `initWithComponentProviderFunc` instead
Reviewed By: passy
Differential Revision: D21629319
fbshipit-source-id: bf39f67ad22259b9c72694e43c507f8869e7bf22
Summary:
As suggested in the previous diff, I change the way to store row values. Now, (kinda) raw values are stored instead of processed values that can be used directly for `ManagedTable`. This simplifies logic in detail sidebar.
I'm not sure what the effect to performance.
Reviewed By: mweststrate
Differential Revision: D21621896
fbshipit-source-id: 472be3caa955ca32f876f81095af21e9c17cb159
Summary:
This allows long text to be seen on the sidebar in database plugin. Also, remove weird padding in the sidebar and separate sidebar component to a new file
Refactoring is in the next diff
Reviewed By: mweststrate
Differential Revision: D21550672
fbshipit-source-id: 3e80be16783719e18392fe3d8f8068caf9283f8f
Summary: Freshly init-ed plugins are not picked up by Flipper if they are not on the search path. This diff checks if the current dir is on the search path, and, if not, suggests to add it.
Reviewed By: jknoxville
Differential Revision: D21619632
fbshipit-source-id: b1dbe2695dbee9ce537999dc83e36f969ba4b747
Summary:
Created a test that snapshots the generated files, so that we can capture accidental regressions when generating files.
Also made the package id to package name a bit more robust
Reviewed By: jknoxville
Differential Revision: D21619633
fbshipit-source-id: 88ffb127e050d840df9ccd4b15ba29a71f341975
Summary:
Although there are tools that do this for you (create-react-app, react-native), and other that assume you are already in the created directory before you invoke the command (typescript, git), creating the directory by the tool has a few benefits:
1. less risk of making an accidental mess when people assume they don't need to create the dir first (I definitely ended up with a node_modules in the wrong directory)
1. it provide a naive way of detecting plugin name conflicts early (at least for plugins you create yourself)
1. in the next diff I'll add a pkg suggestion to add the current directory to the search path for flipper plugins. In the current setup, that would require needing to suggest to add the parent directory, which somehow feels less logical
2. makes sure that the directory name follows npm conventions: the package.json name should match the current directory name (not super important, but e.g VSCode will show warnings otherwise)
Reviewed By: jknoxville
Differential Revision: D21619631
fbshipit-source-id: 6d027ad18f14659e0347a66cacf056eacbc65680
Summary:
Added a watch mode to the bundle command of flipper plugins. This makes it easy to test develop plugins locally, even when you are using a production build of flipper, which lowers the barrier of developing / fixing plugins.
opted for `fs.watch` over watchman to avoid some overengineering:
1. pkg / pkg-lib don't have the watchman utilities that would be needed for this. I wasn't sure if I could move those over from `static` without breaking the bootstrapping process
2. watchman is often a nuisance on non FB machines that aren't set up for it. fs.watch in contrast doesn't have any further dependencies or setup requirements, and is much more likely to work ootb.
3. since we watch only the `src` folder we don't really need the watchman optimizations. (so for a package.json change people would have to restart, but I don't think that is much of a problem).
Reviewed By: jknoxville
Differential Revision: D21523814
fbshipit-source-id: b1de72b7d01c6fc50cb8ce5709f54f8019eb89e4
Summary: See previous diff, should have merged those two diffs
Reviewed By: jknoxville
Differential Revision: D21523815
fbshipit-source-id: 3db91d06d845f0764e28f0dbf3020e77812cde53
Summary: When opening a freshly generated plugin in VScode the IDE would be full of errors, even though it can bundle correctly thanks to the defaults used by bundle. This is fixed by diff by correctly setting up a tsconfig.
Reviewed By: jknoxville
Differential Revision: D21523817
fbshipit-source-id: 8f6b58fbfb704460ddb5b845ddfb137b28d37187
Summary: By adding a build command the flipper plugin can be picked up, even when using a production build of Flipper, as we don't require Flipper's own infrastructure anymore to compile plugins.
Reviewed By: jknoxville
Differential Revision: D21523819
fbshipit-source-id: eed935ee95a7e3bff2ace629836b4b2450b5d1ad
Summary:
As soon as any data was send to a freshly generated plugin, the plugin would crash as React doesn't support directly rendering data. Replaced it with a poor mans rendering that simply dumps all the data we received.
Also made sure the view is scrollable now which wasn't the case before.
Reviewed By: jknoxville
Differential Revision: D21523816
fbshipit-source-id: 3e04799facdf8b66ce9d66217a47fc7826d58d43
Summary:
This stack contains a bunch of improvements I made to smoothen the demo of plugin creating in the Flipper + React Native talk.
With 98% likelihood people will manage the source code of their Flipper plugins in git. This will make sure the `.gitignore` is configured properly ootb
Reviewed By: nikoant
Differential Revision: D21523818
fbshipit-source-id: b2ed769edc8fb9fd320464b05686e817e438f21e
Summary:
Bumps [clap](https://github.com/clap-rs/clap) from 2.33.0 to 2.33.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/clap-rs/clap/releases">clap's releases</a>.</em></p>
<blockquote>
<h2>v2.33.1</h2>
<p><a name="v2.33.1"></a></p>
<h3>v2.33.1 (2020-05-11)</h3>
<h4>Bug Fixes</h4>
<ul>
<li>Windows: Prevent some panics when parsing invalid Unicode on Windows (<a href="922c645083">922c645</a>, closes <a href="https://github-redirect.dependabot.com/clap-rs/clap/issues/1905">#1905</a>)</li>
</ul>
<h4>Documentation</h4>
<ul>
<li>fixes versions referenced in the README (<a href="d307466af1">d307466a</a>)</li>
<li><strong>README.md:</strong>
<ul>
<li>cuts down the number of examples to reduce confusion (<a href="6e508ee09e">6e508ee0</a>)</li>
</ul>
</li>
</ul>
<h4>Improvements</h4>
<ul>
<li><strong>Deps:</strong> doesnt compile ansi_term on Windows since its not used (<a href="b57ee94609">b57ee946</a>, closes <a href="https://github-redirect.dependabot.com/kbknapp/clap-rs/issues/1155">https://github.com/facebook/flipper/issues/1155</a>)</li>
</ul>
<h4>Minimum Required Rust</h4>
<ul>
<li>As of this release, <code>clap</code> requires <code>rustc 1.36.0</code> or greater.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/clap-rs/clap/blob/v2.33.1/CHANGELOG.md">clap's changelog</a>.</em></p>
<blockquote>
<h3>v2.33.1 (2020-05-11)</h3>
<h4>Bug Fixes</h4>
<ul>
<li>Windows: Prevent some panics when parsing invalid Unicode on Windows (<a href="922c645083">922c645</a>, closes <a href="https://github-redirect.dependabot.com/clap-rs/clap/issues/1905">#1905</a>)</li>
</ul>
<h4>Documentation</h4>
<ul>
<li>fixes versions referenced in the README (<a href="d307466af1">d307466a</a>)</li>
<li><strong>README.md:</strong>
<ul>
<li>cuts down the number of examples to reduce confusion (<a href="6e508ee09e">6e508ee0</a>)</li>
</ul>
</li>
</ul>
<h4>Improvements</h4>
<ul>
<li><strong>Deps:</strong> doesnt compile ansi_term on Windows since its not used (<a href="b57ee94609">b57ee946</a>, closes <a href="https://github-redirect.dependabot.com/kbknapp/clap-rs/issues/1155">https://github.com/facebook/flipper/issues/1155</a>)</li>
</ul>
<h4>Minimum Required Rust</h4>
<ul>
<li>As of this release, <code>clap</code> requires <code>rustc 1.36.0</code> or greater.</li>
</ul>
<p><a name="v2.33.0"></a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="ffb8d552c2"><code>ffb8d55</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/clap-rs/clap/issues/1917">#1917</a> from clap-rs/v2.33.1</li>
<li><a href="7ac16ac5c7"><code>7ac16ac</code></a> chore: increase ver ref in lib.rs</li>
<li><a href="bc3291db8e"><code>bc3291d</code></a> chore: increase version on v2 branch</li>
<li><a href="922c645083"><code>922c645</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/clap-rs/clap/issues/1907">#1907</a> from oconnor663/windows_2.33</li>
<li><a href="703caf37c4"><code>703caf3</code></a> prevent some panics when parsing invalid Unicode on Windows</li>
<li><a href="0129fe517a"><code>0129fe5</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/clap-rs/clap/issues/1673">#1673</a> from clap-rs/v2-ci</li>
<li><a href="48a71f35ac"><code>48a71f3</code></a> Update minimum rust version</li>
<li><a href="57baeb489c"><code>57baeb4</code></a> Formatted rust</li>
<li><a href="f9ffeb8616"><code>f9ffeb8</code></a> CI for v2-master</li>
<li><a href="fa45af5cad"><code>fa45af5</code></a> where -> were</li>
<li>Additional commits viewable in <a href="https://github.com/clap-rs/clap/compare/v2.33.0...v2.33.1">compare view</a></li>
</ul>
</details>
<br />
[](https://dependabot.com/compatibility-score/?dependency-name=clap&package-manager=cargo&previous-version=2.33.0&new-version=2.33.1)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme
Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1170
Reviewed By: passy
Differential Revision: D21619402
Pulled By: cekkaewnumchai
fbshipit-source-id: 88f9d7579e4c5c0027b2144006fbaff7a02540ef
Summary:
Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.28 to 1.0.31.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dtolnay/anyhow/releases">anyhow's releases</a>.</em></p>
<blockquote>
<h2>1.0.31</h2>
<ul>
<li>Restore "Stack backtrace" header label above the backtrace in <code>{:?}</code> representation (<a href="https://github-redirect.dependabot.com/dtolnay/anyhow/issues/92">https://github.com/facebook/flipper/issues/92</a>)</li>
</ul>
<h2>1.0.30</h2>
<ul>
<li>Hide an error message that appears when building with <code>cargo rustc -vv</code> (<a href="https://github-redirect.dependabot.com/dtolnay/anyhow/issues/91">https://github.com/facebook/flipper/issues/91</a>, thanks <a href="https://github.com/eoger">eoger</a>)</li>
</ul>
<h2>1.0.29</h2>
<ul>
<li>Documentation improvements</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="144763cf99"><code>144763c</code></a> Release 1.0.31</li>
<li><a href="f7424bd1da"><code>f7424bd</code></a> Show an example of {:?} without backtrace</li>
<li><a href="5e4177fc4c"><code>5e4177f</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/dtolnay/anyhow/issues/92">https://github.com/facebook/flipper/issues/92</a> from dtolnay/backtrace</li>
<li><a href="6d33c15b96"><code>6d33c15</code></a> Restore 'Stack backtrace:' above the backtrace</li>
<li><a href="2aa0cc1aba"><code>2aa0cc1</code></a> Release 1.0.30</li>
<li><a href="afc3079dda"><code>afc3079</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/dtolnay/anyhow/issues/91">https://github.com/facebook/flipper/issues/91</a> from eoger/silent-probe</li>
<li><a href="5ed5f56f0c"><code>5ed5f56</code></a> Redirect probe compile errors to /dev/null</li>
<li><a href="290d3d2a50"><code>290d3d2</code></a> Release 1.0.29</li>
<li><a href="5e1a1f8b01"><code>5e1a1f8</code></a> Try out a new style of readme badges</li>
<li><a href="16f607efaa"><code>16f607e</code></a> Add crosslink icons to top of rustdoc</li>
<li>Additional commits viewable in <a href="https://github.com/dtolnay/anyhow/compare/1.0.28...1.0.31">compare view</a></li>
</ul>
</details>
<br />
[](https://dependabot.com/compatibility-score/?dependency-name=anyhow&package-manager=cargo&previous-version=1.0.28&new-version=1.0.31)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme
Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1169
Reviewed By: passy
Differential Revision: D21619401
Pulled By: cekkaewnumchai
fbshipit-source-id: 06e3d86104c4809a3a464a683552e6523a2b67d3
Summary:
Remove warning `'variant.getJavaCompile()' is obsolete and has been replaced with 'variant.getJavaCompileProvider()'.`
## Changelog
- swithed from `variant.getJavaCompile()` to `variant.getJavaCompileProvider()`
Pull Request resolved: https://github.com/facebook/flipper/pull/1168
Test Plan: n/a
Reviewed By: passy
Differential Revision: D21618883
Pulled By: cekkaewnumchai
fbshipit-source-id: 522fe5847b074836cc36a9e1b9a0487b044cf555
Summary:
Very similar to the Logview plugin, showing a table with all logs (from all clients, if more than one is connected to Unity), and a right-side panel for details (the extra).
I'm still thinking how can I display the extra in the table (so it will be more convenient to compare logs), but still don't know (each extra can have different fields), and this is a good starting point.
Note: the POI plugin has an option to display marauder data, but I received requests for an easy way to debug just Pigeon, and since this is simple enough I don't see the harm here.
Reviewed By: timur-valiev
Differential Revision: D21549233
fbshipit-source-id: e7a48b4e21711bc9454e9b87a312e94a662917e2
Summary:
To comply with recent agreement, coverage test for MultipleSelectorSection is added.
Also, add undefined check in `elements.tsx` found while adding the test
Reviewed By: mweststrate
Differential Revision: D21554782
fbshipit-source-id: 7cd868bf16f6105d6f523048f29bdaa052837f45
Summary:
This diff updated the `flipper-out-of-contents` container to render with absolute position, which allows it to cover up all of the content in the plugin. This fixes an issue where content that exists in the plugin can be broken.
For example, the banner in the next diff would look like this:
{F237034745}
Reviewed By: mweststrate
Differential Revision: D21556849
fbshipit-source-id: 95ec4aac24ac995bd1c558123ef5da6087a40d0a
Summary: The effect of opening the screenshot after capturing was removed in D19765926.
Reviewed By: mweststrate
Differential Revision: D21571294
fbshipit-source-id: f3308d80e066cc01786c17323e4ff5f97c092de9
Summary:
Ugh, lockdown brain. This was supposed to be included in the test I added before
to get to 100% coverage. Well, it's here now.
Reviewed By: mweststrate
Differential Revision: D21550904
fbshipit-source-id: 044a11d38e211c6f57cce220adc8c42241a2043a
Summary:
This happened during startup:
{F237135281}
From `tmp` docs:
> IMPORTANT NOTE: template no longer accepts a path. Use the dir option instead if you require tmp to create your temporary filesystem object in a different place than the default tmp.tmpdir.
Reviewed By: mweststrate
Differential Revision: D21570416
fbshipit-source-id: 170886d0fda5e21cb23fe836fcde33eb457a4c1b
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1158
Reviewed By: priteshrnandgaonkar
Differential Revision: D21550463
Pulled By: passy
fbshipit-source-id: 190b52bf2657603f9b6a037df5942ca17de4c0a3
Summary: This is required for the new release of promisify-child-process.
Reviewed By: mweststrate
Differential Revision: D21543812
fbshipit-source-id: dc254ea51381696b9927f7c62dd36e10ef00fcac
Summary: 'to' is for internal pages. href is for generic links, and has tweaks such as opening in new tabs and making sure sites work in iframes.
Reviewed By: passy
Differential Revision: D21550098
fbshipit-source-id: 306dd92378ca721c435b9f4f031136fc421cbb81
Summary:
Compresses artifacts with LZMA by default. `--no-compression` can be used
to skip the quite time-intensive task to just quickly check if the archives
still add up to a full distribution.
Reviewed By: jknoxville
Differential Revision: D21456052
fbshipit-source-id: dfa4686f3fe7ce342b62dab4b5203bc0aad37d9a
Summary: This diff updates the typescript version and it fixes `yarn lint:tsc`. It also successfully pointed out fes of the problems in our codebase. I have fixed those problems
Reviewed By: mweststrate
Differential Revision: D21548003
fbshipit-source-id: e69c986ee3c763588d9e1e290dad08d1cf1976a8
Summary:
This reverts D21285438 and patches some holes in the layout invalidation routines.
(I tried to use `didAddSubview:` and `willRemoveSubview:` but those are annoying for other reasons; for example, `willRemoveSubview:` can be called from within `dealloc` which is surprising. Also they still don't catch the case where subviews are being reordered.)
Reviewed By: Andrey-Mishanin
Differential Revision: D21512129
fbshipit-source-id: 1d9e8dac9333eddfae2309d446ef4de9e83220d6
