Summary:
There's `TODO` in the description for `react-native-flipper` so this should be updated
## Changelog
Internal change.
Pull Request resolved: https://github.com/facebook/flipper/pull/1055
Test Plan: No test plan required.
Reviewed By: mweststrate
Differential Revision: D21256140
Pulled By: passy
fbshipit-source-id: 6b07e38b80ac395481270b05fca6823ec6559da5
Summary: I think that's a good thing to keep up-to-date?
Reviewed By: mweststrate
Differential Revision: D20890360
fbshipit-source-id: a9c95d4afb2f6b6f0b32f595c53f3799b9ffaa73
Summary: Added some UI so that we can manually verify that logging and network inspection is working in RN + Flipper.
Reviewed By: jknoxville
Differential Revision: D20668428
fbshipit-source-id: 4271595583e055b2b0324b3da7ac216c39717093
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/872
Move all the JS code related to desktop app to "desktop" subfolder.
The structure of "desktop" folder:
- `src` - JS code of Flipper desktop app executing in Electron Renderer (Chrome) process. This folder also contains all the Flipper plugins in subfolder "src/plugins".
- `static` - JS code of Flipper desktop app bootstrapping executing in Electron Main (Node.js) process
- `pkg` - Flipper packaging lib and CLI tool
- `doctor` - Flipper diagnostics lib and CLI tool
- `scripts` - Build scripts for Flipper desktop app
- `headless` - Headless version of Flipper app
- `headless-tests` - Integration tests running agains Flipper headless version
Reviewed By: passy
Differential Revision: D20249304
fbshipit-source-id: 9a51c63b51b92b758a02fc8ebf7d3d116770efe9
Summary:
* Followed plan of D20221558
* Manually bumped Flipper version on iOS to 0.33.1, which contains https://github.com/facebook/flipper/pull/874/files (make Flipper compatible with iOS 9).
* Will submit a PR on RN to bump the iOS template
Reviewed By: passy
Differential Revision: D20361824
fbshipit-source-id: 4f013b731b40e2d4f941742f9201bf2bb4382ec3
Summary:
In line with, https://github.com/facebook/flipper/pull/874/files, the package should promote itself as iOS 9.0 compatibe, to prevent errors and warnings like:
```
mweststrate-mbp:ios mweststrate$ pod install
Detected React Native module pod for react-native-flipper
Analyzing dependencies
Fetching podspec for `DoubleConversion` from `../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec`
Fetching podspec for `Folly` from `../node_modules/react-native/third-party-podspecs/Folly.podspec`
Fetching podspec for `glog` from `../node_modules/react-native/third-party-podspecs/glog.podspec`
[!] CocoaPods could not find compatible versions for pod "react-native-flipper":
In Podfile:
react-native-flipper (from `../node_modules/react-native-flipper`)
Specs satisfying the `react-native-flipper (from `../node_modules/react-native-flipper`)` dependency were found, but they required a higher minimum deployment target.
```
```
mweststrate-mbp:ios mweststrate$ pod install
Detected React Native module pod for react-native-flipper
Analyzing dependencies
Downloading dependencies
Installing react-native-flipper 0.33.1
Generating Pods project
Integrating client project
Pod installation complete! There are 34 dependencies from the Podfile and 38 total pods installed.
[!] The platform of the target `ReactNativeFlipperExample` (iOS 9.0) may not be compatible with `react-native-flipper (0.33.1)` which has a minimum requirement of iOS 10.0.
[!] The platform of the target `ReactNativeFlipperExampleTests` (iOS 9.0) may not be compatible with `react-native-flipper (0.33.1)` which has a minimum requirement of iOS 10.0.
mweststrate-mbp:ios mweststrate$ cd ..
mweststrate-mbp:ReactNativeFlipperExample
```
Reviewed By: passy
Differential Revision: D20362156
fbshipit-source-id: 766d033f2ea2e5559a72a3473115bc4a470a284f
Summary:
== Highlights ==
- Android: Theme information for Application, Activity and View descriptors are now visible in the Layout plugin. (6f4de969fb)
- App Visualiser: When importing an archived device, you can now see and inspect the last screen of the app. (20db85adf4)
== Fixes ==
- Fix `FlipperKit` warnings in XCode. (972277b031)
- Upgrade Folly to v2020.02.17.00 (GH809)
- Several performance improvements, originally caused by unnecessary rerenders.
- Crash reports weren't scrollable. (e1e8bb841c)
- Kill orhpaned instruments processes. (GH819)
Reviewed By: nikoant
Differential Revision: D20067792
fbshipit-source-id: 3f0ebcb03881373fd909f513e5d82e23a5f9f1f1
Summary:
As per title.
Ran `arc lint -a --take CLANGFORMAT --paths-cmd 'hg files ./'` from xplat/sonar
Reviewed By: zertosh
Differential Revision: D19943131
fbshipit-source-id: c1dc10b27389fd6f54f055803519dac6bf0e7997
Summary: Releasing Flipper 0.31.2 as preview for the improved React Native support (blog post will follow)
Reviewed By: cekkaewnumchai
Differential Revision: D19939347
fbshipit-source-id: 4bff1aabdd4e63003de9c9c0af2002ed67504da1
Summary:
Implement the react-native-flipper native module on iOS. Uses very similar abstractions as on Android.
## Changelog
[react-native-flipper] Support iOS
Pull Request resolved: https://github.com/facebook/flipper/pull/795
Test Plan:
Tested using the RN TicTacToe example app
{F228406333}
Reviewed By: mweststrate
Differential Revision: D19853017
Pulled By: priteshrnandgaonkar
fbshipit-source-id: d93d35ff984b9ba75f812c4c8e3c82e4d550f0c0
Summary: No changes that should impact us in any way.
Reviewed By: priteshrnandgaonkar
Differential Revision: D19856578
fbshipit-source-id: 35113b4b9e56b6c0b09681ac5649705cf840f60c
Summary:
== Highlights ==
- Database query favourites are now persisted across sessions (b0caaa7)
- Allow disabling iOS development in Settings
(aab004a)
- Various improvements to the sidebar
- FPS graph to visualize slow UIs for plugin developers (31df1db)
- Window theme attributes when clicking on a window in the inspector (c430fc3)
- Removed Stetho dependency (48d6ea4). Thanks, ZacSweers!
- Install plugins directly from package files (b9e7f5d6d1)
== Fixes ==
- Mac plugins not showing up (02e0233)
- Doctor: log both shown and suppressed warnings (35d62e70cb). Thanks, mateosilguero!
- Fix default SDK path on Windows (e178221)
- Doctor complains Android SDK is not installed
(b625efe)
- Update welcome screen links (33ad41c)
- Fix 'Timed out waiting for device' error (060e8c0)
Reviewed By: priteshrnandgaonkar
Differential Revision: D19813089
fbshipit-source-id: 8b1fc6fb140d02b7f78adcadd7c45a3ed1755f2f
Summary:
This allows using the flipper RN module with TurboModules instead of using FlipperPackage.
## Changelog
[react-native-flipper] Allow Flipper module instances to be created by applications
Pull Request resolved: https://github.com/facebook/flipper/pull/786
Test Plan:
An instance of the Flipper module can now be created like this when using TurboModules:
```java
Override
public NativeModule getModule(String name, ReactApplicationContext reactContext) {
switch (name) {
...
case FlipperModule.NAME:
return new FlipperModule(FlipperReactNativeJavaScriptPluginManager.getInstance(), reactContext);
...
}
}
```
Tested that it builds
Reviewed By: mweststrate
Differential Revision: D19812912
Pulled By: passy
fbshipit-source-id: 401b3e4552ea0cdb7444a2cf5d170c408edab4db
Summary: I think that's it. Some more minor changes and removing an unused BUCK file.
Reviewed By: mweststrate
Differential Revision: D19471282
fbshipit-source-id: ceb85111f03a41141dca0bdd445cda12dfbac1c4
Summary:
Some more minor cleanups that don't (well, barely) affect
semantics.
- Fix singleton management in multi-threaded environments.
- Remove double assignment.
- Make all things final where they can be.
- Use ugly Hungarian notation.
- Weaken some types.
Reviewed By: mweststrate
Differential Revision: D19471227
fbshipit-source-id: 18833c3fe940f51b8d4cb3948a63387b8cd9316c
Summary:
Making some changes to make this more idiomatic and abide by
the Flipper/FB standards. This one just removes some unused
variables and annotations.
Reviewed By: jknoxville
Differential Revision: D19470676
fbshipit-source-id: 4beb516f00228b1d33e4e1b42d9bc4f8c29af565
Summary: We won't use them so this is just dead weight that's going to break at some point.
Reviewed By: jknoxville
Differential Revision: D19470548
fbshipit-source-id: 3def22e6f5db2923d5551d7b6a3472cb4364186c
Summary: This diff makes sure that the app doesn't die, or dies in a meaningful way if things are misconfigured.
Reviewed By: passy
Differential Revision: D19468273
fbshipit-source-id: 2471c263391906113446af57d795d1199eb1730e
Summary:
This diff creates a sample React Native project (based on the 0.62-rc.0 template).
This example is created like:
(Documenting this here as in the future this might be easier than upgrading the project itself)
1. Run `npx react-native init ReactNativeFlipperExample --version 0.62.0-rc.0`
2. Follow the installation steps to enable Flipper, that is, call `initializeFlipper(this, getReactNativeHost().getReactInstanceManager());` at the end of the `onCreate` method in `MainApplication.java`
3. Put `FlipperTicTacToe` in the root of the project, and call it from `App.js` as a component
4. install `react-native-flipper` as dependency
5. install `relative-deps` as dev dependency, and set it up as shown in `package.json`. This tool make sure that we build and test this project against the version of react-native-flipper in this repository, rather than against the one on NPM.
6. removed some stuff, like tests and linting, which is just in the way in this repo
This PR does not support iOS, as Flipper + RN iOS is still broken in 0.62.0-rc.0, and the current version of react-native-flipper doesn't support iOS yet either.
Documentation on how to set up Flipper in general is not part of this Diff
_N.B. since this is a **public** project, to be visible and runnable by our OSS community, the build setup is kept plain, vanilla, react-native, and **not** wired up to our normal / internal build processes. This is also the reason that lint suggestions beyond the license headers have been ignored. If any others should be applied, it is probably the official react native template that requires updating_
Reviewed By: passy
Differential Revision: D19449295
fbshipit-source-id: 2aeb6044f8dd01f09a95350c84fff2419d685a65
Summary:
This Diff makes the react-native-flipper package available on NPM.
For simplicity and traceability purposes, this package is released every time Flipper is released, under the same version number. Even though there will be often no changes.
Reviewed By: passy
Differential Revision: D19446815
fbshipit-source-id: 485930e57beac42a2f36dc34a8ac82eed2abe785
Summary: Added some assertions and string casts to make plugins a bit more robust
Reviewed By: passy
Differential Revision: D19427909
fbshipit-source-id: 46a3138805db865b538f745fae25ce1897e35736
Summary:
This diff is part of the bigger task T60496135
This diff changes the RN support from crude to decent citizen, making sure we don't recycle callbacks over the bridge, use subscriptions were possible, and making sure connecting, disconnecting, etc works correctly
For example, connect and disconnect hooks should work.
Finally, throw in hot reloading into the mix, which causes the registerPlugin to be triggered another time, without the old one every been unloaded.
This should trigger a new 'onConnect' on the client, to make sure it can restore any state / subscriptions necessary, even though the never disappeared in the Java world.
These cases should all be handled well.
Reviewed By: jknoxville
Differential Revision: D19347330
fbshipit-source-id: de64a08f4043f01528c794430ccc3c717abf0180
Summary:
This diff is part of the bigger task T60496135
This diff is based on D18706643, extracting only the react native module parts
It implements the entire Android client api for JavaScript, so that there is feature parity. However this implementation is happy path only, and edge cases will be handled in separate diffs
Reviewed By: jknoxville
Differential Revision: D19310265
fbshipit-source-id: 589716fe059952bdde98df84ed250c5c6feaa118
