Commit Graph

10 Commits

Author SHA1 Message Date
Andres Suarez
0675dd924d Tidy up Flipper license headers [1/2]
Reviewed By: passy

Differential Revision: D17863711

fbshipit-source-id: 259dc77826fb803ff1b88c88529d7f679d3b74d8
2019-10-11 13:46:45 -07:00
Pascal Hartig
8da621f8e9 Exit with error code on yarn-install failure (#292)
Summary:
If installation fails, we should exit with an error code and not just a
message. This should help narrow down the CI failures, too.
Pull Request resolved: https://github.com/facebook/flipper/pull/292

Reviewed By: danielbuechele

Differential Revision: D10255759

Pulled By: passy

fbshipit-source-id: a6b033deadf11069e6c5665870a811ae2d0ec5ef
2018-10-09 08:41:10 -07:00
Hilal Alsibai
5285d50abf Add syntax highlighting
Summary: Pretty colors

Reviewed By: danielbuechele

Differential Revision: D9504416

fbshipit-source-id: 7eb467ff43bed5566f3bd9ce72dc74064fb4718c
2018-08-29 03:27:07 -07:00
Daniel Büchele
e3ac7f4e36 fix yarn deadlock in postinstall
Summary:
The script installing the plugin dependencies is executed by yarn itself. This means a yarn instance is running while the script is trying to create another yarn instance to install plugin dependencies. The second yarn instance is waiting for the first to finish, while the second can't start as long as the first hasn't finished. Deadlock.

This is why we use a port dirrerent from yarn's default port (31997) for the mutex.

Reviewed By: jknoxville

Differential Revision: D9149973

fbshipit-source-id: 69790021460fd8ddea9ed84ca8130c77be0a62a9
2018-08-03 08:41:48 -07:00
Daniel Büchele
696c73ebc1 fixing travis builds
Summary:
- making website deployment and desktop app builds two different travis jobs, so if one fails, the other is still working
- running website builds on linux, because, we don't need macOS for this
- making dependency installs serial instead of parallel to avoid problems of multiple yarn instances running at the same time
- removing duplicate postinstall script which breaks for electron 3 builds

Reviewed By: passy

Differential Revision: D9148342

fbshipit-source-id: 22f3a0fe59aff066c04fb964621604efc46aab8a
2018-08-03 05:56:38 -07:00
Daniel Büchele
1b072c71a7 use yarn network mutex
Summary: The file system mutex caused some problems in Sandcastle. This diffs switches for the default setting (network mutex) in the hope this fixes the problem

Reviewed By: passy

Differential Revision: D9132069

fbshipit-source-id: 5abb4d33b6db2a5d2b3f0788116ca6941e554591
2018-08-02 05:43:33 -07:00
Aaron Brady
a223edafaa Get Sonar Running on Windows
Summary: Small tweaks so that Sonar can be started easily on windows.

Reviewed By: danielbuechele

Differential Revision: D8769592

fbshipit-source-id: 084dd50e5600a7e2e9c5544e3e79a18614933fdc
2018-07-11 08:18:25 -07:00
Daniel Büchele
c50b2864ce fix lint errors
Summary: builds were breakign due to linting erros

Reviewed By: jknoxville

Differential Revision: D8781557

fbshipit-source-id: fccd349d0088a7b7ab8359dfd4edee20230c2393
2018-07-10 08:11:44 -07:00
Hilal Alsibai
2a46f93eab Fix install for Windows (#138)
Summary:
This lets `yarn` work properly on Windows. Tested in a Cygwin environment. I also added a note about yarn compatibility to the readme.
Closes https://github.com/facebook/Sonar/pull/138

Reviewed By: danielbuechele

Differential Revision: D8734197

Pulled By: xiphirx

fbshipit-source-id: 19be8bb0653a2b0381224b065df0cac579d72c3b
2018-07-05 03:32:30 -07:00
Daniel Büchele
fbbf8cf16b Initial commit 🎉
fbshipit-source-id: b6fc29740c6875d2e78953b8a7123890a67930f2
Co-authored-by: Sebastian McKenzie <sebmck@fb.com>
Co-authored-by: John Knox <jknox@fb.com>
Co-authored-by: Emil Sjölander <emilsj@fb.com>
Co-authored-by: Pritesh Nandgaonkar <prit91@fb.com>
2018-06-01 11:03:58 +01:00