Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/4597
Not needed. The sample app doesn't have any C++ code.
Reviewed By: aigoncharov
Differential Revision: D44028696
fbshipit-source-id: 0e21e0eda1ff99dae8900fbcd4452b73745d7aa3
Summary:
// allow-large-files
Pull Request resolved: https://github.com/facebook/flipper/pull/4265
Related to https://github.com/facebook/flipper/issues/4240
Resolving https://github.com/facebook/flipper/issues/3859 led to breaking changes in react-native-flipper which made it incompatible with react-natvie < 0.69.
In this diff we migrate our example app to react-native 0.69 and add a notice to our readme about the react-native 0.69+ requirement
Reviewed By: lblasa
Differential Revision: D40673740
fbshipit-source-id: 18f4742449d115be7a5100f2bc4d834dcebea80f
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/3514
^
Updates a few versions of different things used in react-native-android and the provided sample as to have more parity with the ones used in vanilla Android.
Changelog: React-native Android. Bump tools versions.
Reviewed By: passy
Differential Revision: D34751493
fbshipit-source-id: f2f85eb3e680e120f9526d5a64b3e894882149de
Summary:
Bumps [react-native](https://github.com/facebook/react-native) from 0.66.4 to 0.67.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/react-native/releases">react-native's releases</a>.</em></p>
<blockquote>
<h2>0.67.1</h2>
<p>A patch release including fixes to unblock Detox and Android JSC builds</p>
<ul>
<li>Remove alert's window when call to <code>hide</code>. (<a href="a46a99e120">a46a99e120</a> by <a href="https://github.com/asafkorem"><code>@asafkorem</code></a>)</li>
<li>Do not remove libjscexecutor.so from release builds (<a href="574a773f8f">574a773f8f</a> by <a href="https://github.com/cortinico"><code>@cortinico</code></a>)</li>
</ul>
<hr />
<p>You can participate in the conversation on the status of this release at this <a href="https://github.com/reactwg/react-native-releases/discussions/12">discussion</a></p>
<hr />
<p>To help you upgrade to this version, you can use the <a href="https://react-native-community.github.io/upgrade-helper/">upgrade helper</a> ⚛️</p>
<hr />
<p>You can find the whole changelog history in the <a href="https://github.com/facebook/react-native/blob/main/CHANGELOG.md">changelog.md file</a>.</p>
<h2>0.67.0</h2>
<p>0.67 stable is out!</p>
<p>This release includes <strong>385 commits</strong> with <strong>75 contributors</strong>! Thank you to all our contributors new and old! You can find the <a href="https://github.com/facebook/react-native/blob/main/CHANGELOG.md#v0670">full changelog here</a>.</p>
<ul>
<li>See the highlights of the release in our <a href="https://reactnative.dev/blog/2022/01/19/version-067">release blog post</a>.</li>
<li>You can participate in the conversation on the status of this release at <a href="https://github.com/reactwg/react-native-releases/discussions/10">this issue</a>.</li>
<li>You can upgrade to this version using the <a href="https://react-native-community.github.io/upgrade-helper/">upgrade helper webtool</a> ⚛️</li>
</ul>
<h2>0.67.0-rc.6</h2>
<p>We are aiming for this to be our candidate for stable. We aim to promote 0.67.0-rc.6 to stable in the first half of January 2022.</p>
<ul>
<li>(iOS) Fix M1 build error when pod has no IPHONEOS_DEPLOYMENT_TARGET <a href="9cd4092336</a></li>
</ul>
<hr />
<p>To test it, run</p>
<pre lang="sh"><code>npx react-native init RN067RC6 --version 0.67.0-rc.6
</code></pre>
<hr />
<p>You can participate in the conversation on the status of this release at this <a href="https://github.com/reactwg/react-native-releases/discussions/1">discussion</a>.</p>
<hr />
<p>To help you upgrade to this version, you can use the <a href="https://react-native-community.github.io/upgrade-helper/">upgrade helper</a> ⚛️</p>
<hr />
<p>You can find the whole changelog history in the <a href="https://github.com/facebook/react-native/blob/main/CHANGELOG.md">changelog.md file</a>.</p>
<h2>0.67.0-rc.5</h2>
<p>We are aiming for this to be our candidate for stable (�)</p>
<ul>
<li>Revert Hermes 0.10 due to <a href="https://github-redirect.dependabot.com/facebook/hermes/issues/649">facebook/hermes#649</a>
<ul>
<li>Revert Hermes on iOS: <a href="a510c2733f</a></li>
</ul>
</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/facebook/react-native/blob/main/CHANGELOG.md">react-native's changelog</a>.</em></p>
<blockquote>
<h2>v0.67.1</h2>
<h3>Fixed</h3>
<h4>Android specific</h4>
<ul>
<li>Do not remove libjscexecutor.so from release builds (<a href="574a773f8f">574a773f8f</a> by <a href="https://github.com/cortinico"><code>@cortinico</code></a>)</li>
</ul>
<h4>iOS specific</h4>
<ul>
<li>Remove alert's window when call to <code>hide</code>. (<a href="a46a99e120">a46a99e120</a> by <a href="https://github.com/asafkorem"><code>@asafkorem</code></a>)</li>
</ul>
<h2>v0.67.0</h2>
<h3>Added</h3>
<h4>Android specific</h4>
<ul>
<li>Add <code>ACCESS_MEDIA_LOCATION</code> permission to PermisionsAndroid library. (<a href="79db483568">79db483568</a> by <a href="https://github.com/Skrilltrax"><code>@Skrilltrax</code></a>)</li>
<li>Implement <code>SnapToAlignment</code> in <code>ReactScrollView</code> (<a href="e774c037bc">e774c037bc</a>), <code>ReactScrollViewManager</code> (<a href="c6e5640e87">c6e5640e87</a>), <code>ReactHorizontalScrollView</code> (<a href="b12256394e">b12256394e</a>), <code>ReactHorizontalScrollViewManager</code> (<a href="deec1db9fd">deec1db9fd</a>) and update <code>ScrollView.js</code> (<a href="a54cfb9e57">a54cfb9e57</a>) and reach parity with iOS (<a href="04184ef851">04184ef851</a>) by <a href="https://github.com/mdvacca"><code>@mdvacca</code></a></li>
<li>Show Redbox for C++ errors. (<a href="d6c879edba">d6c879edba</a> by <a href="https://github.com/sota000"><code>@sota000</code></a>)</li>
<li>Added an experimental touch dispatch path (<a href="a2feaeb5f1">a2feaeb5f1</a> by <a href="https://github.com/ShikaSD"><code>@ShikaSD</code></a>)</li>
</ul>
<h4>iOS specific</h4>
<ul>
<li>Added <code>cancelButtonTintColor</code> prop for <code>ActionSheetIOS</code> to change only the text color of the cancel button (<a href="01856633a1">01856633a1</a> by <a href="https://github.com/nomi9995"><code>@nomi9995</code></a>)</li>
<li>Added <a href="https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/LaunchServicesKeys.html#//apple_ref/doc/uid/TP40009250-SW14"><code>LSApplicationQueriesSchemes</code></a> in info.plist with entries tel, telprompt, http, fb, geo (<a href="b26f277262">b26f277262</a> by <a href="https://github.com/utkarsh-dixit"><code>@utkarsh-dixit</code></a>)</li>
<li>Add <code>UIAccessibilityTraitUpdatesFrequently</code> to progressBar role (<a href="1a42bd6e97">1a42bd6e97</a> by <a href="https://github.com/jimmy623"><code>@jimmy623</code></a>)</li>
<li>Add <code>asdf-vm</code> support in <code>find-node.sh</code> (<a href="3e7c310b1d">3e7c310b1d</a> by <a href="https://github.com/pastleo"><code>@pastleo</code></a>)</li>
</ul>
<h3>Changed</h3>
<ul>
<li><code>ImageBackground</code> now respects <code>imageStyle</code> width and height (<a href="dbd5c3d8e5">dbd5c3d8e5</a> by <a href="https://github.com/Naturalclar"><code>@Naturalclar</code></a>)</li>
<li>Rename deprecated <code>Keyboard.removeEventListener</code> to <code>Keyboard.removeListener</code>. (<a href="8880c09076">8880c09076</a> by <a href="https://github.com/yungsters"><code>@yungsters</code></a>)</li>
<li>Update <code>Modal</code>'s mock to not render its children when it is not visible (<a href="ec614c16b3">ec614c16b3</a> by <a href="https://github.com/AntoineDoubovetzky"><code>@AntoineDoubovetzky</code></a>)</li>
<li>Upgraded <code>react-devtools-core</code> dependency to 4.19.1 (<a href="356236471a">356236471a</a> by <a href="https://github.com/jstejada"><code>@jstejada</code></a>)</li>
<li>React-native/normalize-color now supports Node.js (<a href="65e58f26e1">65e58f26e1</a> by <a href="https://github.com/yungsters"><code>@yungsters</code></a>)</li>
<li>Updated to Contributor Covenant v2.1 (<a href="19f8d2f7da">19f8d2f7da</a>)</li>
</ul>
<h4>Android specific</h4>
<ul>
<li>Hermes initialization will no longer need an explicit configuration. (<a href="a40f973f58">a40f973f58</a> by <a href="https://github.com/Ashoat"><code>@Ashoat</code></a>)</li>
<li>Setting <code>overflow: scroll</code> in View component style will clip the children in the View container (<a href="93beb83abe">93beb83abe</a> by <a href="https://github.com/ryancat"><code>@ryancat</code></a>)</li>
<li>Native views backing <code>Animated.View</code> (w/ JavaScript-driven animations) will no longer be flattened; this should be a transparent change. (<a href="4fdbc44ab5">4fdbc44ab5</a> by <a href="https://github.com/yungsters"><code>@yungsters</code></a>)</li>
<li>Use new Locale API on Android 11 (API 30)+ (<a href="b7c023a8c1">b7c023a8c1</a>)</li>
<li>Changed <code>react.gradle</code> <code>detectCliPath</code> function logic for <code>cliPath</code> case (<a href="ce51b62494">ce51b62494</a> by <a href="https://github.com/vitalyiegorov"><code>@vitalyiegorov</code></a>)</li>
<li>Remove <code>"high"</code> and <code>"balanced"</code> as values for <code>android_hyphenationFrequency</code> on <code>Text</code> (<a href="a0d30b848a">a0d30b848a</a>)</li>
<li>Bump Gradle version to 7.2, Bump Kotlin version to 1.5.31 (<a href="9ae3367431">9ae3367431</a> by <a href="https://github.com/svbutko"><code>@svbutko</code></a>)</li>
<li>Move mavenCentral repo below local paths (<a href="046b02628d">046b02628d</a> by <a href="https://github.com/friederbluemle"><code>@friederbluemle</code></a>)</li>
</ul>
<h4>iOS specific</h4>
<ul>
<li>Optimized font handling for iOS (<a href="4ac42d88ef">4ac42d88ef</a> by <a href="https://github.com/Adlai-Holler"><code>@Adlai-Holler</code></a>)</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="25f3d310d9"><code>25f3d31</code></a> [0.67.1] Bump version numbers</li>
<li><a href="96ad60e3a1"><code>96ad60e</code></a> Do not remove libjscexecutor.so from release builds (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/32932">#32932</a>)</li>
<li><a href="218b4c19bb"><code>218b4c1</code></a> fix(iOS): remove alert's window when call to <code>hide</code>. (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/32833">#32833</a>)</li>
<li><a href="857dbd9b20"><code>857dbd9</code></a> [0.67.0] Bump version numbers</li>
<li><a href="900af2b3b6"><code>900af2b</code></a> TODO dummy commit</li>
<li><a href="842aac5a3c"><code>842aac5</code></a> Update bump-oss-version.js to guide releaser through release actions (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/32769">#32769</a>)</li>
<li><a href="a59141fb28"><code>a59141f</code></a> Update comments in publish-npm and leverage isTaggedLatest</li>
<li><a href="e7296d6b34"><code>e7296d6</code></a> Remove usages of bump-oss-version from generated scripts</li>
<li><a href="6fc004e95f"><code>6fc004e</code></a> Use tag to set publish version (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/32757">#32757</a>)</li>
<li><a href="c3aa86bea2"><code>c3aa86b</code></a> [0.67.0-rc.6] Bump version numbers</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/react-native/compare/v0.66.4...v0.67.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3341
Test Plan:
React Native Android
1. Start Android emulator (Pixel 4, API 27 Oreo 8.1)
2. Go to ReactNativeFlipperExample
3. Run yarn
4. Run yarn use-local-deps
5. Run yarn android
6. Wait for the app to start
7. Check "Logs" plugin works
8. Check "Network" plugin works (click on "IS NPM UP?")
9. Check "Layout" plugin works
10. Check "React Native Tic-Tac-Toe" plugin works
React Native iOS
1. Go to ReactNativeFlipperExample
2. Run yarn
3. Run yarn use-local-deps
4. Go to ReactNativeFlipperExample/ios
5. Run rm -f Podfile.lock
6. Run pod install --repo-update
7. Go to ReactNativeFlipperExample
8. Run yarn ios
9. Wait for the app to start
10. Check "Logs" plugin works
11. Check "Network" plugin works (click on "IS NPM UP?")
12. Check "Layout" plugin works
13. Check "React Native Tic-Tac-Toe" plugin works
Reviewed By: mweststrate
Differential Revision: D33741751
Pulled By: lblasa
fbshipit-source-id: 0bf7778615c327f3d2ef497932e77e94fb0d766d
Summary:
Per https://react-native-community.github.io/upgrade-helper/?from=0.65.1&to=0.66.0
Also cleaned up lockfiles, made relative-deps non-default, removed old resolutions since I got weird errors with them.
allow-large-files
Reviewed By: timur-valiev
Differential Revision: D31471307
fbshipit-source-id: 2ef8856498bb73293d6638b2c08a1042adb636e5
Summary: Upgrade React Native to 0.65.1 in the reference project. Verified that the app installs on Android, iPhone 12, with and without Hermes
Reviewed By: timur-valiev
Differential Revision: D30807062
fbshipit-source-id: 79f4aba2ca9767769842f77221d4cf3eeefbf478
Summary:
allow-large-files
Per title. hermes enabled so that we can verify the hermes debugger works.
Reviewed By: passy
Differential Revision: D27229331
fbshipit-source-id: c2e45151b9d2097edc7e79f54eb89f9d110899d6
Summary:
In D25244631 (92bd68a371) we bumped the react-native dep of Flipper but we didn't apply the migration guide (sorry for missing that in the review), so the ReactNativeExample fell apart when trying to build for iOS. This diff applies the migration guide which nicely fixes that:
https://react-native-community.github.io/upgrade-helper/?from=0.62.2&to=0.63.4
Recreating the Podfile.lock and running `./gradlew clean` fixed all build problems after that.
Verified that `yarn ios` and `yarn android`, and building from XCode all work.
Found (probably unrelated / existing) issues:
* custom plugins only show up after initial app start after refreshing the plugin list by navigating to another diffs first, so this seems to be a UI staleness bug
* Network plugin doesn't seem to work ion iOS (either not showing traffic or not showing data at all)
Reviewed By: passy
Differential Revision: D25755490
fbshipit-source-id: baea8b152fb252deda04291ec197ab87c2fbe3eb
Summary: Added some UI so that we can manually verify that logging and network inspection is working in RN + Flipper.
Reviewed By: jknoxville
Differential Revision: D20668428
fbshipit-source-id: 4271595583e055b2b0324b3da7ac216c39717093
Summary: We won't use them so this is just dead weight that's going to break at some point.
Reviewed By: jknoxville
Differential Revision: D19470548
fbshipit-source-id: 3def22e6f5db2923d5551d7b6a3472cb4364186c
Summary:
This diff creates a sample React Native project (based on the 0.62-rc.0 template).
This example is created like:
(Documenting this here as in the future this might be easier than upgrading the project itself)
1. Run `npx react-native init ReactNativeFlipperExample --version 0.62.0-rc.0`
2. Follow the installation steps to enable Flipper, that is, call `initializeFlipper(this, getReactNativeHost().getReactInstanceManager());` at the end of the `onCreate` method in `MainApplication.java`
3. Put `FlipperTicTacToe` in the root of the project, and call it from `App.js` as a component
4. install `react-native-flipper` as dependency
5. install `relative-deps` as dev dependency, and set it up as shown in `package.json`. This tool make sure that we build and test this project against the version of react-native-flipper in this repository, rather than against the one on NPM.
6. removed some stuff, like tests and linting, which is just in the way in this repo
This PR does not support iOS, as Flipper + RN iOS is still broken in 0.62.0-rc.0, and the current version of react-native-flipper doesn't support iOS yet either.
Documentation on how to set up Flipper in general is not part of this Diff
_N.B. since this is a **public** project, to be visible and runnable by our OSS community, the build setup is kept plain, vanilla, react-native, and **not** wired up to our normal / internal build processes. This is also the reason that lint suggestions beyond the license headers have been ignored. If any others should be applied, it is probably the official react native template that requires updating_
Reviewed By: passy
Differential Revision: D19449295
fbshipit-source-id: 2aeb6044f8dd01f09a95350c84fff2419d685a65
