Michel Weststrate
d0d0b68e0b
Fixes NPE in page.columns
...
Summary: From stack trace seems that we don't always get columns from the plugin, in which case we can't display anything
Reviewed By: lawrencelomax
Differential Revision: D33981285
fbshipit-source-id: 0d6bf2d9364f7dac93e2179e372308da51699bd3
2022-02-04 01:15:41 -08:00
Andres Orozco Gonzalez
4b6fcb6aaf
new look up for adb path
...
Summary: Look up for the path of the adb may sometimes fail when looking for the folder platform-tools because the adb configuration wasn't done by android studio
Reviewed By: aigoncharov
Differential Revision: D33888687
fbshipit-source-id: 4d0cad2f6b19717e45422632f5d459813a7b7ee0
2022-02-03 07:14:22 -08:00
Bartosz Kaszubowski
6639b547dd
UI: fix hover effect of LeftRail icons with badge ( #3372 )
...
Summary:
This PR fixes the missing hover effect for the `LeftRail` component buttons, when they have included the badge.
To fix the issue, I had to wrap the whole `Button` with `Badge` component (instead wrapping only around icon). However, this solution required to added `offset` property to the `Badge` which moves the indicator to the position prior change (otherwise indicator was moved to the right corner of the button).
The file has been formatted after the changes with ESLint.
**Edit:** I have also spotted that this change fixes the icon placement inside the button, when badge is present. Earlier, as seen below, the log icon was moved towards the top of the button:
<img width="111" alt="Screenshot 2022-01-31 at 00 57 49" src="https://user-images.githubusercontent.com/719641/151723422-0ffb83ee-5806-412e-9191-f9953f78532e.png ">
## Changelog
[desktop] UI: fix hover effect of LeftRail icons with badge
Pull Request resolved: https://github.com/facebook/flipper/pull/3372
Test Plan:
The change has been testes by running the desktop Flipper app locally from source.
## Preview (before & after)
#### Before
<img width="1339" alt="Screenshot 2022-01-31 at 00 24 23" src="https://user-images.githubusercontent.com/719641/151722800-a2f3dd44-aa24-4858-b43e-0620b1f2ae65.png ">
#### After
> I have used mocked indicator values locally to ensure that the Badges are displayed correctly.
<img width="1339" alt="Screenshot 2022-01-31 at 00 26 10" src="https://user-images.githubusercontent.com/719641/151722795-745b04ac-9ee4-49a8-8217-206d8d7456e6.png ">
<img width="1339" alt="Screenshot 2022-01-31 at 00 45 08" src="https://user-images.githubusercontent.com/719641/151722940-aaaf0e9b-f2d1-4245-8b2b-cfc11052b39e.png ">
Reviewed By: aigoncharov
Differential Revision: D33975324
Pulled By: mweststrate
fbshipit-source-id: fe4773b4825b9f22e01821e45259747d319233aa
2022-02-03 05:54:03 -08:00
Michel Weststrate
a31494f321
Fix unnecessary 'still authorizing' error
...
Summary:
When connection to Android, I always get an error popup with 'device still authorizing', which disappears itself and the device connects fine. It seems that this was a case we handled gracefully before, but the error message we check for has changed. Also updated the log message so that we get it in our monitoring I don't silently get stuck in this state.
Changelog: Fixed 'device still authorizing' errors showing up while connecting to an Android device
Reviewed By: aigoncharov
Differential Revision: D33976028
fbshipit-source-id: dbb055bbbd43bad129b10ffee4a8dbb50be8e87a
2022-02-03 04:20:54 -08:00
Michel Weststrate
ccea9058ef
Fix build failure on OSS master ( #3394 )
...
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/3394
This diff caused OSS builds failing due to a FB plugin that requires emotion, instead of using it as peer dep. This introduced a duplicate dep, which doesn't get installed in OSS, causing patch-package for that package to fail. Changed it to a peer dep and removed the patch.
Reviewed By: aigoncharov
Differential Revision: D33975202
fbshipit-source-id: 1e82964988e944a28ecb46a10127ad9e13f743f7
2022-02-03 04:20:54 -08:00
Andrey Goncharov
7376774a95
Add RSocket deprecation warning
...
Reviewed By: lblasa
Differential Revision: D33976369
fbshipit-source-id: c100c145d7c77369347200d32448015ad971d585
2022-02-03 03:52:22 -08:00
Harold Martin
cdb72db5a9
Fix LeakCanary plugin UI, Upgrade LC dependency and make it compile only ( #3367 )
...
Summary:
**Currently, the Leak Canary plugins is broken, see this screenshot (unable to expand):**
<img width="1359" alt="Screen Shot 2022-01-29 at 2 06 33 PM" src="https://user-images.githubusercontent.com/745166/151679662-9d8e8eb6-c19c-4008-9821-1c2c1af92351.png ">
**This fix repairs and improves the UI:**
<img width="1350" alt="Screen Shot 2022-01-29 at 2 06 03 PM" src="https://user-images.githubusercontent.com/745166/151679677-7965604c-dd04-4ee5-bc8e-d53a82da1bd7.png ">
## Changelog
- Fixes UI to enable showing leak trace
- Upgrades LackCanary dependency from 2.6 to 2.8.1
- Makes Kotlin and LC `compileOnly` dependencies in order to prevent conflict for the users
- Updates documentation
Pull Request resolved: https://github.com/facebook/flipper/pull/3367
Test Plan:
See demo at https://github.com/hbmartin/leakcanary/tree/flipper-demo/leakcanary-android-sample
**Static Docs Preview: flipper**
|[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D33915179/V3/flipper/ )|
|**Modified Pages**|
Reviewed By: passy
Differential Revision: D33915179
Pulled By: cekkaewnumchai
fbshipit-source-id: 9698dba23ab475c8cd84e4c222dfc41712b05a1e
2022-02-03 01:37:28 -08:00
dependabot[bot]
eb4ececb9f
Bump typescript from 4.5.4 to 4.5.5 in /desktop ( #3375 )
...
Summary:
Bumps [typescript](https://github.com/Microsoft/TypeScript ) from 4.5.4 to 4.5.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/Microsoft/TypeScript/releases ">typescript's releases</a>.</em></p>
<blockquote>
<h2>TypeScript 4.5.5</h2>
<p>This <a href="https://github.com/microsoft/TypeScript/issues?q=is%3Aissue+milestone%3A%22TypeScript+4.5.5%22+is%3Aclosed ">patch release</a> includes a number of fixes to language service crashes and assertion violations, along with improvements to JSX attribute snippets.</p>
<p>For the complete list of fixed issues, check out the</p>
<ul>
<li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.0%22+ ">fixed issues query for Typescript 4.5.0 (Beta)</a>.</li>
<li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.1%22+ ">fixed issues query for Typescript 4.5.1 (RC)</a>.</li>
<li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.2%22+ ">fixed issues query for Typescript 4.5.2 (Stable)</a>.</li>
<li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.3%22+ ">fixed issues query for Typescript 4.5.3 (Stable)</a>.</li>
<li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.4%22+ ">fixed issues query for Typescript 4.5.4 (Stable)</a>.</li>
<li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.5%22+ ">fixed issues query for Typescript 4.5.5 (Stable)</a>.</li>
</ul>
<p>Downloads are available on:</p>
<ul>
<li><a href="https://www.npmjs.com/package/typescript ">npm</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="55e13e9115c5ce1706f4https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/47500 ">#47500</a> into release-4.5 (<a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/47514 ">#47514</a>)</li>
<li><a href="84509012f3https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/47433 ">#47433</a> into release-4.5 (<a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/47515 ">#47515</a>)</li>
<li><a href="8a8048fb62https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/47413 ">#47413</a>)</li>
<li><a href="14016a7851https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/47395 ">#47395</a> into release-4.5 (<a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/47421 ">#47421</a>)</li>
<li><a href="0854a93040https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/47136 ">#47136</a> into release-4.5 (<a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/47379 ">#47379</a>)</li>
<li><a href="a5ebd5382bhttps://github-redirect.dependabot.com/Microsoft/TypeScript/issues/47348 ">#47348</a> into release-4.5 (<a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/47349 ">#47349</a>)</li>
<li>See full diff in <a href="https://github.com/Microsoft/TypeScript/compare/v4.5.4...v4.5.5 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3375
Reviewed By: passy
Differential Revision: D33892195
Pulled By: cekkaewnumchai
fbshipit-source-id: 92055bc0579fbf48b74bd54ff7be5c491261452b
2022-02-02 11:14:40 -08:00
dependabot[bot]
5253d0750e
Bump @typescript-eslint/experimental-utils from 5.9.1 to 5.10.1 in /desktop ( #3380 )
...
Summary:
Bumps [typescript-eslint/experimental-utils](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/experimental-utils ) from 5.9.1 to 5.10.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases "><code>@typescript-eslint/experimental-utils</code>'s releases</a>.</em></p>
<blockquote>
<h2>v5.10.1</h2>
<h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.0...v5.10.1 ">5.10.1</a> (2022-01-24)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/typescript-eslint</code></p>
<h2>v5.10.0</h2>
<h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.9.1...v5.10.0 ">5.10.0</a> (2022-01-17)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>eslint-plugin:</strong> [explicit-function-return-type] support AllowTypedFunctionExpression within AllowHigherOrderFunction (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/4250 ">#4250</a>) (<a href="d053cde3e8https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/4458 ">#4458</a>) (<a href="f4016c24f9https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/4448 ">#4448</a>) (<a href="e56f1e5d52https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/4411 ">#4411</a>) (<a href="c8e650f0c1https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/4417 ">#4417</a>) (<a href="ef3147cf73https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/4410 ">#4410</a> <a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3714 ">#3714</a></li>
<li><strong>type-utils:</strong> intersection types involving readonly arrays are now handled in most cases (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/4429 ">#4429</a>) (<a href="5046882025https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/4421 ">#4421</a>) (<a href="39a6806c61https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/4419 ">#4419</a>) (<a href="99ab193bb0https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/4172 ">#4172</a>) (<a href="1d55a7511bhttps://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/4415 ">#4415</a>) (<a href="3a07a563c9https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/experimental-utils/CHANGELOG.md "><code>@typescript-eslint/experimental-utils</code>'s changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.0...v5.10.1 ">5.10.1</a> (2022-01-24)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/experimental-utils</code></p>
<h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.9.1...v5.10.0 ">5.10.0</a> (2022-01-17)</h1>
<h3>Features</h3>
<ul>
<li>rename <code>experimental-utils</code> to <code>utils</code> and make <code>experimental-utils</code> an alias to the new package (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/4172 ">#4172</a>) (<a href="1d55a7511b3e1ebcad5588941065091d55a7511bhttps://github.com/typescript-eslint/typescript-eslint/commits/v5.10.1/packages/experimental-utils ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3380
Reviewed By: passy
Differential Revision: D33892239
Pulled By: cekkaewnumchai
fbshipit-source-id: d0e0ab0ad6b2a456121d9bfbc66da979161a17f9
2022-02-02 11:14:40 -08:00
dependabot[bot]
1f41f1dc2d
Bump @adobe/node-fetch-retry from 2.0.0 to 2.1.0 in /desktop ( #3384 )
...
Summary:
Bumps [adobe/node-fetch-retry](https://github.com/adobe/node-fetch-retry ) from 2.0.0 to 2.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/adobe/node-fetch-retry/releases "><code>@adobe/node-fetch-retry</code>'s releases</a>.</em></p>
<blockquote>
<h2>v2.1.0</h2>
<h1><a href="https://github.com/adobe/node-fetch-retry/compare/v2.0.0...v2.1.0 ">2.1.0</a> (2022-01-24)</h1>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="aaf1b7195d24d20a624bhttps://github-redirect.dependabot.com/adobe/node-fetch-retry/issues/42 ">https://github.com/facebook/flipper/issues/42 </a>)</li>
<li>See full diff in <a href="https://github.com/adobe/node-fetch-retry/compare/v2.0.0...v2.1.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3384
Reviewed By: passy
Differential Revision: D33892201
Pulled By: cekkaewnumchai
fbshipit-source-id: e318850d9bcad6908a92e41080fb64d8efafb183
2022-02-02 11:14:39 -08:00
dependabot[bot]
a0ec82c981
Bump @emotion/react from 11.6.0 to 11.7.1 in /desktop ( #3388 )
...
Summary:
Bumps [emotion/react](https://github.com/emotion-js/emotion ) from 11.6.0 to 11.7.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/emotion-js/emotion/releases "><code>@emotion/react</code>'s releases</a>.</em></p>
<blockquote>
<h2><code>@emotion/react</code><a href="https://github.com/11 "><code>@11</code></a>.7.1</h2>
<h3>Patch Changes</h3>
<ul>
<li>
<p><a href="https://github-redirect.dependabot.com/emotion-js/emotion/pull/2577 ">https://github.com/facebook/flipper/issues/2577 </a> <a href="04681a5f52https://github.com/Methuselah96 "><code>@Methuselah96</code></a>! - Export <code>Keyframes</code> type to avoid TypeScript inserting <code>import("emotion/serialize").Keyframes</code> references into declaration files emitted based on a source files exporting <code>keyframes</code> result. This avoids issues with strict package managers that don't allow accessing undeclared dependencies.</p>
</li>
<li>
<p><a href="https://github-redirect.dependabot.com/emotion-js/emotion/pull/2590 ">https://github.com/facebook/flipper/issues/2590 </a> <a href="1554a7e264https://github.com/Andarist "><code>@Andarist</code></a>! - Upgraded and pinned the version of Stylis - the CSS parser that Emotion uses under the hood.</p>
</li>
<li>
<p>Updated dependencies [<a href="1554a7e264https://github.com/11 "><code>@11</code></a>.7.1</li>
</ul>
</li>
</ul>
<h2><code>@emotion/react</code><a href="https://github.com/11 "><code>@11</code></a>.7.0</h2>
<h3>Patch Changes</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/emotion-js/emotion/pull/2534 ">https://github.com/facebook/flipper/issues/2534 </a> <a href="57be9e8cb2https://github.com/srmagura "><code>@srmagura</code></a>! - Changed the implementation of the runtime label extraction in elements using the css prop (that only happens in development) to one that should yield more consistent results across browsers. This fixes some minor issues with React reporting hydration mismatches that wouldn't happen in production.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="01cca604cahttps://github-redirect.dependabot.com/emotion-js/emotion/issues/2581 ">https://github.com/facebook/flipper/issues/2581 </a>)</li>
<li><a href="1554a7e264https://github-redirect.dependabot.com/emotion-js/emotion/issues/2590 ">https://github.com/facebook/flipper/issues/2590 </a>)</li>
<li><a href="04681a5f52https://github-redirect.dependabot.com/emotion-js/emotion/issues/2577 ">https://github.com/facebook/flipper/issues/2577 </a>)</li>
<li><a href="26ded6109f200bc6a56bhttps://github-redirect.dependabot.com/emotion-js/emotion/issues/2564 ">https://github.com/facebook/flipper/issues/2564 </a>)</li>
<li><a href="f046ae40bchttps://github-redirect.dependabot.com/emotion-js/emotion/issues/2562 ">https://github.com/facebook/flipper/issues/2562 </a>)</li>
<li><a href="57be9e8cb2https://github-redirect.dependabot.com/emotion-js/emotion/issues/2534 ">https://github.com/facebook/flipper/issues/2534 </a>)</li>
<li>See full diff in <a href="https://github.com/emotion-js/emotion/compare/emotion/react@11.6.0...@emotion/react@11.7.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3388
Reviewed By: nikoant
Differential Revision: D33892154
Pulled By: cekkaewnumchai
fbshipit-source-id: 460e820c36c367a4174e7cc44bc4d23340db020a
2022-02-02 11:14:39 -08:00
dependabot[bot]
e26540ddd7
Bump axios from 0.24.0 to 0.25.0 in /desktop ( #3383 )
...
Summary:
Bumps [axios](https://github.com/axios/axios ) from 0.24.0 to 0.25.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/axios/axios/releases ">axios's releases</a>.</em></p>
<blockquote>
<h2>v0.25.0</h2>
<h3>0.25.0 (January 18, 2022)</h3>
<p>Breaking changes:</p>
<ul>
<li>Fixing maxBodyLength enforcement (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3786 ">#3786</a>)</li>
<li>Don't rely on strict mode behaviour for arguments (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3470 ">#3470</a>)</li>
<li>Adding error handling when missing url (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3791 ">#3791</a>)</li>
<li>Update isAbsoluteURL.js removing escaping of non-special characters (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3809 ">#3809</a>)</li>
<li>Use native Array.isArray() in utils.js (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3836 ">#3836</a>)</li>
<li>Adding error handling inside stream end callback (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3967 ">#3967</a>)</li>
</ul>
<p>Fixes and Functionality:</p>
<ul>
<li>Added aborted even handler (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3916 ">#3916</a>)</li>
<li>Header types expanded allowing <code>boolean</code> and <code>number</code> types (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4144 ">#4144</a>)</li>
<li>Fix cancel signature allowing cancel message to be <code>undefined</code> (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3153 ">https://github.com/facebook/flipper/issues/3153 </a>)</li>
<li>Updated type checks to be formulated better (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3342 ">https://github.com/facebook/flipper/issues/3342 </a>)</li>
<li>Avoid unnecessary buffer allocations (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3321 ">https://github.com/facebook/flipper/issues/3321 </a>)</li>
<li>Adding a socket handler to keep TCP connection live when processing long living requests (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3422 ">#3422</a>)</li>
<li>Added toFormData helper function (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3757 ">#3757</a>)</li>
<li>Adding responseEncoding prop type in AxiosRequestConfig (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3918 ">#3918</a>)</li>
</ul>
<p>Internal and Tests:</p>
<ul>
<li>Adding axios-test-instance to ecosystem (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3786 ">#3786</a>)</li>
<li>Optimize the logic of isAxiosError (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3546 ">#3546</a>)</li>
<li>Add tests and documentation to display how multiple inceptors work (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3564 ">#3564</a>)</li>
<li>Updating follow-redirects to version 1.14.7 (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4379 ">#4379</a>)</li>
</ul>
<p>Documentation:</p>
<ul>
<li>Fixing changelog to show corrext pull request (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4219 ">#4219</a>)</li>
<li>Update upgrade guide for https proxy setting (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3604 ">#3604</a>)</li>
</ul>
<p>Huge thanks to everyone who contributed to this release via code (authors listed below) or via reviews and triaging on GitHub:</p>
<ul>
<li><a href="https://github.com/axios/axios/blob/HEAD/mailto:jasonsaayman@gmail.com ">Jay</a></li>
<li><a href="https://github.com/rijkvanzanten ">Rijk van Zanten</a></li>
<li><a href="https://github.com/koh110 ">Kohta Ito</a></li>
<li><a href="https://github.com/bfaulk96 ">Brandon Faulkner</a></li>
<li><a href="https://github.com/NoriSte ">Stefano Magni</a></li>
<li><a href="https://github.com/fanguangyi ">enofan</a></li>
<li><a href="https://github.com/puzpuzpuz ">Andrey Pechkurov</a></li>
<li><a href="https://github.com/doowonee ">Doowonee</a></li>
<li><a href="https://github.com/emilbroman-eqt ">Emil Broman</a></li>
<li><a href="https://github.com/remcohaszing ">Remco Haszing</a></li>
<li><a href="https://github.com/BlackHole1 ">Black-Hole</a></li>
<li><a href="https://github.com/wolframkriesing ">Wolfram Kriesing</a></li>
<li><a href="https://github.com/repl-andrew-ovens ">Andrew Ovens</a></li>
<li><a href="https://github.com/PauloRSF ">Paulo Renato</a></li>
<li><a href="https://github.com/carpben ">Ben Carp</a></li>
<li><a href="https://github.com/wafuwafu13 ">Hirotaka Tagawa</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/axios/axios/blob/master/CHANGELOG.md ">axios's changelog</a>.</em></p>
<blockquote>
<h3>0.25.0 (January 18, 2022)</h3>
<p>Breaking changes:</p>
<ul>
<li>Fixing maxBodyLength enforcement (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3786 ">#3786</a>)</li>
<li>Don't rely on strict mode behaviour for arguments (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3470 ">#3470</a>)</li>
<li>Adding error handling when missing url (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3791 ">#3791</a>)</li>
<li>Update isAbsoluteURL.js removing escaping of non-special characters (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3809 ">#3809</a>)</li>
<li>Use native Array.isArray() in utils.js (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3836 ">#3836</a>)</li>
<li>Adding error handling inside stream end callback (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3967 ">#3967</a>)</li>
</ul>
<p>Fixes and Functionality:</p>
<ul>
<li>Added aborted even handler (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3916 ">#3916</a>)</li>
<li>Header types expanded allowing <code>boolean</code> and <code>number</code> types (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4144 ">#4144</a>)</li>
<li>Fix cancel signature allowing cancel message to be <code>undefined</code> (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3153 ">https://github.com/facebook/flipper/issues/3153 </a>)</li>
<li>Updated type checks to be formulated better (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3342 ">https://github.com/facebook/flipper/issues/3342 </a>)</li>
<li>Avoid unnecessary buffer allocations (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3321 ">https://github.com/facebook/flipper/issues/3321 </a>)</li>
<li>Adding a socket handler to keep TCP connection live when processing long living requests (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3422 ">#3422</a>)</li>
<li>Added toFormData helper function (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3757 ">#3757</a>)</li>
<li>Adding responseEncoding prop type in AxiosRequestConfig (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3918 ">#3918</a>)</li>
</ul>
<p>Internal and Tests:</p>
<ul>
<li>Adding axios-test-instance to ecosystem (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3786 ">#3786</a>)</li>
<li>Optimize the logic of isAxiosError (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3546 ">#3546</a>)</li>
<li>Add tests and documentation to display how multiple inceptors work (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3564 ">#3564</a>)</li>
<li>Updating follow-redirects to version 1.14.7 (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4379 ">#4379</a>)</li>
</ul>
<p>Documentation:</p>
<ul>
<li>Fixing changelog to show corrext pull request (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4219 ">#4219</a>)</li>
<li>Update upgrade guide for https proxy setting (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3604 ">#3604</a>)</li>
</ul>
<p>Huge thanks to everyone who contributed to this release via code (authors listed below) or via reviews and triaging on GitHub:</p>
<ul>
<li><a href="https://github.com/axios/axios/blob/master/mailto:jasonsaayman@gmail.com ">Jay</a></li>
<li><a href="https://github.com/rijkvanzanten ">Rijk van Zanten</a></li>
<li><a href="https://github.com/koh110 ">Kohta Ito</a></li>
<li><a href="https://github.com/bfaulk96 ">Brandon Faulkner</a></li>
<li><a href="https://github.com/NoriSte ">Stefano Magni</a></li>
<li><a href="https://github.com/fanguangyi ">enofan</a></li>
<li><a href="https://github.com/puzpuzpuz ">Andrey Pechkurov</a></li>
<li><a href="https://github.com/doowonee ">Doowonee</a></li>
<li><a href="https://github.com/emilbroman-eqt ">Emil Broman</a></li>
<li><a href="https://github.com/remcohaszing ">Remco Haszing</a></li>
<li><a href="https://github.com/BlackHole1 ">Black-Hole</a></li>
<li><a href="https://github.com/wolframkriesing ">Wolfram Kriesing</a></li>
<li><a href="https://github.com/repl-andrew-ovens ">Andrew Ovens</a></li>
<li><a href="https://github.com/PauloRSF ">Paulo Renato</a></li>
<li><a href="https://github.com/carpben ">Ben Carp</a></li>
<li><a href="https://github.com/wafuwafu13 ">Hirotaka Tagawa</a></li>
<li><a href="https://github.com/lzxb ">狼族小狈</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="5c5cbdf4ba63dfce85abdccaeb1b6851f3ccb08ehttps://github-redirect.dependabot.com/axios/axios/issues/4379 ">#4379</a>)</li>
<li><a href="ccc9516af8https://github-redirect.dependabot.com/axios/axios/issues/4346 ">#4346</a>)</li>
<li><a href="ea0d9c69f7https://github-redirect.dependabot.com/axios/axios/issues/3967 ">#3967</a>)</li>
<li><a href="4fbf61dc75https://github-redirect.dependabot.com/axios/axios/issues/3918 ">#3918</a>)</li>
<li><a href="a76571abechttps://github-redirect.dependabot.com/axios/axios/issues/3836 ">#3836</a>)</li>
<li><a href="a8cd75a081https://github-redirect.dependabot.com/axios/axios/issues/3809 ">#3809</a>)</li>
<li><a href="95792908f0https://github-redirect.dependabot.com/axios/axios/issues/3791 ">#3791</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/axios/axios/compare/v0.24.0...v0.25.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3383
Reviewed By: nikoant
Differential Revision: D33892131
Pulled By: cekkaewnumchai
fbshipit-source-id: 50c82da299e0e8ca025e0a0868a3f5deb31f475c
2022-02-02 11:14:39 -08:00
dependabot[bot]
a63f3d9ee5
Bump @typescript-eslint/eslint-plugin from 5.10.0 to 5.10.1 in /desktop ( #3382 )
...
Summary:
Bumps [typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin ) from 5.10.0 to 5.10.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases "><code>@typescript-eslint/eslint-plugin</code>'s releases</a>.</em></p>
<blockquote>
<h2>v5.10.1</h2>
<h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.0...v5.10.1 ">5.10.1</a> (2022-01-24)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/typescript-eslint</code></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md "><code>@typescript-eslint/eslint-plugin</code>'s changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.0...v5.10.1 ">5.10.1</a> (2022-01-24)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/eslint-plugin</code></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="3e1ebcad55https://github.com/typescript-eslint/typescript-eslint/commits/v5.10.1/packages/eslint-plugin ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3382
Reviewed By: nikoant
Differential Revision: D33892140
Pulled By: cekkaewnumchai
fbshipit-source-id: 5185d0dbb9ad2b3db44b3cc8e32fa07e8192fa6a
2022-02-02 11:14:39 -08:00
Anton Kastritskiy
f2abbf63db
ban interface usage for component props and state
...
Summary: another eslint rule for flipper codebase
Reviewed By: passy
Differential Revision: D33917213
fbshipit-source-id: e60b867d359ef5b94a481edf0eda318ecff17eee
2022-02-02 05:09:45 -08:00
Flipper Bot
34d2a5fa59
Flipper Release: v0.132.0
...
Summary: Releasing version 0.132.0
Reviewed By: mweststrate
Differential Revision: D33939899
fbshipit-source-id: 54617c126600230b41e45bed6cea449b67b81503
2022-02-02 04:10:35 -08:00
Andrey Goncharov
c238cef5b0
Verify certificate provider medium
...
Reviewed By: antonk52
Differential Revision: D33917041
fbshipit-source-id: 91a9554397063d53a903a5b1406b46ddf07360b2
2022-02-02 03:07:00 -08:00
Andrey Goncharov
c7492a83c7
Remove global access to adb client and idb config
...
Summary: Idb and adb sholuld not really be accessed out side of Adnroid and iOS device managers
Reviewed By: lawrencelomax
Differential Revision: D33915162
fbshipit-source-id: 0d1bb028b9a53254cf5b0ce6289ae76339c5a254
2022-02-02 03:07:00 -08:00
Andrey Goncharov
51ef1810b2
Defer initialization of Android and iOS device managers
...
Summary: Remove hidden async initialization of adb and idb. Make it explicit. Remove nullable fields in Android and iOS device managers.
Reviewed By: lawrencelomax
Differential Revision: D33915177
fbshipit-source-id: 882f79310410e0dfde6169abf343ab808644e4a2
2022-02-02 03:07:00 -08:00
Andrey Goncharov
fd13399cb9
Extract WWW certificate provider
...
Summary: Extract WWW certificate provider from the iOS certificate provider. Hide its implementation from OSS since it is not relevant for OSS folks.
Reviewed By: mweststrate
Differential Revision: D33895378
fbshipit-source-id: 376afda3b5fa3857c0eb280b92555314eb1a0d1f
2022-02-02 03:07:00 -08:00
Andrey Goncharov
29f6d0e711
Add device-specific Certificate Providers
...
Reviewed By: mweststrate
Differential Revision: D33821880
fbshipit-source-id: c75c71db4d7dc680f75cf41ba2d5dad009a5fd03
2022-02-02 03:07:00 -08:00
Andrey Goncharov
b9aeaa9339
Enhance iOS device manager tests
...
Reviewed By: lawrencelomax
Differential Revision: D33915694
fbshipit-source-id: fc4bfd30b8f504f2f242f94e61967ee68cc83100
2022-02-02 03:07:00 -08:00
Andrey Goncharov
7bf89a840a
Remove a circular dependency between KeytarManager and FlipperServerImpl
...
Reviewed By: passy
Differential Revision: D33846051
fbshipit-source-id: c83f5609308ad732a02b2ee55466f5ed0918d733
2022-02-02 03:07:00 -08:00
Andrey Goncharov
b1f19ecd68
Extract certificate utils
...
Summary: Extract utilities for certificate server-side certificate handling
Reviewed By: lawrencelomax
Differential Revision: D33820263
fbshipit-source-id: 21f1a9ed5f3b83b8350151bdf6d8862aa0b18e8f
2022-02-02 03:07:00 -08:00
Andrey Goncharov
e686766e5f
Simplify CertificateProvider setup
...
Summary:
Currently, certificateSetup is called in two places:
- processCertificateSigningRequest
- loadSecureServerConfig
`loadSecureServerConfig` is a mandatory step of Flipper server initialization ([ServerController.init](https://www.internalfb.com/code/flipper/[24785758018a2ffbd4751ad2b9093b5ef97c611d]/src/fbsource/xplat/sonar/desktop/flipper-server-core/src/comms/ServerController.tsx?lines=118 )). Flipper cannot start without executing it.
As a result, calling `certificateSetup` in `processCertificateSigningRequest` always results in the early return.
This diff removes executing `certificateSetup` from `processCertificateSigningRequest`. Since it's called only during server setup (so only once), it no longer makes sense to use `didCertificateSetup`.
Next steps:
- Extract Android and iOS certificate utils. Remove the dependency on accessing adb/idb dynamically. See D33711652 (da618fd3f3
2022-02-02 03:06:59 -08:00
Anton Kastritskiy
05a3bb69dc
rename left ts files to tsx and ban ts file extension
...
Summary: mass files rename
Reviewed By: passy
Differential Revision: D33890304
fbshipit-source-id: c057ac9fe87dd7659597c85d640619b93e1ff0e6
2022-02-01 12:38:45 -08:00
Lawrence Lomax
ed03f1b107
Use idb to record devices
...
Summary:
`idb` has supported video recording on devices for quite some time now. We even have the implementation in `iOSDevice`, but it's currently unused.
As a result, we just need to remove the check within `iOSDevice` that the target is an "emulator" and it will use the `idb` implementation. Removing this check means that the button is now selectable within the UI.
Reviewed By: passy
Differential Revision: D33913383
fbshipit-source-id: b3d6b4c480c79b54f0d2c206c68092ab62bf71ed
2022-02-01 04:57:16 -08:00
Lawrence Lomax
3a9c875e03
Avoid double recording in iOSDevice
...
Summary: This should in theory never happen since the state of the recording is also managed within the UI. However, it's better to ensure that if `startRecording` is called twice, without calling `stopRecording` first it will error rather than leak a recording (the first process will still run but the object representing it is oprhaned)
Reviewed By: passy
Differential Revision: D33913298
fbshipit-source-id: f8fa6b0e4fdbdf4282633fa29a736d3e7dedf3bb
2022-02-01 04:57:16 -08:00
Lawrence Lomax
7d34c86f78
Remove recording invariants
...
Summary:
The state of the destination and the process are coupled together. As a result it makes sense to move these to an object type.
This prevents destination and process being independently settable. No change in behaviour, just a removal of invariants that need to be checked
Reviewed By: passy
Differential Revision: D33913213
fbshipit-source-id: ed18650cac4f72d40e82d20254674f7fa12cbb48
2022-02-01 04:57:16 -08:00
Lawrence Lomax
a9b9a1bff4
Remove redundant xcodeCommandLineToolsDetected
...
Summary: This is public but never read, no need for it to exist
Reviewed By: passy
Differential Revision: D33893097
fbshipit-source-id: aa423464f9cc0c35768a549fd5cb481784d8bcd6
2022-02-01 00:44:34 -08:00
Lawrence Lomax
9cbdc3038f
Remove mising iOS Bridge invariant in iOSDeviceManager
...
Summary:
There's no need for us to have a property that can be undefined, since we can use the magic of *passing arguments* to achieve the same end result.
The unit test a bit more precarious, but it's left here for posterity or until we decide to kill it otherwise.
Reviewed By: passy
Differential Revision: D33892407
fbshipit-source-id: 3b499511189862e2265d8d6d29f849a7b813050e
2022-02-01 00:44:34 -08:00
Lawrence Lomax
757b82757e
Use polymorphic IOSBridge to perform iOS target listing
...
Summary:
Bulding on the work from prior diffs we can use the created bridge directly. No need to have if statements calling out to sub-functions, just use the base type itself which will use the appropriate implementation.
There's no behavioural change here. Either idb was queried for sims/devices or simctl was queried for just sims, they were always mutually exclusive.
Reviewed By: passy
Differential Revision: D33842604
fbshipit-source-id: 0bf63ffc34368c70df31c105ea0ba5df941e72cc
2022-02-01 00:44:34 -08:00
Lawrence Lomax
b0046c8ddb
Check for xcode mismatch once and only once
...
Summary:
We perform this *repeatedly* (every 2s!!!). Which is clearly excessive.
Let's perform this check once to avoid noise and a waste of system resources
Reviewed By: passy
Differential Revision: D33844194
fbshipit-source-id: 226dc9d67bb83b167afa8e28ade8e1911470ef8a
2022-02-01 00:44:34 -08:00
Lawrence Lomax
e16662a28f
Improve xcode version mismatch messaging
...
Summary:
This runs in a very hot loop (which I will change shortly)
However, there's also some simplification that we can do here:
- Only look for `Simulator.app` processes instead of all the processes. This limits the amount of string comparison to do. If there's a `Simulator.app` running, then we know a sim is running for that Xcode.
- Use piping to extract the launch path of the process, instead of then regex'ing this out.
- Use a simpler substring match to determine if paths have a different start.
Reviewed By: passy
Differential Revision: D33891296
fbshipit-source-id: e37d5f260fc6c6113be9c5268b7c8cffb4057b9a
2022-02-01 00:44:34 -08:00
Anton Kastritskiy
c5dd1fc350
rename files from ts to tsx in flipper-* packages
...
Summary: mass files rename
Reviewed By: nikoant
Differential Revision: D33890252
fbshipit-source-id: d5afaa60af7340313a97d8e4967fe37f00abd9db
2022-01-31 10:16:19 -08:00
Anton Kastritskiy
2476472344
eslint plugin files rename from ts to tsx
...
Summary: mass rename files
Reviewed By: nikoant
Differential Revision: D33890201
fbshipit-source-id: ac73fb040519a566447981bad37b8c78878a5c3d
2022-01-31 10:16:19 -08:00
Lawrence Lomax
ccae37aa71
Extract idb device querying to IOSBridge
...
Summary:
Again this is just a code move for now.
However, we now have a common method between simctl and idb cases. This means that the next diff can call an `IOSBridge` with polymorpism taking over. This is still delegated out, but there's an argument to be made to move `iosUtil` functionality back so that this all lives in the same place.
Reviewed By: passy
Differential Revision: D33843093
fbshipit-source-id: 5cd884140817df851cccf63e5780582b16d4231c
2022-01-31 07:29:34 -08:00
Lawrence Lomax
aeb0b5f317
Extract getSimulators to IOSBridge
...
Summary:
Extracts `getSimulator` interrnals to `SimctlBridge`. This allows this functionality to be used independently of things like the the flipper server.
For now this just moves the functionality, but future diffs will build on top of this.
Reviewed By: passy
Differential Revision: D33842986
fbshipit-source-id: bae26a9bd5c21c9813f8a2b10c3b3e3efc1c5929
2022-01-31 07:29:34 -08:00
Lawrence Lomax
959a2a77d7
Extract launchSimulator to IOSBridge
...
Summary:
This is related to `simctl` functionality, so can be extracted there.
This will aid in future changes whereby we can hide `getDeviceSetPath` in the IOSBridge module
Reviewed By: passy
Differential Revision: D33842987
fbshipit-source-id: de292ce5afba3e7d79d8ba27c2b8852909d7e6f3
2022-01-31 07:29:34 -08:00
Anton Kastritskiy
48d43c7367
rename from ts to tsx in pkg and pkg-lib
...
Summary: mass rename files
Reviewed By: passy
Differential Revision: D33890034
fbshipit-source-id: 1c654a4f7f5b83eaa56a8c11df863003e8d7bed7
2022-01-31 06:22:56 -08:00
Anton Kastritskiy
844728d9dc
rename babel-transformer files from ts to tsx
...
Summary: group files rename
Reviewed By: passy
Differential Revision: D33889860
fbshipit-source-id: 888e173fc72b5e126c1e41324b6cae6be29274c5
2022-01-31 06:14:59 -08:00
Anton Kastritskiy
69bac4a3d6
Rename second batch for '.ts' files to '.tsx' in plugin-lib dir
...
Summary: Rename first batch for '.ts' files to '.tsx'
Reviewed By: passy
Differential Revision: D33843245
fbshipit-source-id: 28fd161e258e4d20200620b083aea48f9e58ea64
2022-01-31 06:08:28 -08:00
Anton Kastritskiy
75f874a5dd
error for I prefixed interface names
...
Summary: {gif:kosnw403}
Reviewed By: mweststrate
Differential Revision: D33845782
fbshipit-source-id: 2b9bd70e3b2d930e8f4cd8fe7976ac76f43b2496
2022-01-31 05:34:58 -08:00
Anton Kastritskiy
071bcaff96
Rename second batch for '.ts' files to '.tsx' in scripts dir
...
Summary: Rename first batch for '.ts' files to '.tsx'
Reviewed By: passy
Differential Revision: D33843246
fbshipit-source-id: eb8080db8cc3ef07820339bf8deafa208432de7c
2022-01-31 02:57:54 -08:00
Anton Kastritskiy
1aff8466b1
let linter handle type naming conventions
...
Summary: {gif:kosnw403}
Reviewed By: passy
Differential Revision: D33846715
fbshipit-source-id: 5de4bb0cf88f24f5a26acedb82a0816417fb0787
2022-01-31 02:49:09 -08:00
Flipper Bot
65bb2a1bc1
Flipper Release: v0.131.1
...
Summary: Releasing version 0.131.1
Reviewed By: cekkaewnumchai
Differential Revision: D33871323
fbshipit-source-id: f5f5b02ec9fdad303fe60673618b461ef3fa26f1
2022-01-29 11:32:40 -08:00
Anton Kastritskiy
b4fc108c2e
Rename first batch for '.ts' files to '.tsx' in doctor, static and test-utils
...
Summary: Rename first batch for '.ts' files to '.tsx'
Reviewed By: nikoant
Differential Revision: D33843051
fbshipit-source-id: 68dd2dc6538afce2daaf24c6412dc5db8b38acbc
2022-01-28 08:32:19 -08:00
Anton Kastritskiy
4c83fbb524
warn about ts file extension
...
Summary: remove statically analysable life from typescript guidelines and let eslint handle it
Reviewed By: passy
Differential Revision: D33819891
fbshipit-source-id: 3cc3cb512607c3651cd3a9e48228d83bab5bb64a
2022-01-28 05:43:46 -08:00
dependabot[bot]
e9da574720
Bump antd from 4.18.2 to 4.18.5 in /desktop ( #3346 )
...
Summary:
Bumps [antd](https://github.com/ant-design/ant-design ) from 4.18.2 to 4.18.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases ">antd's releases</a>.</em></p>
<blockquote>
<h2>4.18.5</h2>
<ul>
<li>Cascader
<ul>
<li>💄 Fix Cascader loading icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799 ">#33799</a></li>
<li>🐞 Fix Cascader not auto offset placement when popup is out of screen and fix active option out of screen not scroll. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777 ">#33777</a></li>
</ul>
</li>
<li>💄 Fix Tag style in dark theme. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751 ">#33751</a></li>
<li>💄 Fix disabled Checkbox inside Tooltip dom structure. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772 ">#33772</a> <a href="https://github.com/boomler "><code>@boomler</code></a></li>
<li>⚡ ️ Fix invalid hook dependency array in Row and Layout.Sider components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804 ">#33804</a> <a href="https://github.com/mrwd2009 "><code>@mrwd2009</code></a></li>
<li>🐞 Fix Card <code>ref</code> not working. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784 ">#33784</a> <a href="https://github.com/LongHaoo "><code>@LongHaoo</code></a></li>
<li>🐞 Fix a Checkbox problem that <code>onChange</code> could not correctly pass in the modified value when dynamically modifying <code>value</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753 ">#33753</a></li>
</ul>
<hr />
<ul>
<li>Cascader
<ul>
<li>🐞 修复 Cascader 弹层超出屏幕时不会自动偏移以及激活选项不会自动滚动到正确位置的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777 ">#33777</a></li>
<li>💄 修复 Cascader 加载中图标。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799 ">#33799</a></li>
</ul>
</li>
<li>💄 修复 Tag 在暗黑主题下的样式。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751 ">#33751</a></li>
<li>💄 修复 Tooltip 的子元素含有禁用态的 CheckBox 时可能引起的行为和样式异常。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772 ">#33772</a> <a href="https://github.com/boomler "><code>@boomler</code></a></li>
<li>⚡ ️ 优化 Row 和 Layout.Sider 的 hooks 依赖数组。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804 ">#33804</a> <a href="https://github.com/mrwd2009 "><code>@mrwd2009</code></a></li>
<li>🐞 修复 Card <code>ref</code> 不生效的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784 ">#33784</a> <a href="https://github.com/LongHaoo "><code>@LongHaoo</code></a></li>
<li>🐞 修复动态修改 Checkbox 的 <code>value</code> 时 <code>onChange</code> 不能正确传入修改后的值的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753 ">#33753</a></li>
</ul>
<h2>4.18.4</h2>
<ul>
<li>Typography
<ul>
<li>⚡ ️ Optimize Typography to use native css ellipsis when <code>tooltip</code> is configured. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669 ">#33669</a></li>
<li>🐞 Refactor Typography <code>ellipsis</code> logic to fix error when <code>children</code> use Context content. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725 ">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 Fix <code><Icon component={HomeOutlined} /></code> and <code><HomeOutlined /></code> not aligned. (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709 ">ant-design/ant-design#33709</a>)</li>
<li>🐞 Fix <code><Icon component={SyncOutlined} spin /></code> shake. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726 ">#33726</a> <a href="https://github.com/JX-Zhuang "><code>@JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 Fix the display effect for Input related components with <code>hidden</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735 ">#33735</a> <a href="https://github.com/fanerge "><code>@fanerge</code></a> <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706 ">#33706</a> <a href="https://github.com/hydraZty "><code>@hydraZty</code></a></li>
<li>🐞 Fix the warning in console for Input with <code>showCount</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686 ">#33686</a> <a href="https://github.com/whwangms "><code>@whwangms</code></a></li>
</ul>
</li>
<li>⚡ ️ Fix ConfigProvider and Anchor rerender unexpectedly. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723 ">#33723</a> <a href="https://github.com/mrwd2009 "><code>@mrwd2009</code></a></li>
<li>🐞 Fix the duplicate keys warning in console for Cascader. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649 ">#33649</a> <a href="https://github.com/dimbslmh "><code>@dimbslmh</code></a></li>
<li>🐞 Checkbox.Group support number and boolean as options element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678 ">#33678</a></li>
<li>🐞 Fix Form <code>validateMessages</code> bug in multiple ConfigProvider. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33705 ">#33705</a></li>
<li>🐞 Fix Steps the tail part would be hidden when type is navigation and labelPlacement is vertical. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33716 ">#33716</a> <a href="https://github.com/toSayNothing "><code>@toSayNothing</code></a></li>
<li>🐞 Fix Image has bottom blank style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33631 ">#33631</a> <a href="https://github.com/fanerge "><code>@fanerge</code></a></li>
<li>🐞 Fix TreeSelect with keyboard operation missing highlight issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33755 ">#33755</a></li>
<li>🇰🇭 Fix some translations for Khmer (km_KH). <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33738 ">#33738</a> <a href="https://github.com/vireakkeosokvibol "><code>@vireakkeosokvibol</code></a></li>
</ul>
<hr />
<ul>
<li>Typography
<ul>
<li>⚡ ️ 优化 Typography 在配置 <code>tooltip</code> 时优先使用原生省略样式以提升性能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669 ">#33669</a></li>
<li>🐞 重构 Typography <code>ellipsis</code> 逻辑以修复 <code>children</code> 如果消费上游 Context 会报错的问题。 <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725 ">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 修复 <code><Icon component={HomeOutlined} /></code> 和 <code><HomeOutlined /></code> 不对齐的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709 ">#33709</a></li>
<li>🐞 修复 <code><Icon component={SyncOutlined} spin /></code> 抖动的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726 ">#33726</a> <a href="https://github.com/JX-Zhuang "><code>@JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 修复 Input 相关组件设置 <code>hidden</code> 时的展示问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735 ">#33735</a> <a href="https://github.com/fanerge "><code>@fanerge</code></a>，<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706 ">#33706</a> <a href="https://github.com/hydraZty "><code>@hydraZty</code></a></li>
<li>🐞 修复 Input 传入 <code>showCount</code> 时控制台 warning 问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686 ">#33686</a> <a href="https://github.com/whwangms "><code>@whwangms</code></a></li>
</ul>
</li>
<li>⚡ ️ 修复 ConfigProvider 和 Anchor 的渲染函数多次运行的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723 ">#33723</a> <a href="https://github.com/mrwd2009 "><code>@mrwd2009</code></a></li>
<li>🐞 修复 Cascader 组件中出现重复 key 的控制台 warning 问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649 ">#33649</a> <a href="https://github.com/dimbslmh "><code>@dimbslmh</code></a></li>
<li>🐞 Checkbox.Group 的 <code>options</code> 支持数组中直接传入 number 和 boolean 类型。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678 ">#33678</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md ">antd's changelog</a>.</em></p>
<blockquote>
<h2>4.18.5</h2>
<p><code>2022-01-24</code></p>
<ul>
<li>Cascader
<ul>
<li>💄 Fix Cascader loading icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799 ">#33799</a></li>
<li>🐞 Fix Cascader not auto offset placement when popup is out of screen and fix active option out of screen not scroll. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777 ">#33777</a></li>
</ul>
</li>
<li>💄 Fix Tag style in dark theme. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751 ">#33751</a></li>
<li>💄 Fix disabled Checkbox inside Tooltip dom structure. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772 ">#33772</a> <a href="https://github.com/boomler "><code>@boomler</code></a></li>
<li>⚡ ️ Fix invalid hook dependency array in Row and Layout.Sider components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804 ">#33804</a> <a href="https://github.com/mrwd2009 "><code>@mrwd2009</code></a></li>
<li>🐞 Fix Card <code>ref</code> not working. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784 ">#33784</a> <a href="https://github.com/LongHaoo "><code>@LongHaoo</code></a></li>
<li>🐞 Fix a Checkbox problem that <code>onChange</code> could not correctly pass in the modified value when dynamically modifying <code>value</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753 ">#33753</a></li>
</ul>
<h2>4.18.4</h2>
<p><code>2022-01-18</code></p>
<ul>
<li>Typography
<ul>
<li>⚡ ️ Optimize Typography to use native css ellipsis when <code>tooltip</code> is configured. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669 ">#33669</a></li>
<li>🐞 Refactor Typography <code>ellipsis</code> logic to fix error when <code>children</code> use Context content. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725 ">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 Fix <code><Icon component={HomeOutlined} /></code> and <code><HomeOutlined /></code> not aligned. (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709 ">ant-design/ant-design#33709</a>)</li>
<li>🐞 Fix <code><Icon component={SyncOutlined} spin /></code> shake. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726 ">#33726</a> <a href="https://github.com/JX-Zhuang "><code>@JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 Fix the display effect for Input related components with <code>hidden</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735 ">#33735</a> <a href="https://github.com/fanerge "><code>@fanerge</code></a> <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706 ">#33706</a> <a href="https://github.com/hydraZty "><code>@hydraZty</code></a></li>
<li>🐞 Fix the warning in console for Input with <code>showCount</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686 ">#33686</a> <a href="https://github.com/whwangms "><code>@whwangms</code></a></li>
</ul>
</li>
<li>⚡ ️ Fix ConfigProvider and Anchor rerender unexpectedly. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723 ">#33723</a> <a href="https://github.com/mrwd2009 "><code>@mrwd2009</code></a></li>
<li>🐞 Fix the duplicate keys warning in console for Cascader. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649 ">#33649</a> <a href="https://github.com/dimbslmh "><code>@dimbslmh</code></a></li>
<li>🐞 Checkbox.Group support number and boolean as options element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678 ">#33678</a></li>
<li>🐞 Fix Form <code>validateMessages</code> bug in multiple ConfigProvider. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33705 ">#33705</a></li>
<li>🐞 Fix Steps the tail part would be hidden when type is navigation and labelPlacement is vertical. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33716 ">#33716</a> <a href="https://github.com/toSayNothing "><code>@toSayNothing</code></a></li>
<li>🐞 Fix Image has bottom blank style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33631 ">#33631</a> <a href="https://github.com/fanerge "><code>@fanerge</code></a></li>
<li>🐞 Fix TreeSelect with keyboard operation missing highlight issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33755 ">#33755</a></li>
<li>🇰🇭 Fix some translations for Khmer (km_KH). <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33738 ">#33738</a> <a href="https://github.com/vireakkeosokvibol "><code>@vireakkeosokvibol</code></a></li>
</ul>
<h2>4.18.3</h2>
<p><code>2022-01-10</code></p>
<ul>
<li>🆕 Menu support <code>home</code> and <code>end</code> keyboard navigate. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33642 ">#33642</a> <a href="https://github.com/dartamonov-vertex "><code>@dartamonov-vertex</code></a></li>
<li>Table
<ul>
<li>⚡ ️ Improve Table perfermance significantly when mount and unmount. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33554 ">#33554</a></li>
<li>🐞 Fix Table emptynode fixed display. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33610 ">#33610</a> <a href="https://github.com/hemengke1997 "><code>@hemengke1997</code></a></li>
<li>🐞 Fix Table tree data hover error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33638 ">#33638</a> <a href="https://github.com/LongHaoo "><code>@LongHaoo</code></a></li>
</ul>
</li>
<li>Form
<ul>
<li>🐞 Fix Form validateMessages is not correct in default locale. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33511 ">#33511</a></li>
<li>🐞 Fix Form.Item help with empty string makes layout shaking. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33644 ">#33644</a></li>
</ul>
</li>
<li>🐞 Fix Input.Textarea throws error on preact. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33536 ">#33536</a> <a href="https://github.com/developit "><code>@developit</code></a></li>
<li>🐞 Fix PageHeader state update error after unmounted. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33546 ">#33546</a> <a href="https://github.com/wuifdesign "><code>@wuifdesign</code></a></li>
<li>💄 Fix Select tag margin issue when using <code>tagRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33539 ">#33539</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="8217c544da✨ ): release 4.18.5 (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33822 ">#33822</a>)</li>
<li><a href="578aaad7f2ab8fc12fa7https://github-redirect.dependabot.com/ant-design/ant-design/issues/33758 ">#33758</a>)</li>
<li><a href="a65ba8aa8ahttps://github-redirect.dependabot.com/ant-design/ant-design/issues/33816 ">#33816</a>)</li>
<li><a href="e55a68670fhttps://github-redirect.dependabot.com/ant-design/ant-design/issues/33817 ">#33817</a>)</li>
<li><a href="fe23374871https://github-redirect.dependabot.com/ant-design/ant-design/issues/33804 ">#33804</a>)</li>
<li><a href="75adc23fe3https://github-redirect.dependabot.com/ant-design/ant-design/issues/33760 ">#33760</a>)</li>
<li><a href="9cf0dca8fchttps://github-redirect.dependabot.com/ant-design/ant-design/issues/33802 ">#33802</a>)</li>
<li><a href="5d2994ec12https://github-redirect.dependabot.com/ant-design/ant-design/issues/33799 ">#33799</a>)</li>
<li><a href="6dd39c1f89https://github-redirect.dependabot.com/ant-design/ant-design/issues/33772 ">#33772</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/ant-design/ant-design/compare/4.18.2...4.18.5 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3346
Reviewed By: aigoncharov
Differential Revision: D33741775
Pulled By: lblasa
fbshipit-source-id: 82e770ed1c09d3a7f9d71a950014d3555c9367fd
2022-01-28 03:09:50 -08:00
Lawrence Lomax
2573462cec
Use provided idb path in iOSBridge idb execs
...
Summary:
We pass the `idbPath` to only the log listener function, when in reality it should be used by all of these functions that call out to idb.
This could result in some bizzare inconsistencies where some idb functions to fail as they are not using the supplied path
Reviewed By: passy
Differential Revision: D33818298
fbshipit-source-id: f0fb7f26579c646a0d5265364d539dfded711c2e
2022-01-28 00:35:23 -08:00
Lawrence Lomax
e2abe1c89a
Separate concerns of reading screenshot into buffer & execing screenshot function
...
Summary: This allows us to change the way that the command is itself exec'd (for instance to change the idb exec'ing in D33818298)
Reviewed By: passy
Differential Revision: D33818822
fbshipit-source-id: c90b7e58c7476f5db08da0e74e9791230ff97f6f
2022-01-28 00:35:23 -08:00
