Commit Graph

6 Commits

Author SHA1 Message Date
Anton Kastritskiy
b6560e1c74 check xcode-select is using the latest major version available
Reviewed By: mweststrate

Differential Revision: D50369254

fbshipit-source-id: 140a044ca55ec1f445b38e02c7df13cb667d89c6
2023-10-17 16:01:08 -07:00
Anton Kastritskiy
73862c9408 refine typescript type of tryExecuteComand
Summary: You can now descriminate based on `hasProblem`. Thus removing asserting operator

Reviewed By: LukeDefeo

Differential Revision: D50366398

fbshipit-source-id: a16a5419ce946831bd2d1624b1baa75c89a47aa3
2023-10-17 16:01:08 -07:00
Andrey Goncharov
55b7ef934c Augument IDB installation instructions for intern users
Reviewed By: passy

Differential Revision: D37994214

fbshipit-source-id: bd36abf1ed024ca1f18fcc5297108e4ca333c578
2022-07-20 06:03:38 -07:00
Lawrence Lomax
fbd3212994 Add valid path check for xcode-select'd Xcode
Summary: We should also check that Xcode exists at the path that the user has `xcode-select`'d

Reviewed By: passy

Differential Revision: D34168672

fbshipit-source-id: dc7c36bcb2ad1cec99e6ebb4d531417e55402f01
2022-02-11 04:21:05 -08:00
Lawrence Lomax
ef2b03ea95 Specialize error message when no xcode selected
Summary:
We can detect an xcode-select failure earlier on, right now this will be misleading as later healtchecks around `xctrace`/`xcodebuild` will fail and it's not clear why.

If you don't have any Xcode selected, then we can detect this and mark it as an error. This can be done by looking out the output of the command.

To do this we have to propogate the stdout of the shell-out back, so there's a subtype of the regular healtcheck. This is then inspected for it's path since `xcode-select` returns the same exit code if xcode isn't selected or at it's default state.

Reviewed By: passy

Differential Revision: D34168673

fbshipit-source-id: c0aa846bb251aaf026beb976a042b727c7cf1c24
2022-02-11 04:21:05 -08:00
Anton Kastritskiy
b4fc108c2e Rename first batch for '.ts' files to '.tsx' in doctor, static and test-utils
Summary: Rename first batch for '.ts' files to '.tsx'

Reviewed By: nikoant

Differential Revision: D33843051

fbshipit-source-id: 68dd2dc6538afce2daaf24c6412dc5db8b38acbc
2022-01-28 08:32:19 -08:00