Andrey Goncharov
4b5357da7e
Allow relative import from package root inside of top-level fb folder
...
Reviewed By: LukeDefeo
Differential Revision: D44415645
fbshipit-source-id: d19c5144f9ee374cde0727f93f583552664bc806
2023-03-28 02:16:43 -07:00
dependabot[bot]
7481c1fece
Bump @typescript-eslint/experimental-utils from 5.10.1 to 5.10.2 in /desktop ( #3411 )
...
Summary:
Bumps [typescript-eslint/experimental-utils](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/experimental-utils ) from 5.10.1 to 5.10.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases "><code>@typescript-eslint/experimental-utils</code>'s releases</a>.</em></p>
<blockquote>
<h2>v5.10.2</h2>
<h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.1...v5.10.2 ">5.10.2</a> (2022-01-31)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>eslint-plugin:</strong> [no-restricted-imports] allow relative type imports with patterns configured (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/4494 ">#4494</a>) (<a href="4a6d217ae8https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/experimental-utils/CHANGELOG.md "><code>@typescript-eslint/experimental-utils</code>'s changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.1...v5.10.2 ">5.10.2</a> (2022-01-31)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/experimental-utils</code></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="1d88ac1d57https://github.com/typescript-eslint/typescript-eslint/commits/v5.10.2/packages/experimental-utils ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3411
Reviewed By: passy
Differential Revision: D34050514
Pulled By: mweststrate
fbshipit-source-id: 272d07121cbfe0720b23844f50942c5b04fb5809
2022-02-09 02:13:06 -08:00
Anton Kastritskiy
f2abbf63db
ban interface usage for component props and state
...
Summary: another eslint rule for flipper codebase
Reviewed By: passy
Differential Revision: D33917213
fbshipit-source-id: e60b867d359ef5b94a481edf0eda318ecff17eee
2022-02-02 05:09:45 -08:00
Anton Kastritskiy
05a3bb69dc
rename left ts files to tsx and ban ts file extension
...
Summary: mass files rename
Reviewed By: passy
Differential Revision: D33890304
fbshipit-source-id: c057ac9fe87dd7659597c85d640619b93e1ff0e6
2022-02-01 12:38:45 -08:00
Anton Kastritskiy
2476472344
eslint plugin files rename from ts to tsx
...
Summary: mass rename files
Reviewed By: nikoant
Differential Revision: D33890201
fbshipit-source-id: ac73fb040519a566447981bad37b8c78878a5c3d
2022-01-31 10:16:19 -08:00
Anton Kastritskiy
75f874a5dd
error for I prefixed interface names
...
Summary: {gif:kosnw403}
Reviewed By: mweststrate
Differential Revision: D33845782
fbshipit-source-id: 2b9bd70e3b2d930e8f4cd8fe7976ac76f43b2496
2022-01-31 05:34:58 -08:00
Anton Kastritskiy
4c83fbb524
warn about ts file extension
...
Summary: remove statically analysable life from typescript guidelines and let eslint handle it
Reviewed By: passy
Differential Revision: D33819891
fbshipit-source-id: 3cc3cb512607c3651cd3a9e48228d83bab5bb64a
2022-01-28 05:43:46 -08:00
Pascal Hartig
7638afb5d6
Upgrade typescript linter
...
Summary:
Just shows some warnings when running `yarn lint` otherwise about lack of compatibility.
Required updating the rules because of a breaking change here: https://github.com/typescript-eslint/typescript-eslint/pull/3800/files
Reviewed By: lblasa
Differential Revision: D33533052
fbshipit-source-id: fd73d534bbd6e1933321b5811832b05a9739af95
2022-01-13 11:09:43 -08:00
Andres Suarez
79023ee190
Update copyright headers from Facebook to Meta
...
Reviewed By: bhamodi
Differential Revision: D33331422
fbshipit-source-id: 016e8dcc0c0c7f1fc353a348b54fda0d5e2ddc01
2021-12-27 14:31:45 -08:00
Pascal Hartig
3431206c0e
Add linter for naked console.errors
...
Summary:
`console.error(err)` are hard to identify in the codebase especially
as we often don't have reliable stack trace information.
I've already cleaned up a bunch of them manually by going after the most
high-firing ones; this should make it easier to identify the remaining ones.
Reviewed By: jknoxville
Differential Revision: D27913964
fbshipit-source-id: 0ff6624a0c083829846550b40954945d655b7cf6
2021-04-22 05:23:09 -07:00
Pascal Hartig
d42932c111
Add rule for warning against electron.remote
...
Summary:
I don't think there's an easy way to do this based on types
which would be ideal ...
So instead I'm checking for
- Importing `remote` from `electron`.
- Accessing `electron.remote`.
You can still hack this by importing `electron`, saving
it to a differently named variable and accessing `remote` on it,
but this should cover all reasonable cases we see in real code.
Reviewed By: mweststrate
Differential Revision: D26453006
fbshipit-source-id: 4b3d223bed43ca3f0d1a4f592ea8f8060a823479
2021-02-16 04:15:51 -08:00
Anton Nikolaev
4a1c2a9ece
Custom eslint rule for disallowing cross-package references
...
Summary:
Added infra for writing and using custom eslint rules and created a rule for disallowing cross-package file imports. Such imports are anti-pattern and they also break standalone plugin bundling.
We still have a bunch of places where Flipper core references code directly from plugins. I've ignored these places for now and added task T71355623 to revisit them.
Reviewed By: passy
Differential Revision: D22998955
fbshipit-source-id: d04cff8fc115ba1300a7e6830306ec134046e927
2020-08-07 10:22:04 -07:00
