Summary:
## The devDependency [flow-bin](https://github.com/flowtype/flow-bin) was updated from `0.110.0` to `0.110.1`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [gabelevi](https://www.npmjs.com/~gabelevi)
**License:** MIT
[Find out more about this release](https://github.com/flowtype/flow-bin).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/602
Reviewed By: jknoxville
Differential Revision: D18169249
Pulled By: passy
fbshipit-source-id: bdffb1c439dbe3daf2120bf77027209080fb6213
Summary:
## There have been updates to the *react* monorepo:
- The `dependency` [react](https://github.com/facebook/react) was updated from `16.10.2` to `16.11.0`.
- The `dependency` [react-dom](https://github.com/facebook/react) was updated from `16.10.2` to `16.11.0`.
- The `dependency` [react-test-renderer](https://github.com/facebook/react) was updated from `16.10.2` to `16.11.0`.
These versions are **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
This monorepo update includes releases of one or more dependencies which all belong to the [react group definition](https://github.com/greenkeeperio/monorepo-definitions).
---
**Publisher:** [acdlite](https://www.npmjs.com/~acdlite)
**License:** MIT
[Find out more about this release](https://github.com/facebook/react).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/598
Reviewed By: jknoxville
Differential Revision: D18083376
Pulled By: passy
fbshipit-source-id: aeec94f1fa1c2d097b525824bf38b1db65f90401
Summary:
Another attempt of D17736468. This time all the breaking
deps should have been found and fixed by greenkeeper.
Reviewed By: jknoxville
Differential Revision: D18059567
fbshipit-source-id: c7f1225af6d7d2842f0a1488637f52651b341598
Summary:
It's already a promise. With the next upgrade this otherwise causes
some nasty type errors due to overloading.
Reviewed By: jknoxville
Differential Revision: D18059641
fbshipit-source-id: 93cee95d7bbf767ff6276a0946262bf83587c728
Summary:
## The devDependency [flow-bin](https://github.com/flowtype/flow-bin) was updated from `0.109.0` to `0.110.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [gabelevi](https://www.npmjs.com/~gabelevi)
**License:** MIT
[Find out more about this release](https://github.com/flowtype/flow-bin).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/597
Reviewed By: jknoxville
Differential Revision: D18058618
Pulled By: passy
fbshipit-source-id: 725a80e04df811a7e2d6ed7161cf8a940002694c
Summary:
## The dependency [ws](https://github.com/websockets/ws) was updated from `7.1.2` to `7.2.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [lpinca](https://www.npmjs.com/~lpinca)
**License:** MIT
[Find out more about this release](https://github.com/websockets/ws).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/595
Reviewed By: jknoxville
Differential Revision: D18036025
Pulled By: passy
fbshipit-source-id: fc897470cbd05fb6605a7816fc8bd72476192957
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/592
Finally we can join the 21st century and use `jest.mock` in tests!
I'm enabling the ts-jest transform to `*/__tests__/*.tsx` files. This takes care of transforming the typescript, and preserves jest mock capabilities.
I have left the existing custom transform on all other files, so they will continue to work as usual.
Caveats:
* Our existing custom transforms will no longer be applied in tests.
* With our current suite this makes no difference. But bear in mind things like importing directly from 'flipper' instead of the actual files, won't work. However, I don't see this being a problem, as I think they'll only be needed inside the actual product code.
Reviewed By: passy
Differential Revision: D17978753
fbshipit-source-id: df7b312b5dd5592e4aa4f8df605f5952ea3158e9
Summary:
Let’s get started with automated dependency management for flipper 💪🔒 Greenkeeper has found a `yarn.lock` file in this repository. Greenkeeper supports lockfile updates for public packages. If you use private packages in your repository, please use [greenkeeper-lockfile](https://github.com/greenkeeperio/greenkeeper-lockfile) to make sure these can get updated as well.
This pull request **updates all your dependencies to their latest version**. Having them all up to date really is the best starting point for keeping up with new releases. Greenkeeper will look out for further dependency updates and make sure to handle them in isolation and in real-time, but only after **you merge this pull request**.
**Important: Greenkeeper will only start watching this repository’s dependency updates after you merge this initial pull request**.
📦📦 Greenkeeper has detected multiple `package.json` files. Since this repo already has a `greenkeeper.json` config file with defined groups, Greenkeeper has only checked whether they’re still valid.
---
<details>
<summary>🏷 How to check the status of this repository</summary>
Greenkeeper adds a badge to your README which indicates the status of this repository.
This is what your badge looks like right now 👉 
</details>
<details>
<summary>🙈 How to ignore certain dependencies</summary>
You may have good reasons for not wanting to update to a certain dependency right now. In this case, you can [change the dependency’s version string in the `package.json` file back to whatever you prefer](https://github.com/facebook/flipper/edit/greenkeeper/initial/package.json).
To make sure Greenkeeper doesn’t nag you again on the next update, add a `greenkeeper.ignore` field to your `package.json`, containing a list of dependencies you don’t want to update.
```js
// package.json
{
…
"greenkeeper": {
"ignore": [
"package-names",
"you-want-me-to-ignore"
]
}
}
```
</details>
<details>
<summary>👩💻 How to update this pull request</summary>
```bash
# Change into your repository’s directory
git fetch --all
git checkout greenkeeper/initial
npm install-test
# Adapt your code until everything works again
git commit -m 'chore: adapt code to updated dependencies'
git push https://github.com/facebook/flipper.git greenkeeper/initial
```
</details>
<details>
<summary>✨ How do dependency updates work with Greenkeeper?</summary>
After you merge this pull request, **Greenkeeper will create a new branch whenever a dependency is updated**, with the new version applied. The branch creation should trigger your testing services and check whether your code still works with the new dependency version. Depending on the the results of these tests Greenkeeper will try to open meaningful and helpful pull requests and issues, so your dependencies remain working and up-to-date.
```diff
- "underscore": "^1.6.0"
+ "underscore": "^1.7.0"
```
The above example shows an in-range update. `1.7.0` is included in the old `^1.6.0` range, because of the [caret `^` character ](https://docs.npmjs.com/misc/semver#ranges).
When the test services report success Greenkeeper will silently delete the branch again, because no action needs to be taken – everything is fine.
However, should the tests fail, Greenkeeper will create an issue to inform you about the problem immediately.
This way, you’ll never be surprised by a dependency breaking your code. As long as everything still works, Greenkeeper will stay out of your way, and as soon as something goes wrong, you’ll be the first to know.
```diff
- "lodash": "^3.0.0"
+ "lodash": "^4.0.0"
```
In this example, the new version `4.0.0` is _not_ included in the old `^3.0.0` range.
For version updates like these – let’s call them “out of range” updates – you’ll receive a pull request.
This means that **you no longer need to check for new versions manually** – Greenkeeper will keep you up to date automatically.
These pull requests not only serve as reminders to update: If you have solid tests and good coverage, and the pull requests passes those tests, you can very likely just merge it and release a new version of your software straight away :shipit:
To get a better idea of which ranges apply to which releases, check out the extremely useful [semver calculator](https://semver.npmjs.com/) provided by npm.
</details>
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Good luck with your project and see you soon ✨
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/591
Reviewed By: jknoxville
Differential Revision: D17951583
Pulled By: passy
fbshipit-source-id: 6ad2bfe7d4a9f7ed4920e50af36e194dc5b1cb93
Summary:
Last one blocking Greenkeeper.
Only change affecting us appears to be where to import from.
Reviewed By: jknoxville
Differential Revision: D17932089
fbshipit-source-id: b913defdabd99721886557d7c92afb8181ca1803
Summary:
Newer rsocket packages are borked; don't have a `main` attribute anymore.
Need to be looked into separately. This is to unblock greenkeeper activation.
Based on https://github.com/facebook/flipper/pull/587/files
Reviewed By: jknoxville
Differential Revision: D17928918
fbshipit-source-id: 3ec38c5740f115883e8534776a96d8a8d6ea6b1e
Summary:
Close https://github.com/facebook/flipper/pull/580
This enables Greenkeeper with some caveats:
- I disabled a bunch of upgrades we know currently break:
- React
- Emotion
- Electron/Electron-Builder
- The bot isn't CLA-whitelisted yet, so we won't be able to directly import yet.
- It might actually be better to have automatic tasks created for the dependencies above breaking.
- Something changed in the prop types and required `StatusBar` to have its signature changed.
allow-large-files
Reviewed By: jknoxville
Differential Revision: D17906693
fbshipit-source-id: f73fe231518f56a6f6114f761d5e5e5528d0d487
Summary: We still use it in some places. Up to 109 before we get kicked off Sandcastle.
Reviewed By: jknoxville
Differential Revision: D17906687
fbshipit-source-id: 391e29add37b6cf5c5dbb9dd9c0743e130cc4381
Summary: Not a fan of the long lines, but if that's where prettier is going, let's roll with it.
Reviewed By: jknoxville
Differential Revision: D17905599
fbshipit-source-id: c4232d46d2ec0b7c743f6afd8349106c85f013b9
Summary:
The existing rendering library doesn't work properly
with hooks. This one provides some pretty powerful
DOM-based testing APIs like waiting for elements to
appear and clicking, which we can use in various
areas.
Reviewed By: jknoxville
Differential Revision: D17787423
fbshipit-source-id: 9eb12f34ae2bc76b679fd28ee25262ce01a5e772
Summary: It's a bit nicer to be able to see if there are any changes made, and save restarting flipper when nothing has changed.
Reviewed By: passy
Differential Revision: D17738036
fbshipit-source-id: 3d7cdc5be1bf948094c3df54439625e5052a9a2f
Summary:
Instead of our ad-hoc mechanism. There's quite a bit
of trickery involved to make this work reliably on Windows
so I'd rather take an off-the-shelf solution than reimplement this
myself.
Reviewed By: jknoxville
Differential Revision: D17628949
fbshipit-source-id: 98806b60a107231d9ee07b721ebb70f2cbd8aec1
Summary:
In the previous implementation plugins were downloaded from npm, but dependencies weren't. This diff uses the `live-plugin-manager` which does mostly what we want. It install a package from NPM with all its dependencies.
live-plugin-manager puts the plugin and its dependencies in the same folder. We expect the plugins to be in `node_modules`. For this reason, we are installing the plugin into `$pluginName/node_modules` and move the plugin after the installation out of the `node_modules` folder.
* Fixed plugin loading path for thirdparty plugins.
* Disabled hot reloading for plugins in the flipper folder to prevent reloads when moving around files and installing dependencies here.
* an empty `.watchmanconfig` is created, because metro requires it
* tsx files are added to the list of supported extensions for metro
Reviewed By: passy
Differential Revision: D17570413
fbshipit-source-id: ecbedc60841b36188fec9c83da41ef1f27e5e155
Summary:
My MBP just crashed again during startup. I would like to
understand why every plugin compilation appears to start
up a new electron process, but until that's understood
and hopefully fixed, it's probably best to limit the number
of processes we spawn by setting an upper bound here.
N.B. My Linux box doesn't mind this at all.
Reviewed By: jknoxville, danielbuechele
Differential Revision: D17419289
fbshipit-source-id: a11562a21a984059dc35e826eb20d869df218546
Summary: Setting up a sheet to list plugins that can be installed from NPM
Reviewed By: jknoxville
Differential Revision: D17394824
fbshipit-source-id: 26c6ffea9de9cf3fe8488ea1a757eae7b7aaa7ef
Summary: Finally we are able to switch back from our adbkit-fb fork to the original `adbkit`. Replacing all imports
Reviewed By: jknoxville
Differential Revision: D17343236
fbshipit-source-id: e6dd328f1a956544e8be2ab768aa270972463c6b
Summary:
This one is in TS, so we get types for free.
`promisify` makes it rather awkward to work with overloaded
functions like `spawn`, so there's still value in having
a proper library for this.
Reviewed By: jknoxville
Differential Revision: D17204471
fbshipit-source-id: 3d07edfe2bb8c1e4c4f3134b53a0c4a0d9be383b
Summary:
Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.2.
<details>
<summary>Commits</summary>
- [`4e1bc07`](4e1bc077c2) 1.4.2
- [`e4cb014`](e4cb01498d) 🐛 add null test
- [`230a4e2`](230a4e2275) 1.4.1
- [`08158db`](08158db1c9) 🐛 fix getStaticValue security issue
- [`587cca2`](587cca2f82) 🐛 fix getStringIfConstant to handle literals correctly
- [`c119e83`](c119e83295) 🐛 fix getStaticValue to handle bigint correctly
- See full diff in [compare view](https://github.com/mysticatea/eslint-utils/compare/v1.4.0...v1.4.2)
</details>
<br />
[](https://help.github.com/articles/configuring-automated-security-fixes)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/flipper/network/alerts).
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/526
Reviewed By: danielbuechele
Differential Revision: D17074295
Pulled By: passy
fbshipit-source-id: f416d2c5b5f300c60694a3e411f16c585fb52afb
Summary:
This Diff is being posted for discussion purposes. It will not be ready to land until React DevTools v4 has been published to NPM.
Update React Native to be compatible with the [new version 4 React DevTools extension](https://github.com/bvaughn/react-devtools-experimental).
**Note that this is a breaking change**, as the version 3 and version 4 backends are **not compatible**. Once this update ships (in React Native) users will be required to update their version of the [`react-devtools` NPM package](https://www.npmjs.com/package/react-devtools). The same will be true for IDEs like Nuclide as well as other developer tools like Flipper and [React Native Debugger](https://github.com/jhen0409/react-native-debugger).
Related changes also included in this diff are:
* Pass an explicit whitelist of style props for the React Native style editor (to improve developer experience when adding new styles).
* Update `YellowBox` console patching to coordinate with DevTools own console patching.
* Also improved formatting slightly by not calling `stringifySafe` for strings (since this adds visible quotation marks).
Regarding the console patching- component stacks will be appended by default when there's no DevTools frontend open. The frontend will provide an option to turn this behavior off though:
{F168852162}
React DevTools will detect if the new version is used with an older version of React Native, and offer inline upgrade instructions:
{F169306863}
**Note that the change to the `RCTEnableTurboModule` will not be included in this Diff**. I've just turned those off temporarily so I can use v8+Chrome for debugging.
Reviewed By: rickhanlonii
Differential Revision: D15973709
fbshipit-source-id: bb9d83fc829af4693e7a10a622acc95a411a48e4
Summary:
This converts the index file to TypeScript which is used as an export for all plugins. Alongside, I had to fix a couple of errors in various files to make sure everything works correctly.
For plugins using flow, we define an interface which uses the type definition for FlipperPlugin and types all UI components as `any`.
Reviewed By: passy
Differential Revision: D16936890
fbshipit-source-id: dacd9a63a82b9f0bbb530b06072186874cba7b6f
Summary: We need this as part of the migration for react-dom types.
Reviewed By: jknoxville
Differential Revision: D16668683
fbshipit-source-id: c50be446ada5539961c89da9f3bd3f240db4ec4c
Summary:
This is the result of a `yarn upgrade`. While this *shouldn't* break
anything, it easily can just as this broke the babel transform
because a previously transitively depended upon library was no
longer included.
It seems like a good idea to stay as close as possible to the upstream of all
the dependencies we have and with the release yesterday we now have one week to
check if the rest works as expected.
allow-large-files
Reviewed By: danielbuechele
Differential Revision: D16579807
fbshipit-source-id: f26d4536abd80f428e94b71e0fa98df612cbd809
Summary: This is just to clear a security warning.
Reviewed By: danielbuechele
Differential Revision: D16542869
fbshipit-source-id: 910c421292efeff2d65769e0c00cea7e4653233d
Summary: This is required to properly run eslint in Atom/VSCode on TypeScript files
Reviewed By: jknoxville
Differential Revision: D16201418
fbshipit-source-id: 31da04c2d313e9147e0f868c1af15bf3115e6d6a
Summary:
It appears that Electron (or the version of Chromium it uses) has a bug that causes a `webview` process to crash if `URL.createObjectURL` is used.
Before releasing `react-devtools-core` 3.5.0, we updated Webpack and the loaders we used. Apparently the version of `style-loader` we now use makes use of the `URL.createObjectURL` API for CSS source maps. This triggers the `webview` crash I mentioned above.
The fix for this is to disable CSS source maps, in which case the loader just uses a `<style>` tag. This diff updates Nuclide to pull in this fixed version.
Reviewed By: bestander
Differential Revision: D16518772
fbshipit-source-id: a779b7d310f869793fa05988d138ce6a46840d8c
Summary:
Original commit changeset: bdbd61bce1bc
That change appears to be causing some issues for open source users: https://github.com/facebook/flipper/issues/498
To mitigate the issue I'm reverting it, the change turns out to be unnecessary anyway.
Reviewed By: passy
Differential Revision: D16486136
fbshipit-source-id: 70decca6e017a6a2903cc484641fb2e736dc5d7c
