jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
7,833 Commits 1 Branch 0 Tags
b31f8c8755a04b34091ae30a86a9110e4b51a2a5
Commit Graph

171 Commits

Author SHA1 Message Date
Andrey Goncharov
851270589f Use flipper lib implementation from flipper-frontend-core in flipper-ui-core 
Summary: See D37139129

Reviewed By: lblasa

Differential Revision: D37236771

fbshipit-source-id: 7f93140f72e89cb4a7907f07cceec1fed50cb66b
 2022-06-20 12:18:40 -07:00
Andrey Goncharov
17ab7a86ef Use getRenderHost from flipper-frontned-core in flipper-ui-core 
Summary: See D37139129

Reviewed By: lblasa

Differential Revision: D37236435

fbshipit-source-id: 927e9f741bfedb65165f5d24f0acfb775925cdc7
 2022-06-20 12:18:40 -07:00
Andrey Goncharov
fab8849c73 Use TestDevice from flipper-frontend-core in flipper-ui-core 
Summary: See D37139129

Reviewed By: lblasa

Differential Revision: D37235567

fbshipit-source-id: a0596ba71fcb8722088e51361774389a7daaebb8
 2022-06-20 12:18:40 -07:00
Andrey Goncharov
a648861273 Use ArchivedDevice from flipper-frontend-core in flipper-ui-core 
Summary: See D37139129

Reviewed By: lblasa

Differential Revision: D37235514

fbshipit-source-id: 54124f2b9768b068ae667b27171eaa05a693b398
 2022-06-20 12:18:40 -07:00
Andrey Goncharov
fd380a4c1e Use BaseDevice from flipper-frontend-core in flipper-ui-core 
Summary: Use BasDevice definition from flipper-frontend-core in flipper-ui-core and remove the redundant definition from flipper-ui-core

Reviewed By: lblasa

Differential Revision: D37234785

fbshipit-source-id: 6e768090a197c1d2c49cb1cd573acea12fb65d24
 2022-06-20 12:18:40 -07:00
Andrey Goncharov
ef5fa275a3 Use AbstractClient from flipper-frontend-core in fliper-ui-core 
Summary: This stack attempts to start using flipper-frontend-core from flipper-ui-core. Currently, flipper-frontend-core contains lots of copy-pasted code from flipper-ui-core.

Reviewed By: lblasa

Differential Revision: D37139198

fbshipit-source-id: 042db7492c550e10ea72c32fd15001c141bf53f9
 2022-06-20 12:18:40 -07:00
Pascal Hartig
b25a212890 Remove SupportRequestFormV2 
Summary: This is now replaced by the support entry point and we need to delete the calling sites before we can clean up the everstore type.

Reviewed By: lawrencelomax

Differential Revision: D37090901

fbshipit-source-id: 597684bb149783d75e46ba61113e73878bf271a8
 2022-06-13 07:16:47 -07:00
Andrey Goncharov
59761ecd50 Mark deprecated plugins in the UI 
Summary:
Changelog: Add a deprecation warning for deprecated plugins.

Closes https://github.com/facebook/flipper/issues/2074

Reviewed By: lblasa, antonk52

Differential Revision: D36760209

fbshipit-source-id: 64cf799644f28aeedf88824c949738a6a766b094
 2022-05-30 07:32:12 -07:00
Pascal Hartig
db045a3b21 Send isHeadlessBuild flag in error reporting 
Summary:
Andrey's diff already ensures that we send the flag, this also adds it to the info string
which makes it more visible.

Reviewed By: lblasa

Differential Revision: D36699070

fbshipit-source-id: 905eded9612b19ecaa35a841ec240af002e11611
 2022-05-30 03:44:28 -07:00
Michel Weststrate
15e9d105c4 Restore styleguide menu entry, reordered menu 
Summary: The styleguide was no longer accessible in Flipper, this diff restores that, and also cleans up the extras menu a bit to by creating a plugin devs only section.

Reviewed By: antonk52

Differential Revision: D36697071

fbshipit-source-id: a2abce40157fffd4952172f379c8063492e2dcc0
 2022-05-26 04:26:20 -07:00
Michel Weststrate
9111b66916 Document Container grow / shrink properties 
Summary: For some reason, the most important container property grow (and shrink) wasn't in the docs. Added that

Reviewed By: antonk52

Differential Revision: D36697072

fbshipit-source-id: 45dd0351e2a94d31972d57a9f006cd06a0d37c4e
 2022-05-26 04:26:20 -07:00
Lorenzo Blasa
6d2bc5cc9a Refactor some of the types used by FBLogger into Logger 
Summary:
^

This change aims to extract some bits and pieces that are not specific to FBLogger and could be used by other Logger implementations.

Reviewed By: passy

Differential Revision: D36473286

fbshipit-source-id: 57f02d132673dbac97384da4dca51bf3e6fb8738
 2022-05-24 10:23:42 -07:00
Pascal Hartig
a73f736d92 Launch emulator error message 
Summary:
It's not obvious for non-mobile developers how to fix it when there are no emulators available. Adding a quick section in the troubleshooting guide and linking to it.

Changelog: Add link to troubleshooting page when no emulators are available.

Reviewed By: nikoant

Differential Revision: D36599925

fbshipit-source-id: f3a1e79e07209e34b66176102c85e7797292978c
 2022-05-24 07:55:40 -07:00
Pascal Hartig
f84f56614d Loading state for emulator launcher 
Summary:
Our current loading state holder for the emulator launch dialogue is a "No emulators available" error message which may stay there for up to 5 seconds (in the case of only iOS enabled) before we see devices.

This adds a proper spinner that will show for as long there are pending device queries.

Changelog: Loading state for emulator launch dialogue

Reviewed By: nikoant

Differential Revision: D36598855

fbshipit-source-id: 64099596b48708b48a43f0208696a7dddc15007c
 2022-05-24 07:55:40 -07:00
Pascal Hartig
fe29183014 Show custom messages for no SDKs in Launch Emulator dialog 
Summary:
Our launch emulator button isn't very helpful when you don't have any SDKs set up as it shows you exactly the same message as if it was loading for a bit longer. We've seen a low, but constant flow of support requests and it's often not easy to debug remotely unless you dig into the state export.

This sets up a new actionable message when you have neither Android nor iOS support enabled and sends you straight to the settings.

Changelog: Show alert in Launch Emulator dialogue if no SDKs are enabled

Reviewed By: mweststrate

Differential Revision: D36596972

fbshipit-source-id: ba72e9aaeb136c1a7e2f360ef9fbbeec6bc76f4d
 2022-05-24 07:55:40 -07:00
Pascal Hartig
b185cabbc2 Fix height of launch emu window 
Summary:
A paper cut that hurt me so many times. The launch emulator window gets populated by external commands that finish at interminate points in time and change the size, jiggling the buttons around. That means, you may hover over an android emulator just when the iOS command returns and when you click, you don't hit the Android emu, but some iOS thing.

This just makes the height fixed, so this cannot happen.

Still having some more improvements in mind as this is such a high-trafficked surface.

Chanlog: Fix wiggling of the Launch Emulator dialogue as data comes in

Reviewed By: mweststrate

Differential Revision: D36595001

fbshipit-source-id: e61de55f348ab4d2f6f977552539d2a44d3fd11d
 2022-05-23 11:25:33 -07:00
Muzammil Mahmood
ec6f732b09 Prevent TypeError exception on missing column. 
Summary: Fix a TypeError exception in TableHead.tsx when an ordered column is not present in the row.

Reviewed By: aigoncharov

Differential Revision: D36497494

fbshipit-source-id: 18c961468fc2bc3cca16290fd9e6c973e5e18ebf
 2022-05-20 02:54:00 -07:00
Kevin Strider
0b16f3a031 NEW troubleshooting section (SetUp) 
Summary: Restyle of Trobleshooting, which involved changes to sidebar.js and splitting up the previous troubleshooting page into five separate pages.

Reviewed By: lblasa

Differential Revision: D36282539

fbshipit-source-id: e60834e2b4d98b70b23bb11309c3438d85e4de0e
 2022-05-11 08:58:34 -07:00
Andrey Goncharov
ad76060614 Expose intern graphQL reuqests to plugins 
Summary: Some intern plugins use it, an dit is currently missing in FlipperLib

Reviewed By: timur-valiev

Differential Revision: D36313032

fbshipit-source-id: 5ea8e250f1d0bc8831727abd883d953286a022d4
 2022-05-11 06:48:05 -07:00
Andrey Goncharov
3ac93d301a Remove optional in plugin init/deinit 
Reviewed By: mweststrate

Differential Revision: D35965072

fbshipit-source-id: 0be6b538d371e41b438263a6a4161b079861b293
 2022-05-10 05:13:24 -07:00
Pascal Hartig
39317adfb7 Disable flaky PluginContainer test (#3693) 
Summary:
Keeps flaking out: https://github.com/facebook/flipper/runs/6308722109?check_suite_focus=true

Pull Request resolved: https://github.com/facebook/flipper/pull/3693

Reviewed By: aigoncharov

Differential Revision: D36170437

Pulled By: passy

fbshipit-source-id: 471e702243d68d927287aad5d1fc1d8c392b059c
 2022-05-09 03:35:52 -07:00
Anton Nikolaev
46340fa30a Fix UI freezes on popup opening by upgrading back React app creation from "createRoot" to "ReactDOM.render" 
Summary: Fix UI freezes on popup opening by upgrading back React app creation from "createRoot" to "ReactDOM.render". These UI freezes started to happen after React upgrade because the issue in integration of Antd with React 18: https://github.com/react-component/trigger/issues/288

Reviewed By: aigoncharov

Differential Revision: D35359129

fbshipit-source-id: eb0ad979443ecf67eb2acc2e219196c9fefcff62
 2022-04-04 08:00:06 -07:00
Andrey Goncharov
ba9a80545d Support globally installed React DevTools 
Summary:
- Support loading globally installed DevTools

Background:
1. Initially, I wanted to use react-devtools-core as before. react-devtools-core standalone contains quite a few imports of node.js APIs. After [a conversation with Brian](https://fb.workplace.com/groups/react.devtools/permalink/3131548550392044), I pivoted to react-devtools-inline
2. Technical design doc of react-devtools-inline integration: https://docs.google.com/document/d/1STUSUhXzrW_KkvqSu7Ge-rxjVFF7oU3_NbwzimkO_Z4
3. We support usage of globally installed devtools. Code of react-devtools-inline is not ready to be used by the browser as is. We need to bundle it and substitute React and ReactDOM imports with the globals.
4. As we can't pre-compile what users install globally, we need to bundle global devtools on demand,
5. I tried re-using our Metro bundling pipeline initially, but gave up after fighting it for 2 days. Included, `rollup` instead.
6. Size of a `tgz` archive with a plugin is 2.1MB

allow-large-files

Reviewed By: mweststrate

Differential Revision: D34968770

fbshipit-source-id: 352299964ccc195b8677dbda47db84ffaf38737b
 2022-03-31 04:01:33 -07:00
Andrey Goncharov
1f83b4b414 Migrate to React 18 
Summary:
Sadly, we have to use the experimental version of React to decapitate React Devtools.
See https://fb.workplace.com/groups/react.devtools/posts/3135684459978453/?comment_id=3135711763309056&reply_comment_id=3135760513304181

On the bright side, Replay.io and Code Sandbox also use experimental React without any problem.

Reviewed By: lblasa

Differential Revision: D34926473

fbshipit-source-id: 5cd63cc065c2535f0583464c7b5e37891dadaf14
 2022-03-31 04:01:33 -07:00
Michel Weststrate
011c5eeafa Fix expired tokens showing as being correctly logged in 
Summary: In the category "how did this ever work", we had quite some reports of Flipper features not working while users are seemingly logged in. The cause of that is because the user info gets stored in the user reducer, so even when the network requests fail, the users appear to be logged in.

Reviewed By: nikoant

Differential Revision: D35114048

fbshipit-source-id: b8c09cb4e3fd7cd0cbe87ecb06dafca88716b689
 2022-03-24 07:52:48 -07:00
dependabot[bot]
7f68a4d673 Bump antd from 4.18.5 to 4.19.2 in /desktop (#3551) 
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/3551

Bumps [antd](https://github.com/ant-design/ant-design) from 4.18.5 to 4.19.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p>
<blockquote>
<h2>4.19.2</h2>
<ul>
<li>🐞 Fix Dropdown not auto adjust placement when position on the edge of window. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34390">#34390</a></li>
<li>💄 Change PageHeader elements margin from <code>12px</code> to <code>8px</code> inside <code>extra</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34428">#34428</a></li>
<li>🛠 Export css variable function in <code>antd/es/config-provider</code> folder to enable ssr requirement. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34436">#34436</a></li>
<li>🛠 Refactor Menu with React hooks. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34433">#34433</a></li>
<li>Input
<ul>
<li>💄 Fix Input font-size when <code>size</code> is large. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34381">#34381</a></li>
<li>💄 Fix Input.Group wrong border when status is error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34412">#34412</a></li>
</ul>
</li>
<li>Form
<ul>
<li>🐞 Fix Form.Item removed in <code>form.validateFields</code> throw <code>Can't perform a React state update on an unmounted component</code> warning. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34405">#34405</a></li>
<li>🐞 Fix to Form that <code>initialValues</code> would change if <code>preserve</code> is false. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34411">#34411</a></li>
</ul>
</li>
<li>Tooltip
<ul>
<li>💄 Fix Tooltip width in Safari. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34415">#34415</a> <a href="https://github.com/jiandandkl"><code>@​jiandandkl</code></a></li>
<li>💄 Fix arrow size of Tooltip/Popover/Popconfirm. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34407">#34407</a></li>
</ul>
</li>
<li>💄 Remove Collapse bottom border in simple style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34366">#34366</a> <a href="https://github.com/PanStar"><code>@​PanStar</code></a></li>
<li>TypeScript
<ul>
<li>� Fix Input <code>data-*</code> type definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34410">#34410</a> <a href="https://github.com/GitKou"><code>@​GitKou</code></a></li>
<li>� Fix Transfer <code>footer</code> type definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34337">#34337</a> <a href="https://github.com/zomixi"><code>@​zomixi</code></a></li>
</ul>
</li>
</ul>
<hr />
<ul>
<li>🐞 修复 Dropdown 在边界情况下不会自动调整展示位置的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34390">#34390</a></li>
<li>💄 缩小 PageHeader <code>extra</code> 内元素间距为 <code>8px</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34428">#34428</a></li>
<li>🛠 导出 antd/es/config-provider 目录下的 css variable 函数以支持 ssr 的需求。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34436">#34436</a></li>
<li>🛠 使用 React hooks 重构 Menu。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34433">#34433</a></li>
<li>Input
<ul>
<li>💄 修复大尺寸 Input 的字号问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34381">#34381</a></li>
<li>💄 修复 Input.Group 多余的错误边框样式。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34412">#34412</a></li>
</ul>
</li>
<li>Form
<ul>
<li>🐞 修复 Form.Item 在 <code>form.validateFields</code> 中移除时抛出 <code>Can't perform a React state update on an unmounted component</code> 警告的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34405">#34405</a></li>
<li>🐞 修复 Form 组件当 <code>preserve</code> 为 <code>false</code> 时 <code>initialValues</code> 会被更改的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34411">#34411</a></li>
</ul>
</li>
<li>Tooltip
<ul>
<li>💄 修复 Tooltip 在 Safari 下的内容宽度问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34415">#34415</a> <a href="https://github.com/jiandandkl"><code>@​jiandandkl</code></a></li>
<li>💄 修复 Tooltip/Popover/Popconfirm 等组件箭头大小问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34407">#34407</a></li>
</ul>
</li>
<li>💄 优化 Collapse 简洁模式的底边框。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34366">#34366</a> <a href="https://github.com/PanStar"><code>@​PanStar</code></a></li>
<li>TypeScript
<ul>
<li>� 修复 Input 不支持 <code>data-*</code> TS 定义的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34410">#34410</a> <a href="https://github.com/GitKou"><code>@​GitKou</code></a></li>
<li>� 修复 Transfer 的 <code>footer</code> 类型定义。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34337">#34337</a> <a href="https://github.com/zomixi"><code>@​zomixi</code></a></li>
</ul>
</li>
</ul>
<h2>4.19.1</h2>
<ul>
<li>🐞 Fix less compile error related to custom status. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34350">#34350</a>
<ul>
<li>🐞 Fix error <code>ReferenceError: colorPalette is not defined</code> when customize theme.</li>
<li>🐞 Fix error <code>Error: Invalid class or id selector syntax</code> when import <code>antd/dist/antd.css</code>.</li>
</ul>
</li>
<li>🐞 Fix Input.Passowrd icon color in site. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34354">#34354</a></li>
<li>🐞 Fix ConfigProvider <code>csp</code> sometime not effect on Icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34356">#34356</a></li>
</ul>
<hr />
<ul>
<li>🐞 修复自定义状态相关的 less 编译错误 <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34350">#34350</a>
<ul>
<li>🐞 修复使用定制主题时 less 编译提示 <code>ReferenceError: colorPalette is not defined</code> 错误。</li>
<li>🐞 修复引入 <code>antd/dist/antd.css</code> 时提示 <code>Error: Invalid class or id selector syntax</code> 错误。</li>
</ul>
</li>
<li>🐞 修复 Input.Passowrd 图标颜色错误。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34354">#34354</a></li>
<li>🐞 修复 ConfigProvider <code>csp</code> 有时在 Icon 上不会生效的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34356">#34356</a></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p>
<blockquote>
<h2>4.19.2</h2>
<p><code>2022-03-13</code></p>
<ul>
<li>🐞 Fix Dropdown not auto adjust placement when position on the edge of window. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34390">#34390</a></li>
<li>💄 Change PageHeader elements margin from <code>12px</code> to <code>8px</code> inside <code>extra</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34428">#34428</a></li>
<li>🛠 Export css variable function in <code>antd/es/config-provider</code> folder to enable ssr requirement. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34436">#34436</a></li>
<li>🛠 Refactor Menu with React hooks. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34433">#34433</a></li>
<li>Input
<ul>
<li>💄 Fix Input font-size when <code>size</code> is large. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34381">#34381</a></li>
<li>💄 Fix Input.Group wrong border when status is error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34412">#34412</a></li>
</ul>
</li>
<li>Form
<ul>
<li>🐞 Fix Form.Item removed in <code>form.validateFields</code> throw <code>Can't perform a React state update on an unmounted component</code> warning. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34405">#34405</a></li>
<li>🐞 Fix to Form that <code>initialValues</code> would change if <code>preserve</code> is false. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34411">#34411</a></li>
</ul>
</li>
<li>Tooltip
<ul>
<li>💄 Fix Tooltip width in Safari. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34415">#34415</a> <a href="https://github.com/jiandandkl"><code>@​jiandandkl</code></a></li>
<li>💄 Fix arrow size of Tooltip/Popover/Popconfirm. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34407">#34407</a></li>
</ul>
</li>
<li>💄 Remove Collapse bottom border in simple style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34366">#34366</a> <a href="https://github.com/PanStar"><code>@​PanStar</code></a></li>
<li>TypeScript
<ul>
<li>� Fix Input <code>data-*</code> type definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34410">#34410</a> <a href="https://github.com/GitKou"><code>@​GitKou</code></a></li>
<li>� Fix Transfer <code>footer</code> type definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34337">#34337</a> <a href="https://github.com/zomixi"><code>@​zomixi</code></a></li>
</ul>
</li>
</ul>
<h2>4.19.1</h2>
<p><code>2022-03-08</code></p>
<ul>
<li>🐞 Fix less compile error related to custom status. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34350">#34350</a>
<ul>
<li>🐞 Fix error <code>ReferenceError: colorPalette is not defined</code> when customize theme.</li>
<li>🐞 Fix error <code>Error: Invalid class or id selector syntax</code> when import <code>antd/dist/antd.css</code>.</li>
</ul>
</li>
<li>🐞 Fix Input.Passowrd icon color in site. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34354">#34354</a></li>
<li>🐞 Fix ConfigProvider <code>csp</code> sometime not effect on Icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34356">#34356</a></li>
</ul>
<h2>4.19.0</h2>
<p><code>2022-03-08</code></p>
<ul>
<li>
<p>💄 Optimize arrow style for some components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33710">#33710</a></p>

</li>
<li>
<p>Input</p>
<ul>
<li>🛠 Refactor Input with rc-input. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34206">#34206</a>
<ul>
<li>Attention: The type and value of <code>ref</code> is modified because of refactoring from class component to function component. You can still get DOM node from <code>input</code>, and other methods such as <code>focus</code> and <code>blur</code> mentioned in document are also supported.</li>
</ul>
</li>
<li>🆕 Support <code>clearIcon</code> prop for customizing clear icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34325">#34325</a></li>
</ul>
</li>
<li>
<p>Table</p>
<ul>
<li>🆕 <code>filterSearch</code> now support passing function to customize search. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34085">#34085</a> <a href="https://github.com/heiyu4585"><code>@​heiyu4585</code></a></li>
<li>🆕 <code>column.filterDropdown({ clearFilters })</code> support <code>clearFilters({ confirm: false, closeDropdown: false })</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34120">#34120</a> <a href="https://github.com/heiyu4585"><code>@​heiyu4585</code></a></li>
<li>⌨️ Table adds <code>aria-sort</code> attribute for screen readers. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33603">#33603</a> <a href="https://github.com/dgreene1"><code>@​dgreene1</code></a></li>
<li>🐞 Fix Table filters select-all Checkbox not changed when select item. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34295">#34295</a></li>
</ul>
</li>
<li>
<p>🆕 Data entry components add <code>status</code> prop to support custom status.</p>
</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="085a9e9235"><code>085a9e9</code></a> chore: upgrade rc-menu to 9.3.x (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34473">#34473</a>)</li>
<li><a href="01dceec0c7"><code>01dceec</code></a> docs(✨ ): changelog for 4.19.2 (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34472">#34472</a>)</li>
<li><a href="ed47a8e1ea"><code>ed47a8e</code></a> docs(module:timeline): fix typo (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34389">#34389</a>)</li>
<li><a href="2e27c00293"><code>2e27c00</code></a> chore: export css variable func (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34436">#34436</a>)</li>
<li><a href="c50bbe64bb"><code>c50bbe6</code></a> chore: refactor internal menu with hooks (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34433">#34433</a>)</li>
<li><a href="f987bd0479"><code>f987bd0</code></a> fix: PageHeader extra gutter (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34428">#34428</a>)</li>
<li><a href="86415ef8a2"><code>86415ef</code></a> docs(Table): replace the link of <code>TableComponents</code> prop with <code>rc-table</code> type ...</li>
<li><a href="fca7210309"><code>fca7210</code></a> fix: Tooltip width in safari (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34415">#34415</a>)</li>
<li><a href="362a99e9d4"><code>362a99e</code></a> feat: hide the last border in borderless mode (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34366">#34366</a>)</li>
<li><a href="fbb98f2b4f"><code>fbb98f2</code></a> Fix InputProps supports data attributes (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/34410">#34410</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/ant-design/ant-design/compare/4.18.5...4.19.2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=antd&package-manager=npm_and_yarn&previous-version=4.18.5&new-version=4.19.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3531

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

   yarn start --no-launcher

{F711751713}

Reviewed By: mweststrate

Differential Revision: D34867418

Pulled By: lblasa

fbshipit-source-id: 6af37b791f4e232dc3ae7b7350d2091f4e2f246f
 2022-03-17 10:02:20 -07:00
Lorenzo Blasa
f8371b19db Not clearing up a previous client connection should not log as error 
Summary:
^
This doesn't seem a functionality impairment and there's no actionable items.

Reviewed By: lawrencelomax

Differential Revision: D34787962

fbshipit-source-id: 9fe42187456bfab3748d469860f6ed7cda2f83d5
 2022-03-10 08:26:04 -08:00
Pascal Hartig
8372d07ae6 Demote "failed to find device" error 
Summary:
This is not actionable for us as it includes changing device identifiers.
In this case it's better to rely on individual user reports if this is about
a particular device/app combo.

Reviewed By: lawrencelomax

Differential Revision: D34749996

fbshipit-source-id: 88c6c8b076b3f7d9808b6a2a9b08854d2d7cb39f
 2022-03-09 07:40:39 -08:00
Anton Nikolaev
37ff34390a Enable Marketplace for Flipper (#3491) 
Summary:
This is PR on top of: https://github.com/facebook/flipper/pull/3473

It adds an option to Settings to allow distribution of marketplace plugins.

Also includes a simple fetch function to retrieve data from external API/server.

## Changelog

Allow marketplace plugins

Pull Request resolved: https://github.com/facebook/flipper/pull/3491

Test Plan:
1. Enable marketplace
2. Provide custom marketplace server (it will serve the list of internal plugins with downloadURL)
3. Test if can see Available plugins and can download/remove the plugin
4. If new update for the plugin, it should also allow auto update

Reviewed By: antonk52

Differential Revision: D34586339

Pulled By: nikoant

fbshipit-source-id: c887982aa0f0f9abd3b5360f22e8692a2445d345
 2022-03-07 02:49:49 -08:00
Andrey Goncharov
6c74f2dd18 Set device features on device initialization 
Summary:
1. Identify if device supports screenshots/screen recording when it is created.
2. Disable screen recording/screenshot buttons when they are not supported

Reviewed By: passy

Differential Revision: D34611133

fbshipit-source-id: 82ad2d67e4af482d9becf7995187667b5d99bc36
 2022-03-04 02:00:23 -08:00
Andrey Goncharov
5068c8273b Add deprecation notice notification 
Summary: Add deprecation notice device icon and notification

Reviewed By: lblasa

Differential Revision: D34582475

fbshipit-source-id: 90fde15caf1925b42f50fbfc77dece88c82833cf
 2022-03-02 09:18:15 -08:00
Andrey Goncharov
8b94186783 Load installed server add-ons 
Reviewed By: nikoant

Differential Revision: D34300475

fbshipit-source-id: 6bb6c0ab811e28806a0924b3487931bdb0dd2c59
 2022-02-28 03:50:34 -08:00
Andrey Goncharov
b4b9c0ab28 Implement receiving messages from add-on on the client 
Reviewed By: mweststrate

Differential Revision: D34249101

fbshipit-source-id: 07297b84ed8640e3b41599726ba613b6b4e2b62e
 2022-02-28 03:50:34 -08:00
Andrey Goncharov
4067f5bd88 Implement sending messages from desktop to add-on 
Reviewed By: antonk52

Differential Revision: D34239803

fbshipit-source-id: 1a18d522ba877ade3d0703fbb374c15b596241d7
 2022-02-28 03:50:34 -08:00
Andrey Goncharov
3b390b74ff Track client connections and autostop server add-ons when all clients leave 
Reviewed By: mweststrate

Differential Revision: D34045584

fbshipit-source-id: 1ad0cfffb9d304f0359c973d76d6956f7e932f72
 2022-02-28 03:50:34 -08:00
Andrey Goncharov
9113006851 Make Client initialize server add-ons 
Reviewed By: mweststrate

Differential Revision: D34044353

fbshipit-source-id: 99bcb1559787b2a904bdd796233666a7a4783ea4
 2022-02-28 03:50:34 -08:00
Anton Nikolaev
38c81ca159 Make internal plugin distribution code publicly available (#3473) 
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/3473

This diff is the first one which addresses https://github.com/facebook/flipper/issues/3320.

In this diff we are making a part of the code used for internal Flipper plugin distribution in Meta also available publicly for re-using in other orgs.

Some explanation on how plugin installation and updates is designed now:
1) We periodically poll for plugins available for download. API for retrieving available plugins list is abstracted and will be different between public and fb versions, however all other logic is re-used.
2) In addition to "Enabled" and "Disabled" plugins in the left panel Flipper shows "Detected in App" list. Plugins in this list are those which are known compatible with the currently selected device/app, but not yet installed.
3) User can install any of "Detected in App" plugins by clicking to "Download and install" button near them in the left panel similarly to enabling plugins in "Disabled" list.
4) If we detect that for some installed plugin we have a newer version available for download - we download it silently and store on disk.
5) If the plugin for which we have new downloaded version is disabled - we update it silently without any notifications by loading new version from the disk and unloading the previous version from cache.
6) If the plugin for which we have new downloaded version is enabled then we avoid updating it automatically (because we need to reset plugin state in such case) and instead show notification on top of the plugin and ask user to reload it to apply new version. On reloading we reset the plugin state.
7) On Flipper startup we always update all plugins to their latest versions available on the disk.

Reviewed By: aigoncharov

Differential Revision: D34380308

fbshipit-source-id: a94d724e42aa5ef78445af266fcd4c424226a703
 2022-02-22 05:23:05 -08:00
Anton Nikolaev
5da0a83a36 Refactor recommended plugin API 
Summary:
This is just refactoring in preparation to open-sourcing internal plugin distribution code to make it available for other orgs so they can distribute their internal plugins. See other diffs in the same stack.

This diff moves recommended plugins handling from `pluginMarketplace` which will be the same for fb-internal and OS versions into `pluginMarketplaceAPI` which will differ for fb-internal and OS versions. This will make it possible for other orgs to define their own "recommended" plugins which then will be automatically installed/enabled for new users.

Reviewed By: aigoncharov

Differential Revision: D34379981

fbshipit-source-id: 5c3a4efb6d0171256cf508f9005d914d7332e14f
 2022-02-22 05:23:05 -08:00
Lorenzo Blasa
77ab722b52 Better notification messaging 
Summary:
'Failed to start connection server' is a bit misleading. 'server-error' is used for both server and client errors.
Changelog: Better notification messaging

Reviewed By: aigoncharov

Differential Revision: D34269045

fbshipit-source-id: f51a28fc0e9ba394b464e5bfca4d0e497f740b1b
 2022-02-16 05:22:35 -08:00
Michel Weststrate
762267bccc Fix name casing to make plugin more easily findable 
Summary:
Noticed in https://fb.workplace.com/groups/flippersupport/permalink/1305583723255616/ that always shows at the end of the plugin list.

Fixed this on two levels:
1. uppercase the title for consistency
2. Make sorting case insensitive

Differential Revision: D33985518

fbshipit-source-id: 70bed519e1ae5b3251b103931472844b2b55a512
 2022-02-04 01:15:42 -08:00
Michel Weststrate
e4a3696fd5 Don't create always rejecting promises for timeout 
Summary:
Our existing `timeout` implementation was always throwing an exception, due to sleeping and then throw an exception, which is than handled but ignored by `Promise.race`.

This implementation has a few problems

1. Because it always throws, having a debugger session with 'break on caught exceptions' will pause on every usage of timeout (rather than just the ones that actually timeout). This makes this way of debugging a bit useless.
2. Throwing exceptions is in principle an expensive process (due to the stack trace generation)
3. Not cancelling the timeout used by sleep is a bit of a waste as well

Reviewed By: lawrencelomax

Differential Revision: D33982717

fbshipit-source-id: d739c02112e1c1bc4cd691af852371d08a99abc6
 2022-02-04 01:15:41 -08:00
Bartosz Kaszubowski
6639b547dd UI: fix hover effect of LeftRail icons with badge (#3372) 
Summary:
This PR fixes the missing hover effect for the `LeftRail` component buttons, when they have included the badge.

To fix the issue, I had to wrap the whole `Button` with `Badge` component (instead wrapping only around icon). However, this solution required to added `offset` property to the `Badge` which moves the indicator to the position prior change (otherwise indicator was moved to the right corner of the button).

The file has been formatted after the changes with ESLint.

**Edit:** I have also spotted that this change fixes the icon placement inside the button, when badge is present. Earlier, as seen below, the log icon was moved towards the top of the button:
<img width="111" alt="Screenshot 2022-01-31 at 00 57 49" src="https://user-images.githubusercontent.com/719641/151723422-0ffb83ee-5806-412e-9191-f9953f78532e.png">

## Changelog

[desktop] UI: fix hover effect of LeftRail icons with badge

Pull Request resolved: https://github.com/facebook/flipper/pull/3372

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

#### Before
<img width="1339" alt="Screenshot 2022-01-31 at 00 24 23" src="https://user-images.githubusercontent.com/719641/151722800-a2f3dd44-aa24-4858-b43e-0620b1f2ae65.png">

#### After

> I have used mocked indicator values locally to ensure that the Badges are displayed correctly.

<img width="1339" alt="Screenshot 2022-01-31 at 00 26 10" src="https://user-images.githubusercontent.com/719641/151722795-745b04ac-9ee4-49a8-8217-206d8d7456e6.png">

<img width="1339" alt="Screenshot 2022-01-31 at 00 45 08" src="https://user-images.githubusercontent.com/719641/151722940-aaaf0e9b-f2d1-4245-8b2b-cfc11052b39e.png">

Reviewed By: aigoncharov

Differential Revision: D33975324

Pulled By: mweststrate

fbshipit-source-id: fe4773b4825b9f22e01821e45259747d319233aa
 2022-02-03 05:54:03 -08:00
Anton Kastritskiy
f2abbf63db ban interface usage for component props and state 
Summary: another eslint rule for flipper codebase

Reviewed By: passy

Differential Revision: D33917213

fbshipit-source-id: e60b867d359ef5b94a481edf0eda318ecff17eee
 2022-02-02 05:09:45 -08:00
Anton Kastritskiy
c5dd1fc350 rename files from ts to tsx in flipper-* packages 
Summary: mass files rename

Reviewed By: nikoant

Differential Revision: D33890252

fbshipit-source-id: d5afaa60af7340313a97d8e4967fe37f00abd9db
 2022-01-31 10:16:19 -08:00
dependabot[bot]
e9da574720 Bump antd from 4.18.2 to 4.18.5 in /desktop (#3346) 
Summary:
Bumps [antd](https://github.com/ant-design/ant-design) from 4.18.2 to 4.18.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p>
<blockquote>
<h2>4.18.5</h2>
<ul>
<li>Cascader
<ul>
<li>💄 Fix Cascader loading icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li>
<li>🐞 Fix Cascader not auto offset placement when popup is out of screen and fix active option out of screen not scroll. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li>
</ul>
</li>
<li>💄 Fix Tag style in dark theme. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li>
<li>💄 Fix disabled Checkbox inside Tooltip dom structure. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@​boomler</code></a></li>
<li>⚡️ Fix invalid hook dependency array in Row and Layout.Sider components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 Fix Card <code>ref</code> not working. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
<li>🐞 Fix a Checkbox problem that <code>onChange</code> could not correctly pass in the modified value when dynamically modifying <code>value</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li>
</ul>
<hr />
<ul>
<li>Cascader
<ul>
<li>🐞 修复 Cascader 弹层超出屏幕时不会自动偏移以及激活选项不会自动滚动到正确位置的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li>
<li>💄 修复 Cascader 加载中图标。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li>
</ul>
</li>
<li>💄 修复 Tag 在暗黑主题下的样式。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li>
<li>💄 修复 Tooltip 的子元素含有禁用态的 CheckBox 时可能引起的行为和样式异常。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@​boomler</code></a></li>
<li>⚡️ 优化 Row 和 Layout.Sider 的 hooks 依赖数组。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 修复 Card <code>ref</code> 不生效的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
<li>🐞 修复动态修改 Checkbox 的 <code>value</code> 时 <code>onChange</code> 不能正确传入修改后的值的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li>
</ul>
<h2>4.18.4</h2>
<ul>
<li>Typography
<ul>
<li>⚡️ Optimize Typography to use native css ellipsis when <code>tooltip</code> is configured. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li>
<li>🐞 Refactor Typography <code>ellipsis</code> logic to fix error when <code>children</code> use Context content. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 Fix <code>&lt;Icon component={HomeOutlined} /&gt;</code> and <code>&lt;HomeOutlined /&gt;</code> not aligned. (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">ant-design/ant-design#33709</a>)</li>
<li>🐞 Fix <code>&lt;Icon component={SyncOutlined} spin /&gt;</code> shake. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@​JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 Fix the display effect for Input related components with <code>hidden</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a> <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@​hydraZty</code></a></li>
<li>🐞 Fix the warning in console for Input with <code>showCount</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@​whwangms</code></a></li>
</ul>
</li>
<li>⚡️ Fix ConfigProvider and Anchor rerender unexpectedly. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 Fix the duplicate keys warning in console for Cascader. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@​dimbslmh</code></a></li>
<li>🐞 Checkbox.Group support number and boolean as options element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li>
<li>🐞 Fix Form <code>validateMessages</code> bug in multiple ConfigProvider. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33705">#33705</a></li>
<li>🐞 Fix Steps the tail part would be hidden when type is navigation and labelPlacement is vertical. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33716">#33716</a> <a href="https://github.com/toSayNothing"><code>@​toSayNothing</code></a></li>
<li>🐞 Fix Image has bottom blank style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33631">#33631</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a></li>
<li>🐞 Fix TreeSelect with keyboard operation missing highlight issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33755">#33755</a></li>
<li>🇰🇭 Fix some translations for Khmer (km_KH). <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33738">#33738</a> <a href="https://github.com/vireakkeosokvibol"><code>@​vireakkeosokvibol</code></a></li>
</ul>
<hr />
<ul>
<li>Typography
<ul>
<li>⚡️ 优化 Typography 在配置 <code>tooltip</code> 时优先使用原生省略样式以提升性能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li>
<li>🐞 重构 Typography <code>ellipsis</code> 逻辑以修复 <code>children</code> 如果消费上游 Context 会报错的问题。 <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 修复 <code>&lt;Icon component={HomeOutlined} /&gt;</code> 和 <code>&lt;HomeOutlined /&gt;</code> 不对齐的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">#33709</a></li>
<li>🐞 修复 <code>&lt;Icon component={SyncOutlined} spin /&gt;</code> 抖动的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@​JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 修复 Input 相关组件设置 <code>hidden</code> 时的展示问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a>，<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@​hydraZty</code></a></li>
<li>🐞 修复 Input 传入 <code>showCount</code> 时控制台 warning 问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@​whwangms</code></a></li>
</ul>
</li>
<li>⚡️ 修复 ConfigProvider 和 Anchor 的渲染函数多次运行的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 修复 Cascader 组件中出现重复 key 的控制台 warning 问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@​dimbslmh</code></a></li>
<li>🐞 Checkbox.Group 的 <code>options</code> 支持数组中直接传入 number 和 boolean 类型。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p>
<blockquote>
<h2>4.18.5</h2>
<p><code>2022-01-24</code></p>
<ul>
<li>Cascader
<ul>
<li>💄 Fix Cascader loading icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li>
<li>🐞 Fix Cascader not auto offset placement when popup is out of screen and fix active option out of screen not scroll. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li>
</ul>
</li>
<li>💄 Fix Tag style in dark theme. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li>
<li>💄 Fix disabled Checkbox inside Tooltip dom structure. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@​boomler</code></a></li>
<li>⚡️ Fix invalid hook dependency array in Row and Layout.Sider components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 Fix Card <code>ref</code> not working. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
<li>🐞 Fix a Checkbox problem that <code>onChange</code> could not correctly pass in the modified value when dynamically modifying <code>value</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li>
</ul>
<h2>4.18.4</h2>
<p><code>2022-01-18</code></p>
<ul>
<li>Typography
<ul>
<li>⚡️ Optimize Typography to use native css ellipsis when <code>tooltip</code> is configured. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li>
<li>🐞 Refactor Typography <code>ellipsis</code> logic to fix error when <code>children</code> use Context content. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 Fix <code>&lt;Icon component={HomeOutlined} /&gt;</code> and <code>&lt;HomeOutlined /&gt;</code> not aligned. (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">ant-design/ant-design#33709</a>)</li>
<li>🐞 Fix <code>&lt;Icon component={SyncOutlined} spin /&gt;</code> shake. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@​JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 Fix the display effect for Input related components with <code>hidden</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a> <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@​hydraZty</code></a></li>
<li>🐞 Fix the warning in console for Input with <code>showCount</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@​whwangms</code></a></li>
</ul>
</li>
<li>⚡️ Fix ConfigProvider and Anchor rerender unexpectedly. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 Fix the duplicate keys warning in console for Cascader. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@​dimbslmh</code></a></li>
<li>🐞 Checkbox.Group support number and boolean as options element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li>
<li>🐞 Fix Form <code>validateMessages</code> bug in multiple ConfigProvider. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33705">#33705</a></li>
<li>🐞 Fix Steps the tail part would be hidden when type is navigation and labelPlacement is vertical. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33716">#33716</a> <a href="https://github.com/toSayNothing"><code>@​toSayNothing</code></a></li>
<li>🐞 Fix Image has bottom blank style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33631">#33631</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a></li>
<li>🐞 Fix TreeSelect with keyboard operation missing highlight issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33755">#33755</a></li>
<li>🇰🇭 Fix some translations for Khmer (km_KH). <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33738">#33738</a> <a href="https://github.com/vireakkeosokvibol"><code>@​vireakkeosokvibol</code></a></li>
</ul>
<h2>4.18.3</h2>
<p><code>2022-01-10</code></p>
<ul>
<li>🆕 Menu support <code>home</code> and <code>end</code> keyboard navigate. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33642">#33642</a> <a href="https://github.com/dartamonov-vertex"><code>@​dartamonov-vertex</code></a></li>
<li>Table
<ul>
<li>⚡️ Improve Table perfermance significantly when mount and unmount. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33554">#33554</a></li>
<li>🐞 Fix Table emptynode fixed display. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33610">#33610</a> <a href="https://github.com/hemengke1997"><code>@​hemengke1997</code></a></li>
<li>🐞 Fix Table tree data hover error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33638">#33638</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
</ul>
</li>
<li>Form
<ul>
<li>🐞 Fix Form validateMessages is not correct in default locale. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33511">#33511</a></li>
<li>🐞 Fix Form.Item help with empty string makes layout shaking. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33644">#33644</a></li>
</ul>
</li>
<li>🐞 Fix Input.Textarea throws error on preact. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33536">#33536</a> <a href="https://github.com/developit"><code>@​developit</code></a></li>
<li>🐞 Fix PageHeader state update error after unmounted. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33546">#33546</a> <a href="https://github.com/wuifdesign"><code>@​wuifdesign</code></a></li>
<li>💄 Fix Select tag margin issue when using <code>tagRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33539">#33539</a></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="8217c544da"><code>8217c54</code></a> docs(✨): release 4.18.5 (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33822">#33822</a>)</li>
<li><a href="578aaad7f2"><code>578aaad</code></a> test: fix lint</li>
<li><a href="ab8fc12fa7"><code>ab8fc12</code></a> docs: add Plasmic for Ant (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33758">#33758</a>)</li>
<li><a href="a65ba8aa8a"><code>a65ba8a</code></a> docs: update sentence structure in the FAQ section (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33816">#33816</a>)</li>
<li><a href="e55a68670f"><code>e55a686</code></a> chore(deps): update dependency simple-git to v3 (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33817">#33817</a>)</li>
<li><a href="fe23374871"><code>fe23374</code></a> fix: Invalid hook dependency array in Sider and Row (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33804">#33804</a>)</li>
<li><a href="75adc23fe3"><code>75adc23</code></a> chore: i18n contributing docs improve (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33760">#33760</a>)</li>
<li><a href="9cf0dca8fc"><code>9cf0dca</code></a> test: fix cascader test coverage (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33802">#33802</a>)</li>
<li><a href="5d2994ec12"><code>5d2994e</code></a> style: Cascader loading icon (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33799">#33799</a>)</li>
<li><a href="6dd39c1f89"><code>6dd39c1</code></a> fix(checkbox): disabled checkbox should works well with tooltip (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33772">#33772</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/ant-design/ant-design/compare/4.18.2...4.18.5">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=antd&package-manager=npm_and_yarn&previous-version=4.18.2&new-version=4.18.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3346

Reviewed By: aigoncharov

Differential Revision: D33741775

Pulled By: lblasa

fbshipit-source-id: 82e770ed1c09d3a7f9d71a950014d3555c9367fd
 2022-01-28 03:09:50 -08:00
Simek
f08bcb2a2c tweak dark mode theme colors, improve LeftRail UI (#3335) 
Summary:
Currently the design of `LeftRail` varies a bit between light and dark modes. Additionally washed background color is hard to differentiate from the main background color in comparison to the light theme (See `LeftRail` sidebars toggle buttons background for example). This lead to few contrast related issues, for example the hover effect on the WelcomeScreen elements is not visible in dark mode.

The PR tweaks the dark mode theme colors and fixes the unnecessary background of Settings icon in dark mode.

I have also spotted that icon `hover` effect is not working when icon has a badge (pure dot or count), I might have an idea how to fix this and I will push another PR for that. 🙂

## Changelog

* tweak dark mode theme colors, improve LeftRail UI

Pull Request resolved: https://github.com/facebook/flipper/pull/3335

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

<img width="390" alt="Screenshot 2022-01-24 at 13 37 20" align="left" src="https://user-images.githubusercontent.com/719641/150784627-36e222a8-e53e-4409-ab72-783d4a594f8e.png">
<img width="390" alt="Screenshot 2022-01-24 at 13 46 08" src="https://user-images.githubusercontent.com/719641/150785438-bb496adf-83ab-4b1c-928d-07f4b0098f1a.png">

Reviewed By: antonk52

Differential Revision: D33741513

Pulled By: lblasa

fbshipit-source-id: ef187db0725ac2b04c09b7f06823e713b50be88f
 2022-01-27 04:45:19 -08:00
Simek
903476bdad use centered prop for variable height modals (#3334) 
Summary:
Currently all of the modals are displayed using default positioning, which works fine for small modals and large app windows, but it cause small UI/UX issues (double scroll bars) when app window is quite small.

Adding [`centered` prop](https://ant.design/components/modal/#API) for variable height modals improves this situation a bit, but it also changes a bit the modal position when using maximised window, but I think this is bearable looking at improvements gained when window size is reduced.

## Changelog

* use `centered` prop for variable height modals to improve UI in small app window

Pull Request resolved: https://github.com/facebook/flipper/pull/3334

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

#### Small App Window
<img width="390" alt="Screenshot 2022-01-24 at 11 58 40" align="left" src="https://user-images.githubusercontent.com/719641/150771900-cb25d110-82c7-4ba9-8ee5-07a093c4f702.png">
<img width="390" alt="Screenshot 2022-01-24 at 11 58 37" src="https://user-images.githubusercontent.com/719641/150771911-c81592ac-1eba-4112-86ad-9549e6248239.png">

<img width="390" alt="Screenshot 2022-01-24 at 12 00 13" align="left" src="https://user-images.githubusercontent.com/719641/150772045-de37c432-4381-4207-8476-5f142dfb6fa5.png">
<img width="390" alt="Screenshot 2022-01-24 at 12 00 10" src="https://user-images.githubusercontent.com/719641/150772057-574cf6cd-6f1a-4ca2-a343-b8fd6342eddb.png">

#### Maximised App Window
<img width="390" alt="Screenshot 2022-01-24 at 12 12 12" align="left" src="https://user-images.githubusercontent.com/719641/150772777-8ac3cb59-3b41-4dcb-9554-137e95857af8.png">
<img width="390" alt="Screenshot 2022-01-24 at 12 12 29" src="https://user-images.githubusercontent.com/719641/150772758-ca9f8c20-d6d0-412d-9067-7e756da0b56c.png">

Reviewed By: mweststrate

Differential Revision: D33741484

Pulled By: lblasa

fbshipit-source-id: 0c3ca883d051cf4fcce9f9c1b6688974b66fd0d8
 2022-01-26 04:23:05 -08:00
Simek
1c91d28390 improve dev perf canvas readability (#3333) 
Summary:
This PR updates the performance Canvas widgets readability in Dev mode.

Currently, for unknown for me reason, the text was rendered with stroke not fill, which results in blurry text.

Also the color of texts and plot in light mode have not enough contrast in comparison to the background. I have tried to use `theme` in there, but unfortunately the CSS variables are not available in the Canvas context and using those values leads to always black text.

## Changelog

* improve the performance canvas widgets readability in Development mode

Pull Request resolved: https://github.com/facebook/flipper/pull/3333

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

#### Dark Mode
<img width="189" alt="Screenshot 2022-01-23 at 17 46 20" align="left" src="https://user-images.githubusercontent.com/719641/150689046-28895487-d488-440f-9440-f792daeca86f.png">
<img width="189" alt="Screenshot 2022-01-23 at 17 54 59" src="https://user-images.githubusercontent.com/719641/150689179-5ef96ca3-78e0-4995-b60c-317a87082604.png">

#### Light Mode
<img width="189" alt="Screenshot 2022-01-23 at 17 46 27" align="left" src="https://user-images.githubusercontent.com/719641/150689061-a3264961-390a-4182-bd81-ba84b6e4979f.png">
<img width="189" alt="Screenshot 2022-01-23 at 17 55 09" src="https://user-images.githubusercontent.com/719641/150689188-17efc7d9-7add-409e-af3b-befa5fbba0bc.png">

Reviewed By: aigoncharov

Differential Revision: D33738722

Pulled By: lblasa

fbshipit-source-id: b992ecacd31bb6aa2a53885ca6dcc858fa510775
 2022-01-24 08:52:22 -08:00
Simek
1fef844878 fix ReleaseChannel info in WelcomeScreen in dark mode (#3328) 
Summary:
This PR fixes the color of ReleaseChannel information in the WelcomeScreen, when user uses dark mode.

I have decided to switch to `textColorSecondary` instead of `textColorPrimary` to emphasise a bit more the information, but I can change it to the primary color if you think it will fit there better. Also the font size has been adjusted to match the paragraph font size.

## Changelog

* fix ReleaseChannel info in WelcomeScreen in dark mode

Pull Request resolved: https://github.com/facebook/flipper/pull/3328

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview

#### Dark Mode (before & after)

<img width="333" alt="Screenshot 2022-01-23 at 15 14 12" align="left" src="https://user-images.githubusercontent.com/719641/150682951-6e256054-d8d9-4293-8f76-4d67b654482f.png">
<img width="333" alt="Screenshot 2022-01-23 at 15 09 58" src="https://user-images.githubusercontent.com/719641/150682954-942eda7a-443d-4ca1-be51-b6d0036548cd.png">

#### Light Mode
<img width="333" alt="Screenshot 2022-01-23 at 15 22 42" src="https://user-images.githubusercontent.com/719641/150683094-62983788-646e-4745-b9c0-3c7f7bea9787.png">

Reviewed By: aigoncharov

Differential Revision: D33738596

Pulled By: lblasa

fbshipit-source-id: 2fdd18871fbf9d1c215b58173932d57d5731948a
 2022-01-24 06:10:03 -08:00
Simek
f1b83a96fd do not add GrayedOutOverlay if there is no children (#3329) 
Summary:
Do not add `GrayedOutOverlay` to the `ToggledSection` component if there is no children.

Current approach was causing UI issue in the Settings Modal in dark mode.

## Changelog

* do not add `GrayedOutOverlay` to the `ToggledSection` if there is no children

Pull Request resolved: https://github.com/facebook/flipper/pull/3329

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

<img width="390" alt="Screenshot 2022-01-23 at 15 32 29" align="left" src="https://user-images.githubusercontent.com/719641/150683689-d70f2af9-d835-4139-a8bb-a638aca9b8d3.png">
<img width="390" alt="Screenshot 2022-01-23 at 15 32 12" src="https://user-images.githubusercontent.com/719641/150683692-86da3fba-5740-426e-96c7-6838632f42f0.png">

Reviewed By: aigoncharov

Differential Revision: D33738627

Pulled By: lblasa

fbshipit-source-id: 12b028e3c7986a4fa196bac6f32a9efc19f1883d
 2022-01-24 05:42:22 -08:00