Summary:
Per title.
The controller you requested could not be found.
Reviewed By: priteshrnandgaonkar
Differential Revision: D9966768
fbshipit-source-id: 224ff9d02d6a01a6f7ee28788ddd9167d15aafee
Summary:
Per title.
The controller you requested could not be found.
Reviewed By: danielbuechele
Differential Revision: D9966597
fbshipit-source-id: eab1a670c7e956aa1dc7f816fb03875cd0b5c965
Summary:
Part of the Sonar -> Flipper rename
Intentionally left externally visible buck target as Sonar for now to minimize diff size.
Reviewed By: passy
Differential Revision: D9871684
fbshipit-source-id: 6926eb62c578a05cd895745c75ed7da3cfe965b5
Summary:
Rename everything `Sonar*.java` in `core/`.
Biggest chunk of the rename happened with
```fish
for name in (cat names.txt)
ambr --no-interactive --regex '\b'"$name"'\b' (echo $name | sed 's/Sonar/Flipper/') fbandroid/java/com/facebook
end
```
names.txt:
```
SonarArray
SonarClient
SonarConnection
SonarDynamic
SonarObject
SonarPlugin
SonarReceiver
SonarResponder
SonarStateUpdateListener
SonarValue
```
The controller you requested could not be found.
Reviewed By: priteshrnandgaonkar
Differential Revision: D9940900
fbshipit-source-id: 4a1342fac02513025d80dcb0af62c26ea38b5086
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/277
Link all dynamically loaded libraries statically with the exception of libevent.
Reviewed By: jknoxville
Differential Revision: D9967422
fbshipit-source-id: b33cec5da0c2b34f47217353f205b9d77f1acae2
Summary:
This leaves a BUCK skeleton in place that re-exports everything. Phew, that
was fun to create ... NOT. Are not-jokes still a thing? I'm on a plane,
and I claim that up here they still are.
Reviewed By: jknoxville
Differential Revision: D9922310
fbshipit-source-id: f48dcd98a7ad651a538c1c697bba24037e13db63
Summary:
This soft-breaks Android Studio support because folder names no longer map to package names, but this will be mitigated by future diffs.
Steps taken for rename:
```
cd xplat/sonar/android/;
ambr 'com.facebook.sonar' 'com.facebook.flipper'
```
Reviewed By: danielbuechele
Differential Revision: D9850009
fbshipit-source-id: d26d8ab783e7050e4e2fbdd0c35eae3f97879464
Summary:
Two fixes included in this one. The debug flag is obvious, the annotations
less so. I'll try and find the right place to document this, but the reason
we need this here is because we reflect on `Prop.class`, so these need to be
available at runtime.
Reviewed By: jknoxville
Differential Revision: D9766713
fbshipit-source-id: 269b5a60c0df644f4fda0ea289ef9dc392ee352b
Summary:
Litho renders differently based on whether applicable accessibility services are enabled. In Flipper's accessibility mode this will be forced (with the option to turn it off) so that you don't have to be running an accessibility service to actually see what someone running an accessibility service would.
Here's an example video of what the re-rendering does (this also happens on toggle of accessibility mode, this is just the settings option to force it):
{F137856647}
Reviewed By: jknoxville
Differential Revision: D9667222
fbshipit-source-id: 292353d89f07734f1e525f795b1d7daf4130e203
Summary: Removes the Accessibility panel from the layout inspector since all of these properties are shown (and logged) in the Accessibility Inspector along with other properties that may be useful. This will make it easier to track accessibility use and also will help more people discover the accessibility feature when they need it.
Reviewed By: blavalla
Differential Revision: D9523532
fbshipit-source-id: f6d3a745980ec631ec8bf2e59017382f4c2edd5a
Summary: Lets AX inspector live update the sidebar when a view is clicked (state may change) or accessibility focus changes (previously only updated the sidebar live if it became the focused element).
Differential Revision: D9489376
fbshipit-source-id: 8959f722370ce1d3a622b24c7b049b03f0d662e6
Summary:
Depends on #247.
Ensure that `libextra` is included when building sonar targets. My
cleanup was a bit too aggressive.
Fixes#246
Pull Request resolved: https://github.com/facebook/flipper/pull/248
Reviewed By: jknoxville
Differential Revision: D9420724
Pulled By: passy
fbshipit-source-id: f2d0625507a4897051840c95feefc534583b080f
Summary:
The plugin was part of the wrong package based on its directory. This
confuses Gradle and I'm frankly a bit surprised this ever built before.
Pull Request resolved: https://github.com/facebook/flipper/pull/247
Reviewed By: danielbuechele
Differential Revision: D9420595
Pulled By: passy
fbshipit-source-id: fd8e47ff242c4535b36e379df93b672eb8bb840d
Summary: Adds on hover descriptions for some of the more esoteric properties in the accessibility sidebar panel such as accessibility-focused and all the talkback derived properties. Also change talkback-focusable and talkback-ignored to both be talkback-focusable.
Differential Revision: D9381676
fbshipit-source-id: 55ce854da24241a7c89b0c122c4c3ebd77438dbb
Summary:
See https://github.com/facebook/flipper/issues/230 for a longer
explanation.
It turns out that many of the tasks in `native.gradle` (at least
`prepareGlog` which modifies files inside the source directory, but also
others) cause the cmake cache to invalidate.
Because we run those tasks unconditionally, we need to recompile all our
C++ code even when unmodified.
I fix this by adding a manual cache key to this which simply skips all
the tasks unless an up-to-date `external_cache_revision.txt` is found.
This is a bit hacky, but the alternatives are a) convincing cmake that
these modifications are not recompile-worthy which I have no idea how to
do and which might be impossible to do `mtime` on the files touches, or
b) having fine-grained `onlyIf` rules for every task which can easily
break. This seems the most straight-forward option.
Fixes#230.
Pull Request resolved: https://github.com/facebook/flipper/pull/242
Reviewed By: jknoxville
Differential Revision: D9381340
Pulled By: passy
fbshipit-source-id: a7db55aacac4a29076c29298d6c5b97d8bc91f66
Summary:
Minor simplification, mostly cleanup. Arguably, better to avoid the birthday paradox e.g. collision with > a few thousand requests.
Tested via
$ ./gradlew :sample:installDebug
Pull Request resolved: https://github.com/facebook/flipper/pull/238
Reviewed By: danielbuechele
Differential Revision: D9359941
Pulled By: passy
fbshipit-source-id: d2988b58f41d84a52aca060b5c583e055b8b203a
Summary: Components and Sections has two different but equal interfaces for StateContainer. This diff create one unique StateContainer interface they can both use.
Reviewed By: passy
Differential Revision: D9359823
fbshipit-source-id: 288abefd53670d3c128b5d00b5c204f0c1ea3948
Summary:
This doesn't solve our build caching issue (GH230) but
helps a bit with build times as we can skip building all
sorts of test targets which are otherwise included.
The sonar target is the only thing we care about here.
Reviewed By: danielbuechele
Differential Revision: D9360117
fbshipit-source-id: 13a976243b48efbe0f69e9fe47780486f9688eb8
Summary:
This allows breaking changes in Litho to be landed.
I'm also adding some helpers to determine if Flipper itself
is currently in a release or snapshot release train.
N.B. We don't publish snapshot releases for Flipper
right now, but will in the future where this will come in
handy.
Reviewed By: jknoxville
Differential Revision: D9359035
fbshipit-source-id: d21b607eca5d57caf4cc34234f6ba3cb0d8f307d
Summary: Updated properties to be more specific about what type of focus they are describing (keyboard vs accessibility vs talkback). Also separates sidebar into 3 sections (View, Talkback, and AccessibilityNodeInfo) since this organization is clearer now that Talkback is more robust.
Reviewed By: blavalla
Differential Revision: D9338822
fbshipit-source-id: d110faa43822faa36a081832207c259cddec44f0
Summary: Talkback-description now called talkback-output to avoid confusion about content-description. Talkback-output now includes the state and role of the view as well so it is more accurate to Talkback's actual output. Talkback-hint also added as a property to show what talkback will append to the description if a user has hints turned on. This may not always be 100% accurate because talkback changes what it says based on certain events and global settings as well but is correct for most general-use cases.
Reviewed By: blavalla
Differential Revision: D9317270
fbshipit-source-id: df9b9b5ebef19f583cbf997e0cd3fac6450170bb
Summary:
Display the summarised state of the sonar agent alongside the "log" view of it.
The log view contains every event, while the summarised view has just one entry for the latest attempt at each step.
Reviewed By: danielbuechele
Differential Revision: D9315502
fbshipit-source-id: 8767c3cce7d2765ef6ab09db5945248ddd6dcbce
Summary:
Adds a more structured representation of state updates than a multiline string.
Also changes the string form to omit [started] records.
Reviewed By: danielbuechele
Differential Revision: D9315503
fbshipit-source-id: 55b8f9572091fd42fe852c8d26a8f2a53f76c82a
Summary: AX tree will now stay in sync with the main tree when searching. Also allows user to completely erase search (previously had left one letter highlighted in the tree even if entire query was erased).
Reviewed By: danielbuechele
Differential Revision: D9276721
fbshipit-source-id: 5272bb9cf3400ad3eb9d16bf438b0e5d4b551c6a
Summary: Adds a link on MainActivitiy that opens the diagnostic screen
Reviewed By: danielbuechele
Differential Revision: D9267065
fbshipit-source-id: 1b44134de0e57f8021b19d76644dac6389c88b65
Summary: Components and Sections has two different but equal interfaces for StateContainer. This diff create one unique StateContainer interface they can both use.
Reviewed By: muraziz
Differential Revision: D9278661
fbshipit-source-id: fac09e914a17d82b5f1053c5d38787a69efdc1b3
Summary: Added logging for accessibility functionality (both usage and performance). Fix to prevent trackTimeSince calls from not matching up to the correct marks. Fix to prevent recursive onElementExpanded calls from mismatching also.
Reviewed By: danielbuechele
Differential Revision: D9229790
fbshipit-source-id: d20f08719d2c4f9a35c9c71a492619ce5538d204
Summary:
I'm "mirroring" the tarball so we can download this from
Java. Even JDK 8 doesn't like LetsEncrypt yet.
Reviewed By: danielbuechele
Differential Revision: D9264373
fbshipit-source-id: abb91fb72d74dccde4775cc852a93d75dd5a48e5
Summary: Adds expanding functionality to ax tree when click-to-inspect is used. Highlight/selection priority is given to the ax tree if in ax mode and the main tree otherwise.
Reviewed By: danielbuechele
Differential Revision: D9206028
fbshipit-source-id: 364b3cfc2e68dbce6006c36002353295aa7cdd07
Summary:
Open the screen by running adb shell
am start -n com.facebook.samples.litho/com.facebook.sonar.android.diagnostics.SonarDiagnosticActivity
Reviewed By: danielbuechele
Differential Revision: D9150556
fbshipit-source-id: 534583cfa5e90af6fd0d2a50572e3763b8888da2
Summary:
The plan is to get SonarState to take update events and aggregate them into an object, that can be displayed in the UI so you can see what sonar is currently trying to do, and what if anything is failing.
This is pretty rubbish right now, as it just uses a single string to represent state, this is just the initial version I'll iterate on.
I also need to pass the SonarState into the SonarWebSocketImpl, since that's where a lot of the heavy lifting is done, but as long as something is logging state updates here, it proves the concept.
SonarStateUpdateListener is the interface that will be implemented by android and iOS implementations. These implementations will notify an activity or screen that the state has changed and they should reflect that.
Reviewed By: danielbuechele
Differential Revision: D9150551
fbshipit-source-id: 8dd585ca503d32e684ff843d66a59a50a420b4c0
Summary: Puts an accessibility icon next to any elements in the ax tree that may be focused on when talkback is running to show that they are "accessibility-focusable". When any sidebar values are changed, the icon will show up/disappear accordingly.
Reviewed By: danielbuechele
Differential Revision: D9171781
fbshipit-source-id: f3b42624988aaef22040ac3325d745a12f0622db
Summary: Allow user to open the context menu on an element in the ax tree and request accessibility focus to that element. If the element is focusable (and talkback or another accessibility service is running), accessibility focus will change to that element, if not, it will not change anything.
Differential Revision: D9162382
fbshipit-source-id: 5dda9b87a2cc6eba4130e3feee978b5fa38ac9f1
