Commit Graph

5 Commits

Author SHA1 Message Date
Chaiwat Ekkaewnumchai
bacb1958fc Back out "Back out Electron 7.1.1/7.1.2 upgrades"
Summary:
Original commit changeset: 05d13aca7145

Attempt to upgrade `electron` as it instacrashed; `electron-builder` version 22.1.0 didn't sign package correctly and caused the instacrash,

Reduced the version to 21.2.0 (latest).

Reviewed By: passy, nikoant

Differential Revision: D18954671

fbshipit-source-id: bc2dbd4fec9afb51d9a535974651b13d195407b4
2020-01-06 09:44:13 -08:00
Pascal Hartig
a75a52a25b Back out Electron 7.1.1/7.1.2 upgrades
Summary:
Original commit changeset: eddfbb3571c7
Original commit changeset: f7300f527b65

Pains me to do this, but probably our best chance right now to get a release out.

Reviewed By: cekkaewnumchai

Differential Revision: D18687890

fbshipit-source-id: 05d13aca71457ca6dd19f5b45d58158ae223e66f
2019-11-26 05:30:34 -08:00
Chaiwat Ekkaewnumchai
a578b4d559 @allow-large-files [flipper][deps] Upgrade Electron (#636)
Summary:
allow-large-files

Pull Request resolved: https://github.com/facebook/flipper/pull/636

per title

Reviewed By: jknoxville

Differential Revision: D18374332

fbshipit-source-id: f7300f527b65b65caebac51c5bcf8f019dc34228
2019-11-13 10:51:16 -08:00
Daniel Büchele
766996b8dd keytar update node v70
Summary: Keytar binaries weren't updated when upgrading the electron version. This diff updates the binaries to match electron's node version.

Reviewed By: passy

Differential Revision: D15821734

fbshipit-source-id: 04688f1e465d2f7bdefecfdda8e2f3868de18780
2019-06-14 03:41:54 -07:00
Daniel Büchele
294d5b110f rename keytar Windows native module
Summary:
`process.platform` is used to require the native-module for keytar. On Windows this returns `win32` (No matter if 64bit or 32bit system). The native module was named `keytar-win.node`. This diff renames it to `keytar-win32.node`.

This is the code that requires the module from `user.js`:

```
keytar = global.electronRequire(
    path.join(
      isProduction() ? remote.app.getAppPath() : process.cwd(),
      'native-modules',
      `keytar-${process.platform}.node`,
    ),
  );
```

Reviewed By: priteshrnandgaonkar

Differential Revision: D14771646

fbshipit-source-id: cd48d25cb5921e07e472eb46636fa2599c8ff721
2019-04-04 04:51:11 -07:00