Summary:
I noticed that after the typescript upgrade, I got several weird positives from ESLint (like unused parameters in a type definition, which are obviously always unused, e.g. `type onClick = (e: Event) => void`). After some investigation, it turned out these warnings are generated by eslint, but that those rules should be performaned by typescript/eslint instead. For future reference to which rules this applies:
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/README.md#extension-rules
Updated the config, and while at it, fixed all warnings in our codebase, except for `react-hooks/exhaustive-deps` warnings, since those require semantic changes.
This reduces the amount of eslint warnings from 86 to 39.
Reviewed By: passy
Differential Revision: D23905630
fbshipit-source-id: 0557708fd9ec6b17840a3c191e7d3baf225bdf23
Summary:
allow-large-files
Updated to typescript 4. Note that this is no new major, the way TS numbers is that 4.0 is simply the number after 3.9 (so they refuse to use 3.10).
Primarily reason is that it allows us to use `/** deprecated */`. although there are definitely more interesting improvements
Reviewed By: passy, nikoant
Differential Revision: D23869445
fbshipit-source-id: 54e251b398b8698d9b18898ce66c3203b32aa356
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1532
Upgrade to Electron 10, in an attempt to fix random hard Electron crashes. Didn't fix it, but given the changelog of Electron with all the bug fixes, seems to be a good idea nonetheless :)
Changelog: Flipper now uses Electron 10
Reviewed By: nikoant
Differential Revision: D23565000
fbshipit-source-id: 3f07b8cf8c438147bde5314698d20046ac9f94cf
Summary:
You know the drill.
Pull Request resolved: https://github.com/facebook/flipper/pull/1530
Test Plan: Checked that `yarn.lock` references the respective new versions.
Reviewed By: nikoant
Differential Revision: D23733338
Pulled By: passy
fbshipit-source-id: abf9812b977542a8b297b88ea16c7c01a062898b
Summary: Adds support for switching dark mode on the fly. Also added the option to apply certain settings without restarting Flipper, as that isn't needed in all cases.
Reviewed By: cekkaewnumchai
Differential Revision: D23625854
fbshipit-source-id: 82175ba10524daf1b48a65feec8c610460df9418
Summary:
allow-large-files
This makes the Ant.design component library available to Flipper
The CSS setup is unconventional, in the sense that the normal way to do this is to use a webpack loader to dynamically load the right less files, and a babel transform to automatically import the style sheets.
Since we use Metro, which is not very suitable for transforming non-JS(like) files, I figured that the simplest thing is to pre-compile the entire less theme. Which should be fine since we shouldn't be changing the less files very often, and since we don't ship a website, it is probably not too bad to have the full ANT theme for now in there, even though we don't use all components. It is 600 K of css. In the next diff the CSS is loaded conditionally, only if Sandy is enabled.
If the CSS turns out to be too big we can optimise this later to only import CSS for components we use by doing some Metro magic, but it doesn't seem to be trivial (that is, I couldn't get in to work in < 2 hours).
Reviewed By: cekkaewnumchai
Differential Revision: D23625855
fbshipit-source-id: 3ba810b2221dc0c7b719f66310e590c7748cf239
Summary: Enable asar which should further improve startup time and bundle size
Reviewed By: passy
Differential Revision: D23705524
fbshipit-source-id: 161d28e4c3995615166171ab4926ec011a4b5dfb
Summary:
- Removed compilation on startup which is not required anymore after switching to plugin spec v2.
- Removed from Node process ("static" package) all the dependencies which are not required anymore: e.g. metro, babel etc.
- Plugin loading code from node process moved to browser process and made asyncronous.
Some expected benefits after these changes:
1) Reduced size of Flipper bundle (~4.5MB reduction for lzma package in my tests) as well as startup time. It's hard to say the exact startup time difference as it is very machine-dependent, and on my machine it was already fast ~1500ms (vs 5500ms for p95) and decreased by just 100ms. But I think we should definitely see some improvements on "launch time" analytics graph for p95/p99.
2) Plugin loading is async now and happens when UI is already shown, so perceptive startup time should be also better now.
3) All plugin loading code is now consolidated in "app/dispatcher/plugins.tsx" instead of being splitted between Node and Browser processes as before. So it will be easier to debug plugin loading.
4) Now it is possible to apply updates of plugins by simple refresh of browser window instead of full Electron process restart as before.
5) 60% less code in Node process. This is good because it is harder to debug changes in Node process than in Browser process, especially taking in account differences between dev/release builds. Because of this Node process often ended up broken after changes. Hopefully now it will be more stable.
Changelog: changed the way of plugin loading, and removed obsolete dependencies, which should reduce bundle size and startup time.
Reviewed By: passy
Differential Revision: D23682756
fbshipit-source-id: 8445c877234b41c73853cebe585e2fdb1638b2c9
Summary:
Added infra for writing and using custom eslint rules and created a rule for disallowing cross-package file imports. Such imports are anti-pattern and they also break standalone plugin bundling.
We still have a bunch of places where Flipper core references code directly from plugins. I've ignored these places for now and added task T71355623 to revisit them.
Reviewed By: passy
Differential Revision: D22998955
fbshipit-source-id: d04cff8fc115ba1300a7e6830306ec134046e927
Summary: Adds a toggle switch to show/hide disk cache images defaulting to inactive. The image data is only sent on the adb connection when the toggle is activated.
Reviewed By: defHLT
Differential Revision: D20002059
fbshipit-source-id: 05c9e515ffe09441e5cfb6f66eb14559ac4a322c
Summary:
1) Added configuration for QPL to be used by Flipper, configured PigeonClient and added an instance of QPL
3) Add a deferred instance for the logger
Reviewed By: timur-valiev
Differential Revision: D22504767
fbshipit-source-id: 73ba2a31e86782fe097a8f14a8edebaee40ec946
Summary:
Add QPL code to Flipper and a lightweight implementation of PigeonClient so that QPL can be integrated into Flipper and it can be used to monitor events inside Flipper.
the code was copied from VSCode from these diffs:
https://www.internalfb.com/diffs/D21271812https://www.internalfb.com/diffs/D21565279
Reviewed By: nubbel, bestander
Differential Revision: D22393607
fbshipit-source-id: 3ce77320c187f406b77321c020afc116bed45a93
Summary:
Created a few breakages. Would appreciate some closer eyes on this.
Pull Request resolved: https://github.com/facebook/flipper/pull/1366
Reviewed By: mweststrate
Differential Revision: D22501454
fbshipit-source-id: 9b882a12aecc65da85f29101bf87bf27519a7d2a
Summary:
Bumps [eslint-plugin-jsx-a11y](https://github.com/evcohen/eslint-plugin-jsx-a11y) from 6.2.3 to 6.3.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/CHANGELOG.md">eslint-plugin-jsx-a11y's changelog</a>.</em></p>
<blockquote>
<h1>6.3.1 / 2020-06-19</h1>
<ul>
<li>765da0f Update to aria-query 4.2.2</li>
<li>d528e8c Fix aria-level allowed on elements wit role heading (<a href="https://github-redirect.dependabot.com/evcohen/eslint-plugin-jsx-a11y/issues/704">https://github.com/facebook/flipper/issues/704</a>)</li>
<li>29c6859 [meta] remove yarn registry from npmrc, so publishing works</li>
<li>f52c206 chore(package): update estraverse to version 5.0.0</li>
</ul>
<h1>6.3.0 / 2020-06-18</h1>
<ul>
<li>cce838a Update aria-query to 4.2.0</li>
<li>121e8a4 Add two test cases found while upgrading to ARIA 1.2</li>
<li>8059f51 Fix test failures raised by the upgrade to ARIA 1.2</li>
<li>0d24e3a Update package.json</li>
<li>b1f412a Fix test failures in role-has-required-aria-props due to ARIA 1.2 updates</li>
<li>74cec6e Fix test failures in no-noninteractive-element-interactions due to ARIA 1.2 updates</li>
<li>835b89e Fix test failures in role-supports-aria-props-test due to ARIA 1.2 updates</li>
<li>730319b Account for the null semantic generic role in ARIA 1.2</li>
<li>7dfa7c9 Update aria-query from 4.0.1 to 4.0.2</li>
<li>42098b9 [Refactor] <code>img-redundant-alt</code>: removing a use of <code>some</code></li>
<li>a910d83 [Tests] <code>label-has-associated-control</code>: add test for <!-- raw HTML omitted --><!-- raw HTML omitted --><!-- raw HTML omitted --><!-- raw HTML omitted --></li>
<li>b273fe5 [New] Support ESLint 7.x</li>
<li>1a97632 [Deps] update <code>babel/runtime</code>, <code>array-includes</code>, <code>axe-core</code>, <code>axobject-query</code>, <code>damerau-levenshtein</code>, <code>jsx-ast-utils</code></li>
<li>b36976f [Dev Deps] update <code>babel/cli</code>, <code>babel/core</code>, <code>babel/plugin-transform-flow-types</code>, <code>babel-eslint</code>, <code>babel-jest</code>, <code>coveralls</code>, <code>eslint-config-airbnb-base</code>, <code>eslint-plugin-flowtype</code>, <code>eslint-plugin-import</code>, <code>estraverse</code>, <code>in-publish</code>, <code>jest</code>, <code>minimist</code>, <code>rimraf</code>, <code>safe-publish-latest</code></li>
<li>89acdc4 fix: removing the use of the some function</li>
<li>410ae43 chore(package): update eslint-plugin-flowtype to version 5.0.0</li>
<li>a87f83d fix(package): update emoji-regex to version 9.0.0</li>
<li>71940e6 chore(package): update babel-preset-airbnb to version 5.0.0</li>
<li>d471f54 docs: Fix 404 links to WAI-ARIA spec</li>
<li>42a2016 Fixes <a href="https://github-redirect.dependabot.com/evcohen/eslint-plugin-jsx-a11y/issues/669">https://github.com/facebook/flipper/issues/669</a>: use the <code>language-tags</code> package to check the <code>lang</code> rule</li>
<li>7bcea20 [Tests] update axe-core</li>
<li>f13dc38 [Deps] Pin axe-core version</li>
<li>33670bb fix: require missing 'autocomplete-valid' rule</li>
<li>aca4c37 chore(mouse-event): revert unrelated formatting changes</li>
<li>df1e275 fix(mouse-event): remove check from custom elements</li>
<li>1a16a1c chore(package): update jscodeshift to version 0.7.0</li>
<li>7a55cdd chore(package): update flow-bin to version 0.113.0</li>
<li>8e0d22b Update aria-query and axobject-query to the latest versions</li>
<li>dd49060 Added test cases for an empty or undefined value of aria-label and aria-labelledby in alt-text</li>
<li>1a7b94f Updated dependencies including eslint-config-airbnb-base</li>
<li>3aea217 chore: replace ignoreNonDOM with inputComponents</li>
<li>1848d00 feat(autocomplete-valid): add to recommended & strict config</li>
<li>8703840 refactor: use to axe-cre 3.4 SerialVirtualNode format</li>
<li>3519c7b chore: Remove axe VirtualNode abstraction</li>
<li>9ac55c4 autocomplete-valid: Add inline comment</li>
<li>44c6098 Update axe-core to 3.3.0</li>
<li>9916990 new autocomplete-valid rule</li>
<li>82f598e [Docs] examples: add language in code block for syntax highlight</li>
<li>2529ad3 fixing casing issue on aria-props</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="1614b85d3e"><code>1614b85</code></a> CHANGELOG v6.3.1</li>
<li><a href="b82b1bdf95"><code>b82b1bd</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/evcohen/eslint-plugin-jsx-a11y/issues/705">https://github.com/facebook/flipper/issues/705</a> from jsx-eslint/fix-heading-error</li>
<li><a href="765da0f8b5"><code>765da0f</code></a> Update to aria-query 4.2.2</li>
<li><a href="d528e8ceba"><code>d528e8c</code></a> Fix aria-level allowed on elements wit role heading (<a href="https://github-redirect.dependabot.com/evcohen/eslint-plugin-jsx-a11y/issues/704">https://github.com/facebook/flipper/issues/704</a>)</li>
<li><a href="3ac17386bf"><code>3ac1738</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/evcohen/eslint-plugin-jsx-a11y/issues/674">https://github.com/facebook/flipper/issues/674</a> from jsx-eslint/greenkeeper/estraverse-5.0.0</li>
<li><a href="bbfcb5a235"><code>bbfcb5a</code></a> Merge branch 'master' into greenkeeper/estraverse-5.0.0</li>
<li><a href="29c68596b1"><code>29c6859</code></a> [meta] remove yarn registry from npmrc, so publishing works</li>
<li><a href="7b5d228d36"><code>7b5d228</code></a> Update CHANGELOG for v6.3.0</li>
<li><a href="e215b876a4"><code>e215b87</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/evcohen/eslint-plugin-jsx-a11y/issues/696">https://github.com/facebook/flipper/issues/696</a> from jsx-eslint/fix-aria-1-2-test-failures</li>
<li><a href="cce838a0cf"><code>cce838a</code></a> Update aria-query to 4.2.0</li>
<li>Additional commits viewable in <a href="https://github.com/evcohen/eslint-plugin-jsx-a11y/compare/v6.2.3...v6.3.1">compare view</a></li>
</ul>
</details>
<br />
[](https://help.github.com/articles/configuring-automated-security-fixes)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1342
Reviewed By: mweststrate
Differential Revision: D22456362
Pulled By: priteshrnandgaonkar
fbshipit-source-id: cc3198dd5278bf7c61bb338f732e5dc6416d32b4
Summary:
Bumps [types/fs-extra](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/fs-extra) from 8.1.0 to 9.0.1.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/fs-extra">compare view</a></li>
</ul>
</details>
<br />
[](https://help.github.com/articles/configuring-automated-security-fixes)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1362
Reviewed By: mweststrate
Differential Revision: D22435350
Pulled By: passy
fbshipit-source-id: 029817966f51b9be3ea0b4e601d59cb63cbe154d
Summary:
Bumps [types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) from 7.0.0 to 8.0.0.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid">compare view</a></li>
</ul>
</details>
<br />
[](https://help.github.com/articles/configuring-automated-security-fixes)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1335
Reviewed By: mweststrate
Differential Revision: D22409664
Pulled By: passy
fbshipit-source-id: 0de34177f04f71b3e58de71027b37ccf4372e0c2
Summary:
Bumps [flow-bin](https://github.com/flowtype/flow-bin) from 0.127.0 to 0.128.0.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/flowtype/flow-bin/commits">compare view</a></li>
</ul>
</details>
<br />
[](https://help.github.com/articles/configuring-automated-security-fixes)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1332
Reviewed By: nikoant
Differential Revision: D22392634
Pulled By: passy
fbshipit-source-id: 15659ba36e2973e17d10bd635771ea36465b9541
Summary: Fixed scripts to return exit code 1 in case of error.
Reviewed By: passy
Differential Revision: D22357664
fbshipit-source-id: 1e067fe507e8f33cf21e70f3d15fd97175b9544e
Summary:
Changed "build-plugin" script to allow triggering release by plugin name (required to enable triggering releases by button in Marketplace):
1) Added new script to resolve plugin dir by name
2) Allow passing either plugin dir or name to "build-plugin" script
Reviewed By: passy
Differential Revision: D22354643
fbshipit-source-id: b7aca57acefc81ca0b6d9c7f359f63d8f0599e39
Summary:
Upgrading to TypeScript 3.9 so that we can use `// ts-expect-error`, that allows us to basically write unit tests for typings.
Fixed the typescript path in `settings.json`, because otherwise VSCode kept picking the built-in version (3.8.3 atm) of ts when opening the `sonar` folder as workspace.
Reviewed By: passy
Differential Revision: D22255818
fbshipit-source-id: ae54aedb237445f32f1797b4290656dbfb0e528f
Summary: Set up an initial library which can (should) be used by plugins in the future.
Reviewed By: jknoxville
Differential Revision: D22019554
fbshipit-source-id: 502b14b34b2c9c117cea377ab6ebbf150e6faee9
Summary: Script to list all plugins included into Flipper desktop workspaces.
Reviewed By: passy
Differential Revision: D22256917
fbshipit-source-id: a3d8a0f9faea6e462a2f22be155d99eb22eb59d8
Summary: Changelog: Added command `flipper-pkg checksum` for computing the total checksum of all the files included into plugin package.
Reviewed By: passy
Differential Revision: D22255125
fbshipit-source-id: a4f91370b4ab16ea4ce4a60e29f9d20fdd5f4331
Summary: Added "build-plugin" command. Can be used like this: `yarn build-plugin fresco` which produces package to 'sonar/dist/plugins/fresco.tgz'
Reviewed By: mweststrate
Differential Revision: D22160253
fbshipit-source-id: 48b202984b0f515bf253b595be1f59953a9ce411
Summary:
Bumps [ws](https://github.com/websockets/ws) from 7.2.3 to 7.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/websockets/ws/releases">ws's releases</a>.</em></p>
<blockquote>
<h2>7.3.0</h2>
<h1>Features</h1>
<ul>
<li><code>WebSocket.prototype.addEventListener()</code> now supports the <code>once</code> option (<a href="https://github-redirect.dependabot.com/websockets/ws/issues/1754">#1754</a>).</li>
</ul>
<h2>7.2.5</h2>
<h1>Bug fixes</h1>
<ul>
<li>Fixed compatibility with Node.js master (651d6627).</li>
</ul>
<h2>7.2.4</h2>
<h1>Bug fixes</h1>
<ul>
<li>The <a href="https://nodejs.org/api/http.html#http_http_request_options_callback"><code>http.request()</code></a> <code>auth</code> option is now supported (<a href="https://github-redirect.dependabot.com/websockets/ws/issues/1734">#1734</a>).</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="41f5e4ff11"><code>41f5e4f</code></a> [dist] 7.3.0</li>
<li><a href="2e5c01f5b5"><code>2e5c01f</code></a> [feature] Make <code>addEventListener()</code> support the <code>once</code> option (<a href="https://github-redirect.dependabot.com/websockets/ws/issues/1754">#1754</a>)</li>
<li><a href="97ddfce983"><code>97ddfce</code></a> [ci] Test on node 14</li>
<li><a href="2b49c4821f"><code>2b49c48</code></a> Revert "[ci] Use GitHub Actions (<a href="https://github-redirect.dependabot.com/websockets/ws/issues/1644">#1644</a>)"</li>
<li><a href="82f05372ba"><code>82f0537</code></a> Revert "[ci] Test on node 14"</li>
<li><a href="b167d1cd45"><code>b167d1c</code></a> Revert "[ci] Update Coveralls GitHub Action to version 1.1.1"</li>
<li><a href="78e1c01959"><code>78e1c01</code></a> [ci] Update Coveralls GitHub Action to version 1.1.1</li>
<li><a href="e6949791fa"><code>e694979</code></a> [doc] Fix badge URL</li>
<li><a href="67983cbba4"><code>67983cb</code></a> [dist] 7.2.5</li>
<li><a href="18d773d1f5"><code>18d773d</code></a> [test] Fix failing tests</li>
<li>Additional commits viewable in <a href="https://github.com/websockets/ws/compare/7.2.3...7.3.0">compare view</a></li>
</ul>
</details>
<br />
[](https://help.github.com/articles/configuring-automated-security-fixes)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1266
Reviewed By: nikoant
Differential Revision: D22118507
Pulled By: passy
fbshipit-source-id: 700f098e5c7b6ddb1dda27ef50974af5b73fe88c
