Summary: TSC actually found a type error here in `safeExec` which is nice.
Reviewed By: danielbuechele
Differential Revision: D16666740
fbshipit-source-id: 28a1ad12190d2351a48323f23c3a69947503625d
Summary: We can't `*`-export as the symbols are invisible but being explicit about this seems like a good improvement anyway.
Reviewed By: danielbuechele
Differential Revision: D16666637
fbshipit-source-id: 8f9a14ed41f4d8ad93b4bab8dd54f3b6c9e24824
Summary:
Very mechanical migration. No syntactic changes, only moves and
file name changes.
Reviewed By: danielbuechele
Differential Revision: D16665891
fbshipit-source-id: afb1f2418f55bf6c5370b8a2b1d2c35ac5986dc3
Summary: This updates the implementation of the export of the fresco plugin on the android side. Initially we used to send all the images info in one call, but its not scalable, as the images increase, the payload size of the rsocket can increase which will lead rsocket to drop messages. This diff updates the implementation of android side to match the one on the iOS side.
Reviewed By: passy
Differential Revision: D16627823
fbshipit-source-id: 563bf5fb20595c198b6447bb4e41f04af6e46644
Summary: Was about to convert this but appears to be unused.
Reviewed By: jknoxville
Differential Revision: D16709265
fbshipit-source-id: b444ceeb58178ecb282038f90e7009adb87f5926
Summary:
Add button in layout inspector to navigate to yoga performance plugin for analyzing a particular component.
We send component id in payload to yoga plugin which then uses to highlight the corresponding component in yoga plugin
Reviewed By: davidaurelio
Differential Revision: D16561301
fbshipit-source-id: 950fb3ea501283fec0a3036fb2796c178014f1f5
Summary:
We just implemented the sending of the required metadata of the images plugin for the android, but not for iOS. Due to which we get the following error.
{F173807861}
I tried to implement `getAllImageData` first for iOS in which we send all the information in one message for the images plugin in iOS. But there were lot of images and due to which it exceeded the max payload of the rsocket. That is why I had to implement this bit for iOS in a little different way. We fetch all the image Ids first and then loop over it to get image data.
Due to this the android and iOS implementations are different. I plan to change the android part in the next diffs and make it similar to iOS, as it is more scalable.
Reviewed By: jknoxville
Differential Revision: D16606748
fbshipit-source-id: e98c2bd5db7ec247b45a7cde304d4f51053ea6fe
Summary:
This commit adds the match patterns that were parsed from the app into the nav bar.
Planned for next commit: Alerting the user if they havn't filled in required parameters, and automatically excluding non-required parameters if not filled in.
Reviewed By: danielbuechele
Differential Revision: D16646774
fbshipit-source-id: 0f9130d659b6b635bfa1240dbd05c5956c6756ce
Summary:
Here I parse in the match patterns belonging to the Facebook app into Flipper. In order to keep things generalized, we can add match patterns for other apps here also e.g. Instagram.
These functions are internal only, but I cannot hide them as we do not have dynamic imports. Instead, the match patterns file is hidden, and I plan to have the file read fail silently for external use.
Reviewed By: danielbuechele
Differential Revision: D16646444
fbshipit-source-id: c7978f61e5e9cfc137552777a9ed53b264184293
Summary: This was an error appearing in the console that was bugging me. About how arrays of React nodes should have a key prop.
Reviewed By: passy
Differential Revision: D16646487
fbshipit-source-id: b61841c001eb4a93f0a071557b921ca7365e2ac3
Summary: I have found it neccessary to get the current app name for the Navigation plugin. This passes the current selectedApp as a prop into any FlipperPlugin.
Reviewed By: jknoxville
Differential Revision: D16645855
fbshipit-source-id: 996d41b1a0e939427e66fa0df172ce1a6471f686
Summary:
This is the result of a `yarn upgrade`. While this *shouldn't* break
anything, it easily can just as this broke the babel transform
because a previously transitively depended upon library was no
longer included.
It seems like a good idea to stay as close as possible to the upstream of all
the dependencies we have and with the release yesterday we now have one week to
check if the rest works as expected.
allow-large-files
Reviewed By: danielbuechele
Differential Revision: D16579807
fbshipit-source-id: f26d4536abd80f428e94b71e0fa98df612cbd809
Summary:
Currently icons were always fetched remotely. We used a service worker to prefetch and cache some icons, that were critical to the UI.
In this diff, we are bundling icons at build time, with the app. In utils/icons.js we still specfify the list of icons which should be bundled. These are downloaded as part of the build step and bundled with the app. We are downloading the icons in 1x and 2x (the two most common pixel densities).
Reviewed By: jknoxville
Differential Revision: D16620764
fbshipit-source-id: 965a7793ad1f08aebb292606add00218429cdaf4
Summary: This may be needed e.g. if there are multiple ManagedTables in the window.
Reviewed By: jknoxville, danielbuechele
Differential Revision: D16620862
fbshipit-source-id: 1880e9e6e8e9ece5f687b2768eae7c4f206f69da
Summary:
Okay so the main changes here are integrating the providers into the auto complete sheet and getting the search bar to work with it also.
For instance, in the search bar, I want to update the value string to whatever the user has highlighted in the auto complete sheet, without executing a new query. So thus, I had to create a new state variable in the search bar component for this.
I've also moved the custom hook into its own file to keep the component short in size. It had to be mainly rewritten to support providers instead of only bookmarks. Same goes for the entire AutoCompleteSheet component.
The bookmarksProvider is stored in the persisted state as to not regenerate every-time on render. It is only updated if the bookmarks are updated which are also now stored in the persistedState for the same reason.
Lastly, a DefaultProvider object was also made for the initial persisted state object.
Reviewed By: danielbuechele
Differential Revision: D16581644
fbshipit-source-id: 88723a4081d96250f723a4cd7b1ade101bf3e8f3
Summary:
- fix mutual selection of elements in ax and non-ax tree (simplifies linkedNode logic as well)
- remove unneeded extraInfo attributes (focused, nonAXwithAXchild, & hasAXNode were not/no longer being used)
- use 50/50 fixed width view for trees when both are visible
Reviewed By: jknoxville
Differential Revision: D16390355
fbshipit-source-id: bbf9ea887f8f1035df8b4b0562ddcc4de291f004
Summary: Adds the capability to run the export in the background along with the display of the status in the title bar.
Reviewed By: danielbuechele
Differential Revision: D16567026
fbshipit-source-id: 3955243cd7f094a7ee33eef3511804ff6e6476be
Summary:
These are a series of utility functions for the auto complete system in the nav bar.
Essentially, the auto complete system will gather information from Providers. Providers provide auto complete information from various sources i.e. bookmarks, recently viewed, or uri match patterns from the build.
There are two main functions in this commit. The first is to turn the bookmarks Map into a Provider (bookmarksToAutoCompleteProvider). This runs in O(n) time where n is the number of bookmarks. A provider has an associated icon and matchPatterns to match what the user types to a uri. Here I concatenate the commonName and the uri of the bookmark together for the match pattern so that the user can search for both.
filterProvidersToLineItems takes an Array of providers and returns line items. These are objects that will be displayed by the nav bar auto complete system. This has a little bit of a longer running time. O(mnop). Where m is the number of providers, n is the number of items in the largest provider, o is the length of the query and p is the length of the line items. This may seem bad, but I've tested the performance using 364 entries and it completes the function in less than a millisecond.
The Providers will have precedence in the final auto complete box. With the most recent provder taking the most precedence, followed by bookmarks, followed by match patterns.
Reviewed By: danielbuechele
Differential Revision: D16568500
fbshipit-source-id: 00b043d51051ee86b3dbe18564e6f582b19e5359
Summary:
Live editing is now working faster.
We had an issue that it took about 5 seconds to see the view changed and 10 seconds to see tha value in the flipper, now it's done immidiately
Reviewed By: priteshrnandgaonkar
Differential Revision: D16500961
fbshipit-source-id: 742ce628a887bab06c1b883d9710c477af2508e7
Summary:
Will post about this in more detail later but in short, this is taking
up wayyyy too much space.
Reviewed By: danielbuechele
Differential Revision: D16543587
fbshipit-source-id: 8130a1a8378e5a6ffde669d651063ef92eb021c0
Summary:
Here I've added a drop down sheet for the nav bar. Currently it only supports showing the first five bookmarks with no filtering.
I use a custom hook to handle navigation with the keyboard in the nav bar, so that works well.
So you can use the arrow keys to select a uri from the dropdown, or by using the mouse.
Reviewed By: danielbuechele
Differential Revision: D16542218
fbshipit-source-id: 4c242fd3097297fc599b36523bb4821bbc172f88
