Summary: Resize oberserver limit exceeded appears to be a benign error that we can safely ignore, added ability to change log level. Given we report errors to our user logs, fb log view and console the console log patching has been centralised and now logs are pushed to whatever destinations we have.
Reviewed By: lblasa
Differential Revision: D44666836
fbshipit-source-id: e028dbc52b00947097833f9f3619189226247e1d
Summary: Requested by antonk52 and MSYS team
Reviewed By: passy
Differential Revision: D44662243
fbshipit-source-id: 2bace476c4e79b6a05bfb89ddc3e6acb437c6c3b
Summary: It makes little sense to hide this info from developers. It was also requested by antonk52
Reviewed By: LukeDefeo
Differential Revision: D44631235
fbshipit-source-id: 1756c5ca2a95b2f815f8c4336621d3c057b704f2
Summary: On downloading the new flipper update some of the older plugins which are on a different release cycle may try to call getUser which was removed in this stack in favour of getCached user and fetchUser, adding this back temporarily so those calls dont fail. This can be removed down the road once those plugins have soaked into the user base
Reviewed By: ivanmisuno, aigoncharov
Differential Revision: D44541277
fbshipit-source-id: 95e67d5ba11bbc26590d2789127cbf6a68c54f16
Summary: This is an edge case where if we make a intern call to fetch user with an invalid token we would imply that the token may have expired. Since we already have a error message in the sign in sheet we dont show the notification
Reviewed By: aigoncharov
Differential Revision: D44502480
fbshipit-source-id: 531df6db28bc2a6f36ffcf0a3903ee0e8e40be0f
Summary:
This command is never actually dispatched so removing to avoid future confusion.
When new plugins are downloaded a check is done here https://fburl.com/code/e3zedljb to see if pluginIsDisabledForAllConnectedClients, if so, load command is queued, which internally calls update (which resets state)
If the plugin is not disabled then a message appears asking user to manually reload.
Reviewed By: aigoncharov
Differential Revision: D44502476
fbshipit-source-id: b796b77f843218c07ee612d9f45cacba073362d3
Summary: The source of truth for logging in is the atom, the userprofile is a side effect and is cached so calling these actions login/logout is very confusing, especially considering those functions exist elsewhere that manage the atoms
Reviewed By: aigoncharov
Differential Revision: D44502481
fbshipit-source-id: 77080cc02134684a58f52fcad74041b4508a22f0
Summary:
This diff introduces a few changes:
The login sheet is no longer closable via the x or clicking outside the modal, the cancel button is removed
On startup we check if we have a toke and throw up the sheet
if logout occurs for any reason we throw up the sheet
renamed write_keychain to login, to be consstent with the logout method. It does more than write to key chain since it manages the logged in atom also
Reviewed By: aigoncharov
Differential Revision: D44502483
fbshipit-source-id: 1d91d4eaae65ca523a08e205d1ad730d4d4d090f
Summary: There were redundant places we were cleaning up and logging out, now all syncronisation between the atom world and everything else is done via the atom subscription.
Reviewed By: aigoncharov
Differential Revision: D44463888
fbshipit-source-id: 9fc2af64b1e0667dd852096557107a48f2fa924c
Summary: Indicate intern connection state via an icon, now that we are polling when offline this icon automatically goes away one we reconnect
Reviewed By: aigoncharov
Differential Revision: D44502479
fbshipit-source-id: fb411940f1e4cad50539fe08df6d6194b176404a
Summary:
Logged in state now means that we have a valid token. On startup we try to retrieve a token, if its there then we are logged in, if we remove the tokem, due to explicit logout, or if its expired we are logged out.
Connected is more dynamic, it means we can actually hit intern with a sucessful response. It implicitly requires a token / being logged in
Reviewed By: aigoncharov
Differential Revision: D44502482
fbshipit-source-id: e3077101766cba5128a61d62be3bbd1ca1f00b4f
Summary:
Previously the left rail state was decided by prescense of user profile but we are moving to logged in state being based on the atom.
As a result we need to cache the user profile so we have something to display when user not on vpn on startup
Reviewed By: aigoncharov
Differential Revision: D44502477
fbshipit-source-id: 11462d24c773d6d364e844b4f606e124e5278348
Summary:
Stacktrace component was not properly displaying on Light/Dark mode as it was using colours not from the theme.
This change addresses that.
Reviewed By: ivanmisuno
Differential Revision: D44537750
fbshipit-source-id: 1d95313bfc9b5ef386864fa230348b76dce6d648
Summary: See https://fb.workplace.com/groups/flippersupport/permalink/1586389021841750/. Flipper suggests that not connecting to VPN is the problem, while the problem can also not being logged in.
Reviewed By: antonk52
Differential Revision: D44164192
fbshipit-source-id: 993d2a4bdc6a9cb0c45f35856b83449cea294d45
Summary:
https://pxl.cl/2tKXq
It was reported the feedback prompt title was unreadable.
Reviewed By: mweststrate
Differential Revision: D43533800
fbshipit-source-id: f756a9822c479105dae890159518c05c99405fb7
Summary: Plugin download failure is typical a transient error, no need to trigger monitoring for that
Reviewed By: ivanmisuno
Differential Revision: D43118116
fbshipit-source-id: 0cd0f87f0ed6123adcba28139308ecea92b1b508
Summary:
Tasks like T143443148 pop up frequently and are inactionable. This is usually due to device flakiness, storage being full, incompatibility or configuration problems.
Start and stop were also copy-pasted to make matters worse.
Reviewed By: ivanmisuno
Differential Revision: D42800489
fbshipit-source-id: 11caaa4133e4fa1d773364a6ba4e5f5bb0d2f2ce
Summary:
Followup of D39772453 (2437aeb3e9)
Fixes https://fb.workplace.com/groups/flippersupport/permalink/1518236858656967/
1. Stop using clientWidth and offsetWidth because they have rounding errors
2. Since step 1 did not resolve the issue entirely (for some weird reason I do not really have the capacity now to investigate - my bet it is a rounding error when you sum up doubles) set offset of the table to "scroll" instead of "auto". As a result, it starts rendering space for the scrollbars all the time, but since Flipper is a dev tool it should be fine
Reviewed By: antonk52
Differential Revision: D41839402
fbshipit-source-id: cf50eb1600b692d3970003fd1b45b953ee45e3df
Summary:
In our organization, Flipper is distributed in a version controlled way. As a result, we do not want users to manually update or receive prompts to update when a new version is available. There is already a `--updater` flag in the command line arguments for flipper.exe, but it isn't piped through. This change pipes it through and disables all update related UI when `--no-updater` is passed in.
## Changelog
Support --updater and --no-updater options for flipper.exe
Pull Request resolved: https://github.com/facebook/flipper/pull/4277
Test Plan: Ran `yarn build --win` in flipper/desktop, and launched flipper.exe from flipper/dist/win-unpacked with the `--updater`, `--no-updater` and no flags and ensured the proper behavior was observed (update UI shows by default or when `--updater` is specified, and doesn't show when `--no-updater` is specified).
Reviewed By: passy
Differential Revision: D41298321
Pulled By: mweststrate
fbshipit-source-id: 5ddfede2700954f0fdd6a111b20d0836fab25565
Summary:
Flipper plugins fail when importing css from third-party dependencies. This diff tries to fix that.
Effectively, the plugin can import the css and export it when is bundled.
When we load the plugin, we check if there's a css file for it. If there's one, we return it and try to use it.
Reviewed By: aigoncharov
Differential Revision: D40758178
fbshipit-source-id: e53afffcc481504905d5eeb1aea1f9114ee2a86b
Summary:
Design doc: https://docs.google.com/document/d/1HLCFl46RfqG0o1mSt8SWrwf_HMfOCRg_oENioc1rkvQ/ed
It does not make too much sense to have 2 different entry points to export Flipper debug data and to create a support request. It only creates ambiguity for our users. We could open the support request form automatically for them every time. In those rare cases when they try to attach new data to an existing support request, they can always not submit the form.
Reviewed By: passy
Differential Revision: D40632145
fbshipit-source-id: 6ca454d6e885493b32ac3aad008482045dccf51d
Summary:
Design doc: https://docs.google.com/document/d/1HLCFl46RfqG0o1mSt8SWrwf_HMfOCRg_oENioc1rkvQ/edit#
Attach what we can to the universal export file if any of the steps time out
CHANGELOG: Add a universal debug export button
Reviewed By: passy
Differential Revision: D40552235
fbshipit-source-id: 775afccacf053fbcf764d1f39e93a89ad20dee0a
Summary:
Design doc: https://docs.google.com/document/d/1HLCFl46RfqG0o1mSt8SWrwf_HMfOCRg_oENioc1rkvQ/edit#
Exporting all files form a device and export Flipper's own state could take a long time. We need to keep our users updated on the status.
Reviewed By: passy
Differential Revision: D40551661
fbshipit-source-id: d5c94fb99d4bc8b4495ce463915b77c475548f01
Summary:
Design doc: https://docs.google.com/document/d/1HLCFl46RfqG0o1mSt8SWrwf_HMfOCRg_oENioc1rkvQ/edit#
Add a button to export all possible debug data at once. IN subsequent diffs, I'll add more extensive data collection.
Reviewed By: antonk52
Differential Revision: D40467606
fbshipit-source-id: 6a4225945b1feb6c1a8073b5209a62ba0beb6148
Summary:
There were some situations were we would hang waiting for new clients but one had connected.
Additionally the old approach would close and reopen the dialog every time a state update happened in the redux store which was a little jarring. Now the polling of the update is independant the dialog
The dialog still flashes for other parts of the flow (when scanning for devices) and would be nice to fix this too in the future
Reviewed By: mweststrate
Differential Revision: D40477502
fbshipit-source-id: d1ff161f262493cf5b3fb74e22b49ed65de8c292
Summary: We were incorrectly assuming a client did not support a plugin because it was not fully initialized. This issue was only apparant on start deep links
Reviewed By: mweststrate
Differential Revision: D40477503
fbshipit-source-id: 5fd9db765f559b8eb80cc3680ee694dfd2cf9a37
Summary:
Without seeing the specific messages it might be hard to debug what is taking so long.
CHANGELOG: Enhance a warning about taking too much time to process plugin messages
Differential Revision: D40340272
fbshipit-source-id: a4dbd639cf389763a3cb00a190216c0e653c08e4
Summary:
Show users a way to fix Flipper EADDRINUSE on their own without filing a support request
CHANGELOG: Better error message for EADDRINUSE
Reviewed By: mweststrate
Differential Revision: D40338164
fbshipit-source-id: ec0419c78983b55736aa773757775b5302da51e0
Summary: Previously opening a deep link would always fail with flipper thinking the plugin did not exist. In this diff we wait for plugins to be initialized
Differential Revision: D40142275
fbshipit-source-id: 7894fc60a6df57e13395e05263b0905847b11ad3
Summary: We have a list of modules that we do not bundle with the plugins, but provide externally to them from Flipper. For the mechanism to work correctly, we have to stop importing from nested paths of these modules.
Reviewed By: mweststrate
Differential Revision: D39776237
fbshipit-source-id: 06eae9bf9d5b11b48d2720bf592bfea749773847
Summary:
^
Adding listeners was correctly intercepting events but the event object often lacked the information necessary to correctly triage and fix an issue.
I discovered that by subscribing to these events directly, the event object did have the required information.
Changelog: Use global window event handlers instead of listeners
Reviewed By: antonk52
Differential Revision: D39809292
fbshipit-source-id: 8a0fc7b7cd86ea16e40f2dc383bc30364f6fc16c
Summary: Without this change gatekeeped and disabled plugins are also counted as loaded, which results in plugin duplication in the UI
Reviewed By: lblasa
Differential Revision: D39695335
fbshipit-source-id: 759e2e0eaead1bee0f7d61e4ba3d1b8e4b6c0976
