Ranesh Saha
7a28ed1fe5
Pipe through --updater/--no-updater flag for flipper.exe ( #4277 )
...
Summary:
In our organization, Flipper is distributed in a version controlled way. As a result, we do not want users to manually update or receive prompts to update when a new version is available. There is already a `--updater` flag in the command line arguments for flipper.exe, but it isn't piped through. This change pipes it through and disables all update related UI when `--no-updater` is passed in.
## Changelog
Support --updater and --no-updater options for flipper.exe
Pull Request resolved: https://github.com/facebook/flipper/pull/4277
Test Plan: Ran `yarn build --win` in flipper/desktop, and launched flipper.exe from flipper/dist/win-unpacked with the `--updater`, `--no-updater` and no flags and ensured the proper behavior was observed (update UI shows by default or when `--updater` is specified, and doesn't show when `--no-updater` is specified).
Reviewed By: passy
Differential Revision: D41298321
Pulled By: mweststrate
fbshipit-source-id: 5ddfede2700954f0fdd6a111b20d0836fab25565
2022-11-15 03:23:55 -08:00
Lorenzo Blasa
587f428cf8
Allow plugins to use css
...
Summary:
Flipper plugins fail when importing css from third-party dependencies. This diff tries to fix that.
Effectively, the plugin can import the css and export it when is bundled.
When we load the plugin, we check if there's a css file for it. If there's one, we return it and try to use it.
Reviewed By: aigoncharov
Differential Revision: D40758178
fbshipit-source-id: e53afffcc481504905d5eeb1aea1f9114ee2a86b
2022-10-27 22:50:30 -07:00
dependabot[bot]
404449d499
Bump yargs from 17.4.1 to 17.6.0 in /desktop ( #4165 )
...
Summary:
Bumps [yargs](https://github.com/yargs/yargs ) from 17.4.1 to 17.6.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/yargs/yargs/blob/main/CHANGELOG.md ">yargs's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/yargs/yargs/compare/v17.5.1...v17.6.0 ">17.6.0</a> (2022-10-01)</h2>
<h3>Features</h3>
<ul>
<li><strong>lang:</strong> Czech locale (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/2220 ">https://github.com/facebook/flipper/issues/2220 </a>) (<a href="5895cf1ba1https://github-redirect.dependabot.com/yargs/yargs/issues/2210 ">https://github.com/facebook/flipper/issues/2210 </a>) (<a href="b680ace299https://github-redirect.dependabot.com/yargs/yargs/issues/2186 ">https://github.com/facebook/flipper/issues/2186 </a>) (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/2215 ">https://github.com/facebook/flipper/issues/2215 </a>) (<a href="561fc7a787https://github-redirect.dependabot.com/yargs/yargs/issues/2241 ">https://github.com/facebook/flipper/issues/2241 </a>) (<a href="38e8df10f0https://github-redirect.dependabot.com/yargs/yargs/issues/2171 ">https://github.com/facebook/flipper/issues/2171 </a>) (<a href="f91d9b334a394f5f86d1https://github.com/yargs/yargs/compare/v17.5.0...v17.5.1 ">17.5.1</a> (2022-05-16)</h3>
<h3>Bug Fixes</h3>
<ul>
<li>add missing entries to published files (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/2185 ">https://github.com/facebook/flipper/issues/2185 </a>) (<a href="5685382d18https://github-redirect.dependabot.com/yargs/yargs/issues/2164 ">https://github.com/facebook/flipper/issues/2164 </a>) (<a href="cbc2eb726e22e9af28bbhttps://github-redirect.dependabot.com/yargs/yargs/issues/2123 ">https://github.com/facebook/flipper/issues/2123 </a>) (<a href="e0823dd7e6https://github-redirect.dependabot.com/yargs/yargs/issues/2181 ">https://github.com/facebook/flipper/issues/2181 </a>) (<a href="1c331f22c7https://github-redirect.dependabot.com/yargs/yargs/issues/2179 ">https://github.com/facebook/flipper/issues/2179 </a>) (<a href="b672e709e44dac5b8c2fhttps://github.com/yargs/yargs/compare/v17.4.1...v17.5.0 ">17.5.0</a> (2022-05-11)</h2>
<h3>Features</h3>
<ul>
<li>add browser.d.ts and check for existence of Error.captureStackTrace() (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/2144 ">https://github.com/facebook/flipper/issues/2144 </a>) (<a href="6192990509db35423270https://github-redirect.dependabot.com/yargs/yargs/issues/2151 ">https://github.com/facebook/flipper/issues/2151 </a>) (<a href="95aed1c1756cd8e2d6a4https://github-redirect.dependabot.com/yargs/yargs/issues/2213 ">https://github.com/facebook/flipper/issues/2213 </a>)</li>
<li><a href="38e8df10f0https://github-redirect.dependabot.com/yargs/yargs/issues/2241 ">https://github.com/facebook/flipper/issues/2241 </a>)</li>
<li><a href="394f5f86d1561fc7a787https://github-redirect.dependabot.com/yargs/yargs/issues/2186 ">https://github.com/facebook/flipper/issues/2186 </a>) (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/2215 ">https://github.com/facebook/flipper/issues/2215 </a>)</li>
<li><a href="5895cf1ba1https://github-redirect.dependabot.com/yargs/yargs/issues/2220 ">https://github.com/facebook/flipper/issues/2220 </a>)</li>
<li><a href="f91d9b334ahttps://github-redirect.dependabot.com/yargs/yargs/issues/2171 ">https://github.com/facebook/flipper/issues/2171 </a>)</li>
<li><a href="b680ace299https://github-redirect.dependabot.com/yargs/yargs/issues/2210 ">https://github.com/facebook/flipper/issues/2210 </a>)</li>
<li><a href="659dbbb4a402515116f8https://github-redirect.dependabot.com/yargs/yargs/issues/2187 ">https://github.com/facebook/flipper/issues/2187 </a>)</li>
<li><a href="22e9af28bbhttps://github.com/yargs/yargs/compare/v17.4.1...v17.6.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4165
Reviewed By: aigoncharov
Differential Revision: D40022361
Pulled By: aigoncharov
fbshipit-source-id: 5408257376334746865b27b27461ec29dea8e78a
2022-10-05 02:27:07 -07:00
Andrey Goncharov
dd7ba2d6fc
Fix fb-stubs replacement for plugin bundling
...
Reviewed By: nikoant
Differential Revision: D39765543
fbshipit-source-id: 14cbf8a9bdf35031e636bbbde3dbc955faedb66b
2022-09-23 05:50:28 -07:00
Andrey Goncharov
61a8fe09e9
Stop failing the entire plugin compatibility check if a shared plugin lib fails it
...
Summary: Currently, if we publish a new shared plugin lib in a separate diff, the compatibility check fails for it while it should exit with a warning only
Reviewed By: antonk52
Differential Revision: D39731259
fbshipit-source-id: 7651642ebfb5e18ace047d36b52907bca65c4462
2022-09-23 04:52:42 -07:00
Andrey Goncharov
fd811db12b
Rebuild all plugins if a shared lib changed
...
Summary: Some plugins import from shared directories. These directories are not plugins themselves, therefore the current plugin root searching mechanism does nto work for them. To support plugin reloading for this scenario, we start re-building all plugins if we fail to find a plugin root.
Reviewed By: lblasa
Differential Revision: D39693820
fbshipit-source-id: 33dd7de4121bd5665a39b0ea96adce4603dc7df0
2022-09-22 04:17:24 -07:00
Ken Yee
fa9ba6f2d0
Adds a notifyAvailableUpdate flag to config.json to disable update ( #3992 )
...
Summary:
We would like to version control Flipper and some of our custom plugins that are installed on developers' systems.
Flipper by default prompts users to upgrade so they sometimes do the update and then all our custom plugins break because they were compiled for an older version.
See https://github.com/facebook/flipper/issues/3947 for feature request info.
## Changelog
Adds notifyAvailable flag to config.json to disable prompting for users that "an update is available"
Pull Request resolved: https://github.com/facebook/flipper/pull/3992
Test Plan:
Tested by running locally.
Had to comment out the isProduction() check to confirm this it worked properly because this flag is false on dev versions.
Couldn't figure out how to manually test the handleOpenPluginDeeplink.tsx change but made a similar change there; happy to test that if you can tell me how to exercise that path.
Reviewed By: antonk52
Differential Revision: D39654481
Pulled By: antonk52
fbshipit-source-id: cef6b48d870915c48f620269c42d24b8ef1f4c29
2022-09-21 09:47:44 -07:00
Andrey Goncharov
3314c77ce9
Add exportFileBinary to FlipperLib
...
Reviewed By: antonk52
Differential Revision: D39692937
fbshipit-source-id: 7b3c78d004a9734cd8ae660d5782be1f02c00009
2022-09-21 09:26:19 -07:00
Andrey Goncharov
d81dac18b5
Work around empty file restirction
...
Reviewed By: nikoant
Differential Revision: D39578561
fbshipit-source-id: 3a471e7dd06a1e8cee2c7823b1d7f764110ecf80
2022-09-16 09:00:21 -07:00
Andrey Goncharov
2aa3dc9bd8
Remove reference to flipper-server bundle map
...
Summary: flipper-server is currently shipped unbundled and unminified
Reviewed By: nikoant
Differential Revision: D39577062
fbshipit-source-id: cd78aded878358e9f90792c695b6d1b27863f05a
2022-09-16 08:09:31 -07:00
Andrey Goncharov
7c66a83328
Add source map copying for plugins
...
Reviewed By: nikoant
Differential Revision: D39576201
fbshipit-source-id: cd6b11bdb0a4c89e2f84d1c4772f08acc4b86418
2022-09-16 07:22:09 -07:00
Andrey Goncharov
8dc5f4d3ea
Remove stale build options
...
Summary: Now that we build all plugins at all times and it is super-fast, these options are redundant
Reviewed By: lblasa
Differential Revision: D39542723
fbshipit-source-id: 1b30ba384267ec4fd0c35b4dc14f0223ffe414c9
2022-09-15 10:02:19 -07:00
Andrey Goncharov
ab03140201
Fix list of watch folders for electron dev build
...
Summary: Restart electron app if we had any server-code changes
Reviewed By: lblasa
Differential Revision: D39542169
fbshipit-source-id: fb8e335f3e3fe0cf34e57a79b96e9cc8377e9fda
2022-09-15 10:02:19 -07:00
Andrey Goncharov
c69d102ca1
Track plugin changes and notify frontend
...
Summary: Watch source plugin folders and notify frontend that any of them changed. In subsequent diffs, we will start reloading plugins that changed.
Reviewed By: lblasa
Differential Revision: D39539443
fbshipit-source-id: 726916c0bce336a2c0179558526bcb1b74e35b93
2022-09-15 10:02:19 -07:00
Andrey Goncharov
3639feef61
Watch and rebuild plugins
...
Summary: Now, once we build all plugins before we start Flipper, we need to rebuild some of them when they change. Previously, it was handled by Metro when we included plugins int he bundle, but we no longer include them in the bundle.
Reviewed By: lblasa
Differential Revision: D39510213
fbshipit-source-id: a352d78946f844a25d9127ac09c26e43e6739ca9
2022-09-15 10:02:19 -07:00
Andrey Goncharov
9dda947371
Fix flipper server prod build
...
Summary: Make flipper-server link local flipper-* deps for intern prod build. Update flipper-* deps versions for public builds so `npx` pulls them from npm
Reviewed By: lblasa
Differential Revision: D39497944
fbshipit-source-id: ca2674a4ac8f5b6c3efa9546b631f2526bf48f8e
2022-09-15 10:02:19 -07:00
Andrey Goncharov
ed93dfe978
Refine prod and dev deps
...
Summary: Move flipper local deps to prod deps, so yarn installs them later when we build a bundle
Reviewed By: lblasa
Differential Revision: D39475545
fbshipit-source-id: 5b61d15b45ee315c3b35d8e6836c114b90503b1a
2022-09-15 10:02:19 -07:00
Andrey Goncharov
f835e07c46
Build all plugins before start
...
Summary: prepareDefaultPlugins builds all plugins now. We no longer need extra helpers
Reviewed By: lblasa
Differential Revision: D39308098
fbshipit-source-id: 4f12a0bdbc2afd2b306565fff3494daa630e1a20
2022-09-15 10:02:19 -07:00
Andrey Goncharov
642a3ebf81
Remove default plugin entrypoints for hot-reloading
...
Summary: As we stopped bundling plugins in D39276249, we no longer need the entry points for the bundled plugins (these entry points are always going to be empty)
Reviewed By: lblasa
Differential Revision: D39307565
fbshipit-source-id: 43751fe31c8bd962677c226b27cfe52093d3f2d4
2022-09-15 10:02:19 -07:00
Andrey Goncharov
94df830dfb
Migrate plugin bundling to esbuild
...
Summary: With esbuild bundling all plugins takes a couple of seconds instead of 3-5 minutes with metro. As a result, we can stop including plugins into Flipper's bundle for development and always bundle them separately. It reduces complexity of our build pipeline and makes the dev build work more like our prod build. It also allows us to stop bundling flipper-server code and just compile it instead.
Reviewed By: lblasa
Differential Revision: D39262048
fbshipit-source-id: c4da0f2ea2807015d98e0d070349c39b2118e189
2022-09-15 10:02:19 -07:00
Andrey Goncharov
a888e6affa
Simplify bundled plugin setup
...
Summary: Stop bundling plugins into Flipper Server bundles. In later diffs, we will start building all plugins even in dev mode which removes the need to bundle them.
Reviewed By: lblasa
Differential Revision: D39276249
fbshipit-source-id: 091405cfcf58aa7e1bd2b382da40f8d9841ae6b1
2022-09-15 10:02:19 -07:00
Andrey Goncharov
a67a4e5d0f
Remove babel transforms for flipper-server
...
Summary: Flipper server itself requires no babel transforms. We applied extra transforms only for the bundled plugins. However, we pack and ship all plugins in the /static folder. They are always available on the FS. Therefore we could stop bundling any plugins into flipper-server's source code.
Reviewed By: lblasa
Differential Revision: D38910251
fbshipit-source-id: b3e9fe5ae2ab69ce5579b01b6793ebf7e88baf66
2022-09-15 10:02:19 -07:00
Andrey Goncharov
218cb6abf2
Fix server bundling order
...
Summary: prepareDefaultPlugins and prepareHeadlessPlugins should come before compileServerMain to bundle plugins
Reviewed By: passy
Differential Revision: D38862132
fbshipit-source-id: 952a2f6d4f857f4faacfc952bebb4e59afcbc5b0
2022-09-15 10:02:19 -07:00
dependabot[bot]
ef66d452ee
Bump app-builder-lib from 23.0.8 to 23.4.0 in /desktop ( #4008 )
...
Summary:
Bumps [app-builder-lib](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib ) from 23.0.8 to 23.4.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/releases ">app-builder-lib's releases</a>.</em></p>
<blockquote>
<h2>v23.4.0</h2>
<h2>What's Changed</h2>
<ul>
<li>feat: Adding timeout to publisher config for api requests and uploads by <a href="https://github.com/mmaietta "><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7028 ">electron-userland/electron-builder#7028</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.3.3...v23.4.0 ">https://github.com/electron-userland/electron-builder/compare/v23.3.3...v23.4.0 </a></p>
<h2>v23.3.3</h2>
<h2>What's Changed</h2>
<ul>
<li>docs: highlight, thanks by <a href="https://github.com/gaoyia "><code>@gaoyia</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7010 ">electron-userland/electron-builder#7010</a></li>
<li>fix: Duplicate values during deep assign of extra files by <a href="https://github.com/mmaietta "><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7019 ">electron-userland/electron-builder#7019</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/gaoyia "><code>@gaoyia</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7010 ">electron-userland/electron-builder#7010</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.3.2...v23.3.3 ">https://github.com/electron-userland/electron-builder/compare/v23.3.2...v23.3.3 </a></p>
<h2>v23.3.2</h2>
<h2>What's Changed</h2>
<ul>
<li>fix: Wrap the nsProcess include in a !ifndef by <a href="https://github.com/titus-anromedonn "><code>@titus-anromedonn</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6996 ">electron-userland/electron-builder#6996</a></li>
<li>fix: installDir definition <a href="https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6907 ">#6907</a> by <a href="https://github.com/panther7 "><code>@panther7</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6995 ">electron-userland/electron-builder#6995</a></li>
<li>fix(electron-updater): fix backward compatibility for GitHub provider without channels by <a href="https://github.com/matejkriz "><code>@matejkriz</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6998 ">electron-userland/electron-builder#6998</a></li>
<li>chore: Adding allowPrerelease github integration tests by <a href="https://github.com/mmaietta "><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7003 ">electron-userland/electron-builder#7003</a></li>
<li>docs: Add customWelcomePage example to Custom NSIS script by <a href="https://github.com/hueyyeng "><code>@hueyyeng</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7001 ">electron-userland/electron-builder#7001</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/titus-anromedonn "><code>@titus-anromedonn</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6996 ">electron-userland/electron-builder#6996</a></li>
<li><a href="https://github.com/matejkriz "><code>@matejkriz</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6998 ">electron-userland/electron-builder#6998</a></li>
<li><a href="https://github.com/hueyyeng "><code>@hueyyeng</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7001 ">electron-userland/electron-builder#7001</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.3.1...v23.3.2 ">https://github.com/electron-userland/electron-builder/compare/v23.3.1...v23.3.2 </a></p>
<h2>v23.3.1</h2>
<h2>What's Changed</h2>
<ul>
<li>feat: Add installDir property for NsisUpdater by <a href="https://github.com/panther7 "><code>@panther7</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6907 ">electron-userland/electron-builder#6907</a></li>
<li>chore(deps): update dependency <code>@types/archiver</code> to v5.3.1 by <a href="https://github.com/renovate "><code>@renovate</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6979 ">electron-userland/electron-builder#6979</a></li>
<li>chore(deps): update dependency <code>@types/node</code> to v16.11.43 by <a href="https://github.com/renovate "><code>@renovate</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6980 ">electron-userland/electron-builder#6980</a></li>
<li>fix: parallel release creation with Keygen publisher by <a href="https://github.com/ezekg "><code>@ezekg</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6989 ">electron-userland/electron-builder#6989</a></li>
<li>fix: add product scope to Keygen publisher by <a href="https://github.com/ezekg "><code>@ezekg</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6990 ">electron-userland/electron-builder#6990</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.3.0...v23.3.1 ">https://github.com/electron-userland/electron-builder/compare/v23.3.0...v23.3.1 </a></p>
<h2>v23.3.0</h2>
<h2>What's Changed</h2>
<ul>
<li>feat: upgrade Keygen integration to v1.1 by <a href="https://github.com/ezekg "><code>@ezekg</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6941 ">electron-userland/electron-builder#6941</a></li>
<li>fix(mac): allow Mac Developer certs for non Mac App Store builds by <a href="https://github.com/regentcid434 "><code>@regentcid434</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6956 ">electron-userland/electron-builder#6956</a></li>
<li>fix: prevent infinite looping of overwriteArtifact by <a href="https://github.com/CCInc "><code>@CCInc</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6958 ">electron-userland/electron-builder#6958</a></li>
<li>fix: add product scope to keygen provider by <a href="https://github.com/ezekg "><code>@ezekg</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6975 ">electron-userland/electron-builder#6975</a></li>
<li>fix(mas): Allow signing with "3rd Party Mac Developer Application" by <a href="https://github.com/csett86 "><code>@csett86</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6970 ">electron-userland/electron-builder#6970</a></li>
<li>fix(nsis): fix typo in German installer message by <a href="https://github.com/tkleinke "><code>@tkleinke</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6960 ">electron-userland/electron-builder#6960</a></li>
<li>fix: nsis-web target set APP_PACKAGE_URL_IS_INCOMPLETE by <a href="https://github.com/geovie "><code>@geovie</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6964 ">electron-userland/electron-builder#6964</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/CHANGELOG.md ">app-builder-lib's changelog</a>.</em></p>
<blockquote>
<h2>23.4.0</h2>
<h3>Minor Changes</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7028 ">#7028</a> <a href="e7179b57bdhttps://github.com/mmaietta "><code>@mmaietta</code></a>! - feat: Adding timeout to publisher config for api requests and uploads</li>
</ul>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies [<a href="e7179b57bd98d3a6361dhttps://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6996 ">#6996</a> <a href="5301525393https://github.com/titus-anromedonn "><code>@titus-anromedonn</code></a>! - fix: Wrap the nsProcess.nsh include in a !ifndef in case it has already been imported in a custom install script</li>
</ul>
<h2>23.3.1</h2>
<h3>Patch Changes</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6989 ">#6989</a> <a href="7ad5101b4ahttps://github.com/ezekg "><code>@ezekg</code></a>! - Fix issue where, upon publishing a new release, electron-builder would attempt to create the same release for each artifact in parallel, resulting in conflict errors.</li>
</ul>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6990 ">#6990</a> <a href="c3407a202dhttps://github.com/ezekg "><code>@ezekg</code></a>! - Fix release conflicts for Keygen publisher when releases share the same version across open/licensed products.</li>
</ul>
<h2>23.3.0</h2>
<h3>Minor Changes</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6941 ">#6941</a> <a href="14503ceb99https://github.com/ezekg "><code>@ezekg</code></a>! - Upgrade Keygen publisher/updater integration to API version v1.1.</li>
</ul>
<h3>Patch Changes</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6964 ">#6964</a> <a href="b0e1b6f8afhttps://github.com/geovie "><code>@geovie</code></a>! - fix: nsis-web target set APP_PACKAGE_URL_IS_INCOMPLETE</li>
</ul>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6970 ">#6970</a> <a href="28c07b4392https://github.com/csett86 "><code>@csett86</code></a>! - fix(mas): Allow signing with "3rd Party Mac Developer Application"</li>
</ul>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6960 ">#6960</a> <a href="6e90c84591https://github.com/tkleinke "><code>@tkleinke</code></a>! - fix(nsis): fix typo in German installer message</li>
</ul>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6961 ">#6961</a> <a href="4c867aa017https://github.com/aripollak "><code>@aripollak</code></a>! - fix: Optionally allow removing DISABLE_WAYLAND flag for snaps</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="217f4af53ahttps://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/7030 ">#7030</a>)</li>
<li><a href="e7179b57bdhttps://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/7028 ">#7028</a>)</li>
<li><a href="94982619c1https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/7020 ">#7020</a>)</li>
<li><a href="3e9cd2c88ehttps://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/7002 ">#7002</a>)</li>
<li><a href="5301525393https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6996 ">#6996</a>)</li>
<li><a href="d99da8286bhttps://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6986 ">#6986</a>)</li>
<li><a href="c3407a202dhttps://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6990 ">#6990</a>)</li>
<li><a href="7ad5101b4ahttps://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6989 ">#6989</a>)</li>
<li><a href="e7912d92b2https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6950 ">#6950</a>)</li>
<li><a href="f70abf1628https://github.com/electron-userland/electron-builder/commits/v23.4.0/packages/app-builder-lib ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4008
Reviewed By: lawrencelomax
Differential Revision: D38781621
Pulled By: passy
fbshipit-source-id: 6fe8bcbd584cab6fc60abd5fe34b7340ea27ab12
2022-08-18 07:46:18 -07:00
Feiyu Wong
3ffb25e672
Update UI for enabling persisted logs feature
...
Summary:
This is the first diff to implement the feature for the Flipper logs plugin to have an option to persist logs in the table between crashes, disconnections, etc.
Since this is not a local change, the UI option for persistence will be located in the settings for the Flipper UI(as seen in the test plan). The setting is associated with the Redux Store `Settings` and is stored globally to be used across all plugins. So the plan is making the persistence pertain to all plugins.
Reviewed By: mweststrate
Differential Revision: D37786988
fbshipit-source-id: 7ffc6077cbca559b3401b16770eda657a6c45620
2022-07-28 13:56:34 -07:00
Lorenzo Blasa
646b9d5a5d
UDS/TCP options
...
Summary:
Provide an option to enable/disable TCP connections on flipper-server.
The only change at this stage is that Flipper Desktop will use UDS to connect to flipper-server.
Reviewed By: passy
Differential Revision: D37519656
fbshipit-source-id: 3d02084666fde532ec76134edf8cf6a231060a48
2022-06-29 15:01:05 -07:00
Andrey Goncharov
e4d33483d0
Fix starting Flipper electron in dev mode without default plugins
...
Summary: yarn start --no-default-plugins currently fails
Reviewed By: nikoant
Differential Revision: D37456367
fbshipit-source-id: 3700055b3b780af4575dd67d50532050d12119df
2022-06-27 08:05:31 -07:00
Andrey Goncharov
92cdb81096
Upgrade electron version
...
Summary:
CHANGELOG: Upgrade electron to 18.2.0.
In Electron 18.2.0 we no longer have access to `remote`. Instead, we are recommended to implement IPC communications. We re-implement `remote` methods used before as IPC commands. To support type-safe execution of the commands, we create electron IPC clients on both sides: the main process and renderer process. We also move the main menu creation to the main process and track its usage via sending IPC messages to the renderer process where the logging happens.
Reviewed By: mweststrate
Differential Revision: D36593625
fbshipit-source-id: 6dcf531461ef2edceb9cac372a650f84f3370953
2022-05-31 06:52:14 -07:00
Pascal Hartig
11ff9b51e3
Fix node +x bit in server distribution
...
Summary: This was lost when I changed from `pkg-fetch` writing it to copying the file.
Reviewed By: mweststrate, aigoncharov
Differential Revision: D36682861
fbshipit-source-id: 23822d4cc75720a83282de949d28029a05a2a7f9
2022-05-30 03:44:28 -07:00
Andrey Goncharov
4eca8d1088
Add isHeadlessBuild to EnvironmentInfo
...
Summary: Allows to attribute errors to flipper server or flipper electron
Reviewed By: passy
Differential Revision: D36698504
fbshipit-source-id: 6d07216fd05aa48b7c8cca5b53145916b64526eb
2022-05-27 02:37:53 -07:00
dependabot[bot]
8ce64bbec4
Bump yargs from 17.2.1 to 17.4.1 in /desktop ( #3714 )
...
Summary:
Bumps [yargs](https://github.com/yargs/yargs ) from 17.2.1 to 17.4.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/yargs/yargs/blob/main/CHANGELOG.md ">yargs's changelog</a>.</em></p>
<blockquote>
<h3><a href="https://github.com/yargs/yargs/compare/v17.4.0...v17.4.1 ">17.4.1</a> (2022-04-09)</h3>
<h3>Bug Fixes</h3>
<ul>
<li>coerce pollutes argv (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/2161 ">https://github.com/facebook/flipper/issues/2161 </a>) (<a href="2d1136d303https://github-redirect.dependabot.com/yargs/yargs/issues/2148 ">https://github.com/facebook/flipper/issues/2148 </a>) (<a href="b58b5bc2cdhttps://github-redirect.dependabot.com/yargs/yargs/issues/2143 ">https://github.com/facebook/flipper/issues/2143 </a>) (<a href="e086dfad7fhttps://github-redirect.dependabot.com/yargs/yargs/issues/2142 ">https://github.com/facebook/flipper/issues/2142 </a></li>
<li>show message when showHelpOnFail is chained globally (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/2154 ">https://github.com/facebook/flipper/issues/2154 </a>) (<a href="ad9fcacb00https://github.com/yargs/yargs/compare/v17.3.1...v17.4.0 ">17.4.0</a> (2022-03-19)</h2>
<h3>Features</h3>
<ul>
<li><strong>completion:</strong> choices will now work for all possible aliases of an option and not just the default long option (<a href="30edd50671https://github-redirect.dependabot.com/yargs/yargs/issues/2090 ">https://github.com/facebook/flipper/issues/2090 </a>) (<a href="00e4ebbe3a30edd5067130edd50671https://github-redirect.dependabot.com/yargs/yargs/issues/2105 ">https://github.com/facebook/flipper/issues/2105 </a>) (<a href="d6e342d8efhttps://github-redirect.dependabot.com/yargs/yargs/issues/2092 ">https://github.com/facebook/flipper/issues/2092 </a>) (<a href="6a2977867bhttps://github.com/yargs/yargs/compare/v17.3.0...v17.3.1 ">17.3.1</a> (2021-12-23)</h3>
<h3>Bug Fixes</h3>
<ul>
<li><strong>translations:</strong> correct Korean translation (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/2095 ">https://github.com/facebook/flipper/issues/2095 </a>) (<a href="c7c2b9eb34https://github.com/yargs/yargs/compare/v17.2.1...v17.3.0 ">17.3.0</a> (2021-11-30)</h2>
<h3>Features</h3>
<ul>
<li>fallback to default bash completion (<a href="74c0ba5cfchttps://github-redirect.dependabot.com/yargs/yargs/issues/2013 ">https://github.com/facebook/flipper/issues/2013 </a>) (<a href="adb0d11e02https://github-redirect.dependabot.com/yargs/yargs/issues/2063 ">https://github.com/facebook/flipper/issues/2063 </a>) (<a href="76c19518d73a44796c84https://github-redirect.dependabot.com/yargs/yargs/issues/2079 ">https://github.com/facebook/flipper/issues/2079 </a>) (<a href="e75319d991be525157f3https://github-redirect.dependabot.com/yargs/yargs/issues/2147 ">https://github.com/facebook/flipper/issues/2147 </a>)</li>
<li><a href="2d1136d303https://github-redirect.dependabot.com/yargs/yargs/issues/2161 ">https://github.com/facebook/flipper/issues/2161 </a>)</li>
<li><a href="ad9fcacb00https://github-redirect.dependabot.com/yargs/yargs/issues/2154 ">https://github.com/facebook/flipper/issues/2154 </a>)</li>
<li><a href="b58b5bc2cdhttps://github-redirect.dependabot.com/yargs/yargs/issues/2148 ">https://github.com/facebook/flipper/issues/2148 </a>)</li>
<li><a href="0bb49c3d86https://github-redirect.dependabot.com/yargs/yargs/issues/2125 ">https://github.com/facebook/flipper/issues/2125 </a>)</li>
<li><a href="e086dfad7fhttps://github-redirect.dependabot.com/yargs/yargs/issues/2143 ">https://github.com/facebook/flipper/issues/2143 </a>)</li>
<li><a href="bcd59f1715https://github-redirect.dependabot.com/yargs/yargs/issues/2108 ">https://github.com/facebook/flipper/issues/2108 </a>)</li>
<li><a href="3cbc38ccbfhttps://github-redirect.dependabot.com/yargs/yargs/issues/2141 ">https://github.com/facebook/flipper/issues/2141 </a>)</li>
<li><a href="00e4ebbe3ahttps://github-redirect.dependabot.com/yargs/yargs/issues/2090 ">https://github.com/facebook/flipper/issues/2090 </a>)</li>
<li><a href="c0661643fchttps://github-redirect.dependabot.com/yargs/yargs/issues/2114 ">https://github.com/facebook/flipper/issues/2114 </a>)</li>
<li>Additional commits viewable in <a href="https://github.com/yargs/yargs/compare/v17.2.1...v17.4.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3714
Reviewed By: timur-valiev
Differential Revision: D36371211
Pulled By: mweststrate
fbshipit-source-id: 8a67df778d5d4cb3c314eaf1463d9437fe4261bb
2022-05-23 07:29:26 -07:00
Pascal Hartig
02adfa79e9
Add sourcemap support to server build
...
Summary:
Provide the same build parameters as for the main build and move
the two bundles to a folder where we can pick them up.
For consistency, I'm keeping the naming scheme with the main build.
Reviewed By: antonk52
Differential Revision: D36521046
fbshipit-source-id: 9ea992d6e5dc299d88083d751ca8e84eadb1430b
2022-05-20 04:04:06 -07:00
Pascal Hartig
3c3610662a
Change build to make use of offline cache
...
Summary:
pkg-fetch is a bit weird in that it doesn't use the offline cache
if an output path is defined. That makes building in Sandcastle a lot harder.
Reviewed By: lawrencelomax, aigoncharov
Differential Revision: D36485283
fbshipit-source-id: 27596999c69441bc25e341db77b409ed0caaf0fe
2022-05-19 04:14:47 -07:00
Pascal Hartig
1e20ec7d27
Bump pkg-fetch
...
Summary: Seems to have improvements to the cache which we need in Sandcastle
Reviewed By: lawrencelomax
Differential Revision: D36483459
fbshipit-source-id: 4dfe1dcccddd21c3966508b1260644630c1082f5
2022-05-18 16:11:59 -07:00
Andrey Goncharov
a6d7f98cfd
Bundle headless plugins
...
Summary: Current temporary limitations: all headless plugins are bundled with Flipper.
Reviewed By: antonk52
Differential Revision: D36098168
fbshipit-source-id: c58abe41776157258a5c39a80a5c1a33cf3f42c5
2022-05-10 05:13:24 -07:00
Pascal Hartig
045e0cc9fe
App bundle for server
...
Summary:
This bundles up the Flipper Server in a Mac App Bundle which is identically in shape to a regular Desktop bundle. That means we can swap them out transparently without having to keep the layout in sync with Flipper Launcher.
It bundles nodeJS binary which we can later also provide for aarch64.
Reviewed By: aigoncharov
Differential Revision: D36140809
fbshipit-source-id: fb3410626ab172ce0da48f1a4a1489da68450369
2022-05-09 04:19:55 -07:00
Pascal Hartig
d05d3f9336
Upgrade more /desktop deps
...
Summary: Taking care of the remaining dependabot tasks In my queue.
Reviewed By: mweststrate
Differential Revision: D36131782
fbshipit-source-id: f8a5ce18bfab7c5d50a88d64f9516d67bba4bd6d
2022-05-05 08:07:44 -07:00
Pascal Hartig
342e22bd87
Upgrade more /desktop deps
...
Summary: More bumps for patch and minor releases. allow-large-files
Reviewed By: aigoncharov
Differential Revision: D36104098
fbshipit-source-id: 6db995e660afbe4febd72aa70ed8150cc16a8c93
2022-05-04 04:03:19 -07:00
Pascal Hartig
ef19d06239
Upgrade metro
...
Summary: Bunch of dependabot PRs showed that the signal is green, but still wanted to have all in one diff.
Reviewed By: aigoncharov
Differential Revision: D36102480
fbshipit-source-id: 88d472fdc2a910a7441a9e8164fe8af0f2d90f7b
2022-05-04 04:03:19 -07:00
Pascal Hartig
cc3aca0e8b
Upgrade @types/node to one version everywhere
...
Summary: Caused some inconsistencies when running `tsc`. This brings them back in line.
Reviewed By: aigoncharov
Differential Revision: D36101548
fbshipit-source-id: b8f757c59f879911c9b0920fe11396246ffa37e2
2022-05-04 04:03:19 -07:00
Pascal Hartig
92f88e877b
Script for platform-specific flipper-server bundles
...
Summary:
To roll out Flipper Server for desktop, we need a bundle that comes with all node dependencies pre-installed and a bundled Node runtime. This creates some platform-specific sub-folders in `dist/` with both.
The `--mac`, `--linux`, `--win` options are chosen to be compatible with the main build script. For now, we only build x64 builds for Mac which is also in line with the Desktop build as we don't have signing for the whole bundle.
Reviewed By: lblasa
Differential Revision: D35545492
fbshipit-source-id: cce7165916d91a333f305713b9d6d7b9984984f4
2022-04-12 04:12:55 -07:00
dependabot[bot]
2d46b8bc48
Bump metro from 0.69.0 to 0.69.1 in /desktop ( #3560 )
...
Summary:
Bumps [metro](https://github.com/facebook/metro ) from 0.69.0 to 0.69.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/metro/releases ">metro's releases</a>.</em></p>
<blockquote>
<h2>Release v0.69.1</h2>
<ul>
<li><strong>[Fix]</strong> buck-worker-tool: Implement worker <a href="https://buck.build/rule/worker_tool.html#:~:text=it%20should%20exit%20after%20replying%20on%20stdout ">termination</a> correctly. (22af8747469529ed2532b5392d695514930fb298)</li>
<li><strong>[Fix]</strong> metro-resolver: Export the <code>CustomResolutionContext</code> Flow type for use in custom resolvers. (cde639ca3c4d118a46448eb2a960cfb7bcdc4227)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="32408b89dccde639ca3c0fe1253cc4fa06113363https://github-redirect.dependabot.com/facebook/metro/issues/784 ">https://github.com/facebook/flipper/issues/784 </a>)</li>
<li><a href="8c3f4bffeehttps://github-redirect.dependabot.com/facebook/metro/issues/782 ">https://github.com/facebook/flipper/issues/782 </a>)</li>
<li><a href="64ea6be3cfhttps://github-redirect.dependabot.com/facebook/metro/issues/786 ">https://github.com/facebook/flipper/issues/786 </a>)</li>
<li><a href="d37dea360bhttps://github-redirect.dependabot.com/facebook/metro/issues/785 ">https://github.com/facebook/flipper/issues/785 </a>)</li>
<li><a href="e0cf1daaf4https://github-redirect.dependabot.com/facebook/metro/issues/783 ">https://github.com/facebook/flipper/issues/783 </a>)</li>
<li><a href="521aebd6869e06ce6e5bhttps://github.com/facebook/metro/compare/v0.69.0...v0.69.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3560
Reviewed By: passy
Differential Revision: D35181291
Pulled By: mweststrate
fbshipit-source-id: 248d4efa40dfb1c5d2751f952ed9e6e5ddbbed1b
2022-03-29 09:54:15 -07:00
Michel Weststrate
5b19b378f6
Disable .strict() on all tsx yargs scripts
...
Summary:
Some internal jobs started to fail in the same way as GH did. Applied the same patch as in the parent diff.
I suspect the cause is an earlier update of node / bash / other dep? Couldn't really find anything clearly pointing at the problem
Reviewed By: aigoncharov
Differential Revision: D35212673
fbshipit-source-id: c09956137a4b10537718ffa60223cc4e557f41f7
2022-03-29 09:54:15 -07:00
Andrey Goncharov
886d04a81b
Upgrade electron-builder
...
Summary:
Fix build on new MacOS
https://github.com/electron-userland/electron-builder/issues/6726
Reviewed By: passy
Differential Revision: D35211540
fbshipit-source-id: f59828f008482c503c260ca5f9bc625ca694e1be
2022-03-29 04:34:49 -07:00
Michel Weststrate
767caad593
Fix tsc:build on linux machines ( #3588 )
...
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/3588
Fix failing CI builds on Linux
See screenshot, sometimes the script being executed by ts-node, ends up as argument to the script itself. This seems to happen in CI, and *sometimes* happens for me locally. Since compute-package-checksum doesn't read any varargs anyway, just disabled the `strict` flag to ignore the additional arguments. This fixes our GH builds failing on linux.
Reviewed By: aigoncharov
Differential Revision: D35210590
fbshipit-source-id: 91057fd657a888020ea333495d1f16b7ff9cca50
2022-03-29 02:22:36 -07:00
Pascal Hartig
314855f5e1
Respect --no-open option during server startup
...
Summary:
This was previously ignored and can get a little annoying while testing.
Changelog: Respect --no-open during server startup
Reviewed By: timur-valiev
Differential Revision: D34932895
fbshipit-source-id: d2bf9d6fb57a76834b86ab013baf01628d2550fc
2022-03-16 16:39:23 -07:00
Andrey Goncharov
6ec3771824
Upgrade Metro
...
Reviewed By: passy
Differential Revision: D34789498
fbshipit-source-id: 9e984b308ac6d0dbc917ddaa20812f76d2a69d77
2022-03-10 10:31:24 -08:00
dependabot[bot]
4bcc3d0c46
Bump app-builder-lib from 22.14.12 to 23.0.2 in /desktop ( #3505 )
...
Summary:
allow-large-files
Bumps [app-builder-lib](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib ) from 22.14.12 to 23.0.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/releases ">app-builder-lib's releases</a>.</em></p>
<blockquote>
<h2>v23.0.2</h2>
<h2>What's Changed</h2>
<ul>
<li>fix(app-builder-lib): export missing TS types by <a href="https://github.com/indutny-signal "><code>@indutny-signal</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6692 ">electron-userland/electron-builder#6692</a></li>
<li>fix(signing): Include swiftshader in signing directories for windows by <a href="https://github.com/karliatto "><code>@karliatto</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6682 ">electron-userland/electron-builder#6682</a></li>
<li>fix: Upgrading app-builder-bin in an attempt to resolve <a href="https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6678 ">#6678</a> by <a href="https://github.com/mmaietta "><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6684 ">electron-userland/electron-builder#6684</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/karliatto "><code>@karliatto</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6682 ">electron-userland/electron-builder#6682</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.0.1...v23.0.2 ">https://github.com/electron-userland/electron-builder/compare/v23.0.1...v23.0.2 </a></p>
<h2>v23.0.1</h2>
<h2>What's Changed</h2>
<ul>
<li>fix: signing of user-defined binaries by <a href="https://github.com/mifi "><code>@mifi</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6660 ">electron-userland/electron-builder#6660</a></li>
<li>chore(docs): Update winOptions.ts comment to be more explicit by <a href="https://github.com/UppaJung "><code>@UppaJung</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6670 ">electron-userland/electron-builder#6670</a></li>
<li>fix(dmg-builder): the "import" unbound issue by <a href="https://github.com/pan93412 "><code>@pan93412</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6672 ">electron-userland/electron-builder#6672</a></li>
<li>chore(deploy): Release by <a href="https://github.com/github-actions "><code>@github-actions</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6667 ">electron-userland/electron-builder#6667</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/UppaJung "><code>@UppaJung</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6670 ">electron-userland/electron-builder#6670</a></li>
<li><a href="https://github.com/pan93412 "><code>@pan93412</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6672 ">electron-userland/electron-builder#6672</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.0.0...v23.0.1 ">https://github.com/electron-userland/electron-builder/compare/v23.0.0...v23.0.1 </a></p>
<h2>v23.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>chore(app-builder-lib): update electron-osx-sign from 0.5.0 to 0.6.0 by <a href="https://github.com/baparham "><code>@baparham</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6598 ">electron-userland/electron-builder#6598</a></li>
<li>chore(deploy): Enable docker deployments by <a href="https://github.com/mmaietta "><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6560 ">electron-userland/electron-builder#6560</a></li>
<li>chore(deps): update amannn/action-semantic-pull-request action to v3.7.0 by <a href="https://github.com/renovate "><code>@renovate</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6646 ">electron-userland/electron-builder#6646</a></li>
<li>chore(deps): update amannn/action-semantic-pull-request action to v4 by <a href="https://github.com/renovate "><code>@renovate</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6647 ">electron-userland/electron-builder#6647</a></li>
<li>chore(deps): update tj-actions/changed-files action to v15 by <a href="https://github.com/renovate "><code>@renovate</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6648 ">electron-userland/electron-builder#6648</a></li>
<li>chore(deps): update typescript-eslint monorepo to v4.33.0 by <a href="https://github.com/mmaietta "><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6582 ">electron-userland/electron-builder#6582</a></li>
<li>chore(docs): Update configuration.md - Improve productName description by <a href="https://github.com/kiruh "><code>@kiruh</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6585 ">electron-userland/electron-builder#6585</a></li>
<li>chore(docs): Updating docs to include instructions on pnpm usage by <a href="https://github.com/mmaietta "><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6658 ">electron-userland/electron-builder#6658</a></li>
<li>chore: Exit prerelease mode by <a href="https://github.com/mmaietta "><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6653 ">electron-userland/electron-builder#6653</a></li>
<li>chore: Migrate TravisCI and CircleCI to GH Actions by <a href="https://github.com/mmaietta "><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6541 ">electron-userland/electron-builder#6541</a></li>
<li>chore: Only publish electron-builder & electron-updater tags by <a href="https://github.com/mmaietta "><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6595 ">electron-userland/electron-builder#6595</a></li>
<li>chore: readme update by <a href="https://github.com/mmaietta "><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6627 ">electron-userland/electron-builder#6627</a></li>
<li>chore: Removing Bintray support since it was sunset. Ref: <a href="https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/ ">https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/ </a> <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6556 ">electron-userland/electron-builder#6556</a></li>
<li>docs: add vite electron builder boilerplate by <a href="https://github.com/oceanlvr "><code>@oceanlvr</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6654 ">electron-userland/electron-builder#6654</a></li>
<li>feat(mac): Force authentication for local mac squirrel update server <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6556 ">electron-userland/electron-builder#6556</a></li>
<li>feat(updater): Add Channel Support for Github with PreRelease by <a href="https://github.com/KenCorma "><code>@KenCorma</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6505 ">electron-userland/electron-builder#6505</a></li>
<li>feat: use <code>mergeASARs</code> API by <code>@electron/universal</code> by <a href="https://github.com/indutny-signal "><code>@indutny-signal</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6578 ">electron-userland/electron-builder#6578</a></li>
<li>fix(dmg-builder): Support python 3 by <a href="https://github.com/mmaietta "><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6617 ">electron-userland/electron-builder#6617</a></li>
<li>fix(docs): Fixing formatting of code groups and previews by <a href="https://github.com/mmaietta "><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6601 ">electron-userland/electron-builder#6601</a></li>
<li>fix(nsis): Adding --INPUTCHARSET to makensis <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6556 ">electron-userland/electron-builder#6556</a></li>
<li>fix(nsis): Fail-fast for windows signature verification failures. Adding <code>-LiteralPath</code> to update file path to disregard injected wildcards <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6556 ">electron-userland/electron-builder#6556</a></li>
<li>fix(nsis): Force strip path separators for backslashes on Windows during update process <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6556 ">electron-userland/electron-builder#6556</a></li>
<li>fix(NSIS): prevent partial overwrites by <a href="https://github.com/indutny-signal "><code>@indutny-signal</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6547 ">electron-userland/electron-builder#6547</a></li>
<li>fix(nsis): use atomic rmdir on update by <a href="https://github.com/indutny-signal "><code>@indutny-signal</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6551 ">electron-userland/electron-builder#6551</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/CHANGELOG.md ">app-builder-lib's changelog</a>.</em></p>
<blockquote>
<h2>23.0.2</h2>
<h3>Patch Changes</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6682 ">#6682</a> <a href="e6312cb54ehttps://github.com/karliatto "><code>@karliatto</code></a>! - fix(signing): Include swiftshader in signing directories for windows</li>
</ul>
<ul>
<li>
<p><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6692 ">#6692</a> <a href="93181a78f2https://github.com/indutny-signal "><code>@indutny-signal</code></a>! - fix(app-builder-lib): export missing TS types</p>
</li>
<li>
<p>Updated dependencies [<a href="5ffbe1e299https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6660 ">#6660</a> <a href="4c6d1546d4https://github.com/mifi "><code>@mifi</code></a>! - Fix error thrown due to duplicated signing of user-defined binaries on mac when resolving relative path</li>
</ul>
<h2>23.0.0</h2>
<h3>Major Changes</h3>
<ul>
<li>
<p><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6556 ">#6556</a> <a href="a138a86fb7https://github.com/mmaietta "><code>@mmaietta</code></a>! - Breaking changes
Removing Bintray support since it was sunset. Ref: <a href="https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/ ">https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/ </a>
Fail-fast for windows signature verification failures. Adding <code>-LiteralPath</code> to update file path to disregard injected wildcards
Force strip path separators for backslashes on Windows during update process
Force authentication for local mac squirrel update server</p>
<p>Fixes:
fix(nsis): Adding --INPUTCHARSET to makensis. (<a href="https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/4898 ">#4898</a> <a href="https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6232 ">#6232</a> <a href="https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6259 ">#6259</a>)</p>
<p>Adding additional details to error console logging</p>
</li>
</ul>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6556 ">#6556</a> <a href="a138a86fb7https://github.com/mmaietta "><code>@mmaietta</code></a>! - BREAKING CHANGE: remove MSI option <code>iconId</code></li>
</ul>
<h3>Minor Changes</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6578 ">#6578</a> <a href="81132a857bhttps://github.com/indutny-signal "><code>@indutny-signal</code></a>! - feat: use <code>mergeASARs</code> API by <code>@electron/universal</code></li>
</ul>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6556 ">#6556</a> <a href="a138a86fb7https://github.com/mmaietta "><code>@mmaietta</code></a>! - feat(msi): support assisted installer for MSI target</li>
</ul>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6556 ">#6556</a> <a href="a138a86fb7https://github.com/mmaietta "><code>@mmaietta</code></a>! - feat(msi): add fileAssociation support for MSI target</li>
</ul>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6556 ">#6556</a> <a href="a138a86fb7https://github.com/mmaietta "><code>@mmaietta</code></a>! - feat(mac): ElectronAsarIntegrity in electron@15</li>
</ul>
<ul>
<li>
<p><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6556 ">#6556</a> <a href="a138a86fb7https://github.com/mmaietta "><code>@mmaietta</code></a>! - Default to LZO compression for snap packages.
This greatly improves cold startup performance (<a href="https://snapcraft.io/blog/why-lzo-was-chosen-as-the-new-compression-method ">https://snapcraft.io/blog/why-lzo-was-chosen-as-the-new-compression-method </a>).
LZO has already been adopted by most desktop-oriented snaps outside of the Electron realm.</p>
<p>For the rare case where developers prefer a smaller file size (XZ) to vastly improved decompression performance (LZO), provided an option to override the default compression method.</p>
</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="e7f0d3bbd6https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6695 ">#6695</a>)</li>
<li><a href="5ffbe1e299https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6678 ">#6678</a> (<a href="https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6684 ">#6684</a>)</li>
<li><a href="e6312cb54ehttps://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6682 ">#6682</a>)</li>
<li><a href="93181a78f2https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6692 ">#6692</a>)</li>
<li><a href="6fcd47767ahttps://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6680 ">#6680</a>)</li>
<li><a href="bf0382e8a1https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6667 ">#6667</a>)</li>
<li><a href="e1a439be9d4c6d1546d48db6c72273https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6657 ">#6657</a>)</li>
<li><a href="19ab1f5e3bhttps://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6658 ">#6658</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/electron-userland/electron-builder/commits/v23.0.2/packages/app-builder-lib ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3505
Reviewed By: lblasa
Differential Revision: D34718809
Pulled By: passy
fbshipit-source-id: fda35629589644e056640750fc43dc70cb11391c
2022-03-09 03:29:11 -08:00
Anton Nikolaev
37ff34390a
Enable Marketplace for Flipper ( #3491 )
...
Summary:
This is PR on top of: https://github.com/facebook/flipper/pull/3473
It adds an option to Settings to allow distribution of marketplace plugins.
Also includes a simple fetch function to retrieve data from external API/server.
## Changelog
Allow marketplace plugins
Pull Request resolved: https://github.com/facebook/flipper/pull/3491
Test Plan:
1. Enable marketplace
2. Provide custom marketplace server (it will serve the list of internal plugins with downloadURL)
3. Test if can see Available plugins and can download/remove the plugin
4. If new update for the plugin, it should also allow auto update
Reviewed By: antonk52
Differential Revision: D34586339
Pulled By: nikoant
fbshipit-source-id: c887982aa0f0f9abd3b5360f22e8692a2445d345
2022-03-07 02:49:49 -08:00
Pascal Hartig
7c1251075f
Dep bump for /desktop
...
Summary:
Combining a bunch of dependabot PRs.
N.B. I had to manually clean up the `yarn.lock` a few times because some dependencies resolved to multiple version numbers, catching tsc off-guard.
allow-large-files
Reviewed By: nikoant
Differential Revision: D34579180
fbshipit-source-id: a4848e1010ff240d9b0e721d3878585e7b4bd078
2022-03-03 04:11:52 -08:00
