Michel Weststrate
075c9e1dda
Disable NUX animations
...
Summary:
I noticed that on my Mac M1 Flipper feels really sluggish in term of interactions compared to my Mac Pro. Started profiling and notices we have continously 60 reflows/sec and a very continous stream of DOM nodes allocations. This in turn is caused by our NUX elements, whose opacity anymation causes a reflow, which causes our interactive container (used for resizable sidebars etc) do to some calculations.
This is quite noticeble in how fluent clicks etc are handled, as long as there are NUX-es open. Not sure why this doesn't feel as bad on Intel machines, but alas the effect is very clearly visible in the performance monitor. Or when dismissing all NUX-es, which drops the performance issue even in current builds.
Disabling the opacity anymation and giving it a fixed value, fixes the issue as well, which is done in this diff.
Changelog: Minor improvements on M1 machines
Reviewed By: passy
Differential Revision: D38859406
fbshipit-source-id: 3b97c6c8444290e2a0a8b17b175de9e44159e258
2022-08-19 04:28:43 -07:00
Flipper Bot
882c06fb65
Flipper Release: v0.160.0
...
Summary: Releasing version 0.160.0
Reviewed By: mweststrate
Differential Revision: D38829728
fbshipit-source-id: b0c28f7099ecde8f1afba298af713891d5f37c04
2022-08-18 09:21:56 -07:00
dependabot[bot]
ef66d452ee
Bump app-builder-lib from 23.0.8 to 23.4.0 in /desktop ( #4008 )
...
Summary:
Bumps [app-builder-lib](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib ) from 23.0.8 to 23.4.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/releases ">app-builder-lib's releases</a>.</em></p>
<blockquote>
<h2>v23.4.0</h2>
<h2>What's Changed</h2>
<ul>
<li>feat: Adding timeout to publisher config for api requests and uploads by <a href="https://github.com/mmaietta "><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7028 ">electron-userland/electron-builder#7028</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.3.3...v23.4.0 ">https://github.com/electron-userland/electron-builder/compare/v23.3.3...v23.4.0 </a></p>
<h2>v23.3.3</h2>
<h2>What's Changed</h2>
<ul>
<li>docs: highlight, thanks by <a href="https://github.com/gaoyia "><code>@gaoyia</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7010 ">electron-userland/electron-builder#7010</a></li>
<li>fix: Duplicate values during deep assign of extra files by <a href="https://github.com/mmaietta "><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7019 ">electron-userland/electron-builder#7019</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/gaoyia "><code>@gaoyia</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7010 ">electron-userland/electron-builder#7010</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.3.2...v23.3.3 ">https://github.com/electron-userland/electron-builder/compare/v23.3.2...v23.3.3 </a></p>
<h2>v23.3.2</h2>
<h2>What's Changed</h2>
<ul>
<li>fix: Wrap the nsProcess include in a !ifndef by <a href="https://github.com/titus-anromedonn "><code>@titus-anromedonn</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6996 ">electron-userland/electron-builder#6996</a></li>
<li>fix: installDir definition <a href="https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6907 ">#6907</a> by <a href="https://github.com/panther7 "><code>@panther7</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6995 ">electron-userland/electron-builder#6995</a></li>
<li>fix(electron-updater): fix backward compatibility for GitHub provider without channels by <a href="https://github.com/matejkriz "><code>@matejkriz</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6998 ">electron-userland/electron-builder#6998</a></li>
<li>chore: Adding allowPrerelease github integration tests by <a href="https://github.com/mmaietta "><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7003 ">electron-userland/electron-builder#7003</a></li>
<li>docs: Add customWelcomePage example to Custom NSIS script by <a href="https://github.com/hueyyeng "><code>@hueyyeng</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7001 ">electron-userland/electron-builder#7001</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/titus-anromedonn "><code>@titus-anromedonn</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6996 ">electron-userland/electron-builder#6996</a></li>
<li><a href="https://github.com/matejkriz "><code>@matejkriz</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6998 ">electron-userland/electron-builder#6998</a></li>
<li><a href="https://github.com/hueyyeng "><code>@hueyyeng</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7001 ">electron-userland/electron-builder#7001</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.3.1...v23.3.2 ">https://github.com/electron-userland/electron-builder/compare/v23.3.1...v23.3.2 </a></p>
<h2>v23.3.1</h2>
<h2>What's Changed</h2>
<ul>
<li>feat: Add installDir property for NsisUpdater by <a href="https://github.com/panther7 "><code>@panther7</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6907 ">electron-userland/electron-builder#6907</a></li>
<li>chore(deps): update dependency <code>@types/archiver</code> to v5.3.1 by <a href="https://github.com/renovate "><code>@renovate</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6979 ">electron-userland/electron-builder#6979</a></li>
<li>chore(deps): update dependency <code>@types/node</code> to v16.11.43 by <a href="https://github.com/renovate "><code>@renovate</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6980 ">electron-userland/electron-builder#6980</a></li>
<li>fix: parallel release creation with Keygen publisher by <a href="https://github.com/ezekg "><code>@ezekg</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6989 ">electron-userland/electron-builder#6989</a></li>
<li>fix: add product scope to Keygen publisher by <a href="https://github.com/ezekg "><code>@ezekg</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6990 ">electron-userland/electron-builder#6990</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.3.0...v23.3.1 ">https://github.com/electron-userland/electron-builder/compare/v23.3.0...v23.3.1 </a></p>
<h2>v23.3.0</h2>
<h2>What's Changed</h2>
<ul>
<li>feat: upgrade Keygen integration to v1.1 by <a href="https://github.com/ezekg "><code>@ezekg</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6941 ">electron-userland/electron-builder#6941</a></li>
<li>fix(mac): allow Mac Developer certs for non Mac App Store builds by <a href="https://github.com/regentcid434 "><code>@regentcid434</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6956 ">electron-userland/electron-builder#6956</a></li>
<li>fix: prevent infinite looping of overwriteArtifact by <a href="https://github.com/CCInc "><code>@CCInc</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6958 ">electron-userland/electron-builder#6958</a></li>
<li>fix: add product scope to keygen provider by <a href="https://github.com/ezekg "><code>@ezekg</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6975 ">electron-userland/electron-builder#6975</a></li>
<li>fix(mas): Allow signing with "3rd Party Mac Developer Application" by <a href="https://github.com/csett86 "><code>@csett86</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6970 ">electron-userland/electron-builder#6970</a></li>
<li>fix(nsis): fix typo in German installer message by <a href="https://github.com/tkleinke "><code>@tkleinke</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6960 ">electron-userland/electron-builder#6960</a></li>
<li>fix: nsis-web target set APP_PACKAGE_URL_IS_INCOMPLETE by <a href="https://github.com/geovie "><code>@geovie</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6964 ">electron-userland/electron-builder#6964</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/CHANGELOG.md ">app-builder-lib's changelog</a>.</em></p>
<blockquote>
<h2>23.4.0</h2>
<h3>Minor Changes</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7028 ">#7028</a> <a href="e7179b57bdhttps://github.com/mmaietta "><code>@mmaietta</code></a>! - feat: Adding timeout to publisher config for api requests and uploads</li>
</ul>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies [<a href="e7179b57bd98d3a6361dhttps://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6996 ">#6996</a> <a href="5301525393https://github.com/titus-anromedonn "><code>@titus-anromedonn</code></a>! - fix: Wrap the nsProcess.nsh include in a !ifndef in case it has already been imported in a custom install script</li>
</ul>
<h2>23.3.1</h2>
<h3>Patch Changes</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6989 ">#6989</a> <a href="7ad5101b4ahttps://github.com/ezekg "><code>@ezekg</code></a>! - Fix issue where, upon publishing a new release, electron-builder would attempt to create the same release for each artifact in parallel, resulting in conflict errors.</li>
</ul>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6990 ">#6990</a> <a href="c3407a202dhttps://github.com/ezekg "><code>@ezekg</code></a>! - Fix release conflicts for Keygen publisher when releases share the same version across open/licensed products.</li>
</ul>
<h2>23.3.0</h2>
<h3>Minor Changes</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6941 ">#6941</a> <a href="14503ceb99https://github.com/ezekg "><code>@ezekg</code></a>! - Upgrade Keygen publisher/updater integration to API version v1.1.</li>
</ul>
<h3>Patch Changes</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6964 ">#6964</a> <a href="b0e1b6f8afhttps://github.com/geovie "><code>@geovie</code></a>! - fix: nsis-web target set APP_PACKAGE_URL_IS_INCOMPLETE</li>
</ul>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6970 ">#6970</a> <a href="28c07b4392https://github.com/csett86 "><code>@csett86</code></a>! - fix(mas): Allow signing with "3rd Party Mac Developer Application"</li>
</ul>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6960 ">#6960</a> <a href="6e90c84591https://github.com/tkleinke "><code>@tkleinke</code></a>! - fix(nsis): fix typo in German installer message</li>
</ul>
<ul>
<li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6961 ">#6961</a> <a href="4c867aa017https://github.com/aripollak "><code>@aripollak</code></a>! - fix: Optionally allow removing DISABLE_WAYLAND flag for snaps</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="217f4af53ahttps://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/7030 ">#7030</a>)</li>
<li><a href="e7179b57bdhttps://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/7028 ">#7028</a>)</li>
<li><a href="94982619c1https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/7020 ">#7020</a>)</li>
<li><a href="3e9cd2c88ehttps://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/7002 ">#7002</a>)</li>
<li><a href="5301525393https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6996 ">#6996</a>)</li>
<li><a href="d99da8286bhttps://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6986 ">#6986</a>)</li>
<li><a href="c3407a202dhttps://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6990 ">#6990</a>)</li>
<li><a href="7ad5101b4ahttps://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6989 ">#6989</a>)</li>
<li><a href="e7912d92b2https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6950 ">#6950</a>)</li>
<li><a href="f70abf1628https://github.com/electron-userland/electron-builder/commits/v23.4.0/packages/app-builder-lib ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4008
Reviewed By: lawrencelomax
Differential Revision: D38781621
Pulled By: passy
fbshipit-source-id: 6fe8bcbd584cab6fc60abd5fe34b7340ea27ab12
2022-08-18 07:46:18 -07:00
Michel Weststrate
80d3659e3f
Don't kill WS connection if individual message handling fails
...
Summary:
GraphQL plugin sends garbage JSON at the moment (see T129428800). Still figuring out if that is caused by the plugin on client side, or that the Flipper SDK should escape that properly.
In the mean time, closing the Flipper connection on not being able to handle an individual message seems a cause of unnecessary connection ping-pong and instability. Changing the strategy to instead merely log and drop the message.
Changelog: Stop applications from disconnecting if a single plugin message cannot be processed.
Reviewed By: LukeDefeo
Differential Revision: D38825940
fbshipit-source-id: 4d45c8eea457375ec677238ad09b5e02bc2eb5bf
2022-08-18 06:58:59 -07:00
Jacy
c863af6942
Fix share preference plugin layout flicker ( #3903 )
...
Summary:
The share preference plugin page flashes when INSPECTOR's width is too large.
## Changelog
Add 'overflowX: 'hidden'' to FlexRow.
Pull Request resolved: https://github.com/facebook/flipper/pull/3903
Test Plan: Pass the test on MAC.
Reviewed By: passy
Differential Revision: D38784840
Pulled By: mweststrate
fbshipit-source-id: 4ca3fc17ccc66767e75ce0f9ab7ad71741dbf15e
2022-08-18 06:35:20 -07:00
Matthew Rheaume
efdc7e58c4
Fixed reload & zoom in Flipper Desktop application. ( #3840 )
...
Summary:
After the upgrade to Electron in `92cdb81`, the reload functionality no
longer works. I believe this is due to the main menu creation being
moved to the main process where the `window` global variable is undefined
(whereas previously it was on the render process, where `window` would
be defined). Rather than rely on the `window` global, when a reload is
requested just reload the given `focusedWindow`.
Similarly, zooming was also broken, so fix that by going through `focusedWindow` rather than `webFrame` (since `webFrame` only exists in the render process).
Fixes https://github.com/facebook/flipper/issues/3839 , https://github.com/facebook/flipper/issues/3820
## Changelog
changelog: Fixed reload & zoom in Flipper Desktop application.
Pull Request resolved: https://github.com/facebook/flipper/pull/3840
Test Plan: Built the application locally, verified that reload worked as expected (and would reload the application), verified that zooming (in, out, actual size) worked as expected.
Reviewed By: passy
Differential Revision: D38784319
Pulled By: mweststrate
fbshipit-source-id: c219063a8aaf42425678c2c8824f6fcde1cadd52
2022-08-18 06:11:38 -07:00
dependabot[bot]
e95b222864
Bump react-is from 17.0.2 to 18.2.0 in /desktop ( #3904 )
...
Summary:
Bumps [react-is](https://github.com/facebook/react/tree/HEAD/packages/react-is ) from 17.0.2 to 18.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/react/releases ">react-is's releases</a>.</em></p>
<blockquote>
<h2>18.2.0 (June 14, 2022)</h2>
<h3>React DOM</h3>
<ul>
<li>Provide a component stack as a second argument to <code>onRecoverableError</code>. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24591 ">#24591</a>)</li>
<li>Fix hydrating into <code>document</code> causing a blank page on mismatch. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24523 ">#24523</a>)</li>
<li>Fix false positive hydration errors with Suspense. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24480 ">#24480</a> and <a href="https://github.com/acdlite "><code>@acdlite</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24532 ">#24532</a>)</li>
<li>Fix ignored <code>setState</code> in Safari when adding an iframe. (<a href="https://github.com/gaearon "><code>@gaearon</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24459 ">#24459</a>)</li>
</ul>
<h3>React DOM Server</h3>
<ul>
<li>Pass information about server errors to the client. (<a href="https://github.com/salazarm "><code>@salazarm</code></a> and <a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24551 ">#24551</a> and <a href="https://github-redirect.dependabot.com/facebook/react/pull/24591 ">#24591</a>)</li>
<li>Allow to provide a reason when aborting the HTML stream. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24680 ">#24680</a>)</li>
<li>Eliminate extraneous text separators in the HTML where possible. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24630 ">#24630</a>)</li>
<li>Disallow complex children inside <code><title></code> elements to match the browser constraints. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24679 ">#24679</a>)</li>
<li>Fix buffering in some worker environments by explicitly setting <code>highWaterMark</code> to <code>0</code>. (<a href="https://github.com/jplhomer "><code>@jplhomer</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24641 ">#24641</a>)</li>
</ul>
<h3>Server Components (Experimental)</h3>
<ul>
<li>Add support for <code>useId()</code> inside Server Components. (<a href="https://github.com/gnoff "><code>@gnoff</code></a>) in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24172 ">#24172</a></li>
</ul>
<h2>18.1.0 (April 26, 2022)</h2>
<h3>React DOM</h3>
<ul>
<li>Fix the false positive warning about <code>react-dom/client</code> when using UMD bundle. (<a href="https://github.com/alireza-molaee "><code>@alireza-molaee</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24274 ">#24274</a>)</li>
<li>Fix <code>suppressHydrationWarning</code> to work in production too. (<a href="https://github.com/gaearon "><code>@gaearon</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24271 ">#24271</a>)</li>
<li>Fix <code>componentWillUnmount</code> firing twice inside of Suspense. (<a href="https://github.com/acdlite "><code>@acdlite</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24308 ">#24308</a>)</li>
<li>Fix some transition updates being ignored. (<a href="https://github.com/acdlite "><code>@acdlite</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24353 ">#24353</a>)</li>
<li>Fix <code>useDeferredValue</code> causing an infinite loop when passed an unmemoized value. (<a href="https://github.com/acdlite "><code>@acdlite</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24247 ">#24247</a>)</li>
<li>Fix throttling of revealing Suspense fallbacks. (<a href="https://github.com/sunderls "><code>@sunderls</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24253 ">#24253</a>)</li>
<li>Fix an inconsistency in whether the props object is the same between renders. (<a href="https://github.com/Andarist "><code>@Andarist</code></a> and <a href="https://github.com/acdlite "><code>@acdlite</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24421 ">#24421</a>)</li>
<li>Fix a missing warning about a <code>setState</code> loop in <code>useEffect</code>. (<a href="https://github.com/gaearon "><code>@gaearon</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24298 ">#24298</a>)</li>
<li>Fix a spurious hydration error. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24404 ">#24404</a>)</li>
<li>Warn when calling <code>setState</code> in <code>useInsertionEffect</code>. (<a href="https://github.com/gaearon "><code>@gaearon</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24295 ">#24295</a>)</li>
<li>Ensure the reason for hydration errors is always displayed. (<a href="https://github.com/gaearon "><code>@gaearon</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24276 ">#24276</a>)</li>
</ul>
<h3>React DOM Server</h3>
<ul>
<li>Fix escaping for the <code>bootstrapScriptContent</code> contents. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24385 ">#24385</a>)</li>
<li>Significantly improve performance of <code>renderToPipeableStream</code>. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24291 ">#24291</a>)</li>
</ul>
<h3>ESLint Plugin: React Hooks</h3>
<ul>
<li>Fix false positive errors with a large number of branches. (<a href="https://github.com/scyron6 "><code>@scyron6</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24287 ">#24287</a>)</li>
<li>Don't consider a known dependency stable when the variable is reassigned. (<a href="https://github.com/afzalsayed96 "><code>@afzalsayed96</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24343 ">#24343</a>)</li>
</ul>
<h3>Use Subscription</h3>
<ul>
<li>Replace the implementation with the <code>use-sync-external-store</code> shim. (<a href="https://github.com/gaearon "><code>@gaearon</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24289 ">#24289</a>)</li>
</ul>
<h2>18.0.0 (March 29, 2022)</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/facebook/react/blob/main/CHANGELOG.md ">react-is's changelog</a>.</em></p>
<blockquote>
<h2>18.2.0 (June 14, 2022)</h2>
<h3>React DOM</h3>
<ul>
<li>Provide a component stack as a second argument to <code>onRecoverableError</code>. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24591 ">#24591</a>)</li>
<li>Fix hydrating into <code>document</code> causing a blank page on mismatch. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24523 ">#24523</a>)</li>
<li>Fix false positive hydration errors with Suspense. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24480 ">#24480</a> and <a href="https://github.com/acdlite "><code>@acdlite</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24532 ">#24532</a>)</li>
<li>Fix ignored <code>setState</code> in Safari when adding an iframe. (<a href="https://github.com/gaearon "><code>@gaearon</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24459 ">#24459</a>)</li>
</ul>
<h3>React DOM Server</h3>
<ul>
<li>Pass information about server errors to the client. (<a href="https://github.com/salazarm "><code>@salazarm</code></a> and <a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24551 ">#24551</a> and <a href="https://github-redirect.dependabot.com/facebook/react/pull/24591 ">#24591</a>)</li>
<li>Allow to provide a reason when aborting the HTML stream. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24680 ">#24680</a>)</li>
<li>Eliminate extraneous text separators in the HTML where possible. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24630 ">#24630</a>)</li>
<li>Disallow complex children inside <code><title></code> elements to match the browser constraints. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24679 ">#24679</a>)</li>
<li>Fix buffering in some worker environments by explicitly setting <code>highWaterMark</code> to <code>0</code>. (<a href="https://github.com/jplhomer "><code>@jplhomer</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24641 ">#24641</a>)</li>
</ul>
<h3>Server Components (Experimental)</h3>
<ul>
<li>Add support for <code>useId()</code> inside Server Components. (<a href="https://github.com/gnoff "><code>@gnoff</code></a>) in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24172 ">#24172</a></li>
</ul>
<h2>18.1.0 (April 26, 2022)</h2>
<h3>React DOM</h3>
<ul>
<li>Fix the false positive warning about <code>react-dom/client</code> when using UMD bundle. (<a href="https://github.com/alireza-molaee "><code>@alireza-molaee</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24274 ">#24274</a>)</li>
<li>Fix <code>suppressHydrationWarning</code> to work in production too. (<a href="https://github.com/gaearon "><code>@gaearon</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24271 ">#24271</a>)</li>
<li>Fix <code>componentWillUnmount</code> firing twice inside of Suspense. (<a href="https://github.com/acdlite "><code>@acdlite</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24308 ">#24308</a>)</li>
<li>Fix some transition updates being ignored. (<a href="https://github.com/acdlite "><code>@acdlite</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24353 ">#24353</a>)</li>
<li>Fix <code>useDeferredValue</code> causing an infinite loop when passed an unmemoized value. (<a href="https://github.com/acdlite "><code>@acdlite</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24247 ">#24247</a>)</li>
<li>Fix throttling of revealing Suspense fallbacks. (<a href="https://github.com/sunderls "><code>@sunderls</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24253 ">#24253</a>)</li>
<li>Fix an inconsistency in whether the props object is the same between renders. (<a href="https://github.com/Andarist "><code>@Andarist</code></a> and <a href="https://github.com/acdlite "><code>@acdlite</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24421 ">#24421</a>)</li>
<li>Fix a missing warning about a <code>setState</code> loop in <code>useEffect</code>. (<a href="https://github.com/gaearon "><code>@gaearon</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24298 ">#24298</a>)</li>
<li>Fix a spurious hydration error. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24404 ">#24404</a>)</li>
<li>Warn when calling <code>setState</code> in <code>useInsertionEffect</code>. (<a href="https://github.com/gaearon "><code>@gaearon</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24295 ">#24295</a>)</li>
<li>Ensure the reason for hydration errors is always displayed. (<a href="https://github.com/gaearon "><code>@gaearon</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24276 ">#24276</a>)</li>
</ul>
<h3>React DOM Server</h3>
<ul>
<li>Fix escaping for the <code>bootstrapScriptContent</code> contents. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24385 ">#24385</a>)</li>
<li>Significantly improve performance of <code>renderToPipeableStream</code>. (<a href="https://github.com/gnoff "><code>@gnoff</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24291 ">#24291</a>)</li>
</ul>
<h3>ESLint Plugin: React Hooks</h3>
<ul>
<li>Fix false positive errors with a large number of branches. (<a href="https://github.com/scyron6 "><code>@scyron6</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24287 ">#24287</a>)</li>
<li>Don't consider a known dependency stable when the variable is reassigned. (<a href="https://github.com/afzalsayed96 "><code>@afzalsayed96</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24343 ">#24343</a>)</li>
</ul>
<h3>Use Subscription</h3>
<ul>
<li>Replace the implementation with the <code>use-sync-external-store</code> shim. (<a href="https://github.com/gaearon "><code>@gaearon</code></a> in <a href="https://github-redirect.dependabot.com/facebook/react/pull/24289 ">#24289</a>)</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="72b7462fe7https://github.com/facebook/react/tree/HEAD/packages/react-is/issues/24447 ">#24447</a>)</li>
<li><a href="34aa5cfe0dd5f1b067c8https://github.com/facebook/react/tree/HEAD/packages/react-is/issues/23244 ">#23244</a>)</li>
<li><a href="0dedfcc681https://github.com/facebook/react/tree/HEAD/packages/react-is/issues/23257 ">#23257</a>)</li>
<li><a href="83564712b6https://github.com/facebook/react/tree/HEAD/packages/react-is/issues/22765 ">#22765</a>)</li>
<li><a href="2bf4805e4bhttps://github.com/facebook/react/tree/HEAD/packages/react-is/issues/21488 ">#21488</a>)</li>
<li><a href="3ba5c87377https://github.com/facebook/react/tree/HEAD/packages/react-is/issues/21107 ">#21107</a>)</li>
<li><a href="90bde6505ehttps://github.com/facebook/react/tree/HEAD/packages/react-is/issues/20874 ">#20874</a>)</li>
<li><a href="a2a025537dhttps://github.com/facebook/react/tree/HEAD/packages/react-is/issues/20362 ">#20362</a>)</li>
<li><a href="eaaf4cbce7https://github.com/facebook/react/commits/v18.2.0/packages/react-is ">compare view</a></li>
</ul>
</details>
<details>
<summary>Maintainer changes</summary>
<p>This version was pushed to npm by <a href="https://www.npmjs.com/~gnoff ">gnoff</a>, a new releaser for react-is since your current version.</p>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3904
Reviewed By: passy
Differential Revision: D38781408
Pulled By: mweststrate
fbshipit-source-id: 68bb86127bf12bda946a388edc421a704f5b7f32
2022-08-17 11:09:34 -07:00
Andrey Goncharov
5e818edc2f
Expose text report for unit test code coverage
...
Summary: At the request of msys
Reviewed By: lblasa
Differential Revision: D38740940
fbshipit-source-id: 25722144037ce404ef7572e9553037e7344c6955
2022-08-17 04:37:52 -07:00
Flipper Bot
a2df0e36e3
Flipper Release: v0.159.0
...
Summary: Releasing version 0.159.0
Reviewed By: mweststrate
Differential Revision: D38779691
fbshipit-source-id: 096542c590ad80dede43b7d72300ad99667b96d7
2022-08-17 03:32:56 -07:00
Feiyu Wong
02c21f5cb0
Changed documentation with DataSource to be up to date
...
Summary: Since there were large refactoring's done to `DataSource` during the milestone for side-by-side panels, wanted to update some of the documentation as well so that the information is accurate and up to date.
Reviewed By: mweststrate
Differential Revision: D38541404
fbshipit-source-id: a6ba472f881fb8cbfa90ff5ac295a0b87c595080
2022-08-12 08:47:06 -07:00
Flipper Bot
c96c5ca1a3
Flipper Release: v0.158.0
...
Summary: Releasing version 0.158.0
Reviewed By: lblasa
Differential Revision: D38571158
fbshipit-source-id: 942b513f45163fe923483f17c87945ff289020c9
2022-08-10 05:09:36 -07:00
Lorenzo Blasa
a357e280c2
Fix highlight selection background colour
...
Summary: There was a regression in which the selection background color made the selection hard to read in dark mode.
Reviewed By: mweststrate
Differential Revision: D38572894
fbshipit-source-id: c46d384175132112e1223434534a379318bfa2ea
2022-08-10 04:13:11 -07:00
Flipper Bot
714ee44929
Flipper Release: v0.157.0
...
Summary: Releasing version 0.157.0
Reviewed By: passy
Differential Revision: D38382530
fbshipit-source-id: 687ff275c280587d4d40c9c2d8622a1d0ba1adaa
2022-08-03 05:02:01 -07:00
Andrey Goncharov
f132d95bee
Fix crash reporter
...
Summary: Changelog: Make crash reporter pick up and parse .ips crash reports
Reviewed By: LukeDefeo
Differential Revision: D38355089
fbshipit-source-id: dc1b46257ea12c2e67d8a9baab7f35a905be2204
2022-08-02 10:08:35 -07:00
Feiyu Wong
ab49b17c7b
Save logs that are shown in logs plugin if persisted logging is enabled
...
Summary:
This is the second part of the feature which enables data/log persistence by adding a global setting which controls whether the data is wiped when the same device is disconnected and reconnected.
Building on the previous diff, this diff uses the setting from the Redux Store to determine whether to "wipe" the data or not.
Changelog: Added option in Flipper settings to persist device data upon reconnection instead of wiping everything.
Reviewed By: mweststrate
Differential Revision: D38076567
fbshipit-source-id: 83658ac09bc88921a56517e1a1f624d4a4bbc2c5
2022-07-28 13:56:34 -07:00
Feiyu Wong
3ffb25e672
Update UI for enabling persisted logs feature
...
Summary:
This is the first diff to implement the feature for the Flipper logs plugin to have an option to persist logs in the table between crashes, disconnections, etc.
Since this is not a local change, the UI option for persistence will be located in the settings for the Flipper UI(as seen in the test plan). The setting is associated with the Redux Store `Settings` and is stored globally to be used across all plugins. So the plan is making the persistence pertain to all plugins.
Reviewed By: mweststrate
Differential Revision: D37786988
fbshipit-source-id: 7ffc6077cbca559b3401b16770eda657a6c45620
2022-07-28 13:56:34 -07:00
Aaron Coplan
45f3222b87
Upsell for arc uiqr in Flipper plugin UI
...
Summary:
This diff updates the Flipper plugin for UIQR+DDR to upsell people to use `arc uiqr` on the "Upload and Get Link" tab. At the moment I'm not showing the upsell on the "Upload Screens to Diff" tab since this functionality isn't really supported through `arc uiqr` yet.
The upsell uses localstorage to maintain its open/close state so it will show up by default but will be permanently dismissed (unless localstorage is cleared somehow :) ).
NOTE: I hacked out this UI using some existing reusable UIQR Flipper components and some extra styling for the background, but definitely open to feedback on the UI!
Differential Revision: D38232117
fbshipit-source-id: e1745e32974bd9e750bbbaaa2f47bafdd0ac87eb
2022-07-28 10:56:39 -07:00
Lorenzo Blasa
4da7419b19
Dismiss set highlight calls for null elements
...
Summary: ^
Reviewed By: mweststrate
Differential Revision: D38238280
fbshipit-source-id: c48d8ff1c69b5c3d535ce050381ba91f1f405937
2022-07-28 08:00:10 -07:00
Feiyu Wong
a47528a726
Icon in search bar to show/hide search results
...
Summary:
1. Added icon to search bar to manually trigger the hide/show search context/results functionality, which was only triggerable by ctrl(now migrated to ctrl+t) before.
2. Added tool tips to increase visibility of keyboard shortcuts
Changelog: Added icon for showing search result context(only triggered by keyboard shortcut before). Added tool tips to search bar icons.
Reviewed By: mweststrate
Differential Revision: D38207087
fbshipit-source-id: a34c1322294ed8091ea3f90d2f1f206af981c9ca
2022-07-27 12:19:51 -07:00
Feiyu Wong
499275af8a
Add keyboard shortcut to support quick selecting recent searches
...
Summary:
Currently there's no way of quickly selecting recent searches other than manually opening the recent search history and then clicking one of the search terms. This diff seeks to add a new feature that would allow not only a keyboard short cut to open the recent search history drop down but also number the most recent 5 search terms so that the user could quickly select them with a number on their keyboard
Additionally, fixed bug found in terms of the search bar not showing the current search value correctly
`Changelog`: Introduced keyboard shortcut(ctrl + f) option to toggle the search history dropdown along with numbers attached to the options in order to quickly navigate to recent search terms. Have to first enable the option(search shortcut) in menu in order to use the feature. Also added a new button in the options menu that would trigger the search result toggle as triggered by the keyboard shortcut `ctrl` before(`ctrl` + `t` now)
WARNING: The current behavior of "ctrl" toggling back and forth to focus the selected item has been migrated to "ctrl + t" key combo
Reviewed By: mweststrate
Differential Revision: D37685738
fbshipit-source-id: a7ac4dd3dceb846a98258de2d884ebc279ee5995
2022-07-27 11:37:59 -07:00
Flipper Bot
5607276fee
Flipper Release: v0.156.0
...
Summary: Releasing version 0.156.0
Reviewed By: LukeDefeo
Differential Revision: D38198427
fbshipit-source-id: b348e3bc2c4ee18d897841a1ad359db950b15100
2022-07-27 04:31:07 -07:00
Feiyu Wong
3fbf1215ec
Refactored DataView to be the primary data driver for DataTable instead
...
Summary:
In order to accomplish multi-panel mode, we need to use multiple data views on the same data source so that the filters can be applied differently, etc.
This diff serves to refactor DataTable and some of its associated classes to use DataView as the primary driver for data management. Additionally, the diff refactored the state to allow multi-paneling to be on the DataPanel layer instead of the DataTable layer for ease of usage
This is the last diff of the larger stack which introduces the multi-panel mode feature. A possible next step could be allowing infinite(up to a certain limit) panels to be populated.
Changelog: Introduced side by side view feature for `DataTable`. There is now a new boolean for `DataTable` props called `enableMultiPanels`. If this is passed in, then the table will have an option to open a different "side panel" using a completely different dataview which allows different filters, searches, etc.
Reviewed By: mweststrate
Differential Revision: D37685390
fbshipit-source-id: 51e35f59da1ceba07ba8d379066970b57ab1734e
2022-07-22 09:16:37 -07:00
Andrey Goncharov
55b7ef934c
Augument IDB installation instructions for intern users
...
Reviewed By: passy
Differential Revision: D37994214
fbshipit-source-id: bd36abf1ed024ca1f18fcc5297108e4ca333c578
2022-07-20 06:03:38 -07:00
Andrey Goncharov
f3cb9de5c9
Fix Sidebar resizing handler propagation
...
Summary: SidebarInteractiveContainer sets mousedown/mouseup handlers. Whenever user tries to select text in child element those are triggered.
Reviewed By: passy
Differential Revision: D37994014
fbshipit-source-id: 5dcf5642b3a92ec50008aa4aad6b9522a09c1527
2022-07-20 06:01:10 -07:00
Jacy
bd5ac524f5
Update some welcome links ( #3902 )
...
Summary:
Some old welcome links are 'Page Not Found'.
## Changelog
Some old links are 'Page Not Found', so update them as follows:
1. Update "Using Flipper" link to 'https://fbflipper.com/docs/features '
2. Update "Add Flipper Support to Your App" link to 'https://fbflipper.com/docs/getting-started '
Pull Request resolved: https://github.com/facebook/flipper/pull/3902
Test Plan: Pass the test on a Mac.
Reviewed By: lblasa
Differential Revision: D37927376
Pulled By: passy
fbshipit-source-id: 0aac129932395e3f2ce3afa8c47cc637f3e814a8
2022-07-19 10:46:28 -07:00
Flipper Bot
e3110be5a6
Flipper Release: v0.155.0
...
Summary: Releasing version 0.155.0
Reviewed By: lblasa
Differential Revision: D37957716
fbshipit-source-id: f682464ec8737acc3e28197fa3724a6ae150e8cd
2022-07-19 09:01:42 -07:00
Lorenzo Blasa
d4597f455e
Add a handler for any errors during highlight
...
Summary:
^
Ignore the errors as otherwise it may cause unhandled rejection errors.
Reviewed By: aigoncharov
Differential Revision: D37926740
fbshipit-source-id: 50476378b4d254e28af953979fbedad1113e43aa
2022-07-19 06:09:55 -07:00
Lorenzo Blasa
04220b6c7e
Typo and increase timeout to 45s
...
Summary:
Observed that a few requests tend to timeout when using Flipper with flipper-server.
Increasing timeout to 45s as to be a bit more flexible.
'exec' operations don't have a timeout when not using flipper-server.
Reviewed By: antonk52
Differential Revision: D37955108
fbshipit-source-id: 5d8ef7f066d6b316e4b485b281a015794b5bd2de
2022-07-19 04:06:03 -07:00
Lorenzo Blasa
c871b221fd
Add catch handlers to client calls
...
Summary:
Client calls return a promise. Not dealing with the error causes promise unhandled rejection errors.
This change adds a catch block and logs the error instead.
Reviewed By: antonk52
Differential Revision: D37955029
fbshipit-source-id: 50cac5a5339961d16868ab2102d3c77790e6943c
2022-07-19 04:05:12 -07:00
Lorenzo Blasa
860cf332e1
Do not disconnect when there's a 'send' error
...
Summary:
Historically, RSocket used to raise an error when there was an error during send, most likely because the connection was dead.
With WS, this is no longer the case.
WS connection issues are raised through the according handlers.
Reviewed By: passy
Differential Revision: D37825821
fbshipit-source-id: 7fcda8cf26fb42eb0d8ca03b62482f11c931777f
2022-07-14 10:40:43 -07:00
Feiyu Wong
53b89f485a
Add Toggle to control showing full search history instead of filtered list
...
Summary:
This diff adds a new menu option to the Logs plugin which allows for enabling/disabling the automatic filtering of search terms in the search history as user types.
Additionally, fixed bug regarding the search term that's used is not actually showing correctly. This is caused by the search value being set in the input search bar instead of the autoComplete component level
Differential Revision: D37555209
fbshipit-source-id: 8a76299f7e1a4b0a3adfa6a4dd883d17f1e7a442
2022-07-14 06:21:45 -07:00
Flipper Bot
14d385827d
Flipper Release: v0.154.0
...
Summary: Releasing version 0.154.0
Reviewed By: jknoxville
Differential Revision: D37813763
fbshipit-source-id: f16392937146a50c7018c2ae5abd18e433059622
2022-07-13 09:21:01 -07:00
Alex Hunt
e7591b2a81
Set clearLogs accelerator for log-rendering plugins
...
Summary:
Sets a default key binding of `ctrl+l` to clear the screen within built-in Flipper plugins which display a log view.
Motivation: A small quality of life improvement for developers used to the default "clear screen" binding. This makes our log-rendering plugins consistent with other native apps such as terminals, Chrome DevTools, and many others.
Reviewed By: mweststrate
Differential Revision: D37782638
fbshipit-source-id: 0a85b930faaa0e9468d5391f15092aad7b6057ee
2022-07-13 01:38:55 -07:00
Lorenzo Blasa
c01df31459
Handle disconnection events whilst executing requests
...
Summary:
If there's a device client disconnect during request execution, no response is ever given back to the client (flipperd).
This change effectively subscribes to client disconnect events and notifies flipperd of any disconnection during request processing.
Reviewed By: passy
Differential Revision: D37787986
fbshipit-source-id: 31737a50b83b0cbe4141ce814064aebef7e09bfc
2022-07-12 12:55:19 -07:00
Gabriele Palma
01fc74d4f1
Added NetworkSourceContainers Flipper Plugin (Desktop) 1/3
...
Summary:
Added Flipper plugin.
Initial scaffolding for both iOS and JS
javascript code
Reviewed By: apadalko
Differential Revision: D37612499
fbshipit-source-id: a0a0ef596ef39f1d0bfe978767748c8fc3840d7a
2022-07-12 08:38:24 -07:00
Shipeng Xu
4daa1d41db
enable XMLTextFormatter for application/xml and text/xml
...
Summary:
Currently in the Flipper network plugin implementation, XMLTextFormatter is only enabled if `content-type` is `text/html`.
We should enable it for `application/xml` and `text/xml` as well.
Reviewed By: mweststrate
Differential Revision: D37733487
fbshipit-source-id: f272c5d0a305cf4afd32701d40459c3e11049886
2022-07-11 10:29:42 -07:00
Lorenzo Blasa
18854ce5fc
Install plugin from marketplace if not available
...
Summary: For the Flipper Server Companion, if a plugin is being requested which is not yet installed, try to install it first from the marketplace.
Reviewed By: passy
Differential Revision: D37716962
fbshipit-source-id: d618fbc597f82b540dbb02e8ffc296dcee9e1eb9
2022-07-11 07:04:55 -07:00
Lorenzo Blasa
c91c766b12
FlipperServer new plugin marketplace methods
...
Summary:
Expose two new methods as to be able to:
- List plugins from marketplace
- Install a plugin from marketplace
Reviewed By: passy
Differential Revision: D37749817
fbshipit-source-id: 82b78f7906c5664d5747289fa4f8eadebcde1d73
2022-07-11 07:04:55 -07:00
Lorenzo Blasa
1778ce4f46
HeadlessPluginInitialiser install plugin
...
Summary:
Allow adding plugins after initialisation. Effectively:
- Load the plugin creates the SandyPluginDefinition
- Add the definition to the existing loaded plugins
Reviewed By: passy
Differential Revision: D37749811
fbshipit-source-id: ea834b9e6105cf605fc906a794022f61807ce1d8
2022-07-11 07:04:55 -07:00
Lorenzo Blasa
b9e1039b7a
Load marketplace plugins from PluginManager
...
Summary: Expand PluginManager as to be able to load and install plugins from Marketplace.
Reviewed By: passy
Differential Revision: D37749802
fbshipit-source-id: 7d7e23427cc9d01f5c953b90e5b346a9d6bab19f
2022-07-11 07:04:55 -07:00
Lorenzo Blasa
04b433fe1d
Load marketplace plugins
...
Summary:
Load marketplace plugins using FlipperServer.
Extracted from:
https://www.internalfb.com/code/fbsource/[c3fdda2336d6]/xplat/sonar/desktop/flipper-ui-core/src/dispatcher/plugins.tsx?lines=89
Reviewed By: passy
Differential Revision: D37749793
fbshipit-source-id: 687d6f7c076c9314c6e96dc1cf6fba8c96c71841
2022-07-11 07:04:55 -07:00
Lorenzo Blasa
77276f5ac0
isPluginVersionMoreRecent for flipper-server-core
...
Summary:
Another implementation for isPluginVersionMoreRecent.
References:
https://www.internalfb.com/code/fbsource/[2d3c2d3ce5fb]/xplat/sonar/desktop/flipper-frontend-core/src/utils/isPluginVersionMoreRecent.tsx?lines=14
https://www.internalfb.com/code/fbsource/[2d3c2d3ce5fb]/xplat/sonar/desktop/flipper-ui-core/src/utils/isPluginVersionMoreRecent.tsx?lines=14
Is not immediately obvious what is different, but it boils down to the implementation of:
```
isPluginCompatible
```
and passing the flipper version.
That one depends on the package. As with other changes, this can probably be refactored out, for left as is unless strongly advised otherwise (it seems OK as we already have 2 implementations).
Reviewed By: passy
Differential Revision: D37749785
fbshipit-source-id: 5a22d90f094b53223d2469c572646d5bfd3d1d33
2022-07-11 07:04:55 -07:00
Lorenzo Blasa
beb0ed1991
Plugin marketplace for flipper-server-core
...
Summary:
Implementation taken from:
https://www.internalfb.com/code/fbsource/[85c1fe5afee7]/xplat/sonar/desktop/flipper-ui-core/src/fb/pluginMarketplaceAPI.tsx
As with the previous diff, the marketplace API for flipper-server-core accesses the existing config in a different way and depends on FlipperServer, instead of User, to execute intern request as to obtain marketplace plugins.
Reviewed By: passy
Differential Revision: D37749775
fbshipit-source-id: 968ea3f7a412893f032e5a7a50ecf17c298e18ff
2022-07-11 07:04:55 -07:00
Lorenzo Blasa
ff66cd18ec
isPluginCompatible for flipper-server-core
...
Summary:
Yet another implementation of this function.
References:
https://www.internalfb.com/code/fbsource/[85c1fe5afee7]/xplat/sonar/desktop/flipper-frontend-core/src/utils/isPluginCompatible.tsx?lines=14
https://www.internalfb.com/code/fbsource/[85c1fe5afee7]/xplat/sonar/desktop/flipper-ui-core/src/utils/isPluginCompatible.tsx?lines=15
This one:
- Uses GK from the existing server config
- Gets version from the existing server config
It differs in:
- appVersion not passed in as argument
- Doesn't use RenderHost to obtain the server config
I think, this is acceptable as the function body is effectively the conditional, that depends on the caller available dependencies.
Reviewed By: passy
Differential Revision: D37749761
fbshipit-source-id: 3094e87c7770ac66e5764c932a0a0d4e7f5b63f5
2022-07-11 07:04:55 -07:00
James Wysynski
5551cf3bb2
Fix tab names [again]
...
Summary: child.hasOwnProperty -> child.props.hasOwnProperty for tabs
Reviewed By: udat
Differential Revision: D37751552
fbshipit-source-id: 78015bbc185387587ce3644c959596cf0a661ddf
2022-07-11 06:40:31 -07:00
Luke De Feo
0e11eaabb3
Finishing touches
...
Summary:
A few comments in my rewrite stack got missed, I am addressing them here.
In addition react testing library has been hoisted to the root module in the project and been made available to all sub modules
Reviewed By: mweststrate
Differential Revision: D37712339
fbshipit-source-id: 60984c3d16bd535b0c489570907f097c7d80f634
2022-07-11 05:15:25 -07:00
Lorenzo Blasa
ea958b0b15
MarketplacePluginDetails into flipper-common
...
Summary: ^
Reviewed By: antonk52
Differential Revision: D37715921
fbshipit-source-id: 05d35c472e847a7891fd4af1e88a3425e1d55f13
2022-07-11 02:39:49 -07:00
Lorenzo Blasa
caa04f4a44
Move User to flipper-common
...
Summary: Move User from reducers to flipper-common. User will now be usable by other modules.
Reviewed By: passy
Differential Revision: D37599802
fbshipit-source-id: 66412e7ed00bf27448fa2deae70f0e8e80303aba
2022-07-08 14:17:52 -07:00
Hao Yang
54f85029d9
Add Generate Flipper Files [1/5]
...
Differential Revision: D37192850
fbshipit-source-id: d4122bf4c3ceebd251ccc2b06765ec8406771cde
2022-07-07 17:39:46 -07:00
Luke De Feo
4e2e23e3b4
Added ability to override device paramters in Deviceplugin test utils
...
Summary: This allows for more controlled device plugin tests
Reviewed By: mweststrate
Differential Revision: D37609991
fbshipit-source-id: 7e0694ba97e6b2c34b5d9cd81761eecd2f50c6f9
2022-07-07 07:50:14 -07:00
