a76faafa4b94e12277ecb114219173f143da54dd
243 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Sanjaiyan Parthipan
|
7cef8286f9 |
Concurrent Function Upgrade for Enhanced Performance (#4918)
Summary: Republishing sanjaiyan-dev's PR https://github.com/facebook/flipper/pull/4889 running `git rebase` because of a conflict. Pull Request resolved: https://github.com/facebook/flipper/pull/4918 Reviewed By: lblasa Differential Revision: D47294545 Pulled By: passy fbshipit-source-id: 74904ec6179ed5a3bab6f9b701c3cd769ecad3bf |
||
Lorenzo Blasa
|
a165d37ab3 |
Grey icon for PWA
Summary: Right now, both Launcher and PWA share the same icon. As to make it easier to identify which one is which, PWA will have a greyed icon instead. Reviewed By: antonk52 Differential Revision: D47436998 fbshipit-source-id: 69d4d273c35e327263fbbf02d4ac7a005013f1d9 |
||
Michel Weststrate
|
50f50fa46c |
fall back to larger images if requested size is not available
Summary: This diff follows up on the previous one, by trying a larger icon size if the original requested icon size was missing. Reviewed By: lblasa Differential Revision: D46556076 fbshipit-source-id: 4a078088aa27390f247e39afeda4b1df261d8b30 |
||
|
Michel Weststrate
|
a6dac1d8d9 |
make icon download more robust, and use assets_DO_NOT_HARDCODE urls instead of asset urls.
Summary: Since ~yesterday all our builds started failing due to being unable to download static assets. Although those assets load correctly in the browser, and by using the browsers's generated `curl` command, which looks like: ``` curl 'https://facebook.com/assets/?name=face-unhappy&variant=outline&size=24&set=facebook_icons&density=1x' \ -H 'authority: facebook.com' \ -H 'accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.7' \ -H 'accept-language: nl,en-GB;q=0.9,en;q=0.8,nl-NL;q=0.7,en-US;q=0.6' \ -H 'cache-control: no-cache' \ -H 'cookie: OMITTED' \ -H 'pragma: no-cache' \ -H 'sec-ch-ua: "Not.A/Brand";v="8", "Chromium";v="114", "Google Chrome";v="114"' \ -H 'sec-ch-ua-mobile: ?0' \ -H 'sec-ch-ua-platform: "macOS"' \ -H 'sec-fetch-dest: document' \ -H 'sec-fetch-mode: navigate' \ -H 'sec-fetch-site: none' \ -H 'sec-fetch-user: ?1' \ -H 'upgrade-insecure-requests: 1' \ -H 'user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36' \ --compressed ``` Download fails as soon as the cookie header is dropped. Changes the base url to `https://facebook.com/images/assets_DO_NOT_HARDCODE/facebook_icons/` fixes that problem, unless the resolution doesn't exist (addressed in next diff). This also seems to remove the flakiness we were experiencing before, so dropped the retry mechanism for now. Also made failing to download an icon a warning instead of a build failure. Reviewed By: lblasa Differential Revision: D46552986 fbshipit-source-id: f1382d6a8fc6669691f0c8da6b77834d24a373c5 |
||
|
Lorenzo Blasa
|
2815ba0fb8 |
Copy/Paste implementation
Summary: ^ Reviewed By: aigoncharov Differential Revision: D46515194 fbshipit-source-id: 0ee6931569d5248d5643b391683e230e0c095e41 |
||
|
Lorenzo Blasa
|
6430403da0 |
Jest update v26.6.3 -> v29.5.1
Summary: ^ Basically, update Jest and fix any raised issues. Mainly: - Update necessary dependencies - Update snapshots - `useFakeTimers` caused a few issues which meant that the way we hook into the performance object had to be tweaked. The main code change is: `//fbsource/xplat/sonar/desktop/scripts/jest-setup-after.tsx` - `mocked` -> `jest.mocked` Changelog: Update Jest to v29.5.1 Reviewed By: antonk52 Differential Revision: D46319818 fbshipit-source-id: d218ca8f7e43abac6b00844953ddeb7f4e1010a2 |
||
|
Lorenzo Blasa
|
49c356059a |
Use a direct download from Node distribution instead of relying on pkg-fetch
Summary:
It seems the available binary for macOS arm64 is not signed:
```
codesign -dv --verbose=4 ./node-v16.16.0-macos-arm64
./node-v16.16.0-macos-arm64: code object is not signed
```
This is an issue as it crashes for our flipper server releases.
This can be compared to a binary downloaded from the Node distribution page:
```
codesign -dv --verbose=4 ./node
Executable=/Users/realpassy/Downloads/node-v16.15.0-darwin-arm64/bin/node
Identifier=node
Format=Mach-O thin (arm64)
CodeDirectory v=20500 size=597360 flags=0x10000(runtime) hashes=18657+7 location=embedded
VersionPlatform=1
VersionMin=720896
VersionSDK=721152
Hash type=sha256 size=32
CandidateCDHash sha256=31cdf84cac42a622c1a68558376700a2dd12d40d
CandidateCDHashFull sha256=31cdf84cac42a622c1a68558376700a2dd12d40d81c5118f3b0e0370c414eb69
Hash choices=sha256
CMSDigest=31cdf84cac42a622c1a68558376700a2dd12d40d81c5118f3b0e0370c414eb69
CMSDigestType=2
Executable Segment base=0
Executable Segment limit=56082432
Executable Segment flags=0x1
Page size=4096
Launch Constraints:
None
CDHash=31cdf84cac42a622c1a68558376700a2dd12d40d
Signature size=8986
Authority=Developer ID Application: Node.js Foundation (HX7739G8FX)
Authority=Developer ID Certification Authority
Authority=Apple Root CA
Timestamp=26 Apr 2022 at 23:00:57
Info.plist=not bound
TeamIdentifier=HX7739G8FX
Runtime Version=11.1.0
Sealed Resources=none
Internal requirements count=1 size=164
```
For additional context:
Node binary by using pkg-fetch. We just get the binary from this release page: https://github.com/vercel/pkg-fetch/releases/tag/v3.4
The exact binary we're downloading is https://github.com/vercel/pkg-fetch/releases/download/v3.4/node-v16.15.0-macos-arm64
If you just download that via Chrome, it will trigger Gatekeeper and you need to manually click "Allow" in the system privacy settings. You can also do the same by just running:
xattr -c ./node-v16*
Afterwards you can:
chmod +x ./node*
It will crash in the same way that it does after our distribution.
Reviewed By: passy
Differential Revision: D46225503
fbshipit-source-id: f0ae2d5101b99c9db7fe80333573caef52c787a2
|
||
|
Lorenzo Blasa
|
eaaac54bc4 |
Manifest as template
Summary: The file manifest.json is injected with the auth token and it happens with every launch. Because the file is tracked, these changes will always get picked no matter what the .gitignore file specifies, because is a tracked file. So, the solution is to have a template with a different name, that gets copied into the right location during build time. Reviewed By: LukeDefeo Differential Revision: D46184772 fbshipit-source-id: 938b9433045485d9846a6a50c1c955ebe7925581 |
||
|
Lorenzo Blasa
|
76fbaf245c |
Replace existing running instance, if any
Summary: Replace an existing running instance, if any. This is useful for: - Applying updates - Ensuring freshness of server Reviewed By: passy Differential Revision: D46146814 fbshipit-source-id: bfb760f3ab26b7632510773609f1c6ca3a97c4ec |
||
Pascal Hartig
|
558316153c |
Build server release for Mac AARCH64
Reviewed By: lblasa Differential Revision: D46144878 fbshipit-source-id: 1aa2982fc99e5dc6cdfbe4d9fcf87f7fc55a1abe |
||
|
Lorenzo Blasa
|
c6d5eb3334 |
Flipper as PWA
Summary: ^ Reference: https://docs.google.com/document/d/1flQJUzTe4AuQz3QCpvbloQycenHsu7ZxbKScov7K7ao Reviewed By: passy Differential Revision: D45693382 fbshipit-source-id: 5a2e6c213a7e7e2cf9cd5f3033cff3e5291a2a92 |
||
Andrey Goncharov
|
423a8d1935 |
Revamp newScript detailed view
Summary: Project: https://docs.google.com/document/d/1SbFrpvfIShX5npANNa1AkgHliR1M-VMLW5Q9RhREt94/edit# Reviewed By: antonk52 Differential Revision: D45353402 fbshipit-source-id: 88cc26f9886fd7b2cdcd5ca3d021790d8669c140 |
||
Niccolò Belli
|
6452816de7 |
fix(build-utils): await stripSourceMapComment (#4586)
Summary: I've just packaged Flipper for Gentoo Linux and I wanted to use the system electron instead of bundling its own copy into the flipper executable. To do so I use my custom `electron-builder` and `app-builder` versions, which also allows me to support otherwise unsupported architectures like ppc64. That means skipping the downloading/unzipping/bundling steps for electron, which greatly shortens the overall build process. Being that fast resulted in countless hours of debugging, because the resulting `app.asar` wouldn't work. At some point I noticed that electron-builder cli was working flawlessly while processing the same exact config through the Javascript API resulted in failure, so I started digging into your scripts and I've noticed that you didn't await `stripSourceMapComment` into `desktop/scripts/build-utils.ts`. In particular the `compile` function was returning before `stripSourceMapComment` had finished doing its stuff, which ended up messing with electron-builder later. You didn't notice because you download electron, unzip it, etc which takes enough time to let `stripSourceMapComment` finish its stuff before the actual build starts, but since I skip these steps in order to use system electron I've been able to notice it. ## Changelog I simply await `stripSourceMapComment` promises in `build-utils`. Pull Request resolved: https://github.com/facebook/flipper/pull/4586 Test Plan: `cd desktop && yarn && yarn build` is enough to test this. ## Additional Suggestions I also suggest to enable the [no-floating-promises](https://typescript-eslint.io/rules/no-floating-promises/) eslint rule in order to ensure similar mistakes won't happen in the future. Reviewed By: ivanmisuno, mweststrate Differential Revision: D43974442 Pulled By: passy fbshipit-source-id: 5acfa3d1479828e9373070c40fe3dd865a862561 |
||
|
Pascal Hartig
|
859653e111 |
Build Linux executable
Summary: Currently, Flipper server cannot be used with Flipper Launcher on Linux because there is no `flipper` binary in the root of the directory. Adding a quick shell script bridges the call from the checked-in node binary and the server JS file. Reviewed By: ardavank Differential Revision: D43837781 fbshipit-source-id: d954ae21d5330aa549d4bc76aefb1d76af8e2c84 |
||
dependabot[bot]
|
6cb64f0af0 |
Bump app-builder-lib from 23.4.0 to 23.6.0 in /desktop (#4515)
Summary: Bumps [app-builder-lib](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib) from 23.4.0 to 23.6.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/releases">app-builder-lib's releases</a>.</em></p> <blockquote> <h2>v23.6.0</h2> <h2>What's Changed</h2> <ul> <li>feat: add nsis option to remove the default uninstall welcome page by <a href="https://github.com/moulinierf"><code>@moulinierf</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7141">electron-userland/electron-builder#7141</a></li> <li>feat: add Github Actions environment variable to isPullRequest method by <a href="https://github.com/kuidaoring"><code>@kuidaoring</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7152">electron-userland/electron-builder#7152</a></li> <li>fix: formatting of Code in the MacOS PKG docs by <a href="https://github.com/hrueger"><code>@hrueger</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7142">electron-userland/electron-builder#7142</a></li> <li>chore: Updating node 16 docker images by <a href="https://github.com/Tarrowren"><code>@Tarrowren</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7158">electron-userland/electron-builder#7158</a></li> <li>fix(ci): workflows security hardening by <a href="https://github.com/sashashura"><code>@sashashura</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7156">electron-userland/electron-builder#7156</a></li> <li>feat: non-silent mode allow not to run the app when the installation is complete by <a href="https://github.com/shenglianlee"><code>@shenglianlee</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7136">electron-userland/electron-builder#7136</a></li> <li>feat: update note for pnpm by <a href="https://github.com/romadryud"><code>@romadryud</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7163">electron-userland/electron-builder#7163</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/moulinierf"><code>@moulinierf</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7141">electron-userland/electron-builder#7141</a></li> <li><a href="https://github.com/kuidaoring"><code>@kuidaoring</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7152">electron-userland/electron-builder#7152</a></li> <li><a href="https://github.com/hrueger"><code>@hrueger</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7142">electron-userland/electron-builder#7142</a></li> <li><a href="https://github.com/Tarrowren"><code>@Tarrowren</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7158">electron-userland/electron-builder#7158</a></li> <li><a href="https://github.com/sashashura"><code>@sashashura</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7156">electron-userland/electron-builder#7156</a></li> <li><a href="https://github.com/shenglianlee"><code>@shenglianlee</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7136">electron-userland/electron-builder#7136</a></li> <li><a href="https://github.com/romadryud"><code>@romadryud</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7163">electron-userland/electron-builder#7163</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.5.1...v23.6.0">https://github.com/electron-userland/electron-builder/compare/v23.5.1...v23.6.0</a></p> <h2>v23.5.1</h2> <h2>What's Changed</h2> <ul> <li>fix: Revert "feat: Upgrade to Ubuntu 22.04 and python 3.10" by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7109">electron-userland/electron-builder#7109</a></li> <li>feat: allow dev update config to be forced for testing auto-updater flow by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7117">electron-userland/electron-builder#7117</a></li> <li>docs: declare node-linker when using Yarn 3 by <a href="https://github.com/ouliuquan"><code>@ouliuquan</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7113">electron-userland/electron-builder#7113</a></li> <li>fix: allow CSC_LINK to have a mime-type prefix by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7119">electron-userland/electron-builder#7119</a></li> <li>fix: strip extra fields out before creating snap.yaml (<a href="https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/7104">#7104</a>) by <a href="https://github.com/MikeJerred"><code>@MikeJerred</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7110">electron-userland/electron-builder#7110</a></li> <li>docs: fix typo by <a href="https://github.com/cjeonguk"><code>@cjeonguk</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7120">electron-userland/electron-builder#7120</a></li> <li>chore(deploy): Release by <a href="https://github.com/github-actions"><code>@github-actions</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7111">electron-userland/electron-builder#7111</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/ouliuquan"><code>@ouliuquan</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7113">electron-userland/electron-builder#7113</a></li> <li><a href="https://github.com/MikeJerred"><code>@MikeJerred</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7110">electron-userland/electron-builder#7110</a></li> <li><a href="https://github.com/cjeonguk"><code>@cjeonguk</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7120">electron-userland/electron-builder#7120</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.5.0...v23.5.1">https://github.com/electron-userland/electron-builder/compare/v23.5.0...v23.5.1</a></p> <h2>v23.5.0</h2> <h2>What's Changed</h2> <ul> <li>docs(signing): add tip for installer env by <a href="https://github.com/richtlu"><code>@richtlu</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7059">electron-userland/electron-builder#7059</a></li> <li>fix: updating integration test for prerelease flag by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7072">electron-userland/electron-builder#7072</a></li> <li>fix: replace update-notifier and update deps by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7078">electron-userland/electron-builder#7078</a></li> <li>fix: use <code>buildVersion</code> not <code>buildNumber</code> for fpm <code>--iteration</code> flag by <a href="https://github.com/davej"><code>@davej</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7075">electron-userland/electron-builder#7075</a></li> <li>fix: Invalid code signing for MAS build (<a href="https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/7040">#7040</a>) by <a href="https://github.com/jeanfbrito"><code>@jeanfbrito</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7089">electron-userland/electron-builder#7089</a></li> <li>fix: improve <code>downloadUpdate</code> typing by <a href="https://github.com/alefoll"><code>@alefoll</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7099">electron-userland/electron-builder#7099</a></li> <li>chore: Add details to entitlement option for macOS configurations by <a href="https://github.com/AxelTerizaki"><code>@AxelTerizaki</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7097">electron-userland/electron-builder#7097</a></li> <li>fix: close file stream when error by <a href="https://github.com/HppZ"><code>@HppZ</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7094">electron-userland/electron-builder#7094</a></li> <li>chore(deploy): Release by <a href="https://github.com/github-actions"><code>@github-actions</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7081">electron-userland/electron-builder#7081</a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/CHANGELOG.md">app-builder-lib's changelog</a>.</em></p> <blockquote> <h2>23.6.0</h2> <h3>Minor Changes</h3> <ul> <li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7141">#7141</a> <a href=" |
||
|
dependabot[bot]
|
420e1df4e4 |
Bump metro-minify-terser from 0.70.2 to 0.75.0 in /desktop (#4493)
Summary: Bumps [metro-minify-terser](https://github.com/facebook/metro) from 0.70.2 to 0.75.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/facebook/metro/releases">metro-minify-terser's releases</a>.</em></p> <blockquote> <h2>Release v0.75.0</h2> <ul> <li><strong>[Breaking]</strong>: Formalise minimum Node JS requirement at 14.17.0 via <code>package.json#engines</code>. (<a href=" |
||
|
dependabot[bot]
|
d02bfabfbf |
Bump ignore from 5.2.0 to 5.2.4 in /desktop (#4420)
Summary: Bumps [ignore](https://github.com/kaelzhang/node-ignore) from 5.2.0 to 5.2.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/kaelzhang/node-ignore/releases">ignore's releases</a>.</em></p> <blockquote> <h2>5.2.4</h2> <ul> <li><strong>PATCH</strong> fixes normal single asterisk and normal consecutive asterisks defined in gitignore spec (<a href="https://github-redirect.dependabot.com/kaelzhang/node-ignore/issues/57">https://github.com/facebook/flipper/issues/57</a>)</li> <li><strong>PATCH</strong> invalid trailing backslash will not throw unexpectedly</li> </ul> <p>An upgrade is recommended for all dependents</p> <hr /> <p>The following rules could be not properly parsed with previous <code>ignore</code> versions</p> <pre lang=".gitignore"><code>**foo *bar qu*ux abc\ # `ignore` would throw if no whitespace after `\` </code></pre> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Pascal Hartig
|
18b6ce6f24 |
Dep bump
Summary: Combining a bunch of individual tasks for dep upgrades into one diff. Reviewed By: ivanmisuno Differential Revision: D42706074 fbshipit-source-id: 054b2545ad1295699f47f4c6eb5065b7b9a1d6a0 |
||
Ranesh Saha
|
7a28ed1fe5 |
Pipe through --updater/--no-updater flag for flipper.exe (#4277)
Summary: In our organization, Flipper is distributed in a version controlled way. As a result, we do not want users to manually update or receive prompts to update when a new version is available. There is already a `--updater` flag in the command line arguments for flipper.exe, but it isn't piped through. This change pipes it through and disables all update related UI when `--no-updater` is passed in. ## Changelog Support --updater and --no-updater options for flipper.exe Pull Request resolved: https://github.com/facebook/flipper/pull/4277 Test Plan: Ran `yarn build --win` in flipper/desktop, and launched flipper.exe from flipper/dist/win-unpacked with the `--updater`, `--no-updater` and no flags and ensured the proper behavior was observed (update UI shows by default or when `--updater` is specified, and doesn't show when `--no-updater` is specified). Reviewed By: passy Differential Revision: D41298321 Pulled By: mweststrate fbshipit-source-id: 5ddfede2700954f0fdd6a111b20d0836fab25565 |
||
|
Lorenzo Blasa
|
587f428cf8 |
Allow plugins to use css
Summary: Flipper plugins fail when importing css from third-party dependencies. This diff tries to fix that. Effectively, the plugin can import the css and export it when is bundled. When we load the plugin, we check if there's a css file for it. If there's one, we return it and try to use it. Reviewed By: aigoncharov Differential Revision: D40758178 fbshipit-source-id: e53afffcc481504905d5eeb1aea1f9114ee2a86b |
||
|
dependabot[bot]
|
404449d499 |
Bump yargs from 17.4.1 to 17.6.0 in /desktop (#4165)
Summary: Bumps [yargs](https://github.com/yargs/yargs) from 17.4.1 to 17.6.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/yargs/yargs/blob/main/CHANGELOG.md">yargs's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/yargs/yargs/compare/v17.5.1...v17.6.0">17.6.0</a> (2022-10-01)</h2> <h3>Features</h3> <ul> <li><strong>lang:</strong> Czech locale (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/2220">https://github.com/facebook/flipper/issues/2220</a>) (<a href=" |
||
|
Andrey Goncharov
|
dd7ba2d6fc |
Fix fb-stubs replacement for plugin bundling
Reviewed By: nikoant Differential Revision: D39765543 fbshipit-source-id: 14cbf8a9bdf35031e636bbbde3dbc955faedb66b |
||
|
Andrey Goncharov
|
61a8fe09e9 |
Stop failing the entire plugin compatibility check if a shared plugin lib fails it
Summary: Currently, if we publish a new shared plugin lib in a separate diff, the compatibility check fails for it while it should exit with a warning only Reviewed By: antonk52 Differential Revision: D39731259 fbshipit-source-id: 7651642ebfb5e18ace047d36b52907bca65c4462 |
||
|
Andrey Goncharov
|
fd811db12b |
Rebuild all plugins if a shared lib changed
Summary: Some plugins import from shared directories. These directories are not plugins themselves, therefore the current plugin root searching mechanism does nto work for them. To support plugin reloading for this scenario, we start re-building all plugins if we fail to find a plugin root. Reviewed By: lblasa Differential Revision: D39693820 fbshipit-source-id: 33dd7de4121bd5665a39b0ea96adce4603dc7df0 |
||
Ken Yee
|
fa9ba6f2d0 |
Adds a notifyAvailableUpdate flag to config.json to disable update (#3992)
Summary: We would like to version control Flipper and some of our custom plugins that are installed on developers' systems. Flipper by default prompts users to upgrade so they sometimes do the update and then all our custom plugins break because they were compiled for an older version. See https://github.com/facebook/flipper/issues/3947 for feature request info. ## Changelog Adds notifyAvailable flag to config.json to disable prompting for users that "an update is available" Pull Request resolved: https://github.com/facebook/flipper/pull/3992 Test Plan: Tested by running locally. Had to comment out the isProduction() check to confirm this it worked properly because this flag is false on dev versions. Couldn't figure out how to manually test the handleOpenPluginDeeplink.tsx change but made a similar change there; happy to test that if you can tell me how to exercise that path. Reviewed By: antonk52 Differential Revision: D39654481 Pulled By: antonk52 fbshipit-source-id: cef6b48d870915c48f620269c42d24b8ef1f4c29 |
||
|
Andrey Goncharov
|
3314c77ce9 |
Add exportFileBinary to FlipperLib
Reviewed By: antonk52 Differential Revision: D39692937 fbshipit-source-id: 7b3c78d004a9734cd8ae660d5782be1f02c00009 |
||
Andrey Goncharov
|
d81dac18b5 |
Work around empty file restirction
Reviewed By: nikoant Differential Revision: D39578561 fbshipit-source-id: 3a471e7dd06a1e8cee2c7823b1d7f764110ecf80 |
||
|
Andrey Goncharov
|
2aa3dc9bd8 |
Remove reference to flipper-server bundle map
Summary: flipper-server is currently shipped unbundled and unminified Reviewed By: nikoant Differential Revision: D39577062 fbshipit-source-id: cd78aded878358e9f90792c695b6d1b27863f05a |
||
|
Andrey Goncharov
|
7c66a83328 |
Add source map copying for plugins
Reviewed By: nikoant Differential Revision: D39576201 fbshipit-source-id: cd6b11bdb0a4c89e2f84d1c4772f08acc4b86418 |
||
|
Andrey Goncharov
|
8dc5f4d3ea |
Remove stale build options
Summary: Now that we build all plugins at all times and it is super-fast, these options are redundant Reviewed By: lblasa Differential Revision: D39542723 fbshipit-source-id: 1b30ba384267ec4fd0c35b4dc14f0223ffe414c9 |
||
|
Andrey Goncharov
|
ab03140201 |
Fix list of watch folders for electron dev build
Summary: Restart electron app if we had any server-code changes Reviewed By: lblasa Differential Revision: D39542169 fbshipit-source-id: fb8e335f3e3fe0cf34e57a79b96e9cc8377e9fda |
||
|
Andrey Goncharov
|
c69d102ca1 |
Track plugin changes and notify frontend
Summary: Watch source plugin folders and notify frontend that any of them changed. In subsequent diffs, we will start reloading plugins that changed. Reviewed By: lblasa Differential Revision: D39539443 fbshipit-source-id: 726916c0bce336a2c0179558526bcb1b74e35b93 |
||
|
Andrey Goncharov
|
3639feef61 |
Watch and rebuild plugins
Summary: Now, once we build all plugins before we start Flipper, we need to rebuild some of them when they change. Previously, it was handled by Metro when we included plugins int he bundle, but we no longer include them in the bundle. Reviewed By: lblasa Differential Revision: D39510213 fbshipit-source-id: a352d78946f844a25d9127ac09c26e43e6739ca9 |
||
|
Andrey Goncharov
|
9dda947371 |
Fix flipper server prod build
Summary: Make flipper-server link local flipper-* deps for intern prod build. Update flipper-* deps versions for public builds so `npx` pulls them from npm Reviewed By: lblasa Differential Revision: D39497944 fbshipit-source-id: ca2674a4ac8f5b6c3efa9546b631f2526bf48f8e |
||
|
Andrey Goncharov
|
ed93dfe978 |
Refine prod and dev deps
Summary: Move flipper local deps to prod deps, so yarn installs them later when we build a bundle Reviewed By: lblasa Differential Revision: D39475545 fbshipit-source-id: 5b61d15b45ee315c3b35d8e6836c114b90503b1a |
||
|
Andrey Goncharov
|
f835e07c46 |
Build all plugins before start
Summary: prepareDefaultPlugins builds all plugins now. We no longer need extra helpers Reviewed By: lblasa Differential Revision: D39308098 fbshipit-source-id: 4f12a0bdbc2afd2b306565fff3494daa630e1a20 |
||
|
Andrey Goncharov
|
642a3ebf81 |
Remove default plugin entrypoints for hot-reloading
Summary: As we stopped bundling plugins in D39276249, we no longer need the entry points for the bundled plugins (these entry points are always going to be empty) Reviewed By: lblasa Differential Revision: D39307565 fbshipit-source-id: 43751fe31c8bd962677c226b27cfe52093d3f2d4 |
||
|
Andrey Goncharov
|
94df830dfb |
Migrate plugin bundling to esbuild
Summary: With esbuild bundling all plugins takes a couple of seconds instead of 3-5 minutes with metro. As a result, we can stop including plugins into Flipper's bundle for development and always bundle them separately. It reduces complexity of our build pipeline and makes the dev build work more like our prod build. It also allows us to stop bundling flipper-server code and just compile it instead. Reviewed By: lblasa Differential Revision: D39262048 fbshipit-source-id: c4da0f2ea2807015d98e0d070349c39b2118e189 |
||
|
Andrey Goncharov
|
a888e6affa |
Simplify bundled plugin setup
Summary: Stop bundling plugins into Flipper Server bundles. In later diffs, we will start building all plugins even in dev mode which removes the need to bundle them. Reviewed By: lblasa Differential Revision: D39276249 fbshipit-source-id: 091405cfcf58aa7e1bd2b382da40f8d9841ae6b1 |
||
|
Andrey Goncharov
|
a67a4e5d0f |
Remove babel transforms for flipper-server
Summary: Flipper server itself requires no babel transforms. We applied extra transforms only for the bundled plugins. However, we pack and ship all plugins in the /static folder. They are always available on the FS. Therefore we could stop bundling any plugins into flipper-server's source code. Reviewed By: lblasa Differential Revision: D38910251 fbshipit-source-id: b3e9fe5ae2ab69ce5579b01b6793ebf7e88baf66 |
||
|
Andrey Goncharov
|
218cb6abf2 |
Fix server bundling order
Summary: prepareDefaultPlugins and prepareHeadlessPlugins should come before compileServerMain to bundle plugins Reviewed By: passy Differential Revision: D38862132 fbshipit-source-id: 952a2f6d4f857f4faacfc952bebb4e59afcbc5b0 |
||
|
dependabot[bot]
|
ef66d452ee |
Bump app-builder-lib from 23.0.8 to 23.4.0 in /desktop (#4008)
Summary: Bumps [app-builder-lib](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib) from 23.0.8 to 23.4.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/releases">app-builder-lib's releases</a>.</em></p> <blockquote> <h2>v23.4.0</h2> <h2>What's Changed</h2> <ul> <li>feat: Adding timeout to publisher config for api requests and uploads by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7028">electron-userland/electron-builder#7028</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.3.3...v23.4.0">https://github.com/electron-userland/electron-builder/compare/v23.3.3...v23.4.0</a></p> <h2>v23.3.3</h2> <h2>What's Changed</h2> <ul> <li>docs: highlight, thanks by <a href="https://github.com/gaoyia"><code>@gaoyia</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7010">electron-userland/electron-builder#7010</a></li> <li>fix: Duplicate values during deep assign of extra files by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7019">electron-userland/electron-builder#7019</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/gaoyia"><code>@gaoyia</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7010">electron-userland/electron-builder#7010</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.3.2...v23.3.3">https://github.com/electron-userland/electron-builder/compare/v23.3.2...v23.3.3</a></p> <h2>v23.3.2</h2> <h2>What's Changed</h2> <ul> <li>fix: Wrap the nsProcess include in a !ifndef by <a href="https://github.com/titus-anromedonn"><code>@titus-anromedonn</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6996">electron-userland/electron-builder#6996</a></li> <li>fix: installDir definition <a href="https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6907">#6907</a> by <a href="https://github.com/panther7"><code>@panther7</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6995">electron-userland/electron-builder#6995</a></li> <li>fix(electron-updater): fix backward compatibility for GitHub provider without channels by <a href="https://github.com/matejkriz"><code>@matejkriz</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6998">electron-userland/electron-builder#6998</a></li> <li>chore: Adding allowPrerelease github integration tests by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7003">electron-userland/electron-builder#7003</a></li> <li>docs: Add customWelcomePage example to Custom NSIS script by <a href="https://github.com/hueyyeng"><code>@hueyyeng</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7001">electron-userland/electron-builder#7001</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/titus-anromedonn"><code>@titus-anromedonn</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6996">electron-userland/electron-builder#6996</a></li> <li><a href="https://github.com/matejkriz"><code>@matejkriz</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6998">electron-userland/electron-builder#6998</a></li> <li><a href="https://github.com/hueyyeng"><code>@hueyyeng</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7001">electron-userland/electron-builder#7001</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.3.1...v23.3.2">https://github.com/electron-userland/electron-builder/compare/v23.3.1...v23.3.2</a></p> <h2>v23.3.1</h2> <h2>What's Changed</h2> <ul> <li>feat: Add installDir property for NsisUpdater by <a href="https://github.com/panther7"><code>@panther7</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6907">electron-userland/electron-builder#6907</a></li> <li>chore(deps): update dependency <code>@types/archiver</code> to v5.3.1 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6979">electron-userland/electron-builder#6979</a></li> <li>chore(deps): update dependency <code>@types/node</code> to v16.11.43 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6980">electron-userland/electron-builder#6980</a></li> <li>fix: parallel release creation with Keygen publisher by <a href="https://github.com/ezekg"><code>@ezekg</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6989">electron-userland/electron-builder#6989</a></li> <li>fix: add product scope to Keygen publisher by <a href="https://github.com/ezekg"><code>@ezekg</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6990">electron-userland/electron-builder#6990</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.3.0...v23.3.1">https://github.com/electron-userland/electron-builder/compare/v23.3.0...v23.3.1</a></p> <h2>v23.3.0</h2> <h2>What's Changed</h2> <ul> <li>feat: upgrade Keygen integration to v1.1 by <a href="https://github.com/ezekg"><code>@ezekg</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6941">electron-userland/electron-builder#6941</a></li> <li>fix(mac): allow Mac Developer certs for non Mac App Store builds by <a href="https://github.com/regentcid434"><code>@regentcid434</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6956">electron-userland/electron-builder#6956</a></li> <li>fix: prevent infinite looping of overwriteArtifact by <a href="https://github.com/CCInc"><code>@CCInc</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6958">electron-userland/electron-builder#6958</a></li> <li>fix: add product scope to keygen provider by <a href="https://github.com/ezekg"><code>@ezekg</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6975">electron-userland/electron-builder#6975</a></li> <li>fix(mas): Allow signing with "3rd Party Mac Developer Application" by <a href="https://github.com/csett86"><code>@csett86</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6970">electron-userland/electron-builder#6970</a></li> <li>fix(nsis): fix typo in German installer message by <a href="https://github.com/tkleinke"><code>@tkleinke</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6960">electron-userland/electron-builder#6960</a></li> <li>fix: nsis-web target set APP_PACKAGE_URL_IS_INCOMPLETE by <a href="https://github.com/geovie"><code>@geovie</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6964">electron-userland/electron-builder#6964</a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/CHANGELOG.md">app-builder-lib's changelog</a>.</em></p> <blockquote> <h2>23.4.0</h2> <h3>Minor Changes</h3> <ul> <li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/7028">#7028</a> <a href=" |
||
Feiyu Wong
|
3ffb25e672 |
Update UI for enabling persisted logs feature
Summary: This is the first diff to implement the feature for the Flipper logs plugin to have an option to persist logs in the table between crashes, disconnections, etc. Since this is not a local change, the UI option for persistence will be located in the settings for the Flipper UI(as seen in the test plan). The setting is associated with the Redux Store `Settings` and is stored globally to be used across all plugins. So the plan is making the persistence pertain to all plugins. Reviewed By: mweststrate Differential Revision: D37786988 fbshipit-source-id: 7ffc6077cbca559b3401b16770eda657a6c45620 |
||
Lorenzo Blasa
|
646b9d5a5d |
UDS/TCP options
Summary: Provide an option to enable/disable TCP connections on flipper-server. The only change at this stage is that Flipper Desktop will use UDS to connect to flipper-server. Reviewed By: passy Differential Revision: D37519656 fbshipit-source-id: 3d02084666fde532ec76134edf8cf6a231060a48 |
||
|
Andrey Goncharov
|
e4d33483d0 |
Fix starting Flipper electron in dev mode without default plugins
Summary: yarn start --no-default-plugins currently fails Reviewed By: nikoant Differential Revision: D37456367 fbshipit-source-id: 3700055b3b780af4575dd67d50532050d12119df |
||
|
Andrey Goncharov
|
92cdb81096 |
Upgrade electron version
Summary: CHANGELOG: Upgrade electron to 18.2.0. In Electron 18.2.0 we no longer have access to `remote`. Instead, we are recommended to implement IPC communications. We re-implement `remote` methods used before as IPC commands. To support type-safe execution of the commands, we create electron IPC clients on both sides: the main process and renderer process. We also move the main menu creation to the main process and track its usage via sending IPC messages to the renderer process where the logging happens. Reviewed By: mweststrate Differential Revision: D36593625 fbshipit-source-id: 6dcf531461ef2edceb9cac372a650f84f3370953 |
||
Pascal Hartig
|
11ff9b51e3 |
Fix node +x bit in server distribution
Summary: This was lost when I changed from `pkg-fetch` writing it to copying the file. Reviewed By: mweststrate, aigoncharov Differential Revision: D36682861 fbshipit-source-id: 23822d4cc75720a83282de949d28029a05a2a7f9 |
||
|
Andrey Goncharov
|
4eca8d1088 |
Add isHeadlessBuild to EnvironmentInfo
Summary: Allows to attribute errors to flipper server or flipper electron Reviewed By: passy Differential Revision: D36698504 fbshipit-source-id: 6d07216fd05aa48b7c8cca5b53145916b64526eb |
||
|
dependabot[bot]
|
8ce64bbec4 |
Bump yargs from 17.2.1 to 17.4.1 in /desktop (#3714)
Summary: Bumps [yargs](https://github.com/yargs/yargs) from 17.2.1 to 17.4.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/yargs/yargs/blob/main/CHANGELOG.md">yargs's changelog</a>.</em></p> <blockquote> <h3><a href="https://github.com/yargs/yargs/compare/v17.4.0...v17.4.1">17.4.1</a> (2022-04-09)</h3> <h3>Bug Fixes</h3> <ul> <li>coerce pollutes argv (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/2161">https://github.com/facebook/flipper/issues/2161</a>) (<a href=" |
||
|
Pascal Hartig
|
02adfa79e9 |
Add sourcemap support to server build
Summary: Provide the same build parameters as for the main build and move the two bundles to a folder where we can pick them up. For consistency, I'm keeping the naming scheme with the main build. Reviewed By: antonk52 Differential Revision: D36521046 fbshipit-source-id: 9ea992d6e5dc299d88083d751ca8e84eadb1430b |