Summary: Excluding `react-virtual` which seems to include a breaking change with the patch release.
Reviewed By: jknoxville
Differential Revision: D30189687
fbshipit-source-id: b40cb5edd407fd03009ee38c0af5202c8deaaa26
Summary:
- This diff adds usage statistics for
- How often was the troubleshooting button opened
- What were its end states ( Problem solved or file a support request)
- I am using the tracked flipper plugin to obtain and analyse the stats on Infinity analytics events dev in Scuba backend.
(Since this is not yet productionized we are using the dev version now )
Reviewed By: nikoant
Differential Revision: D30098054
fbshipit-source-id: 871cc18872bccf70a829dc1dd173a337b02ec6e6
Summary:
- Added a dialogue with 2 possible end state buttons
- Problem Solved
- File Support Request
- This diff is the start of the implementation of the troubleshooting wizard.
- The previously implemented troubleshooting button (D29993355 (921a65bc17)) now links to a modal dialogue box.
- This is essentially the last screen of the troubleshooting guide to be implemented.
- We have options for a user to either select file a support request if the issue persists after navigating the guide or click on problem solved if the guide helped them solve it.
- Selecting option 2 (file support request) links to the pre-existing form
The modal has been implemented as an independent reusable component and can be easily extended.
Reviewed By: passy
Differential Revision: D30069270
fbshipit-source-id: f61bf8c03de786e11b7f06194328dbee703abf8b
Summary:
This change enables a WebSocket server if the user is on the 'flipper_websocket_server' GK.
I don't expect this change to make it as the final product of the entire solution. Instead, it can be used to quickly enable/disable WebSocket during development/testing without requiring any code changes.
Reviewed By: passy
Differential Revision: D30069694
fbshipit-source-id: 75daac75e6dad7f63cf194d8287971c33d3abb61
Summary:
This change addresses a problem with using data.id straight into the if statement.
If `data.id` is not undefined but has a value of 0 then the expression evaluates to false.
Right now, that wasn't the intended usage.
Using this change to also export some types from Client.
Reviewed By: passy
Differential Revision: D30069746
fbshipit-source-id: 04a8d161efceadf7a38ee556be70c15b45c11056
Summary: The markdown bump required ignoring another prop, the rest was smooth.
Reviewed By: timur-valiev
Differential Revision: D30067682
fbshipit-source-id: 6038ffe29d2e0041c81bac132eed747cbfe40f54
Summary:
- Minor change on Diff - D30040808
- Removed cyclic dependancy on AppSelector
- Previous dependancy chain : AppSelector -> TroubleshootingGuide -> AppSelector
- Now the NoDevices component that troubleshooting guide was importing has been moved to an independent file.
Reviewed By: passy
Differential Revision: D30041820
fbshipit-source-id: 17856aad7d2a569ec4e0f19e63f458472b22dcf8
Summary:
- Added a troubleshooting guide button which on clicking will open the expert chat bot system of flipper. ( Will be implemented in future diffs)
- This has been added only in the internal version of flipper available to FB.
- The public version shall continue to link to the troubleshooting guide for now.
- Also a new gatekeeper flipper_self_sufficiency was set up.
- This currently gives access to ongoing changes only to a few team members.
- In the future access shall be extended to the entire team, followed by the entire org and then finally all internal FB users in the final stages of the project.
Reviewed By: passy
Differential Revision: D29993355
fbshipit-source-id: afdb76baef6fde2c785c50ad6530ea2f76ce7284
Summary:
WebSocket implementation of ServerAdapter.
About the setup payload:
RSocket uses a setup payload sent by the client when the initial handshake takes place.
WebSocket handshake doesn't use one.
Instead, it is proposed to use the URL query string to embed any arguments that the server may require to correctly identify and verify a client.
This is the case for the existing Browser WebSocket server.
The only extra adjustment was made for the CSR, proposed to be Base64 encoded.
There's no particular reason to Base64 encode it, as it was already tested by simply escaping any necessary characters.
I feel Base64 adds a layer of simple obfuscation that although doesn't offer any security, it abstracts the content to the URL reader.
The only concern was about the URL maximum length. It seems to be accepted that URL lengths should be at most 2048 characters.
Also, it seems to be the case that the PEM encoded public key size is 451 characters.
That, combined with all the extra necessary arguments, the final URL seem to fit well within the 2048 characters limit.
Reviewed By: passy
Differential Revision: D30014341
fbshipit-source-id: f3e13754b9e513eb84473e45de03f9e101c73862
Summary:
This is the change that will pull the previous diffs together by making ServerController use the refactored components.
There are no logical changes.
The only additions are the ServerEventsListener interface implementation that re-use logic that was previously scattered around this same type.
Reviewed By: passy
Differential Revision: D29989270
fbshipit-source-id: 9ed7ff84ae8cd8ca46fad0db0737456eb705241c
Summary:
ServerController creates, configures, and contains any necessary servers to be used by Flipper.
ServerFactory is added as a means to abstract the creation of servers from it.
Reviewed By: passy
Differential Revision: D29987328
fbshipit-source-id: ff60a408710dbd51ea28ff27a9f85c0020741f4b
Summary:
Introduce a base class for WebSocket based servers and a Browser-based implementation which is in use by Kite.
The implementation for the Browser-based one is basically taken as is from ServerController but slightly adapted to match the existing interface.
As with the RSocket-based implementation, this diff doesn't put this implementation into use but is a good opportunity to revisit the existing implementation.
Reviewed By: passy
Differential Revision: D29985886
fbshipit-source-id: 32abba37ec31478b6497ef5cfe90bb9aedc282d3
Summary:
RSocket server which implements the ServerAdapter interface.
Most of the code was taken from the ServerController class with a few minor adjustments.
Once ServerController starts using ServerAdapter instances the code will be removed from there.
Reviewed By: fabiomassimo
Differential Revision: D29984578
fbshipit-source-id: e35e7635dff995314b3c1fbc85177f90384e025d
Summary:
Introduce ServerAdapter which should be used as a base class for different server implementations e.g. RSocket, WebSocket.
The type is not used elsewhere at this point but this is a good chance to look at the API and suggest changes and/or improvements.
Reviewed By: passy
Differential Revision: D29958434
fbshipit-source-id: 50ba46332d40e836b0a87bcf354d3237bf8fe7c5
Summary:
Extract the following utility functions from ServerController:
transformCertificateExchangeMediumToType
appNameWithUpdateHint
The functions are not tied to the ServerController and will be used outside of it.
Reviewed By: passy
Differential Revision: D29938355
fbshipit-source-id: ea489f54a3a6bf46ae4e108579d48ede1f891093
Summary:
allow-large-files
Got a ton of open bumps in GitHub. Want to address a bunch of them in one swoop.
Reviewed By: jknoxville, nikoant
Differential Revision: D29933570
fbshipit-source-id: d5dc18fab22e8c5b300ab318e60dd1514aecfd52
Summary:
Move BrowserClientFlipperConnection to a better location.
All communication types should be located inside the comms/ directory.
Reviewed By: jknoxville
Differential Revision: D29937942
fbshipit-source-id: 7fbf92c60d53a8f4f16d738bcbd6c451ce367ff1
Summary:
At the moment Flipper spawns a WebSocket server which can be used to debug Web applications in the Browser i.e. Kite.
This diff renames websocketClientFlipperConnection to BrowserClientFlipperConnection.
Renamed to make it clearer what type of connection it really is. WebSocket connections will no longer have the same meaning once RSocket is removed and WebSockets are used instead.
Reviewed By: jknoxville
Differential Revision: D29937656
fbshipit-source-id: 99d55fcfe256865add1ba3aada2c23f935f5cabe
Summary: TSC is raising this for a missing property.
Reviewed By: timur-valiev
Differential Revision: D29933795
fbshipit-source-id: 2acb3ea3b504f1bce1fb4bd0f7e4b52fd49e00b0
Summary:
FlipperClientConnection used to define an interface which closely matched the Socket interface defined in RSocket.
Presumably it tried to 'decouple' RSocket from consumers of the client socket connection. It also limited the amount of actions that could be triggered on said socket connection.
This diff does two things:
- Renames FlipperClientConnection to ClientConnection.
- Changes the interface so that it no longer matches the RSocket Socket interface. The new interface doesn't use RSocket reactive types either.
As a result, current implementations of the interface will act as a proxy to the RSocket Socket type. The change allows the usage of other implementations such as WebSocket.
Reviewed By: fabiomassimo
Differential Revision: D29934090
fbshipit-source-id: 02742e50cd6e801310698969c81b3bf1ef0fa2a2
Summary:
In the file server.tsx was defined the Server type.
Server is being renamed to ServerController and the new file is ServerController.tsx
This is the last diff where things are being moved or renamed in a way that will make harder to review future changes.
Reviewed By: fabiomassimo
Differential Revision: D29912626
fbshipit-source-id: ae583671d98823a10f7efceeefd8215621f59dcf
Summary:
A new comms/ directory is introduced which will contain all the communication code between client and server.
This change just moves server.tsx to its new location, it will make the next changes easier to follow.
Reviewed By: fabiomassimo
Differential Revision: D29911904
fbshipit-source-id: ae319dc8f9fd7af9d8b5b5c0ee87b56102cc0a18
Summary: When loading a Flipper trace, the loading dialog was no longer show. This diff fixes that.
Reviewed By: nikoant
Differential Revision: D29844892
fbshipit-source-id: 23d1f53962a3f64f93cc42127cd008c03486c14c
Summary: Introduce convenience abstractions to make it easier to manage dialogs imperatively, by promisyfying common dialog abstractions.
Reviewed By: jknoxville, nikoant
Differential Revision: D29790462
fbshipit-source-id: c092c15cf569ec353b9c1042f25cd67e6c76db01
Summary: This diff makes sure we can manually & unit tests deeplinks more easily, by introducing a dialog in which a deeplink can be entered manually and extracting deeplink handling logic from the application dispatcher.
Reviewed By: jknoxville
Differential Revision: D29760933
fbshipit-source-id: 0fc8f577204ecdd278716853b87786557a6e2194
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2609
Make it possible to mark some tests to run on non-CI, or unix only
Reviewed By: nikoant
Differential Revision: D29813506
fbshipit-source-id: 140f8a4eaed5af3282ab9d139b46a52818be0934
Summary:
Fix changelog display in dark mode, as reported in https://github.com/facebook/flipper/issues/2379#issuecomment-851059786
Changelog: Fix dark mode support in changelog dialog.
Reviewed By: timur-valiev
Differential Revision: D29801181
fbshipit-source-id: ffbbd012c99dee897c4fd67653b4f6375294d668
Summary:
Restored sidebar in Flipper messages plugin, by using a Container, as DetailsSidebar is only valid in a PluginContainer context.
Also made tab rendering a bit more condensed while at it.
Reviewed By: timur-valiev
Differential Revision: D29734639
fbshipit-source-id: d3ec6f354e14194035e93daa014985721844416d
Summary:
Some folks were missing the copy as text ManagedTable used to have, so introduced both the options to either copy as text (visible columns or custom copy handler) or as JSON
Changelog: It is now possible to both copy as text or as JSON from data tables
Reviewed By: jknoxville
Differential Revision: D29712096
fbshipit-source-id: 27bd2e869a247bd0896ce2774c08651123fd531d
Summary: As reported in https://fb.workplace.com/groups/flippersupport/permalink/1171595499987773/, the SupportForm doesn't support dark mode. Fixed this by fixing theming in some of the underlying deprecated components.
Reviewed By: timur-valiev
Differential Revision: D29694034
fbshipit-source-id: f8b90ecc87f7f16f6e1f9751d22309d37a052d5a
Summary: A bunch of dropdowns in Flipper are using native context menu to show their items. Rewrote to use Antd instead and reduce coupling with Electron
Reviewed By: timur-valiev
Differential Revision: D29694035
fbshipit-source-id: 5fd80c255c308567daf3e46e03bc27494c8ba142
Summary: Similarly to previous stack, remove the need to import Electron to write things to clipboard. Introduced linter to prevent future use.
Reviewed By: timur-valiev
Differential Revision: D29661777
fbshipit-source-id: 7bc67ede40b65c5f232b69128f3a423e232ddc1b
Summary:
This stack reduces our direct dependency on Electron, for example by exposing our own API to open links.
Also exposing `getFlipperLib` as API from `flipper-plugin`, so that these utility methods are available outside plugin contexts as well.
Reviewed By: timur-valiev
Differential Revision: D29661689
fbshipit-source-id: 0c0523326eeb0d9d8fbe3e03c4609327bb53596b
Summary: If no device/client was selected, no plugins would show up in the plugin status list either, which is very confusing. Changed this to always show all loaded plugins, regardless of selected device / app.
Reviewed By: nikoant
Differential Revision: D29661006
fbshipit-source-id: 720a1697df7ed17b00d5db5a72a8e2b6bb344b1e
Summary:
During component cleanup broke the error handling :'). Causing plugin errors to bubble up and be handled as chrome errors instead. This caused our soft crash metric to spike in the last week.
Changelog: Fixed error handling of UI errors caused by plugins
Reviewed By: passy
Differential Revision: D29585448
fbshipit-source-id: 4c5d40b300a7b71eeb532f7be4765f742d239890
Summary: Found some errors in a CI failure originating from a JavaScript file. The horror!
Reviewed By: jknoxville
Differential Revision: D29549998
fbshipit-source-id: 633100ec9a446050bb0c703dcc37e9b132b17198
Summary:
Going through all the patch updates and other small updates to pre-empt dependabot.
allow-large-files
Reviewed By: jknoxville
Differential Revision: D29547777
fbshipit-source-id: 86ef2408da0564049916cd96d66665074cdc23f2
Summary:
Fixed bug with "Hermes Debugger" and "React Dev Tools" plugin loading reported on GitHub: https://github.com/facebook/flipper/issues/2545.
Changelog: Fixed bug with React Native plugins not loaded: Hermes Debugger, React Dev Tools etc.
Reviewed By: mweststrate
Differential Revision: D29516394
fbshipit-source-id: 4620e3d2b49ca2a1d3a5b2dd76d40d4667a0980b
Summary:
Changelog: Flipper message debugging moved from a separate device to the console tab
This makes message debugging easier accessible, and in production (recently requested at GH). Also it clears up a lot of infra that was created just to make flipper a self recursive inspection device + a separate plugin. While fun, a hardcoded setup is just a bit more simpler (no exception rules and better static verification)
Reviewed By: nikoant
Differential Revision: D29487811
fbshipit-source-id: b412adc3ef5bd831001333443b432b6c0f934a5e
