3 Commits

Author	SHA1	Message	Date
John Knox	a480be90a2	Rename facebook::sonar namespace ... Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/271 Reviewed By: passy Differential Revision: D9861393 Pulled By: jknoxville fbshipit-source-id: d65f751c35028748915023f33f273d6ec45863c8	2018-09-18 07:27:28 -07:00
John Knox	afea2f63ec	Extract file system interaction from SonarWebSocketImpl ... Summary: SonarWebSocketImpl has got pretty bloated. So I'm extracting all the file interaction out of it into ConnectionContextStore. The purpose of this class is to provide all the context needed to establish a connection. This makes SonarWebSocketImpl more functional and therefore testable. Reviewed By: priteshrnandgaonkar Differential Revision: D9540089 fbshipit-source-id: 0cd1d69f2b11eaf9f569245a2da14f85cc140427	2018-09-03 11:12:28 -07:00
John Knox	a5af72a169	Reject null event base arguments ... Summary: If you use a null eventbase, folly implicitly decides which one to run the futures in, for example the timekeeper thread. The only component that passes in event bases is sonar.cpp. Reviewed By: priteshrnandgaonkar Differential Revision: D9539443 fbshipit-source-id: 7fd7289257c84b039a7ac00b14f78bb271262480	2018-09-03 11:12:28 -07:00