Lawrence Lomax
ccae37aa71
Extract idb device querying to IOSBridge
...
Summary:
Again this is just a code move for now.
However, we now have a common method between simctl and idb cases. This means that the next diff can call an `IOSBridge` with polymorpism taking over. This is still delegated out, but there's an argument to be made to move `iosUtil` functionality back so that this all lives in the same place.
Reviewed By: passy
Differential Revision: D33843093
fbshipit-source-id: 5cd884140817df851cccf63e5780582b16d4231c
2022-01-31 07:29:34 -08:00
Lawrence Lomax
aeb0b5f317
Extract getSimulators to IOSBridge
...
Summary:
Extracts `getSimulator` interrnals to `SimctlBridge`. This allows this functionality to be used independently of things like the the flipper server.
For now this just moves the functionality, but future diffs will build on top of this.
Reviewed By: passy
Differential Revision: D33842986
fbshipit-source-id: bae26a9bd5c21c9813f8a2b10c3b3e3efc1c5929
2022-01-31 07:29:34 -08:00
Lawrence Lomax
959a2a77d7
Extract launchSimulator to IOSBridge
...
Summary:
This is related to `simctl` functionality, so can be extracted there.
This will aid in future changes whereby we can hide `getDeviceSetPath` in the IOSBridge module
Reviewed By: passy
Differential Revision: D33842987
fbshipit-source-id: de292ce5afba3e7d79d8ba27c2b8852909d7e6f3
2022-01-31 07:29:34 -08:00
Anton Kastritskiy
48d43c7367
rename from ts to tsx in pkg and pkg-lib
...
Summary: mass rename files
Reviewed By: passy
Differential Revision: D33890034
fbshipit-source-id: 1c654a4f7f5b83eaa56a8c11df863003e8d7bed7
2022-01-31 06:22:56 -08:00
Anton Kastritskiy
844728d9dc
rename babel-transformer files from ts to tsx
...
Summary: group files rename
Reviewed By: passy
Differential Revision: D33889860
fbshipit-source-id: 888e173fc72b5e126c1e41324b6cae6be29274c5
2022-01-31 06:14:59 -08:00
Anton Kastritskiy
69bac4a3d6
Rename second batch for '.ts' files to '.tsx' in plugin-lib dir
...
Summary: Rename first batch for '.ts' files to '.tsx'
Reviewed By: passy
Differential Revision: D33843245
fbshipit-source-id: 28fd161e258e4d20200620b083aea48f9e58ea64
2022-01-31 06:08:28 -08:00
Anton Kastritskiy
75f874a5dd
error for I prefixed interface names
...
Summary: {gif:kosnw403}
Reviewed By: mweststrate
Differential Revision: D33845782
fbshipit-source-id: 2b9bd70e3b2d930e8f4cd8fe7976ac76f43b2496
2022-01-31 05:34:58 -08:00
Anton Kastritskiy
071bcaff96
Rename second batch for '.ts' files to '.tsx' in scripts dir
...
Summary: Rename first batch for '.ts' files to '.tsx'
Reviewed By: passy
Differential Revision: D33843246
fbshipit-source-id: eb8080db8cc3ef07820339bf8deafa208432de7c
2022-01-31 02:57:54 -08:00
Anton Kastritskiy
1aff8466b1
let linter handle type naming conventions
...
Summary: {gif:kosnw403}
Reviewed By: passy
Differential Revision: D33846715
fbshipit-source-id: 5de4bb0cf88f24f5a26acedb82a0816417fb0787
2022-01-31 02:49:09 -08:00
Flipper Bot
65bb2a1bc1
Flipper Release: v0.131.1
...
Summary: Releasing version 0.131.1
Reviewed By: cekkaewnumchai
Differential Revision: D33871323
fbshipit-source-id: f5f5b02ec9fdad303fe60673618b461ef3fa26f1
2022-01-29 11:32:40 -08:00
Anton Kastritskiy
b4fc108c2e
Rename first batch for '.ts' files to '.tsx' in doctor, static and test-utils
...
Summary: Rename first batch for '.ts' files to '.tsx'
Reviewed By: nikoant
Differential Revision: D33843051
fbshipit-source-id: 68dd2dc6538afce2daaf24c6412dc5db8b38acbc
2022-01-28 08:32:19 -08:00
Anton Kastritskiy
4c83fbb524
warn about ts file extension
...
Summary: remove statically analysable life from typescript guidelines and let eslint handle it
Reviewed By: passy
Differential Revision: D33819891
fbshipit-source-id: 3cc3cb512607c3651cd3a9e48228d83bab5bb64a
2022-01-28 05:43:46 -08:00
dependabot[bot]
e9da574720
Bump antd from 4.18.2 to 4.18.5 in /desktop ( #3346 )
...
Summary:
Bumps [antd](https://github.com/ant-design/ant-design ) from 4.18.2 to 4.18.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases ">antd's releases</a>.</em></p>
<blockquote>
<h2>4.18.5</h2>
<ul>
<li>Cascader
<ul>
<li>💄 Fix Cascader loading icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799 ">#33799</a></li>
<li>🐞 Fix Cascader not auto offset placement when popup is out of screen and fix active option out of screen not scroll. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777 ">#33777</a></li>
</ul>
</li>
<li>💄 Fix Tag style in dark theme. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751 ">#33751</a></li>
<li>💄 Fix disabled Checkbox inside Tooltip dom structure. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772 ">#33772</a> <a href="https://github.com/boomler "><code>@boomler</code></a></li>
<li>⚡ ️ Fix invalid hook dependency array in Row and Layout.Sider components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804 ">#33804</a> <a href="https://github.com/mrwd2009 "><code>@mrwd2009</code></a></li>
<li>🐞 Fix Card <code>ref</code> not working. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784 ">#33784</a> <a href="https://github.com/LongHaoo "><code>@LongHaoo</code></a></li>
<li>🐞 Fix a Checkbox problem that <code>onChange</code> could not correctly pass in the modified value when dynamically modifying <code>value</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753 ">#33753</a></li>
</ul>
<hr />
<ul>
<li>Cascader
<ul>
<li>🐞 修复 Cascader 弹层超出屏幕时不会自动偏移以及激活选项不会自动滚动到正确位置的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777 ">#33777</a></li>
<li>💄 修复 Cascader 加载中图标。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799 ">#33799</a></li>
</ul>
</li>
<li>💄 修复 Tag 在暗黑主题下的样式。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751 ">#33751</a></li>
<li>💄 修复 Tooltip 的子元素含有禁用态的 CheckBox 时可能引起的行为和样式异常。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772 ">#33772</a> <a href="https://github.com/boomler "><code>@boomler</code></a></li>
<li>⚡ ️ 优化 Row 和 Layout.Sider 的 hooks 依赖数组。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804 ">#33804</a> <a href="https://github.com/mrwd2009 "><code>@mrwd2009</code></a></li>
<li>🐞 修复 Card <code>ref</code> 不生效的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784 ">#33784</a> <a href="https://github.com/LongHaoo "><code>@LongHaoo</code></a></li>
<li>🐞 修复动态修改 Checkbox 的 <code>value</code> 时 <code>onChange</code> 不能正确传入修改后的值的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753 ">#33753</a></li>
</ul>
<h2>4.18.4</h2>
<ul>
<li>Typography
<ul>
<li>⚡ ️ Optimize Typography to use native css ellipsis when <code>tooltip</code> is configured. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669 ">#33669</a></li>
<li>🐞 Refactor Typography <code>ellipsis</code> logic to fix error when <code>children</code> use Context content. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725 ">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 Fix <code><Icon component={HomeOutlined} /></code> and <code><HomeOutlined /></code> not aligned. (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709 ">ant-design/ant-design#33709</a>)</li>
<li>🐞 Fix <code><Icon component={SyncOutlined} spin /></code> shake. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726 ">#33726</a> <a href="https://github.com/JX-Zhuang "><code>@JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 Fix the display effect for Input related components with <code>hidden</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735 ">#33735</a> <a href="https://github.com/fanerge "><code>@fanerge</code></a> <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706 ">#33706</a> <a href="https://github.com/hydraZty "><code>@hydraZty</code></a></li>
<li>🐞 Fix the warning in console for Input with <code>showCount</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686 ">#33686</a> <a href="https://github.com/whwangms "><code>@whwangms</code></a></li>
</ul>
</li>
<li>⚡ ️ Fix ConfigProvider and Anchor rerender unexpectedly. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723 ">#33723</a> <a href="https://github.com/mrwd2009 "><code>@mrwd2009</code></a></li>
<li>🐞 Fix the duplicate keys warning in console for Cascader. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649 ">#33649</a> <a href="https://github.com/dimbslmh "><code>@dimbslmh</code></a></li>
<li>🐞 Checkbox.Group support number and boolean as options element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678 ">#33678</a></li>
<li>🐞 Fix Form <code>validateMessages</code> bug in multiple ConfigProvider. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33705 ">#33705</a></li>
<li>🐞 Fix Steps the tail part would be hidden when type is navigation and labelPlacement is vertical. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33716 ">#33716</a> <a href="https://github.com/toSayNothing "><code>@toSayNothing</code></a></li>
<li>🐞 Fix Image has bottom blank style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33631 ">#33631</a> <a href="https://github.com/fanerge "><code>@fanerge</code></a></li>
<li>🐞 Fix TreeSelect with keyboard operation missing highlight issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33755 ">#33755</a></li>
<li>🇰🇭 Fix some translations for Khmer (km_KH). <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33738 ">#33738</a> <a href="https://github.com/vireakkeosokvibol "><code>@vireakkeosokvibol</code></a></li>
</ul>
<hr />
<ul>
<li>Typography
<ul>
<li>⚡ ️ 优化 Typography 在配置 <code>tooltip</code> 时优先使用原生省略样式以提升性能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669 ">#33669</a></li>
<li>🐞 重构 Typography <code>ellipsis</code> 逻辑以修复 <code>children</code> 如果消费上游 Context 会报错的问题。 <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725 ">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 修复 <code><Icon component={HomeOutlined} /></code> 和 <code><HomeOutlined /></code> 不对齐的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709 ">#33709</a></li>
<li>🐞 修复 <code><Icon component={SyncOutlined} spin /></code> 抖动的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726 ">#33726</a> <a href="https://github.com/JX-Zhuang "><code>@JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 修复 Input 相关组件设置 <code>hidden</code> 时的展示问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735 ">#33735</a> <a href="https://github.com/fanerge "><code>@fanerge</code></a>，<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706 ">#33706</a> <a href="https://github.com/hydraZty "><code>@hydraZty</code></a></li>
<li>🐞 修复 Input 传入 <code>showCount</code> 时控制台 warning 问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686 ">#33686</a> <a href="https://github.com/whwangms "><code>@whwangms</code></a></li>
</ul>
</li>
<li>⚡ ️ 修复 ConfigProvider 和 Anchor 的渲染函数多次运行的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723 ">#33723</a> <a href="https://github.com/mrwd2009 "><code>@mrwd2009</code></a></li>
<li>🐞 修复 Cascader 组件中出现重复 key 的控制台 warning 问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649 ">#33649</a> <a href="https://github.com/dimbslmh "><code>@dimbslmh</code></a></li>
<li>🐞 Checkbox.Group 的 <code>options</code> 支持数组中直接传入 number 和 boolean 类型。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678 ">#33678</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md ">antd's changelog</a>.</em></p>
<blockquote>
<h2>4.18.5</h2>
<p><code>2022-01-24</code></p>
<ul>
<li>Cascader
<ul>
<li>💄 Fix Cascader loading icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799 ">#33799</a></li>
<li>🐞 Fix Cascader not auto offset placement when popup is out of screen and fix active option out of screen not scroll. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777 ">#33777</a></li>
</ul>
</li>
<li>💄 Fix Tag style in dark theme. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751 ">#33751</a></li>
<li>💄 Fix disabled Checkbox inside Tooltip dom structure. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772 ">#33772</a> <a href="https://github.com/boomler "><code>@boomler</code></a></li>
<li>⚡ ️ Fix invalid hook dependency array in Row and Layout.Sider components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804 ">#33804</a> <a href="https://github.com/mrwd2009 "><code>@mrwd2009</code></a></li>
<li>🐞 Fix Card <code>ref</code> not working. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784 ">#33784</a> <a href="https://github.com/LongHaoo "><code>@LongHaoo</code></a></li>
<li>🐞 Fix a Checkbox problem that <code>onChange</code> could not correctly pass in the modified value when dynamically modifying <code>value</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753 ">#33753</a></li>
</ul>
<h2>4.18.4</h2>
<p><code>2022-01-18</code></p>
<ul>
<li>Typography
<ul>
<li>⚡ ️ Optimize Typography to use native css ellipsis when <code>tooltip</code> is configured. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669 ">#33669</a></li>
<li>🐞 Refactor Typography <code>ellipsis</code> logic to fix error when <code>children</code> use Context content. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725 ">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 Fix <code><Icon component={HomeOutlined} /></code> and <code><HomeOutlined /></code> not aligned. (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709 ">ant-design/ant-design#33709</a>)</li>
<li>🐞 Fix <code><Icon component={SyncOutlined} spin /></code> shake. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726 ">#33726</a> <a href="https://github.com/JX-Zhuang "><code>@JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 Fix the display effect for Input related components with <code>hidden</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735 ">#33735</a> <a href="https://github.com/fanerge "><code>@fanerge</code></a> <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706 ">#33706</a> <a href="https://github.com/hydraZty "><code>@hydraZty</code></a></li>
<li>🐞 Fix the warning in console for Input with <code>showCount</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686 ">#33686</a> <a href="https://github.com/whwangms "><code>@whwangms</code></a></li>
</ul>
</li>
<li>⚡ ️ Fix ConfigProvider and Anchor rerender unexpectedly. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723 ">#33723</a> <a href="https://github.com/mrwd2009 "><code>@mrwd2009</code></a></li>
<li>🐞 Fix the duplicate keys warning in console for Cascader. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649 ">#33649</a> <a href="https://github.com/dimbslmh "><code>@dimbslmh</code></a></li>
<li>🐞 Checkbox.Group support number and boolean as options element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678 ">#33678</a></li>
<li>🐞 Fix Form <code>validateMessages</code> bug in multiple ConfigProvider. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33705 ">#33705</a></li>
<li>🐞 Fix Steps the tail part would be hidden when type is navigation and labelPlacement is vertical. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33716 ">#33716</a> <a href="https://github.com/toSayNothing "><code>@toSayNothing</code></a></li>
<li>🐞 Fix Image has bottom blank style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33631 ">#33631</a> <a href="https://github.com/fanerge "><code>@fanerge</code></a></li>
<li>🐞 Fix TreeSelect with keyboard operation missing highlight issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33755 ">#33755</a></li>
<li>🇰🇭 Fix some translations for Khmer (km_KH). <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33738 ">#33738</a> <a href="https://github.com/vireakkeosokvibol "><code>@vireakkeosokvibol</code></a></li>
</ul>
<h2>4.18.3</h2>
<p><code>2022-01-10</code></p>
<ul>
<li>🆕 Menu support <code>home</code> and <code>end</code> keyboard navigate. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33642 ">#33642</a> <a href="https://github.com/dartamonov-vertex "><code>@dartamonov-vertex</code></a></li>
<li>Table
<ul>
<li>⚡ ️ Improve Table perfermance significantly when mount and unmount. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33554 ">#33554</a></li>
<li>🐞 Fix Table emptynode fixed display. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33610 ">#33610</a> <a href="https://github.com/hemengke1997 "><code>@hemengke1997</code></a></li>
<li>🐞 Fix Table tree data hover error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33638 ">#33638</a> <a href="https://github.com/LongHaoo "><code>@LongHaoo</code></a></li>
</ul>
</li>
<li>Form
<ul>
<li>🐞 Fix Form validateMessages is not correct in default locale. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33511 ">#33511</a></li>
<li>🐞 Fix Form.Item help with empty string makes layout shaking. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33644 ">#33644</a></li>
</ul>
</li>
<li>🐞 Fix Input.Textarea throws error on preact. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33536 ">#33536</a> <a href="https://github.com/developit "><code>@developit</code></a></li>
<li>🐞 Fix PageHeader state update error after unmounted. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33546 ">#33546</a> <a href="https://github.com/wuifdesign "><code>@wuifdesign</code></a></li>
<li>💄 Fix Select tag margin issue when using <code>tagRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33539 ">#33539</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="8217c544da✨ ): release 4.18.5 (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33822 ">#33822</a>)</li>
<li><a href="578aaad7f2ab8fc12fa7https://github-redirect.dependabot.com/ant-design/ant-design/issues/33758 ">#33758</a>)</li>
<li><a href="a65ba8aa8ahttps://github-redirect.dependabot.com/ant-design/ant-design/issues/33816 ">#33816</a>)</li>
<li><a href="e55a68670fhttps://github-redirect.dependabot.com/ant-design/ant-design/issues/33817 ">#33817</a>)</li>
<li><a href="fe23374871https://github-redirect.dependabot.com/ant-design/ant-design/issues/33804 ">#33804</a>)</li>
<li><a href="75adc23fe3https://github-redirect.dependabot.com/ant-design/ant-design/issues/33760 ">#33760</a>)</li>
<li><a href="9cf0dca8fchttps://github-redirect.dependabot.com/ant-design/ant-design/issues/33802 ">#33802</a>)</li>
<li><a href="5d2994ec12https://github-redirect.dependabot.com/ant-design/ant-design/issues/33799 ">#33799</a>)</li>
<li><a href="6dd39c1f89https://github-redirect.dependabot.com/ant-design/ant-design/issues/33772 ">#33772</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/ant-design/ant-design/compare/4.18.2...4.18.5 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3346
Reviewed By: aigoncharov
Differential Revision: D33741775
Pulled By: lblasa
fbshipit-source-id: 82e770ed1c09d3a7f9d71a950014d3555c9367fd
2022-01-28 03:09:50 -08:00
Lawrence Lomax
2573462cec
Use provided idb path in iOSBridge idb execs
...
Summary:
We pass the `idbPath` to only the log listener function, when in reality it should be used by all of these functions that call out to idb.
This could result in some bizzare inconsistencies where some idb functions to fail as they are not using the supplied path
Reviewed By: passy
Differential Revision: D33818298
fbshipit-source-id: f0fb7f26579c646a0d5265364d539dfded711c2e
2022-01-28 00:35:23 -08:00
Lawrence Lomax
e2abe1c89a
Separate concerns of reading screenshot into buffer & execing screenshot function
...
Summary: This allows us to change the way that the command is itself exec'd (for instance to change the idb exec'ing in D33818298)
Reviewed By: passy
Differential Revision: D33818822
fbshipit-source-id: c90b7e58c7476f5db08da0e74e9791230ff97f6f
2022-01-28 00:35:23 -08:00
Lawrence Lomax
4f886448e0
Move simctl iOSBridge free-functions into class
...
Summary: Similar to D33818267, but for simctl. Brings logical ordering of methods as well as consistency
Reviewed By: passy
Differential Revision: D33818687
fbshipit-source-id: 3fbcea128d06c900b49b83ad583ec8a7a07cae2c
2022-01-28 00:35:23 -08:00
Lawrence Lomax
1e5a070dbd
Move idb iOSBridge free-functions into class
...
Summary:
This isn't that important right now, but will help as the `IOSBridge` is expanded in the future. There's also an argument for logical ordering of functions within a container (a class!), but that's not the real motivation here.
The existence of `bind` shows that this free function is effectively closing over this argument anyway.
Reviewed By: passy, lblasa
Differential Revision: D33818267
fbshipit-source-id: e7b83f013121cedbd31cb28746b69c1fa76a0803
2022-01-28 00:35:23 -08:00
dependabot[bot]
08c09e6c6e
Bump socket.io-client from 4.4.0 to 4.4.1 in /desktop ( #3347 )
...
Summary:
Bumps [socket.io-client](https://github.com/socketio/socket.io-client ) from 4.4.0 to 4.4.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io-client/releases ">socket.io-client's releases</a>.</em></p>
<blockquote>
<h2>4.4.1</h2>
<p>This release only contains minor changes. Please see the diff for more details.</p>
<h4>Links:</h4>
<ul>
<li>Diff: <a href="https://github.com/socketio/socket.io-client/compare/4.4.0...4.4.1 ">https://github.com/socketio/socket.io-client/compare/4.4.0...4.4.1 </a></li>
<li>Server release: <a href="https://github.com/socketio/socket.io/releases/tag/4.4.1 ">4.4.1</a></li>
<li>engine.io-client version: <code>~6.1.1</code></li>
<li>ws version: <code>~8.2.3</code></li>
</ul>
<p>Size of the bundles:</p>
<table>
<thead>
<tr>
<th></th>
<th>min</th>
<th>min+gzip</th>
</tr>
</thead>
<tbody>
<tr>
<td>socket.io.min.js</td>
<td>40.4 KB (-)</td>
<td>13.1 KB (-)</td>
</tr>
<tr>
<td>socket.io.msgpack.min.js</td>
<td>45.6 KB (-)</td>
<td>14.2 KB (-)</td>
</tr>
<tr>
<td>socket.io.esm.min.js</td>
<td>33.1 KB (-)</td>
<td>11.3 KB (-)</td>
</tr>
</tbody>
</table>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io-client/blob/master/CHANGELOG.md ">socket.io-client's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/socketio/socket.io-client/compare/4.4.0...4.4.1 ">4.4.1</a> (2022-01-06)</h2>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="359d1e25e7f56fdd0f0919836d9abfhttps://github.com/socketio/socket.io-client/compare/4.4.0...4.4.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3347
Reviewed By: mweststrate
Differential Revision: D33741779
Pulled By: lblasa
fbshipit-source-id: ab87f191dab7d1835005f07ea89ded7890f6f649
2022-01-27 07:22:35 -08:00
dependabot[bot]
9415bff254
Bump react-virtual from 2.10.0 to 2.10.4 in /desktop ( #3343 )
...
Summary:
Bumps [react-virtual](https://github.com/tannerlinsley/react-virtual ) from 2.10.0 to 2.10.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/tannerlinsley/react-virtual/releases ">react-virtual's releases</a>.</em></p>
<blockquote>
<h2>v2.10.4</h2>
<h2><a href="https://github.com/tannerlinsley/react-virtual/compare/v2.10.3...v2.10.4 ">2.10.4</a> (2022-01-21)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><code>totalSize</code> should be <code>paddingStart</code> + <code>paddingEnd</code> when size is 0 (<a href="https://github-redirect.dependabot.com/tannerlinsley/react-virtual/issues/238 ">https://github.com/facebook/flipper/issues/238 </a>) (<a href="5300e47ea5https://github.com/tannerlinsley/react-virtual/compare/v2.10.2...v2.10.3 ">2.10.3</a> (2022-01-20)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>types:</strong> Move options interface definition to separated interface and export it (<a href="https://github-redirect.dependabot.com/tannerlinsley/react-virtual/issues/178 ">https://github.com/facebook/flipper/issues/178 </a>) (<a href="df4723cf72https://github.com/tannerlinsley/react-virtual/compare/v2.10.1...v2.10.2 ">2.10.2</a> (2022-01-20)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>increment patch to fix breaking change (<a href="7a799a2f405300e47ea5https://github-redirect.dependabot.com/tannerlinsley/react-virtual/issues/238 ">https://github.com/facebook/flipper/issues/238 </a>)</li>
<li><a href="bc21ad14ffdf4723cf7275417452c7https://github-redirect.dependabot.com/tannerlinsley/react-virtual/issues/169 ">https://github.com/facebook/flipper/issues/169 </a>)</li>
<li><a href="7a799a2f406a748a69146056d1d8197f88ae6f23https://github.com/tannerlinsley/react-virtual/compare/v2.10.0...v2.10.4 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3343
Reviewed By: mweststrate
Differential Revision: D33741758
Pulled By: lblasa
fbshipit-source-id: 84edbb7cc1a4a80c1967c97eebe5732000ebc76d
2022-01-27 07:22:34 -08:00
dependabot[bot]
1262ee05f1
Bump react-debounce-render from 7.0.0 to 7.0.1 in /desktop ( #3351 )
...
Summary:
Bumps [react-debounce-render](https://github.com/podefr/react-debounce-render ) from 7.0.0 to 7.0.1.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/podefr/react-debounce-render/commits ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3351
Reviewed By: mweststrate
Differential Revision: D33741785
Pulled By: lblasa
fbshipit-source-id: 4ceee9922dd80ec2ec47b9826fd8da09cd551122
2022-01-27 05:22:43 -08:00
Simek
f08bcb2a2c
tweak dark mode theme colors, improve LeftRail UI ( #3335 )
...
Summary:
Currently the design of `LeftRail` varies a bit between light and dark modes. Additionally washed background color is hard to differentiate from the main background color in comparison to the light theme (See `LeftRail` sidebars toggle buttons background for example). This lead to few contrast related issues, for example the hover effect on the WelcomeScreen elements is not visible in dark mode.
The PR tweaks the dark mode theme colors and fixes the unnecessary background of Settings icon in dark mode.
I have also spotted that icon `hover` effect is not working when icon has a badge (pure dot or count), I might have an idea how to fix this and I will push another PR for that. 🙂
## Changelog
* tweak dark mode theme colors, improve LeftRail UI
Pull Request resolved: https://github.com/facebook/flipper/pull/3335
Test Plan:
The change has been testes by running the desktop Flipper app locally from source.
## Preview (before & after)
<img width="390" alt="Screenshot 2022-01-24 at 13 37 20" align="left" src="https://user-images.githubusercontent.com/719641/150784627-36e222a8-e53e-4409-ab72-783d4a594f8e.png ">
<img width="390" alt="Screenshot 2022-01-24 at 13 46 08" src="https://user-images.githubusercontent.com/719641/150785438-bb496adf-83ab-4b1c-928d-07f4b0098f1a.png ">
Reviewed By: antonk52
Differential Revision: D33741513
Pulled By: lblasa
fbshipit-source-id: ef187db0725ac2b04c09b7f06823e713b50be88f
2022-01-27 04:45:19 -08:00
Flipper Bot
1fee833de6
Flipper Release: v0.131.0
...
Summary: Releasing version 0.131.0
Reviewed By: cekkaewnumchai
Differential Revision: D33814533
fbshipit-source-id: fde9830a063c99c5735cc66a0a2a614905c4335d
2022-01-27 04:45:18 -08:00
Lawrence Lomax
be451e15d9
Use demandOption instead of explicit checks of args
...
Summary: `yargs` supports this
Reviewed By: passy
Differential Revision: D33812132
fbshipit-source-id: d7846222f140fc32035824fe035737ae9ae2780e
2022-01-27 03:22:30 -08:00
Lawrence Lomax
85d1b060c7
Match on device serial as well as title
...
Summary: Device UDID/serial is necessary for matching uniquely. It's certainly possible to connect more than one of the same phone model, or have multiple iOS Sims with the same model and different OS versions.
Reviewed By: nikoant
Differential Revision: D33793569
fbshipit-source-id: aabd31a5b86c78a85aa867c6fa34d92f411fcb6e
2022-01-27 01:22:51 -08:00
Andrey Goncharov
e0204486a5
Fix stale idbConfig and adb in CertificateProvider
...
Summary: CertificateProvider initializes too early, and set abd and idb to undefined, before adb and idb are initialized by android and ios manager.
Reviewed By: lawrencelomax
Differential Revision: D33792854
fbshipit-source-id: b6bba32dead7edf62e360b2e2563f2b67243b1b8
2022-01-26 10:23:45 -08:00
Flipper Bot
66478d3e11
Flipper Release: v0.130.0
...
Summary: Releasing version 0.130.0
Reviewed By: cekkaewnumchai
Differential Revision: D33788026
fbshipit-source-id: bed50ad4001a40d899c673547dac16c8aef8aa1d
2022-01-26 07:51:52 -08:00
Simek
903476bdad
use centered prop for variable height modals ( #3334 )
...
Summary:
Currently all of the modals are displayed using default positioning, which works fine for small modals and large app windows, but it cause small UI/UX issues (double scroll bars) when app window is quite small.
Adding [`centered` prop](https://ant.design/components/modal/#API ) for variable height modals improves this situation a bit, but it also changes a bit the modal position when using maximised window, but I think this is bearable looking at improvements gained when window size is reduced.
## Changelog
* use `centered` prop for variable height modals to improve UI in small app window
Pull Request resolved: https://github.com/facebook/flipper/pull/3334
Test Plan:
The change has been testes by running the desktop Flipper app locally from source.
## Preview (before & after)
#### Small App Window
<img width="390" alt="Screenshot 2022-01-24 at 11 58 40" align="left" src="https://user-images.githubusercontent.com/719641/150771900-cb25d110-82c7-4ba9-8ee5-07a093c4f702.png ">
<img width="390" alt="Screenshot 2022-01-24 at 11 58 37" src="https://user-images.githubusercontent.com/719641/150771911-c81592ac-1eba-4112-86ad-9549e6248239.png ">
<img width="390" alt="Screenshot 2022-01-24 at 12 00 13" align="left" src="https://user-images.githubusercontent.com/719641/150772045-de37c432-4381-4207-8476-5f142dfb6fa5.png ">
<img width="390" alt="Screenshot 2022-01-24 at 12 00 10" src="https://user-images.githubusercontent.com/719641/150772057-574cf6cd-6f1a-4ca2-a343-b8fd6342eddb.png ">
#### Maximised App Window
<img width="390" alt="Screenshot 2022-01-24 at 12 12 12" align="left" src="https://user-images.githubusercontent.com/719641/150772777-8ac3cb59-3b41-4dcb-9554-137e95857af8.png ">
<img width="390" alt="Screenshot 2022-01-24 at 12 12 29" src="https://user-images.githubusercontent.com/719641/150772758-ca9f8c20-d6d0-412d-9067-7e756da0b56c.png ">
Reviewed By: mweststrate
Differential Revision: D33741484
Pulled By: lblasa
fbshipit-source-id: 0c3ca883d051cf4fcce9f9c1b6688974b66fd0d8
2022-01-26 04:23:05 -08:00
Andrey Goncharov
da618fd3f3
Decouple CertificateProvider and adb/idb client intialization
...
Summary:
Previously CertificateProvider initialized ADB and provided config to IDB. As result, AndroidDeviceManager and iOSDeviceManager indirectly depended on CertificateProvider.
With this diff we:
1. Make idbConfig resemble adbClient.
2. Make AndroidDeviceManager and iOSDeviceManager initialize their own clients
3. Fix server crash when one of the clients couldn't be initialized. The reason for the crash is CertificateProvider.prototype.init which is no longer needed.
Reviewed By: passy
Differential Revision: D33711652
fbshipit-source-id: 055b5625ed993827b65396f4af5157808479242b
2022-01-26 04:23:05 -08:00
Brian Vaughn
639df5c81a
React DevTools 4.22.1 -> 4.23.0
...
Summary:
Update `react-devtools-core` and `react-devtools` dependencies for RN, VSCode, Flipper, etc.
`js1 upgrade react-devtools -v 4.23.0`
# Changelog:
[General][Changed] - Upgraded react-devtools-core dependency to 4.23.0
Reviewed By: lunaruan
Differential Revision: D33752754
fbshipit-source-id: 81d123e058d5660b3b7c34823d15272b34d6c0b6
2022-01-25 18:23:06 -08:00
Lorenzo Blasa
c1a05c0366
Bump node-fetch 2.6.7
...
Summary: ^
Reviewed By: nikoant
Differential Revision: D33767745
fbshipit-source-id: c1ed481e140e88f7d7917e572430d14fcd5fa057
2022-01-25 10:22:59 -08:00
dependabot[bot]
493915bc8d
Bump dotenv from 8.2.0 to 14.2.0 in /desktop ( #3344 )
...
Summary:
Bumps [dotenv](https://github.com/motdotla/dotenv ) from 8.2.0 to 14.2.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md ">dotenv's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/motdotla/dotenv/compare/v14.1.1...v14.2.0 ">14.2.0</a> (2022-01-17)</h2>
<h3>Added</h3>
<ul>
<li>Add <code>dotenv_config_override</code> cli option</li>
<li>Add <code>DOTENV_CONFIG_OVERRIDE</code> command line env option</li>
</ul>
<h2><a href="https://github.com/motdotla/dotenv/compare/v14.1.0...v14.1.1 ">14.1.1</a> (2022-01-17)</h2>
<h3>Added</h3>
<ul>
<li>Add React gotcha to FAQ on README</li>
</ul>
<h2><a href="https://github.com/motdotla/dotenv/compare/v14.0.1...v14.1.0 ">14.1.0</a> (2022-01-17)</h2>
<h3>Added</h3>
<ul>
<li>Add <code>override</code> option 🎉 (<a href="https://github-redirect.dependabot.com/motdotla/dotenv/pull/595 ">https://github.com/facebook/flipper/issues/595 </a>)</li>
</ul>
<h2><a href="https://github.com/motdotla/dotenv/compare/v14.0.0...v14.0.1 ">14.0.1</a> (2022-01-16)</h2>
<h3>Added</h3>
<ul>
<li>Log error on failure to load <code>.env</code> file (<a href="https://github-redirect.dependabot.com/motdotla/dotenv/pull/594 ">https://github.com/facebook/flipper/issues/594 </a>)</li>
</ul>
<h2><a href="https://github.com/motdotla/dotenv/compare/v13.0.1...v14.0.0 ">14.0.0</a> (2022-01-16)</h2>
<h3>Added</h3>
<ul>
<li><em>Breaking:</em> Support inline comments for the parser 🎉 (<a href="https://github-redirect.dependabot.com/motdotla/dotenv/pull/568 ">https://github.com/facebook/flipper/issues/568 </a>)</li>
</ul>
<h2><a href="https://github.com/motdotla/dotenv/compare/v13.0.0...v13.0.1 ">13.0.1</a> (2022-01-16)</h2>
<h3>Changed</h3>
<ul>
<li>Hide comments and newlines from debug output (<a href="https://github-redirect.dependabot.com/motdotla/dotenv/pull/404 ">https://github.com/facebook/flipper/issues/404 </a>)</li>
</ul>
<h2><a href="https://github.com/motdotla/dotenv/compare/v12.0.4...v13.0.0 ">13.0.0</a> (2022-01-16)</h2>
<h3>Added</h3>
<ul>
<li><em>Breaking:</em> Add type file for <code>config.js</code> (<a href="https://github-redirect.dependabot.com/motdotla/dotenv/pull/539 ">https://github.com/facebook/flipper/issues/539 </a>)</li>
</ul>
<h2><a href="https://github.com/motdotla/dotenv/compare/v12.0.3...v12.0.4 ">12.0.4</a> (2022-01-16)</h2>
<h3>Changed</h3>
<ul>
<li>README updates</li>
<li>Minor order adjustment to package json format</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="aeae434e5378996affef18b6e1ccdcfb38f298b4f1c38d5a67d1af7f8f2d5e922fea74https://github-redirect.dependabot.com/motdotla/dotenv/issues/596 ">https://github.com/facebook/flipper/issues/596 </a> from darkgl0w/bump</li>
<li><a href="1da837bdf5ec4b0fa0066b0d2eb604https://github.com/motdotla/dotenv/compare/v8.2.0...v14.2.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3344
Reviewed By: aigoncharov
Differential Revision: D33741763
Pulled By: lblasa
fbshipit-source-id: 7188e804d6230ec7504c8ff43a70463c7959d130
2022-01-25 04:23:37 -08:00
dependabot[bot]
3764b5aa2d
Bump immer from 9.0.7 to 9.0.12 in /desktop ( #3345 )
...
Summary:
Bumps [immer](https://github.com/immerjs/immer ) from 9.0.7 to 9.0.12.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/immerjs/immer/releases ">immer's releases</a>.</em></p>
<blockquote>
<h2>v9.0.12</h2>
<h2><a href="https://github.com/immerjs/immer/compare/v9.0.11...v9.0.12 ">9.0.12</a> (2022-01-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>produceWithPatches should not wrap result in Immutable, fixes <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/850 ">https://github.com/facebook/flipper/issues/850 </a>, <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/881 ">https://github.com/facebook/flipper/issues/881 </a> (<a href="d8f26362a9https://github.com/immerjs/immer/compare/v9.0.10...v9.0.11 ">9.0.11</a> (2022-01-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>incorrect patches for <code>delete</code> on arrays. Fixes <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/879 ">https://github.com/facebook/flipper/issues/879 </a> (<a href="d91a6597e9https://github.com/immerjs/immer/compare/v9.0.9...v9.0.10 ">9.0.10</a> (2022-01-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>No patches being generated for root primitive replacements. Fixes <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/888 ">https://github.com/facebook/flipper/issues/888 </a> (<a href="0f96270840https://github.com/immerjs/immer/compare/v9.0.8...v9.0.9 ">9.0.9</a> (2022-01-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>make sure produceWithPatches accepts promises (<a href="d80e823733https://github.com/immerjs/immer/compare/v9.0.7...v9.0.8 ">9.0.8</a> (2022-01-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>immerjs<a href="https://github-redirect.dependabot.com/immerjs/immer/issues/876 ">https://github.com/facebook/flipper/issues/876 </a> Ensure empty patch set for atomic set+delete on Map (<a href="https://github-redirect.dependabot.com/immerjs/immer/issues/878 ">https://github.com/facebook/flipper/issues/878 </a>) (<a href="e1409180ebd8f26362a9https://github-redirect.dependabot.com/immerjs/immer/issues/850 ">https://github.com/facebook/flipper/issues/850 </a>, <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/881 ">https://github.com/facebook/flipper/issues/881 </a></li>
<li><a href="feba5d1404d91a6597e9https://github-redirect.dependabot.com/immerjs/immer/issues/879 ">https://github.com/facebook/flipper/issues/879 </a></li>
<li><a href="0f96270840https://github-redirect.dependabot.com/immerjs/immer/issues/888 ">https://github.com/facebook/flipper/issues/888 </a></li>
<li><a href="d80e823733e1409180ebhttps://github-redirect.dependabot.com/immerjs/immer/issues/878 ">https://github.com/facebook/flipper/issues/878 </a>)</li>
<li>See full diff in <a href="https://github.com/immerjs/immer/compare/v9.0.7...v9.0.12 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3345
Reviewed By: antonk52
Differential Revision: D33741770
Pulled By: lblasa
fbshipit-source-id: 2f52bee684c99d171c1e3460825c557b027e8cf0
2022-01-25 03:30:52 -08:00
dependabot[bot]
0d1520bbec
Bump ws from 8.4.0 to 8.4.2 in /desktop ( #3354 )
...
Summary:
Bumps [ws](https://github.com/websockets/ws ) from 8.4.0 to 8.4.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/websockets/ws/releases ">ws's releases</a>.</em></p>
<blockquote>
<h2>8.4.2</h2>
<h1>Bug fixes</h1>
<ul>
<li>Fixed a data framing issue introduced in version 8.4.1 (<a href="https://github-redirect.dependabot.com/websockets/ws/issues/2004 ">https://github.com/facebook/flipper/issues/2004 </a>).</li>
</ul>
<h2>8.4.1</h2>
<h1>Notable changes</h1>
<ul>
<li>To improve performance, strings sent via <code>websocket.ping()</code>,
<code>websocket.pong()</code>, and <code>websocket.send()</code> are no longer converted to
<code>Buffer</code>s if the data does not need to be masked (<a href="https://github-redirect.dependabot.com/websockets/ws/issues/2000 ">https://github.com/facebook/flipper/issues/2000 </a>).</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="33fd1016ec0c0754b897https://github-redirect.dependabot.com/websockets/ws/issues/2004 ">https://github.com/facebook/flipper/issues/2004 </a>)</li>
<li><a href="6ebfeb8be75b7fbb0009https://github-redirect.dependabot.com/websockets/ws/issues/2000 ">https://github.com/facebook/flipper/issues/2000 </a>)</li>
<li><a href="8de448fbd191f3c07b26ad3fe6dc4f4081a368ffd2c935a477https://github-redirect.dependabot.com/websockets/ws/issues/1996 ">https://github.com/facebook/flipper/issues/1996 </a>)</li>
<li><a href="5edf1f4a1bhttps://github-redirect.dependabot.com/websockets/ws/issues/1994 ">https://github.com/facebook/flipper/issues/1994 </a>)</li>
<li>See full diff in <a href="https://github.com/websockets/ws/compare/8.4.0...8.4.2 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3354
Reviewed By: aigoncharov
Differential Revision: D33741798
Pulled By: lblasa
fbshipit-source-id: e8d43d2408118f6b19a2c59603b92c701100f355
2022-01-24 09:38:27 -08:00
Simek
1c91d28390
improve dev perf canvas readability ( #3333 )
...
Summary:
This PR updates the performance Canvas widgets readability in Dev mode.
Currently, for unknown for me reason, the text was rendered with stroke not fill, which results in blurry text.
Also the color of texts and plot in light mode have not enough contrast in comparison to the background. I have tried to use `theme` in there, but unfortunately the CSS variables are not available in the Canvas context and using those values leads to always black text.
## Changelog
* improve the performance canvas widgets readability in Development mode
Pull Request resolved: https://github.com/facebook/flipper/pull/3333
Test Plan:
The change has been testes by running the desktop Flipper app locally from source.
## Preview (before & after)
#### Dark Mode
<img width="189" alt="Screenshot 2022-01-23 at 17 46 20" align="left" src="https://user-images.githubusercontent.com/719641/150689046-28895487-d488-440f-9440-f792daeca86f.png ">
<img width="189" alt="Screenshot 2022-01-23 at 17 54 59" src="https://user-images.githubusercontent.com/719641/150689179-5ef96ca3-78e0-4995-b60c-317a87082604.png ">
#### Light Mode
<img width="189" alt="Screenshot 2022-01-23 at 17 46 27" align="left" src="https://user-images.githubusercontent.com/719641/150689061-a3264961-390a-4182-bd81-ba84b6e4979f.png ">
<img width="189" alt="Screenshot 2022-01-23 at 17 55 09" src="https://user-images.githubusercontent.com/719641/150689188-17efc7d9-7add-409e-af3b-befa5fbba0bc.png ">
Reviewed By: aigoncharov
Differential Revision: D33738722
Pulled By: lblasa
fbshipit-source-id: b992ecacd31bb6aa2a53885ca6dcc858fa510775
2022-01-24 08:52:22 -08:00
Andrey Goncharov
3349cb514f
Remove stale fs-extra dep from crash reporter plugin
...
Reviewed By: mweststrate
Differential Revision: D33740272
fbshipit-source-id: 6b1033a67a12a456301a2a7f8bdb9d7eab2f717c
2022-01-24 07:45:46 -08:00
Andrey Goncharov
0bb2b1680a
Remove stake fs-extra dep from cpu plugin
...
Reviewed By: antonk52
Differential Revision: D33740271
fbshipit-source-id: d64e684957714271286034edf3a2aa5ea9e404f3
2022-01-24 07:45:46 -08:00
Simek
1fef844878
fix ReleaseChannel info in WelcomeScreen in dark mode ( #3328 )
...
Summary:
This PR fixes the color of ReleaseChannel information in the WelcomeScreen, when user uses dark mode.
I have decided to switch to `textColorSecondary` instead of `textColorPrimary` to emphasise a bit more the information, but I can change it to the primary color if you think it will fit there better. Also the font size has been adjusted to match the paragraph font size.
## Changelog
* fix ReleaseChannel info in WelcomeScreen in dark mode
Pull Request resolved: https://github.com/facebook/flipper/pull/3328
Test Plan:
The change has been testes by running the desktop Flipper app locally from source.
## Preview
#### Dark Mode (before & after)
<img width="333" alt="Screenshot 2022-01-23 at 15 14 12" align="left" src="https://user-images.githubusercontent.com/719641/150682951-6e256054-d8d9-4293-8f76-4d67b654482f.png ">
<img width="333" alt="Screenshot 2022-01-23 at 15 09 58" src="https://user-images.githubusercontent.com/719641/150682954-942eda7a-443d-4ca1-be51-b6d0036548cd.png ">
#### Light Mode
<img width="333" alt="Screenshot 2022-01-23 at 15 22 42" src="https://user-images.githubusercontent.com/719641/150683094-62983788-646e-4745-b9c0-3c7f7bea9787.png ">
Reviewed By: aigoncharov
Differential Revision: D33738596
Pulled By: lblasa
fbshipit-source-id: 2fdd18871fbf9d1c215b58173932d57d5731948a
2022-01-24 06:10:03 -08:00
Simek
f1b83a96fd
do not add GrayedOutOverlay if there is no children ( #3329 )
...
Summary:
Do not add `GrayedOutOverlay` to the `ToggledSection` component if there is no children.
Current approach was causing UI issue in the Settings Modal in dark mode.
## Changelog
* do not add `GrayedOutOverlay` to the `ToggledSection` if there is no children
Pull Request resolved: https://github.com/facebook/flipper/pull/3329
Test Plan:
The change has been testes by running the desktop Flipper app locally from source.
## Preview (before & after)
<img width="390" alt="Screenshot 2022-01-23 at 15 32 29" align="left" src="https://user-images.githubusercontent.com/719641/150683689-d70f2af9-d835-4139-a8bb-a638aca9b8d3.png ">
<img width="390" alt="Screenshot 2022-01-23 at 15 32 12" src="https://user-images.githubusercontent.com/719641/150683692-86da3fba-5740-426e-96c7-6838632f42f0.png ">
Reviewed By: aigoncharov
Differential Revision: D33738627
Pulled By: lblasa
fbshipit-source-id: 12b028e3c7986a4fa196bac6f32a9efc19f1883d
2022-01-24 05:42:22 -08:00
Pascal Hartig
7135456434
Dep bump
...
Summary: Get ahead of dependabot by bundling a few small bumps.
Reviewed By: nikoant
Differential Revision: D33739602
fbshipit-source-id: 1482c062493a4214da81cbf5daf408aa382fb0ac
2022-01-24 04:57:29 -08:00
Simek
4b0091df0f
fix Plugins table UI glitch in dark mode, add column name ( #3332 )
...
Summary:
Same as Settings modal, the Plugin Manager table used in Plugins modal includes the UI glitch in dark mode due to overflow setting. This PR fixes that and also adds missing column caption in "Install Plugins" table.
I have chosen `Action` as a title but this can be altered, I have no strong preference in there. The goal was to improve the clarity and also improve the context menu content (where user can show/hide columns).
## Changelog
* fix Plugins table UI glitch in dark mode, add column name
Pull Request resolved: https://github.com/facebook/flipper/pull/3332
Test Plan:
The change has been testes by running the desktop Flipper app locally from source.
## Preview (before & after)
<img width="396" alt="Screenshot 2022-01-23 at 16 19 02" align="left" src="https://user-images.githubusercontent.com/719641/150685739-e2047e70-de14-4801-ac5a-0fc45a6ea476.png ">
<img width="396" alt="Screenshot 2022-01-23 at 16 19 31" src="https://user-images.githubusercontent.com/719641/150685735-3de8b7a2-ea3f-489a-b1f8-7af73f0a5225.png ">
Reviewed By: aigoncharov
Differential Revision: D33738705
Pulled By: lblasa
fbshipit-source-id: 704fe40f26d424c62a9bbc3e73132a0026f2e8b8
2022-01-24 03:56:59 -08:00
Simek
41950946a2
tweak Doctor modal footer UI, replace deprecated UI components ( #3331 )
...
Summary:
This PR fixes the unaligned checkbox in the Doctor modal (I have based the solution of the Settings modal code) and also replaces deprecated components `FlexRow` and `FlexColumn` in Settings modal.
## Changelog
* fix checkbox placement in the Doctor modal footer
Pull Request resolved: https://github.com/facebook/flipper/pull/3331
Test Plan:
The change has been testes by running the desktop Flipper app locally from source.
## Preview (before & after)
<img width="596" alt="Screenshot 2022-01-23 at 16 01 48" src="https://user-images.githubusercontent.com/719641/150685091-ce494847-eea6-4263-900a-2b5541d3d897.png ">
<img width="596" alt="Screenshot 2022-01-23 at 16 01 44" src="https://user-images.githubusercontent.com/719641/150685096-29723d14-6cfc-42aa-9564-431a61b1061d.png ">
Reviewed By: aigoncharov
Differential Revision: D33738683
Pulled By: lblasa
fbshipit-source-id: 900657d6cb095d6d32dd412205e714a46e64a564
2022-01-24 02:40:39 -08:00
Simek
d897cfd765
fix Settings modal UI glitch with overlow in dark mode ( #3330 )
...
Summary:
This small tweak fixes the Setting modal UI glitch (white rectangle in the bottom right) related to the modal content overflow setting.
## Changelog
* fix Settings modal UI glitch with content overflow setting in dark mode
Pull Request resolved: https://github.com/facebook/flipper/pull/3330
Test Plan:
The change has been testes by running the desktop Flipper app locally from source.
## Preview (before & after)
#### No scrollbar
<img width="390" alt="Screenshot 2022-01-23 at 15 45 47" align="left" src="https://user-images.githubusercontent.com/719641/150684278-b09031bd-9b8c-4c9c-9ac2-2dba3c1af63d.png ">
<img width="390" alt="Screenshot 2022-01-23 at 15 45 39" src="https://user-images.githubusercontent.com/719641/150684279-151b83d6-c819-45e0-a662-3d294f4f6a77.png ">
#### With scrollbar
<img width="390" alt="Screenshot 2022-01-23 at 15 51 40" align="left" src="https://user-images.githubusercontent.com/719641/150684331-a8f27623-9a2b-4ffe-b4c1-3fb06a6362a2.png ">
<img width="390" alt="Screenshot 2022-01-23 at 15 51 47" src="https://user-images.githubusercontent.com/719641/150684330-57434f21-0d4d-4ef6-be41-fdd88d082d1b.png ">
Reviewed By: aigoncharov
Differential Revision: D33738647
Pulled By: lblasa
fbshipit-source-id: f5a170950271302241a29d4382c481f2ce8bf4ec
2022-01-24 02:33:42 -08:00
almouro
3eb53f5987
Fix desktop template tests ( #3327 )
...
Summary:
When creating a brand new Flipper desktop plugin, the tests don't pass
### To Reproduce
```
npx flipper-pkg init
cd flipper-plugin-new
yarn jest
```
The test are not passing.
It would seem that we have 2 issues since this commit: e46fcba0b2 (diff-26467a831e67f87a2bd99be5b62a71a6e3e4e7f86135c11ccede9a02e58c44feR48)https://user-images.githubusercontent.com/4534323/150385278-29527a4d-4783-4902-aeea-986b3c634a29.png )
Adding:
```ts
// ts-ignore
global.electronRequire = require;
```
fixes the issue of course like [here](e46fcba0b2 (diff-a283d77d8667b28aec5319fe5671a91489485a683898efedf9441b816c84a447R15)https://user-images.githubusercontent.com/4534323/150385722-c0604cfc-33ef-4d8e-a8fd-d60042a87699.png )
This is because we now require `testing-library/react` on the fly: e46fcba0b2 (diff-26467a831e67f87a2bd99be5b62a71a6e3e4e7f86135c11ccede9a02e58c44feR198)071a6fdc1d/src/index.js (L12)https://github.com/facebook/flipper/pull/3327
Test Plan:
I've cloned the repo and run:
```
cd flipper/desktop/pkg
yarn
cd ../../..
./flipper/desktop/pkg/bin/run init
```
I run the tests on the newly package created and they're now good
## Side note
The fixes are not great, if you guys have better ones to suggest, really addressing the root cause of the issue, I'll happily close the PR
Also it's so easy to test desktop plugins with the awesome work you've done �, it'd be sad if the community could not totally benefit from it.
Since I had this issue before (https://github.com/facebook/flipper/pull/3039 ), I'd be really happy to help (if given some directions 🙏 ) set up a test to ensure a plugin generated is always well set up.
Reviewed By: passy
Differential Revision: D33713611
Pulled By: aigoncharov
fbshipit-source-id: 43834b30f24c2549d80923d2194487b9f9e6a1ae
2022-01-21 13:37:37 -08:00
Andrey Goncharov
b5cd33f7e8
Fix excessive error login for FLIPPER_BROWSER_PORT
...
Summary: Prior to this diff, an empty env var FLIPPER_BROWSER_PORT resulted in an error
Reviewed By: passy
Differential Revision: D33712720
fbshipit-source-id: 760fc92bbf44268ec428a3d2947735d5cf8567b7
2022-01-21 13:31:33 -08:00
Andrey Goncharov
f5b356cb2f
Remove dead code from GraghQL plugin
...
Summary: Did not find any usage of getQueryFromQueryId.tsx
Differential Revision: D33658515
fbshipit-source-id: 93f0a42ef30de158dbdb3d8d70559a87839522b0
2022-01-20 07:28:54 -08:00
Flipper Bot
ed2a643737
Flipper Release: v0.129.0
...
Summary: Releasing version 0.129.0
Reviewed By: lblasa
Differential Revision: D33655352
fbshipit-source-id: e783d5962b1ceb2e82df699ca52342e6176c837c
2022-01-20 04:56:21 -08:00
Pascal Hartig
cb6d9c9d90
Update antd patch
...
Summary: Result of `yarn patch-package antd` to mute the scary warning.
Reviewed By: antonk52
Differential Revision: D33660054
fbshipit-source-id: 9ee8aaecb9c2ed25722744c3b416ec2e32332002
2022-01-19 11:05:06 -08:00
dependabot[bot]
629bdbea3d
Bump socket.io from 4.4.0 to 4.4.1 in /desktop ( #3313 )
...
Summary:
Bumps [socket.io](https://github.com/socketio/socket.io ) from 4.4.0 to 4.4.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io/releases ">socket.io's releases</a>.</em></p>
<blockquote>
<h2>4.4.1</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>types:</strong> make <code>RemoteSocket.data</code> type safe (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4234 ">#4234</a>) (<a href="770ee5949fhttps://github-redirect.dependabot.com/socketio/socket.io/issues/4233 ">#4233</a>) (<a href="f2b8de7191https://github.com/socketio/socket.io/compare/4.4.0...4.4.1 ">https://github.com/socketio/socket.io/compare/4.4.0...4.4.1 </a></li>
<li>Client release: <a href="https://github.com/socketio/socket.io-client/releases/tag/4.4.1 ">4.4.1</a></li>
<li>engine.io version: <code>~6.1.0</code> (<a href="https://github.com/socketio/engine.io/compare/6.0.0...6.1.0 ">diff</a>)</li>
<li>ws version: <code>~8.2.3</code></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io/blob/master/CHANGELOG.md ">socket.io's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/socketio/socket.io/compare/4.4.0...4.4.1 ">4.4.1</a> (2022-01-06)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>types:</strong> make <code>RemoteSocket.data</code> type safe (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4234 ">#4234</a>) (<a href="770ee5949fhttps://github-redirect.dependabot.com/socketio/socket.io/issues/4233 ">#4233</a>) (<a href="f2b8de7191c82a4bdf1f770ee5949fhttps://github-redirect.dependabot.com/socketio/socket.io/issues/4234 ">#4234</a>)</li>
<li><a href="3bf5d92735fc82e44f73https://github-redirect.dependabot.com/socketio/socket.io/issues/4215 ">#4215</a>)</li>
<li><a href="c840bad43af2b8de7191https://github-redirect.dependabot.com/socketio/socket.io/issues/4233 ">#4233</a>)</li>
<li><a href="51784d0305c1966895457a70f63499https://github-redirect.dependabot.com/socketio/socket.io/issues/4189 ">#4189</a>)</li>
<li><a href="e5897dd7dchttps://github-redirect.dependabot.com/socketio/socket.io/issues/4195 ">#4195</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/socketio/socket.io/compare/4.4.0...4.4.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3313
Reviewed By: aigoncharov
Differential Revision: D33622435
Pulled By: passy
fbshipit-source-id: 5df288d3436c368bd6683f3b7186a2c9a1a2fc74
2022-01-18 06:10:48 -08:00
dependabot[bot]
b4f32a0f17
Bump algoliasearch from 4.11.0 to 4.12.0 in /desktop ( #3314 )
...
Summary:
Bumps [algoliasearch](https://github.com/algolia/algoliasearch-client-javascript ) from 4.11.0 to 4.12.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/algolia/algoliasearch-client-javascript/releases ">algoliasearch's releases</a>.</em></p>
<blockquote>
<h2>4.12.0</h2>
<h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.11.0...4.12.0 ">v4.12.0</a></h2>
<ul>
<li>feat(types): add reranking engine settings to types (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1378 ">https://github.com/facebook/flipper/issues/1378 </a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/e9c0f30 ">e9c0f30</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1378 ">https://github.com/facebook/flipper/issues/1378 </a></li>
<li>chore: clean up unused package and auto exports (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1315 ">https://github.com/facebook/flipper/issues/1315 </a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/dfa7254 ">dfa7254</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1315 ">https://github.com/facebook/flipper/issues/1315 </a></li>
<li>chore: Configure Renovate (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1304 ">https://github.com/facebook/flipper/issues/1304 </a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/f75924d ">f75924d</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1304 ">https://github.com/facebook/flipper/issues/1304 </a></li>
<li>chore: disable renovate until the test suite is less flaky (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1370 ">https://github.com/facebook/flipper/issues/1370 </a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/8c8db3d ">8c8db3d</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1370 ">https://github.com/facebook/flipper/issues/1370 </a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/algolia/algoliasearch-client-javascript/blob/master/CHANGELOG.md ">algoliasearch's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.11.0...4.12.0 ">v4.12.0</a></h2>
<ul>
<li>feat(types): add reranking engine settings to types (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1378 ">https://github.com/facebook/flipper/issues/1378 </a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/e9c0f30 ">e9c0f30</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1378 ">https://github.com/facebook/flipper/issues/1378 </a></li>
<li>chore: clean up unused package and auto exports (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1315 ">https://github.com/facebook/flipper/issues/1315 </a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/dfa7254 ">dfa7254</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1315 ">https://github.com/facebook/flipper/issues/1315 </a></li>
<li>chore: Configure Renovate (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1304 ">https://github.com/facebook/flipper/issues/1304 </a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/f75924d ">f75924d</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1304 ">https://github.com/facebook/flipper/issues/1304 </a></li>
<li>chore: disable renovate until the test suite is less flaky (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1370 ">https://github.com/facebook/flipper/issues/1370 </a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/8c8db3d ">8c8db3d</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1370 ">https://github.com/facebook/flipper/issues/1370 </a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="2c626a3dd5https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1379 ">https://github.com/facebook/flipper/issues/1379 </a>)</li>
<li><a href="e9c0f3073dhttps://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1378 ">https://github.com/facebook/flipper/issues/1378 </a>)</li>
<li><a href="8c8db3d1d6https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1370 ">https://github.com/facebook/flipper/issues/1370 </a>)</li>
<li><a href="f75924d4b3https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1304 ">https://github.com/facebook/flipper/issues/1304 </a>)</li>
<li><a href="dfa7254b1dhttps://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1315 ">https://github.com/facebook/flipper/issues/1315 </a>)</li>
<li>See full diff in <a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.11.0...4.12.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3314
Reviewed By: aigoncharov
Differential Revision: D33622434
Pulled By: passy
fbshipit-source-id: 8436ea8d0b7e5acfa40ebb2a51937334b5340f77
2022-01-18 06:10:48 -08:00
Andrey Goncharov
3865a3d9a2
Support a custom port for the insecure connection flow
...
Summary:
1. Remove GK.get('comet_enable_flipper_connection') which does not seem to be needed anymore
2. Support custom ports for the insecure connection flow
Reviewed By: lblasa
Differential Revision: D33632891
fbshipit-source-id: 045d6886ea94e15bff38f2f61c7d5a2c56c39859
2022-01-18 05:52:57 -08:00
