flipper

jens/flipper

Fork 0

Commit Graph

Author	SHA1	Message	Date
Oleksiy Ivanov	6924416de8	Fix for compilation error about missing virtual destructor in GCDQueue (#236 ) Summary: error: destructor called on non-final 'facebook::sonar::GCDQueue' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor] __data_.second().~_Tp(); Pull Request resolved: https://github.com/facebook/flipper/pull/236 Reviewed By: passy Differential Revision: D9351946 Pulled By: priteshrnandgaonkar fbshipit-source-id: 4718460ff587e1d5fa475a5f3bf115b1e2b5305f	2018-08-16 08:44:47 -07:00
Pritesh Nandgaonkar	0c60347593	Swift support for NetworkPlugin (#201 ) Summary: Solves #173 - [x] Add plugins in the sonarkit xcodeproj so that its easy to debug - [x] Get rid off the c++ in the headers - [x] Add example to hit network requests and validate Have a look at the screen shot below ✨⭐️⚡️ <img width="1677" alt="screen shot 2018-08-02 at 12 46 07 pm" src="https://user-images.githubusercontent.com/3865908/43581809-22efe4fe-9652-11e8-9424-f279d07c5c81.png"> Pull Request resolved: https://github.com/facebook/flipper/pull/201 Reviewed By: danielbuechele Differential Revision: D9132157 Pulled By: priteshrnandgaonkar fbshipit-source-id: 2b425506961f02eb2bf629c2bcab0da6e7ce5bb0	2018-08-06 12:43:13 -07:00
Daniel Büchele	fbbf8cf16b	Initial commit 🎉 fbshipit-source-id: b6fc29740c6875d2e78953b8a7123890a67930f2 Co-authored-by: Sebastian McKenzie <sebmck@fb.com> Co-authored-by: John Knox <jknox@fb.com> Co-authored-by: Emil Sjölander <emilsj@fb.com> Co-authored-by: Pritesh Nandgaonkar <prit91@fb.com>	2018-06-01 11:03:58 +01:00

Author

SHA1

Message

Date

Oleksiy Ivanov

6924416de8

Fix for compilation error about missing virtual destructor in GCDQueue (#236 )

Summary:
error: destructor called on non-final 'facebook::sonar::GCDQueue' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    __data_.second().~_Tp();
Pull Request resolved: https://github.com/facebook/flipper/pull/236

Reviewed By: passy

Differential Revision: D9351946

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 4718460ff587e1d5fa475a5f3bf115b1e2b5305f

2018-08-16 08:44:47 -07:00

Pritesh Nandgaonkar

0c60347593

Swift support for NetworkPlugin (#201 )

Summary:
Solves #173

- [x] Add plugins in the sonarkit xcodeproj so that its easy to debug
- [x] Get rid off the c++ in the headers
- [x] Add example to hit network requests and validate

Have a look at the screen shot below ✨⭐️⚡️

<img width="1677" alt="screen shot 2018-08-02 at 12 46 07 pm" src="https://user-images.githubusercontent.com/3865908/43581809-22efe4fe-9652-11e8-9424-f279d07c5c81.png">
Pull Request resolved: https://github.com/facebook/flipper/pull/201

Reviewed By: danielbuechele

Differential Revision: D9132157

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 2b425506961f02eb2bf629c2bcab0da6e7ce5bb0

2018-08-06 12:43:13 -07:00

Daniel Büchele

fbbf8cf16b

Initial commit 🎉

fbshipit-source-id: b6fc29740c6875d2e78953b8a7123890a67930f2
Co-authored-by: Sebastian McKenzie <sebmck@fb.com>
Co-authored-by: John Knox <jknox@fb.com>
Co-authored-by: Emil Sjölander <emilsj@fb.com>
Co-authored-by: Pritesh Nandgaonkar <prit91@fb.com>

2018-06-01 11:03:58 +01:00

3 Commits