flipper

jens/flipper

Fork 0

Commit Graph

Author	SHA1	Message	Date
Pascal Hartig	3a657ed46a	Use textContent for showing dev error message (#199 ) Summary: `innerHTML` seems unnecessarily dangerous, rendering unescaped content from the network in an execution context. It can also raise exceptions if the HTML received is invalid, so let's not do this? Pull Request resolved: https://github.com/facebook/flipper/pull/199 Reviewed By: danielbuechele Differential Revision: D9179150 Pulled By: passy fbshipit-source-id: 911b2686150be73c8e9e42b94b2a96da62fd6ae7	2018-08-06 05:42:30 -07:00
Daniel Büchele	fbbf8cf16b	Initial commit 🎉 fbshipit-source-id: b6fc29740c6875d2e78953b8a7123890a67930f2 Co-authored-by: Sebastian McKenzie <sebmck@fb.com> Co-authored-by: John Knox <jknox@fb.com> Co-authored-by: Emil Sjölander <emilsj@fb.com> Co-authored-by: Pritesh Nandgaonkar <prit91@fb.com>	2018-06-01 11:03:58 +01:00

Author

SHA1

Message

Date

Pascal Hartig

3a657ed46a

Use textContent for showing dev error message (#199 )

Summary:
`innerHTML` seems unnecessarily dangerous, rendering unescaped content from the network in an execution context. It can also raise exceptions if the HTML received is invalid, so let's not do this?
Pull Request resolved: https://github.com/facebook/flipper/pull/199

Reviewed By: danielbuechele

Differential Revision: D9179150

Pulled By: passy

fbshipit-source-id: 911b2686150be73c8e9e42b94b2a96da62fd6ae7

2018-08-06 05:42:30 -07:00

Daniel Büchele

fbbf8cf16b

Initial commit 🎉

fbshipit-source-id: b6fc29740c6875d2e78953b8a7123890a67930f2
Co-authored-by: Sebastian McKenzie <sebmck@fb.com>
Co-authored-by: John Knox <jknox@fb.com>
Co-authored-by: Emil Sjölander <emilsj@fb.com>
Co-authored-by: Pritesh Nandgaonkar <prit91@fb.com>

2018-06-01 11:03:58 +01:00

2 Commits