Commit Graph

27 Commits

Author SHA1 Message Date
Pascal Hartig
99a4884fad Bump Gradle plugin to 3.6.1 (#958)
Summary:
This is in line with the most recent stable Android Studio Release.
Pull Request resolved: https://github.com/facebook/flipper/pull/958

Test Plan:
Used it myself.

Open Source CI required a higher NDK, so let's first check what CI says to that internally now.

Reviewed By: jknoxville

Differential Revision: D20794634

Pulled By: passy

fbshipit-source-id: c32f934634b036ad3c1cad9fc49541e585d64329
2020-04-06 06:43:43 -07:00
Pascal Hartig
406f2f47af Fix DMG publish by running publish step on Ubuntu (#984)
Summary:
The current upload process is broken because the publish step only works on Linux.
This first uploads the binary to artifact storage, then downloads it on Linux and runs the publish step.

Pull Request resolved: https://github.com/facebook/flipper/pull/984

Test Plan:
@public

https://github.com/facebook/flipper/pull/984/checks?check_run_id=563996817

Everything here works apart from the publish action which throws a 400, which is expected as there's no tag/release associated with the PR. We can only really test the entire thing on a new release.

Reviewed By: nikoant

Differential Revision: D20868825

Pulled By: passy

fbshipit-source-id: 97304328ec7eb1243280ca7a9f26e8049869d33b
2020-04-06 06:21:11 -07:00
Anton Nikolaev
3e853157da Do not run tests for "doctor" and "pkg" separately (#983)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/983

This diff fixes broken test jobs on GitHub. Tests for all the packages are already being run by the "yarn test" in the root package, so I'm disabling running them separately.

Reviewed By: jknoxville

Differential Revision: D20868138

fbshipit-source-id: 04a86a8127481fecaee63af1f9fd9c7ad0f4269b
2020-04-06 04:53:26 -07:00
Pascal Hartig
7f91d07718 Fix dmg build (#929)
Summary:
Still had the old paths referenced.
Pull Request resolved: https://github.com/facebook/flipper/pull/929

Test Plan: Next release, I guess?

Reviewed By: nikoant

Differential Revision: D20669327

Pulled By: passy

fbshipit-source-id: e268259065df5a48336ec09b81776771e1124fd0
2020-03-26 06:49:58 -07:00
Anton Nikolaev
85c13bb1f3 Move desktop-related code to "desktop" subfolder (#872)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/872
Move all the JS code related to desktop app to "desktop" subfolder.

The structure of "desktop" folder:
- `src` - JS code of Flipper desktop app executing in Electron Renderer (Chrome) process. This folder also contains all the Flipper plugins in subfolder "src/plugins".
- `static` - JS code of Flipper desktop app bootstrapping executing in Electron Main (Node.js) process
- `pkg` - Flipper packaging lib and CLI tool
- `doctor` - Flipper diagnostics lib and CLI tool
- `scripts` - Build scripts for Flipper desktop app
- `headless` - Headless version of Flipper app
- `headless-tests` - Integration tests running agains Flipper headless version

Reviewed By: passy

Differential Revision: D20249304

fbshipit-source-id: 9a51c63b51b92b758a02fc8ebf7d3d116770efe9
2020-03-14 14:35:17 -07:00
Pascal Hartig
13841b1cf6 DMG build: Add missing yarn install
Summary: This happened: https://github.com/facebook/flipper/runs/496468216?check_suite_focus=true

Reviewed By: mweststrate

Differential Revision: D20361438

fbshipit-source-id: 5b9649ccabf8cc06fbdf28e5f7b45bd7fb5204a9
2020-03-10 03:41:13 -07:00
Pascal Hartig
31c9df92b8 Set up GitHub action for Doctor (#849)
Summary:
Action for Doctor.
Pull Request resolved: https://github.com/facebook/flipper/pull/849

Test Plan: Watch that box below turn green.

Reviewed By: mweststrate

Differential Revision: D20281213

Pulled By: passy

fbshipit-source-id: 87977c3f67605b4f4f080dd6ca7ab921b10a375b
2020-03-05 11:06:01 -08:00
Pascal Hartig
83807f12f6 Build mac dmg in Action (#869)
Summary:
`build --mac` no longer implies building the DMG so the upload step currently fails.
Pull Request resolved: https://github.com/facebook/flipper/pull/869

Reviewed By: mweststrate

Differential Revision: D20283002

Pulled By: passy

fbshipit-source-id: c255ae3a7e4e006e198b79ad8ce79cfd5e80b6a3
2020-03-05 10:48:05 -08:00
Pascal Hartig
ffefa0694e Remove "Expected Behavior" section from template (#871)
Summary:
This seems to only encourage snark. I've yet to see this being used productively.
Pull Request resolved: https://github.com/facebook/flipper/pull/871

Reviewed By: mweststrate

Differential Revision: D20283096

Pulled By: passy

fbshipit-source-id: 1f5d8553505eb41ef8d4000e55cacf510e46949b
2020-03-05 10:34:30 -08:00
Pascal Hartig
b923bcfdf1 Build and upload dmg on release (#852)
Summary:
We're no longer building this internally because it requires a Mac to build and we only use it in OSS.

Pull Request resolved: https://github.com/facebook/flipper/pull/852

Reviewed By: mweststrate

Differential Revision: D20250521

Pulled By: passy

fbshipit-source-id: c1691c62b2db3bc22cb0231040f593a35ec4f17e
2020-03-05 08:14:10 -08:00
Pascal Hartig
07f1ddb1c4 Disable lint pkg (#867)
Summary:
This is too aggressive right now.
Pull Request resolved: https://github.com/facebook/flipper/pull/867

Reviewed By: nikoant

Differential Revision: D20279641

Pulled By: passy

fbshipit-source-id: cdf1d65f0d4137ab689d228846e9c20ec1230b1a
2020-03-05 05:41:29 -08:00
Pascal Hartig
26a5a87158 Set up pkg GitHub Action (#848)
Summary:
Setting up another action for `flipper-pkg`.
Pull Request resolved: https://github.com/facebook/flipper/pull/848

Reviewed By: nikoant

Differential Revision: D20191654

Pulled By: passy

fbshipit-source-id: 18e8fd7f697fe9a7f11c85d13b50322cbd218d12
2020-03-03 09:24:23 -08:00
Pascal Hartig
887a8721c5 Upload dmg artifact on tag (#836)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/836

^

Reviewed By: nikoant

Differential Revision: D20139272

fbshipit-source-id: 0246b571399744b57aa8a222bbcad7238f52fe96
2020-02-27 12:28:13 -08:00
John Knox
51f62ff602 Fix artifact path in android-sample.yml (#820)
Summary:
This workflow is currently building the android app and then trying to upload the mac app (which isn't built) which is failing.

I think it should be uploading the android app instead.
Pull Request resolved: https://github.com/facebook/flipper/pull/820

Reviewed By: passy

Differential Revision: D20035055

Pulled By: jknoxville

fbshipit-source-id: 08367d464a045b47cf1b8b5395fd2151793a23cf
2020-02-24 02:16:59 -08:00
Pascal Hartig
a0cd6e3adb Build Android sample app with GitHub Actions (#810)
Summary:
Getting really pissed off with Travis and this has significantly shorter queue times.

Mind that this probably won't work until the Folly PR is merged.
Pull Request resolved: https://github.com/facebook/flipper/pull/810

Test Plan: CI

Reviewed By: mweststrate

Differential Revision: D19951126

Pulled By: passy

fbshipit-source-id: ed51ad5ec6d4df3a59784dbd31e7c1667593d04f
2020-02-19 04:36:21 -08:00
Pascal Hartig
b4fa7be97c Upload Flipper artifacts from GH Actions (#801)
Summary:
This makes testing and verifying of PRs much easier as you can directly download the resulting artifact from GitHub.

Close https://github.com/facebook/flipper/issues/796.
Pull Request resolved: https://github.com/facebook/flipper/pull/801

Test Plan: https://github.com/facebook/flipper/runs/446036416

Reviewed By: mweststrate

Differential Revision: D19903724

Pulled By: passy

fbshipit-source-id: 9efe37e93b2373d1ec98640496322ad85ea9a21b
2020-02-14 12:55:48 -08:00
Pascal Hartig
83c15219da Add gradle validation (#748)
Summary:
Copied from here: https://github.com/facebook/fresco/pull/2457

Our version is too old to have checksums available, so we first need to merge
https://github.com/facebook/flipper/pull/749.
Pull Request resolved: https://github.com/facebook/flipper/pull/748

Test Plan: GitHub

Reviewed By: mweststrate

Differential Revision: D19447711

Pulled By: passy

fbshipit-source-id: acd1752fa84c14804f0e1012e56763635127d926
2020-01-20 06:04:25 -08:00
Anton Nikolaev
5fd8db294a Add Windows to GitHub Actions CI matrix
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/741

Reviewed By: jknoxville

Differential Revision: D19371114

fbshipit-source-id: 07c6bd71e58011cc3fffa34354546eb773e3fc3d
2020-01-14 03:52:52 -08:00
Anton Nikolaev
5ea4c2211e Run github actions CI on pull requests
Reviewed By: passy

Differential Revision: D19371690

fbshipit-source-id: b15909ea9570cae21fcb27774b10e161bf0d8e98
2020-01-13 07:18:55 -08:00
Pascal Hartig
e50f900758 Build sample release build in Action
Summary: Build it on GitHub.

Reviewed By: jknoxville

Differential Revision: D18657328

fbshipit-source-id: a826bffbee2cb20690579c7ac4ee8f53dc976b6d
2019-11-26 05:30:33 -08:00
John Knox
33a63c9c5b Re-enable github actions (#655)
Summary:
This reverts commit 5bd0cd3d63 and adds back the github actions which were temporarily disabled.
Pull Request resolved: https://github.com/facebook/flipper/pull/655

Reviewed By: passy

Differential Revision: D18656754

Pulled By: jknoxville

fbshipit-source-id: 9dc9a9aa4224f996677ddfbaf37387ae0b066c56
2019-11-22 05:25:17 -08:00
Pascal Hartig
5bd0cd3d63 Remove workflows (#639)
Summary:
sadface

Hopefully this can be reverted quickly but right now we don't have
Actions support in our org and the failures here are causing all
sorts of downstream errors.
Pull Request resolved: https://github.com/facebook/flipper/pull/639

Test Plan: This PR

Reviewed By: cekkaewnumchai

Differential Revision: D18506405

Pulled By: passy

fbshipit-source-id: 325209d91b5d985772195703a3429e49700d7666
2019-11-15 02:55:32 -08:00
John Knox
9c5faa8e96 Add android sample apps to new releases (#615)
Summary:
Now on every new release, a sample app will be built and added to the Github release artifacts.

Adds a Github action to automatically build and attach the android sample app for every flipper release.
This will allow potential users to try out flipper without having to go to the trouble of building their own app.
Pull Request resolved: https://github.com/facebook/flipper/pull/615

Test Plan:
Tested on my private repo:
https://github.com/jknoxville/flipper/releases/tag/v0.1.john

Reviewed By: passy

Differential Revision: D18224747

Pulled By: jknoxville

fbshipit-source-id: 25d2905bd7539faa91974b23a33678168aef29d8
2019-10-30 11:23:28 -07:00
Pascal Hartig
1d7b194abb Run lint and build step (#583)
Summary:
This should just work, but let's see what CI says.
Pull Request resolved: https://github.com/facebook/flipper/pull/583

Reviewed By: jknoxville

Differential Revision: D17906598

Pulled By: passy

fbshipit-source-id: 5de686c8c9b23b101999da938d6e8f9baff7bc86
2019-10-14 08:37:36 -07:00
Pascal Hartig
85e0d8e965 Create nodejs workflow (#555)
Summary:
A very basic first workflow that we can extend to match what we currently have in Travis and hopefully remove that in the near future.
Pull Request resolved: https://github.com/facebook/flipper/pull/555

Test Plan: https://github.com/facebook/flipper/pull/555/checks?check_run_id=232330215

Reviewed By: danielbuechele

Differential Revision: D17525516

Pulled By: passy

fbshipit-source-id: c1ebc1af2260482cfa97faae99f3baa5d5b9046c
2019-09-23 03:29:30 -07:00
Pascal Hartig
c01edec88d Add issue templates
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/418

Reviewed By: danielbuechele

Differential Revision: D15120797

Pulled By: passy

fbshipit-source-id: 196aafe8f228a52bd20dc492c3754675259f389a
2019-04-29 08:24:00 -07:00
Pascal Hartig
4548aecefe Add PR template
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/422

Reviewed By: danielbuechele

Differential Revision: D15121695

Pulled By: passy

fbshipit-source-id: c33b426ed309f140ffe5b06c2e20b19abe6e655c
2019-04-29 08:15:20 -07:00