Commit Graph

4 Commits

Author SHA1 Message Date
Anton Nikolaev
a2e77f5da0 Patch metro to avoid erasing "process" global var
Summary:
Patch for "metro" to avoid erasing of "process" global var during bundling.

Also removed "process" babel transform for main Electron process which was also made to workaround the same issue with "process" being erased.

Reviewed By: mweststrate

Differential Revision: D22389153

fbshipit-source-id: 569882e20534eedfca45509b8efe0186d335c681
2020-07-06 03:09:41 -07:00
Michel Weststrate
89de3d4ae2 Disable require cycle warnings
Summary: The holier-than-thou warnings of metro about require cycles are annoying. Require cycles are generally speaking well handles by ESM, and cause only harm if modules themselves are stateful, which is a bad smell. But warning for every cycle is just a flooding of false positives and removes the insentive to drop actual warnings.

Reviewed By: jknoxville

Differential Revision: D21859908

fbshipit-source-id: 66ec9a619a3737ccab5b16d11be5623d1d97c9f6
2020-06-03 08:45:16 -07:00
Anton Nikolaev
ec7cbd7f14 Fixed the patch disabling warnings for cyclic dependencies inside node_modules
Summary: Fixed the patch disabling warnings for cyclic dependencies inside node_modules. It broke after I changed the way of bundling plugins.

Reviewed By: passy

Differential Revision: D21065488

fbshipit-source-id: f8891f007d14d2475df517b28452dc0b8346f113
2020-04-16 09:52:27 -07:00
Anton Nikolaev
627cc8fe7f Update Metro
Summary: Updated Metro to the latest version 0.59.0

Reviewed By: passy

Differential Revision: D21027614

fbshipit-source-id: 0b2c1c422dfed7e8426bb9a36c5626f3a96eb8f6
2020-04-15 03:59:38 -07:00