jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
6,740 Commits 1 Branch 0 Tags
9d390d08643b54df15224dd4713ce7bbb0abb38c
Commit Graph

2355 Commits

Author SHA1 Message Date
Andrey Goncharov
29f6d0e711 Add device-specific Certificate Providers 
Reviewed By: mweststrate

Differential Revision: D33821880

fbshipit-source-id: c75c71db4d7dc680f75cf41ba2d5dad009a5fd03
 2022-02-02 03:07:00 -08:00
Andrey Goncharov
b9aeaa9339 Enhance iOS device manager tests 
Reviewed By: lawrencelomax

Differential Revision: D33915694

fbshipit-source-id: fc4bfd30b8f504f2f242f94e61967ee68cc83100
 2022-02-02 03:07:00 -08:00
Andrey Goncharov
7bf89a840a Remove a circular dependency between KeytarManager and FlipperServerImpl 
Reviewed By: passy

Differential Revision: D33846051

fbshipit-source-id: c83f5609308ad732a02b2ee55466f5ed0918d733
 2022-02-02 03:07:00 -08:00
Andrey Goncharov
b1f19ecd68 Extract certificate utils 
Summary: Extract utilities for certificate server-side certificate handling

Reviewed By: lawrencelomax

Differential Revision: D33820263

fbshipit-source-id: 21f1a9ed5f3b83b8350151bdf6d8862aa0b18e8f
 2022-02-02 03:07:00 -08:00
Andrey Goncharov
e686766e5f Simplify CertificateProvider setup 
Summary:
Currently, certificateSetup is called in two places:
- processCertificateSigningRequest
- loadSecureServerConfig

`loadSecureServerConfig` is a mandatory step of Flipper server initialization ([ServerController.init](https://www.internalfb.com/code/flipper/[24785758018a2ffbd4751ad2b9093b5ef97c611d]/src/fbsource/xplat/sonar/desktop/flipper-server-core/src/comms/ServerController.tsx?lines=118)). Flipper cannot start without executing it.

As a result, calling `certificateSetup` in `processCertificateSigningRequest` always results in the early return.

This diff removes executing `certificateSetup` from `processCertificateSigningRequest`. Since it's called only during server setup (so only once), it no longer makes sense to use `didCertificateSetup`.

Next steps:
- Extract Android and iOS certificate utils. Remove the dependency on accessing adb/idb dynamically. See D33711652 (da618fd3f3).

Reviewed By: jknoxville

Differential Revision: D33817119

fbshipit-source-id: 675d1e2fe468782da458832c2e88259c92951fdb
 2022-02-02 03:06:59 -08:00
Anton Kastritskiy
05a3bb69dc rename left ts files to tsx and ban ts file extension 
Summary: mass files rename

Reviewed By: passy

Differential Revision: D33890304

fbshipit-source-id: c057ac9fe87dd7659597c85d640619b93e1ff0e6
 2022-02-01 12:38:45 -08:00
Lawrence Lomax
ed03f1b107 Use idb to record devices 
Summary:
`idb` has supported video recording on devices for quite some time now. We even have the implementation in `iOSDevice`, but it's currently unused.

As a result, we just need to remove the check within `iOSDevice` that the target is an "emulator" and it will use the `idb` implementation. Removing this check means that the button is now selectable within the UI.

Reviewed By: passy

Differential Revision: D33913383

fbshipit-source-id: b3d6b4c480c79b54f0d2c206c68092ab62bf71ed
 2022-02-01 04:57:16 -08:00
Lawrence Lomax
3a9c875e03 Avoid double recording in iOSDevice 
Summary: This should in theory never happen since the state of the recording is also managed within the UI. However, it's better to ensure that if `startRecording` is called twice, without calling `stopRecording` first it will error rather than leak a recording (the first process will still run but the object representing it is oprhaned)

Reviewed By: passy

Differential Revision: D33913298

fbshipit-source-id: f8fa6b0e4fdbdf4282633fa29a736d3e7dedf3bb
 2022-02-01 04:57:16 -08:00
Lawrence Lomax
7d34c86f78 Remove recording invariants 
Summary:
The state of the destination and the process are coupled together. As a result it makes sense to move these to an object type.

This prevents destination and process being independently settable. No change in behaviour, just a removal of invariants that need to be checked

Reviewed By: passy

Differential Revision: D33913213

fbshipit-source-id: ed18650cac4f72d40e82d20254674f7fa12cbb48
 2022-02-01 04:57:16 -08:00
Lawrence Lomax
a9b9a1bff4 Remove redundant xcodeCommandLineToolsDetected 
Summary: This is public but never read, no need for it to exist

Reviewed By: passy

Differential Revision: D33893097

fbshipit-source-id: aa423464f9cc0c35768a549fd5cb481784d8bcd6
 2022-02-01 00:44:34 -08:00
Lawrence Lomax
9cbdc3038f Remove mising iOS Bridge invariant in iOSDeviceManager 
Summary:
There's no need for us to have a property that can be undefined, since we can use the magic of *passing arguments* to achieve the same end result.

The unit test a bit more precarious, but it's left here for posterity or until we decide to kill it otherwise.

Reviewed By: passy

Differential Revision: D33892407

fbshipit-source-id: 3b499511189862e2265d8d6d29f849a7b813050e
 2022-02-01 00:44:34 -08:00
Lawrence Lomax
757b82757e Use polymorphic IOSBridge to perform iOS target listing 
Summary:
Bulding on the work from prior diffs we can use the created bridge directly. No need to have if statements calling out to sub-functions, just use the base type itself which will use the appropriate implementation.

There's no behavioural change here. Either idb was queried for sims/devices or simctl was queried for just sims, they were always mutually exclusive.

Reviewed By: passy

Differential Revision: D33842604

fbshipit-source-id: 0bf63ffc34368c70df31c105ea0ba5df941e72cc
 2022-02-01 00:44:34 -08:00
Lawrence Lomax
b0046c8ddb Check for xcode mismatch once and only once 
Summary:
We perform this *repeatedly* (every 2s!!!). Which is clearly excessive.

Let's perform this check once to avoid noise and a waste of system resources

Reviewed By: passy

Differential Revision: D33844194

fbshipit-source-id: 226dc9d67bb83b167afa8e28ade8e1911470ef8a
 2022-02-01 00:44:34 -08:00
Lawrence Lomax
e16662a28f Improve xcode version mismatch messaging 
Summary:
This runs in a very hot loop (which I will change shortly)

However, there's also some simplification that we can do here:
- Only look for `Simulator.app` processes instead of all the processes. This limits the amount of string comparison to do. If there's a `Simulator.app` running, then we know a sim is running for that Xcode.
- Use piping to extract the launch path of the process, instead of then regex'ing this out.
- Use a simpler substring match to determine if paths have a different start.

Reviewed By: passy

Differential Revision: D33891296

fbshipit-source-id: e37d5f260fc6c6113be9c5268b7c8cffb4057b9a
 2022-02-01 00:44:34 -08:00
Anton Kastritskiy
c5dd1fc350 rename files from ts to tsx in flipper-* packages 
Summary: mass files rename

Reviewed By: nikoant

Differential Revision: D33890252

fbshipit-source-id: d5afaa60af7340313a97d8e4967fe37f00abd9db
 2022-01-31 10:16:19 -08:00
Anton Kastritskiy
2476472344 eslint plugin files rename from ts to tsx 
Summary: mass rename files

Reviewed By: nikoant

Differential Revision: D33890201

fbshipit-source-id: ac73fb040519a566447981bad37b8c78878a5c3d
 2022-01-31 10:16:19 -08:00
Lawrence Lomax
ccae37aa71 Extract idb device querying to IOSBridge 
Summary:
Again this is just a code move for now.

However, we now have a common method between simctl and idb cases. This means that the next diff can call an `IOSBridge` with polymorpism taking over. This is still delegated out, but there's an argument to be made to move `iosUtil` functionality back so that this all lives in the same place.

Reviewed By: passy

Differential Revision: D33843093

fbshipit-source-id: 5cd884140817df851cccf63e5780582b16d4231c
 2022-01-31 07:29:34 -08:00
Lawrence Lomax
aeb0b5f317 Extract getSimulators to IOSBridge 
Summary:
Extracts `getSimulator` interrnals to `SimctlBridge`. This allows this functionality to be used independently of things like the the flipper server.

For now this just moves the functionality, but future diffs will build on top of this.

Reviewed By: passy

Differential Revision: D33842986

fbshipit-source-id: bae26a9bd5c21c9813f8a2b10c3b3e3efc1c5929
 2022-01-31 07:29:34 -08:00
Lawrence Lomax
959a2a77d7 Extract launchSimulator to IOSBridge 
Summary:
This is related to `simctl` functionality, so can be extracted there.

This will aid in future changes whereby we can hide `getDeviceSetPath` in the IOSBridge module

Reviewed By: passy

Differential Revision: D33842987

fbshipit-source-id: de292ce5afba3e7d79d8ba27c2b8852909d7e6f3
 2022-01-31 07:29:34 -08:00
Anton Kastritskiy
48d43c7367 rename from ts to tsx in pkg and pkg-lib 
Summary: mass rename files

Reviewed By: passy

Differential Revision: D33890034

fbshipit-source-id: 1c654a4f7f5b83eaa56a8c11df863003e8d7bed7
 2022-01-31 06:22:56 -08:00
Anton Kastritskiy
844728d9dc rename babel-transformer files from ts to tsx 
Summary: group files rename

Reviewed By: passy

Differential Revision: D33889860

fbshipit-source-id: 888e173fc72b5e126c1e41324b6cae6be29274c5
 2022-01-31 06:14:59 -08:00
Anton Kastritskiy
69bac4a3d6 Rename second batch for '.ts' files to '.tsx' in plugin-lib dir 
Summary: Rename first batch for '.ts' files to '.tsx'

Reviewed By: passy

Differential Revision: D33843245

fbshipit-source-id: 28fd161e258e4d20200620b083aea48f9e58ea64
 2022-01-31 06:08:28 -08:00
Anton Kastritskiy
75f874a5dd error for I prefixed interface names 
Summary: {gif:kosnw403}

Reviewed By: mweststrate

Differential Revision: D33845782

fbshipit-source-id: 2b9bd70e3b2d930e8f4cd8fe7976ac76f43b2496
 2022-01-31 05:34:58 -08:00
Anton Kastritskiy
071bcaff96 Rename second batch for '.ts' files to '.tsx' in scripts dir 
Summary: Rename first batch for '.ts' files to '.tsx'

Reviewed By: passy

Differential Revision: D33843246

fbshipit-source-id: eb8080db8cc3ef07820339bf8deafa208432de7c
 2022-01-31 02:57:54 -08:00
Anton Kastritskiy
1aff8466b1 let linter handle type naming conventions 
Summary: {gif:kosnw403}

Reviewed By: passy

Differential Revision: D33846715

fbshipit-source-id: 5de4bb0cf88f24f5a26acedb82a0816417fb0787
 2022-01-31 02:49:09 -08:00
Flipper Bot
65bb2a1bc1 Flipper Release: v0.131.1 
Summary: Releasing version 0.131.1

Reviewed By: cekkaewnumchai

Differential Revision: D33871323

fbshipit-source-id: f5f5b02ec9fdad303fe60673618b461ef3fa26f1
 2022-01-29 11:32:40 -08:00
Anton Kastritskiy
b4fc108c2e Rename first batch for '.ts' files to '.tsx' in doctor, static and test-utils 
Summary: Rename first batch for '.ts' files to '.tsx'

Reviewed By: nikoant

Differential Revision: D33843051

fbshipit-source-id: 68dd2dc6538afce2daaf24c6412dc5db8b38acbc
 2022-01-28 08:32:19 -08:00
Anton Kastritskiy
4c83fbb524 warn about ts file extension 
Summary: remove statically analysable life from typescript guidelines and let eslint handle it

Reviewed By: passy

Differential Revision: D33819891

fbshipit-source-id: 3cc3cb512607c3651cd3a9e48228d83bab5bb64a
 2022-01-28 05:43:46 -08:00
dependabot[bot]
e9da574720 Bump antd from 4.18.2 to 4.18.5 in /desktop (#3346) 
Summary:
Bumps [antd](https://github.com/ant-design/ant-design) from 4.18.2 to 4.18.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p>
<blockquote>
<h2>4.18.5</h2>
<ul>
<li>Cascader
<ul>
<li>💄 Fix Cascader loading icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li>
<li>🐞 Fix Cascader not auto offset placement when popup is out of screen and fix active option out of screen not scroll. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li>
</ul>
</li>
<li>💄 Fix Tag style in dark theme. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li>
<li>💄 Fix disabled Checkbox inside Tooltip dom structure. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@​boomler</code></a></li>
<li>⚡️ Fix invalid hook dependency array in Row and Layout.Sider components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 Fix Card <code>ref</code> not working. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
<li>🐞 Fix a Checkbox problem that <code>onChange</code> could not correctly pass in the modified value when dynamically modifying <code>value</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li>
</ul>
<hr />
<ul>
<li>Cascader
<ul>
<li>🐞 修复 Cascader 弹层超出屏幕时不会自动偏移以及激活选项不会自动滚动到正确位置的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li>
<li>💄 修复 Cascader 加载中图标。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li>
</ul>
</li>
<li>💄 修复 Tag 在暗黑主题下的样式。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li>
<li>💄 修复 Tooltip 的子元素含有禁用态的 CheckBox 时可能引起的行为和样式异常。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@​boomler</code></a></li>
<li>⚡️ 优化 Row 和 Layout.Sider 的 hooks 依赖数组。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 修复 Card <code>ref</code> 不生效的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
<li>🐞 修复动态修改 Checkbox 的 <code>value</code> 时 <code>onChange</code> 不能正确传入修改后的值的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li>
</ul>
<h2>4.18.4</h2>
<ul>
<li>Typography
<ul>
<li>⚡️ Optimize Typography to use native css ellipsis when <code>tooltip</code> is configured. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li>
<li>🐞 Refactor Typography <code>ellipsis</code> logic to fix error when <code>children</code> use Context content. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 Fix <code>&lt;Icon component={HomeOutlined} /&gt;</code> and <code>&lt;HomeOutlined /&gt;</code> not aligned. (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">ant-design/ant-design#33709</a>)</li>
<li>🐞 Fix <code>&lt;Icon component={SyncOutlined} spin /&gt;</code> shake. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@​JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 Fix the display effect for Input related components with <code>hidden</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a> <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@​hydraZty</code></a></li>
<li>🐞 Fix the warning in console for Input with <code>showCount</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@​whwangms</code></a></li>
</ul>
</li>
<li>⚡️ Fix ConfigProvider and Anchor rerender unexpectedly. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 Fix the duplicate keys warning in console for Cascader. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@​dimbslmh</code></a></li>
<li>🐞 Checkbox.Group support number and boolean as options element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li>
<li>🐞 Fix Form <code>validateMessages</code> bug in multiple ConfigProvider. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33705">#33705</a></li>
<li>🐞 Fix Steps the tail part would be hidden when type is navigation and labelPlacement is vertical. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33716">#33716</a> <a href="https://github.com/toSayNothing"><code>@​toSayNothing</code></a></li>
<li>🐞 Fix Image has bottom blank style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33631">#33631</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a></li>
<li>🐞 Fix TreeSelect with keyboard operation missing highlight issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33755">#33755</a></li>
<li>🇰🇭 Fix some translations for Khmer (km_KH). <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33738">#33738</a> <a href="https://github.com/vireakkeosokvibol"><code>@​vireakkeosokvibol</code></a></li>
</ul>
<hr />
<ul>
<li>Typography
<ul>
<li>⚡️ 优化 Typography 在配置 <code>tooltip</code> 时优先使用原生省略样式以提升性能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li>
<li>🐞 重构 Typography <code>ellipsis</code> 逻辑以修复 <code>children</code> 如果消费上游 Context 会报错的问题。 <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 修复 <code>&lt;Icon component={HomeOutlined} /&gt;</code> 和 <code>&lt;HomeOutlined /&gt;</code> 不对齐的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">#33709</a></li>
<li>🐞 修复 <code>&lt;Icon component={SyncOutlined} spin /&gt;</code> 抖动的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@​JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 修复 Input 相关组件设置 <code>hidden</code> 时的展示问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a>，<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@​hydraZty</code></a></li>
<li>🐞 修复 Input 传入 <code>showCount</code> 时控制台 warning 问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@​whwangms</code></a></li>
</ul>
</li>
<li>⚡️ 修复 ConfigProvider 和 Anchor 的渲染函数多次运行的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 修复 Cascader 组件中出现重复 key 的控制台 warning 问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@​dimbslmh</code></a></li>
<li>🐞 Checkbox.Group 的 <code>options</code> 支持数组中直接传入 number 和 boolean 类型。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p>
<blockquote>
<h2>4.18.5</h2>
<p><code>2022-01-24</code></p>
<ul>
<li>Cascader
<ul>
<li>💄 Fix Cascader loading icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li>
<li>🐞 Fix Cascader not auto offset placement when popup is out of screen and fix active option out of screen not scroll. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li>
</ul>
</li>
<li>💄 Fix Tag style in dark theme. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li>
<li>💄 Fix disabled Checkbox inside Tooltip dom structure. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@​boomler</code></a></li>
<li>⚡️ Fix invalid hook dependency array in Row and Layout.Sider components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 Fix Card <code>ref</code> not working. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
<li>🐞 Fix a Checkbox problem that <code>onChange</code> could not correctly pass in the modified value when dynamically modifying <code>value</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li>
</ul>
<h2>4.18.4</h2>
<p><code>2022-01-18</code></p>
<ul>
<li>Typography
<ul>
<li>⚡️ Optimize Typography to use native css ellipsis when <code>tooltip</code> is configured. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li>
<li>🐞 Refactor Typography <code>ellipsis</code> logic to fix error when <code>children</code> use Context content. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 Fix <code>&lt;Icon component={HomeOutlined} /&gt;</code> and <code>&lt;HomeOutlined /&gt;</code> not aligned. (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">ant-design/ant-design#33709</a>)</li>
<li>🐞 Fix <code>&lt;Icon component={SyncOutlined} spin /&gt;</code> shake. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@​JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 Fix the display effect for Input related components with <code>hidden</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a> <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@​hydraZty</code></a></li>
<li>🐞 Fix the warning in console for Input with <code>showCount</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@​whwangms</code></a></li>
</ul>
</li>
<li>⚡️ Fix ConfigProvider and Anchor rerender unexpectedly. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 Fix the duplicate keys warning in console for Cascader. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@​dimbslmh</code></a></li>
<li>🐞 Checkbox.Group support number and boolean as options element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li>
<li>🐞 Fix Form <code>validateMessages</code> bug in multiple ConfigProvider. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33705">#33705</a></li>
<li>🐞 Fix Steps the tail part would be hidden when type is navigation and labelPlacement is vertical. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33716">#33716</a> <a href="https://github.com/toSayNothing"><code>@​toSayNothing</code></a></li>
<li>🐞 Fix Image has bottom blank style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33631">#33631</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a></li>
<li>🐞 Fix TreeSelect with keyboard operation missing highlight issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33755">#33755</a></li>
<li>🇰🇭 Fix some translations for Khmer (km_KH). <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33738">#33738</a> <a href="https://github.com/vireakkeosokvibol"><code>@​vireakkeosokvibol</code></a></li>
</ul>
<h2>4.18.3</h2>
<p><code>2022-01-10</code></p>
<ul>
<li>🆕 Menu support <code>home</code> and <code>end</code> keyboard navigate. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33642">#33642</a> <a href="https://github.com/dartamonov-vertex"><code>@​dartamonov-vertex</code></a></li>
<li>Table
<ul>
<li>⚡️ Improve Table perfermance significantly when mount and unmount. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33554">#33554</a></li>
<li>🐞 Fix Table emptynode fixed display. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33610">#33610</a> <a href="https://github.com/hemengke1997"><code>@​hemengke1997</code></a></li>
<li>🐞 Fix Table tree data hover error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33638">#33638</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
</ul>
</li>
<li>Form
<ul>
<li>🐞 Fix Form validateMessages is not correct in default locale. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33511">#33511</a></li>
<li>🐞 Fix Form.Item help with empty string makes layout shaking. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33644">#33644</a></li>
</ul>
</li>
<li>🐞 Fix Input.Textarea throws error on preact. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33536">#33536</a> <a href="https://github.com/developit"><code>@​developit</code></a></li>
<li>🐞 Fix PageHeader state update error after unmounted. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33546">#33546</a> <a href="https://github.com/wuifdesign"><code>@​wuifdesign</code></a></li>
<li>💄 Fix Select tag margin issue when using <code>tagRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33539">#33539</a></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="8217c544da"><code>8217c54</code></a> docs(✨): release 4.18.5 (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33822">#33822</a>)</li>
<li><a href="578aaad7f2"><code>578aaad</code></a> test: fix lint</li>
<li><a href="ab8fc12fa7"><code>ab8fc12</code></a> docs: add Plasmic for Ant (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33758">#33758</a>)</li>
<li><a href="a65ba8aa8a"><code>a65ba8a</code></a> docs: update sentence structure in the FAQ section (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33816">#33816</a>)</li>
<li><a href="e55a68670f"><code>e55a686</code></a> chore(deps): update dependency simple-git to v3 (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33817">#33817</a>)</li>
<li><a href="fe23374871"><code>fe23374</code></a> fix: Invalid hook dependency array in Sider and Row (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33804">#33804</a>)</li>
<li><a href="75adc23fe3"><code>75adc23</code></a> chore: i18n contributing docs improve (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33760">#33760</a>)</li>
<li><a href="9cf0dca8fc"><code>9cf0dca</code></a> test: fix cascader test coverage (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33802">#33802</a>)</li>
<li><a href="5d2994ec12"><code>5d2994e</code></a> style: Cascader loading icon (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33799">#33799</a>)</li>
<li><a href="6dd39c1f89"><code>6dd39c1</code></a> fix(checkbox): disabled checkbox should works well with tooltip (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33772">#33772</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/ant-design/ant-design/compare/4.18.2...4.18.5">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=antd&package-manager=npm_and_yarn&previous-version=4.18.2&new-version=4.18.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3346

Reviewed By: aigoncharov

Differential Revision: D33741775

Pulled By: lblasa

fbshipit-source-id: 82e770ed1c09d3a7f9d71a950014d3555c9367fd
 2022-01-28 03:09:50 -08:00
Lawrence Lomax
2573462cec Use provided idb path in iOSBridge idb execs 
Summary:
We pass the `idbPath` to only the log listener function, when in reality it should be used by all of these functions that call out to idb.

This could result in some bizzare inconsistencies where some idb functions to fail as they are not using the supplied path

Reviewed By: passy

Differential Revision: D33818298

fbshipit-source-id: f0fb7f26579c646a0d5265364d539dfded711c2e
 2022-01-28 00:35:23 -08:00
Lawrence Lomax
e2abe1c89a Separate concerns of reading screenshot into buffer & execing screenshot function 
Summary: This allows us to change the way that the command is itself exec'd (for instance to change the idb exec'ing in D33818298)

Reviewed By: passy

Differential Revision: D33818822

fbshipit-source-id: c90b7e58c7476f5db08da0e74e9791230ff97f6f
 2022-01-28 00:35:23 -08:00
Lawrence Lomax
4f886448e0 Move simctl iOSBridge free-functions into class 
Summary: Similar to D33818267, but for simctl. Brings logical ordering of methods as well as consistency

Reviewed By: passy

Differential Revision: D33818687

fbshipit-source-id: 3fbcea128d06c900b49b83ad583ec8a7a07cae2c
 2022-01-28 00:35:23 -08:00
Lawrence Lomax
1e5a070dbd Move idb iOSBridge free-functions into class 
Summary:
This isn't that important right now, but will help as the `IOSBridge` is expanded in the future. There's also an argument for logical ordering of functions within a container (a class!), but that's not the real motivation here.

The existence of `bind` shows that this free function is effectively closing over this argument anyway.

Reviewed By: passy, lblasa

Differential Revision: D33818267

fbshipit-source-id: e7b83f013121cedbd31cb28746b69c1fa76a0803
 2022-01-28 00:35:23 -08:00
dependabot[bot]
08c09e6c6e Bump socket.io-client from 4.4.0 to 4.4.1 in /desktop (#3347) 
Summary:
Bumps [socket.io-client](https://github.com/socketio/socket.io-client) from 4.4.0 to 4.4.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io-client/releases">socket.io-client's releases</a>.</em></p>
<blockquote>
<h2>4.4.1</h2>
<p>This release only contains minor changes. Please see the diff for more details.</p>
<h4>Links:</h4>
<ul>
<li>Diff: <a href="https://github.com/socketio/socket.io-client/compare/4.4.0...4.4.1">https://github.com/socketio/socket.io-client/compare/4.4.0...4.4.1</a></li>
<li>Server release: <a href="https://github.com/socketio/socket.io/releases/tag/4.4.1">4.4.1</a></li>
<li>engine.io-client version: <code>~6.1.1</code></li>
<li>ws version: <code>~8.2.3</code></li>
</ul>
<p>Size of the bundles:</p>
<table>
<thead>
<tr>
<th></th>
<th>min</th>
<th>min+gzip</th>
</tr>
</thead>
<tbody>
<tr>
<td>socket.io.min.js</td>
<td>40.4 KB (-)</td>
<td>13.1 KB (-)</td>
</tr>
<tr>
<td>socket.io.msgpack.min.js</td>
<td>45.6 KB (-)</td>
<td>14.2 KB (-)</td>
</tr>
<tr>
<td>socket.io.esm.min.js</td>
<td>33.1 KB (-)</td>
<td>11.3 KB (-)</td>
</tr>
</tbody>
</table>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io-client/blob/master/CHANGELOG.md">socket.io-client's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/socketio/socket.io-client/compare/4.4.0...4.4.1">4.4.1</a> (2022-01-06)</h2>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="359d1e25e7"><code>359d1e2</code></a> chore(release): 4.4.1</li>
<li><a href="f56fdd0f09"><code>f56fdd0</code></a> chore: remove duplicate package.json file</li>
<li><a href="19836d9abf"><code>19836d9</code></a> chore: add types to exports field to be compatible with nodenext module resol...</li>
<li>See full diff in <a href="https://github.com/socketio/socket.io-client/compare/4.4.0...4.4.1">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=socket.io-client&package-manager=npm_and_yarn&previous-version=4.4.0&new-version=4.4.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3347

Reviewed By: mweststrate

Differential Revision: D33741779

Pulled By: lblasa

fbshipit-source-id: ab87f191dab7d1835005f07ea89ded7890f6f649
 2022-01-27 07:22:35 -08:00
dependabot[bot]
9415bff254 Bump react-virtual from 2.10.0 to 2.10.4 in /desktop (#3343) 
Summary:
Bumps [react-virtual](https://github.com/tannerlinsley/react-virtual) from 2.10.0 to 2.10.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/tannerlinsley/react-virtual/releases">react-virtual's releases</a>.</em></p>
<blockquote>
<h2>v2.10.4</h2>
<h2><a href="https://github.com/tannerlinsley/react-virtual/compare/v2.10.3...v2.10.4">2.10.4</a> (2022-01-21)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><code>totalSize</code> should be <code>paddingStart</code> + <code>paddingEnd</code> when size is 0 (<a href="https://github-redirect.dependabot.com/tannerlinsley/react-virtual/issues/238">https://github.com/facebook/flipper/issues/238</a>) (<a href="5300e47ea5">5300e47</a>)</li>
</ul>
<h2>v2.10.3</h2>
<h2><a href="https://github.com/tannerlinsley/react-virtual/compare/v2.10.2...v2.10.3">2.10.3</a> (2022-01-20)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>types:</strong> Move options interface definition to separated interface and export it (<a href="https://github-redirect.dependabot.com/tannerlinsley/react-virtual/issues/178">https://github.com/facebook/flipper/issues/178</a>) (<a href="df4723cf72">df4723c</a>)</li>
</ul>
<h2>v2.10.2</h2>
<h2><a href="https://github.com/tannerlinsley/react-virtual/compare/v2.10.1...v2.10.2">2.10.2</a> (2022-01-20)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>increment patch to fix breaking change (<a href="7a799a2f40">7a799a2</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="5300e47ea5"><code>5300e47</code></a> fix: <code>totalSize</code> should be <code>paddingStart</code> + <code>paddingEnd</code> when size is 0 (<a href="https://github-redirect.dependabot.com/tannerlinsley/react-virtual/issues/238">https://github.com/facebook/flipper/issues/238</a>)</li>
<li><a href="bc21ad14ff"><code>bc21ad1</code></a> docs: fix dynamic example</li>
<li><a href="df4723cf72"><code>df4723c</code></a> fix(types): Move options interface definition to separated interface and expo...</li>
<li><a href="75417452c7"><code>7541745</code></a> docs: add sticky example (<a href="https://github-redirect.dependabot.com/tannerlinsley/react-virtual/issues/169">https://github.com/facebook/flipper/issues/169</a>)</li>
<li><a href="7a799a2f40"><code>7a799a2</code></a> fix: increment patch to fix breaking change</li>
<li><a href="6a748a6914"><code>6a748a6</code></a> feat: put version to 2.10 in prep for fix release to cure breaking change</li>
<li><a href="6056d1d819"><code>6056d1d</code></a> fix: rebase breaking changes into next branch, rerelease 2.10.1 as non-breaking</li>
<li><a href="7f88ae6f23"><code>7f88ae6</code></a> Update logo.sketch</li>
<li>See full diff in <a href="https://github.com/tannerlinsley/react-virtual/compare/v2.10.0...v2.10.4">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=react-virtual&package-manager=npm_and_yarn&previous-version=2.10.0&new-version=2.10.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3343

Reviewed By: mweststrate

Differential Revision: D33741758

Pulled By: lblasa

fbshipit-source-id: 84edbb7cc1a4a80c1967c97eebe5732000ebc76d
 2022-01-27 07:22:34 -08:00
dependabot[bot]
1262ee05f1 Bump react-debounce-render from 7.0.0 to 7.0.1 in /desktop (#3351) 
Summary:
Bumps [react-debounce-render](https://github.com/podefr/react-debounce-render) from 7.0.0 to 7.0.1.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/podefr/react-debounce-render/commits">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=react-debounce-render&package-manager=npm_and_yarn&previous-version=7.0.0&new-version=7.0.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3351

Reviewed By: mweststrate

Differential Revision: D33741785

Pulled By: lblasa

fbshipit-source-id: 4ceee9922dd80ec2ec47b9826fd8da09cd551122
 2022-01-27 05:22:43 -08:00
Simek
f08bcb2a2c tweak dark mode theme colors, improve LeftRail UI (#3335) 
Summary:
Currently the design of `LeftRail` varies a bit between light and dark modes. Additionally washed background color is hard to differentiate from the main background color in comparison to the light theme (See `LeftRail` sidebars toggle buttons background for example). This lead to few contrast related issues, for example the hover effect on the WelcomeScreen elements is not visible in dark mode.

The PR tweaks the dark mode theme colors and fixes the unnecessary background of Settings icon in dark mode.

I have also spotted that icon `hover` effect is not working when icon has a badge (pure dot or count), I might have an idea how to fix this and I will push another PR for that. 🙂

## Changelog

* tweak dark mode theme colors, improve LeftRail UI

Pull Request resolved: https://github.com/facebook/flipper/pull/3335

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

<img width="390" alt="Screenshot 2022-01-24 at 13 37 20" align="left" src="https://user-images.githubusercontent.com/719641/150784627-36e222a8-e53e-4409-ab72-783d4a594f8e.png">
<img width="390" alt="Screenshot 2022-01-24 at 13 46 08" src="https://user-images.githubusercontent.com/719641/150785438-bb496adf-83ab-4b1c-928d-07f4b0098f1a.png">

Reviewed By: antonk52

Differential Revision: D33741513

Pulled By: lblasa

fbshipit-source-id: ef187db0725ac2b04c09b7f06823e713b50be88f
 2022-01-27 04:45:19 -08:00
Flipper Bot
1fee833de6 Flipper Release: v0.131.0 
Summary: Releasing version 0.131.0

Reviewed By: cekkaewnumchai

Differential Revision: D33814533

fbshipit-source-id: fde9830a063c99c5735cc66a0a2a614905c4335d
 2022-01-27 04:45:18 -08:00
Lawrence Lomax
be451e15d9 Use demandOption instead of explicit checks of args 
Summary: `yargs` supports this

Reviewed By: passy

Differential Revision: D33812132

fbshipit-source-id: d7846222f140fc32035824fe035737ae9ae2780e
 2022-01-27 03:22:30 -08:00
Lawrence Lomax
85d1b060c7 Match on device serial as well as title 
Summary: Device UDID/serial is necessary for matching uniquely. It's certainly possible to connect more than one of the same phone model, or have multiple iOS Sims with the same model and different OS versions.

Reviewed By: nikoant

Differential Revision: D33793569

fbshipit-source-id: aabd31a5b86c78a85aa867c6fa34d92f411fcb6e
 2022-01-27 01:22:51 -08:00
Andrey Goncharov
e0204486a5 Fix stale idbConfig and adb in CertificateProvider 
Summary: CertificateProvider initializes too early, and set abd and idb to undefined, before adb and idb are initialized by android and ios manager.

Reviewed By: lawrencelomax

Differential Revision: D33792854

fbshipit-source-id: b6bba32dead7edf62e360b2e2563f2b67243b1b8
 2022-01-26 10:23:45 -08:00
Flipper Bot
66478d3e11 Flipper Release: v0.130.0 
Summary: Releasing version 0.130.0

Reviewed By: cekkaewnumchai

Differential Revision: D33788026

fbshipit-source-id: bed50ad4001a40d899c673547dac16c8aef8aa1d
 2022-01-26 07:51:52 -08:00
Simek
903476bdad use centered prop for variable height modals (#3334) 
Summary:
Currently all of the modals are displayed using default positioning, which works fine for small modals and large app windows, but it cause small UI/UX issues (double scroll bars) when app window is quite small.

Adding [`centered` prop](https://ant.design/components/modal/#API) for variable height modals improves this situation a bit, but it also changes a bit the modal position when using maximised window, but I think this is bearable looking at improvements gained when window size is reduced.

## Changelog

* use `centered` prop for variable height modals to improve UI in small app window

Pull Request resolved: https://github.com/facebook/flipper/pull/3334

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

#### Small App Window
<img width="390" alt="Screenshot 2022-01-24 at 11 58 40" align="left" src="https://user-images.githubusercontent.com/719641/150771900-cb25d110-82c7-4ba9-8ee5-07a093c4f702.png">
<img width="390" alt="Screenshot 2022-01-24 at 11 58 37" src="https://user-images.githubusercontent.com/719641/150771911-c81592ac-1eba-4112-86ad-9549e6248239.png">

<img width="390" alt="Screenshot 2022-01-24 at 12 00 13" align="left" src="https://user-images.githubusercontent.com/719641/150772045-de37c432-4381-4207-8476-5f142dfb6fa5.png">
<img width="390" alt="Screenshot 2022-01-24 at 12 00 10" src="https://user-images.githubusercontent.com/719641/150772057-574cf6cd-6f1a-4ca2-a343-b8fd6342eddb.png">

#### Maximised App Window
<img width="390" alt="Screenshot 2022-01-24 at 12 12 12" align="left" src="https://user-images.githubusercontent.com/719641/150772777-8ac3cb59-3b41-4dcb-9554-137e95857af8.png">
<img width="390" alt="Screenshot 2022-01-24 at 12 12 29" src="https://user-images.githubusercontent.com/719641/150772758-ca9f8c20-d6d0-412d-9067-7e756da0b56c.png">

Reviewed By: mweststrate

Differential Revision: D33741484

Pulled By: lblasa

fbshipit-source-id: 0c3ca883d051cf4fcce9f9c1b6688974b66fd0d8
 2022-01-26 04:23:05 -08:00
Andrey Goncharov
da618fd3f3 Decouple CertificateProvider and adb/idb client intialization 
Summary:
Previously CertificateProvider initialized ADB and provided config to IDB. As result, AndroidDeviceManager and iOSDeviceManager indirectly depended on CertificateProvider.

With this diff we:
1. Make idbConfig resemble adbClient.
2. Make AndroidDeviceManager and iOSDeviceManager initialize their own clients
3. Fix server crash when one of the clients couldn't be initialized. The reason for the crash is CertificateProvider.prototype.init which is no longer needed.

Reviewed By: passy

Differential Revision: D33711652

fbshipit-source-id: 055b5625ed993827b65396f4af5157808479242b
 2022-01-26 04:23:05 -08:00
Brian Vaughn
639df5c81a React DevTools 4.22.1 -> 4.23.0 
Summary:
Update `react-devtools-core` and `react-devtools` dependencies for RN, VSCode, Flipper, etc.

`js1 upgrade react-devtools -v 4.23.0`

# Changelog:

[General][Changed] - Upgraded react-devtools-core dependency to 4.23.0

Reviewed By: lunaruan

Differential Revision: D33752754

fbshipit-source-id: 81d123e058d5660b3b7c34823d15272b34d6c0b6
 2022-01-25 18:23:06 -08:00
Lorenzo Blasa
c1a05c0366 Bump node-fetch 2.6.7 
Summary: ^

Reviewed By: nikoant

Differential Revision: D33767745

fbshipit-source-id: c1ed481e140e88f7d7917e572430d14fcd5fa057
 2022-01-25 10:22:59 -08:00
dependabot[bot]
493915bc8d Bump dotenv from 8.2.0 to 14.2.0 in /desktop (#3344) 
Summary:
Bumps [dotenv](https://github.com/motdotla/dotenv) from 8.2.0 to 14.2.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md">dotenv's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/motdotla/dotenv/compare/v14.1.1...v14.2.0">14.2.0</a> (2022-01-17)</h2>
<h3>Added</h3>
<ul>
<li>Add <code>dotenv_config_override</code> cli option</li>
<li>Add <code>DOTENV_CONFIG_OVERRIDE</code> command line env option</li>
</ul>
<h2><a href="https://github.com/motdotla/dotenv/compare/v14.1.0...v14.1.1">14.1.1</a> (2022-01-17)</h2>
<h3>Added</h3>
<ul>
<li>Add React gotcha to FAQ on README</li>
</ul>
<h2><a href="https://github.com/motdotla/dotenv/compare/v14.0.1...v14.1.0">14.1.0</a> (2022-01-17)</h2>
<h3>Added</h3>
<ul>
<li>Add <code>override</code> option 🎉 (<a href="https://github-redirect.dependabot.com/motdotla/dotenv/pull/595">https://github.com/facebook/flipper/issues/595</a>)</li>
</ul>
<h2><a href="https://github.com/motdotla/dotenv/compare/v14.0.0...v14.0.1">14.0.1</a> (2022-01-16)</h2>
<h3>Added</h3>
<ul>
<li>Log error on failure to load <code>.env</code> file (<a href="https://github-redirect.dependabot.com/motdotla/dotenv/pull/594">https://github.com/facebook/flipper/issues/594</a>)</li>
</ul>
<h2><a href="https://github.com/motdotla/dotenv/compare/v13.0.1...v14.0.0">14.0.0</a> (2022-01-16)</h2>
<h3>Added</h3>
<ul>
<li><em>Breaking:</em> Support inline comments for the parser 🎉 (<a href="https://github-redirect.dependabot.com/motdotla/dotenv/pull/568">https://github.com/facebook/flipper/issues/568</a>)</li>
</ul>
<h2><a href="https://github.com/motdotla/dotenv/compare/v13.0.0...v13.0.1">13.0.1</a> (2022-01-16)</h2>
<h3>Changed</h3>
<ul>
<li>Hide comments and newlines from debug output (<a href="https://github-redirect.dependabot.com/motdotla/dotenv/pull/404">https://github.com/facebook/flipper/issues/404</a>)</li>
</ul>
<h2><a href="https://github.com/motdotla/dotenv/compare/v12.0.4...v13.0.0">13.0.0</a> (2022-01-16)</h2>
<h3>Added</h3>
<ul>
<li><em>Breaking:</em> Add type file for <code>config.js</code> (<a href="https://github-redirect.dependabot.com/motdotla/dotenv/pull/539">https://github.com/facebook/flipper/issues/539</a>)</li>
</ul>
<h2><a href="https://github.com/motdotla/dotenv/compare/v12.0.3...v12.0.4">12.0.4</a> (2022-01-16)</h2>
<h3>Changed</h3>
<ul>
<li>README updates</li>
<li>Minor order adjustment to package json format</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="aeae434e53"><code>aeae434</code></a> Version 14.2.0</li>
<li><a href="78996affef"><code>78996af</code></a> Add override cli and env options</li>
<li><a href="18b6e1ccdc"><code>18b6e1c</code></a> Remove verbose test and move -Rspec option to standard test</li>
<li><a href="fb38f298b4"><code>fb38f29</code></a> Version 14.1.1</li>
<li><a href="f1c38d5a67"><code>f1c38d5</code></a> Update CHANGELOG</li>
<li><a href="d1af7f8f2d"><code>d1af7f8</code></a> Package lock update</li>
<li><a href="5e922fea74"><code>5e922fe</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/motdotla/dotenv/issues/596">https://github.com/facebook/flipper/issues/596</a> from darkgl0w/bump</li>
<li><a href="1da837bdf5"><code>1da837b</code></a> fix (test): no need to pass and call <code>done()</code></li>
<li><a href="ec4b0fa006"><code>ec4b0fa</code></a> chore: upgrade package dependencies</li>
<li><a href="6b0d2eb604"><code>6b0d2eb</code></a> Update README</li>
<li>Additional commits viewable in <a href="https://github.com/motdotla/dotenv/compare/v8.2.0...v14.2.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=dotenv&package-manager=npm_and_yarn&previous-version=8.2.0&new-version=14.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3344

Reviewed By: aigoncharov

Differential Revision: D33741763

Pulled By: lblasa

fbshipit-source-id: 7188e804d6230ec7504c8ff43a70463c7959d130
 2022-01-25 04:23:37 -08:00
dependabot[bot]
3764b5aa2d Bump immer from 9.0.7 to 9.0.12 in /desktop (#3345) 
Summary:
Bumps [immer](https://github.com/immerjs/immer) from 9.0.7 to 9.0.12.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/immerjs/immer/releases">immer's releases</a>.</em></p>
<blockquote>
<h2>v9.0.12</h2>
<h2><a href="https://github.com/immerjs/immer/compare/v9.0.11...v9.0.12">9.0.12</a> (2022-01-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>produceWithPatches should not wrap result in Immutable, fixes <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/850">https://github.com/facebook/flipper/issues/850</a>, <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/881">https://github.com/facebook/flipper/issues/881</a> (<a href="d8f26362a9">d8f2636</a>)</li>
</ul>
<h2>v9.0.11</h2>
<h2><a href="https://github.com/immerjs/immer/compare/v9.0.10...v9.0.11">9.0.11</a> (2022-01-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>incorrect patches for <code>delete</code> on arrays. Fixes <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/879">https://github.com/facebook/flipper/issues/879</a> (<a href="d91a6597e9">d91a659</a>)</li>
</ul>
<h2>v9.0.10</h2>
<h2><a href="https://github.com/immerjs/immer/compare/v9.0.9...v9.0.10">9.0.10</a> (2022-01-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>No patches being generated for root primitive replacements. Fixes <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/888">https://github.com/facebook/flipper/issues/888</a> (<a href="0f96270840">0f96270</a>)</li>
</ul>
<h2>v9.0.9</h2>
<h2><a href="https://github.com/immerjs/immer/compare/v9.0.8...v9.0.9">9.0.9</a> (2022-01-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>make sure produceWithPatches accepts promises (<a href="d80e823733">d80e823</a>)</li>
</ul>
<h2>v9.0.8</h2>
<h2><a href="https://github.com/immerjs/immer/compare/v9.0.7...v9.0.8">9.0.8</a> (2022-01-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>immerjs<a href="https://github-redirect.dependabot.com/immerjs/immer/issues/876">https://github.com/facebook/flipper/issues/876</a> Ensure empty patch set for atomic set+delete on Map (<a href="https://github-redirect.dependabot.com/immerjs/immer/issues/878">https://github.com/facebook/flipper/issues/878</a>) (<a href="e1409180eb">e140918</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="d8f26362a9"><code>d8f2636</code></a> fix: produceWithPatches should not wrap result in Immutable, fixes <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/850">https://github.com/facebook/flipper/issues/850</a>, <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/881">https://github.com/facebook/flipper/issues/881</a></li>
<li><a href="feba5d1404"><code>feba5d1</code></a> chore: remove debugger statement</li>
<li><a href="d91a6597e9"><code>d91a659</code></a> fix: incorrect patches for <code>delete</code> on arrays. Fixes <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/879">https://github.com/facebook/flipper/issues/879</a></li>
<li><a href="0f96270840"><code>0f96270</code></a> fix: No patches being generated for root primitive replacements. Fixes <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/888">https://github.com/facebook/flipper/issues/888</a></li>
<li><a href="d80e823733"><code>d80e823</code></a> fix: make sure produceWithPatches accepts promises</li>
<li><a href="e1409180eb"><code>e140918</code></a> fix: immerjs#876 Ensure empty patch set for atomic set+delete on Map (<a href="https://github-redirect.dependabot.com/immerjs/immer/issues/878">https://github.com/facebook/flipper/issues/878</a>)</li>
<li>See full diff in <a href="https://github.com/immerjs/immer/compare/v9.0.7...v9.0.12">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=immer&package-manager=npm_and_yarn&previous-version=9.0.7&new-version=9.0.12)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3345

Reviewed By: antonk52

Differential Revision: D33741770

Pulled By: lblasa

fbshipit-source-id: 2f52bee684c99d171c1e3460825c557b027e8cf0
 2022-01-25 03:30:52 -08:00
dependabot[bot]
0d1520bbec Bump ws from 8.4.0 to 8.4.2 in /desktop (#3354) 
Summary:
Bumps [ws](https://github.com/websockets/ws) from 8.4.0 to 8.4.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/websockets/ws/releases">ws's releases</a>.</em></p>
<blockquote>
<h2>8.4.2</h2>
<h1>Bug fixes</h1>
<ul>
<li>Fixed a data framing issue introduced in version 8.4.1 (<a href="https://github-redirect.dependabot.com/websockets/ws/issues/2004">https://github.com/facebook/flipper/issues/2004</a>).</li>
</ul>
<h2>8.4.1</h2>
<h1>Notable changes</h1>
<ul>
<li>To improve performance, strings sent via <code>websocket.ping()</code>,
<code>websocket.pong()</code>, and <code>websocket.send()</code> are no longer converted to
<code>Buffer</code>s if the data does not need to be masked (<a href="https://github-redirect.dependabot.com/websockets/ws/issues/2000">https://github.com/facebook/flipper/issues/2000</a>).</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="33fd1016ec"><code>33fd101</code></a> [dist] 8.4.2</li>
<li><a href="0c0754b897"><code>0c0754b</code></a> [fix] Use the byte length of the data (<a href="https://github-redirect.dependabot.com/websockets/ws/issues/2004">https://github.com/facebook/flipper/issues/2004</a>)</li>
<li><a href="6ebfeb8be7"><code>6ebfeb8</code></a> [dist] 8.4.1</li>
<li><a href="5b7fbb0009"><code>5b7fbb0</code></a> [perf] Reduce buffer allocations (<a href="https://github-redirect.dependabot.com/websockets/ws/issues/2000">https://github.com/facebook/flipper/issues/2000</a>)</li>
<li><a href="8de448fbd1"><code>8de448f</code></a> [test] Fix failing tests</li>
<li><a href="91f3c07b26"><code>91f3c07</code></a> [minor] Replace echo.websocket.org with websocket-echo.com</li>
<li><a href="ad3fe6dc4f"><code>ad3fe6d</code></a> [test] Improve test title</li>
<li><a href="4081a368ff"><code>4081a36</code></a> [test] Do not call the <code>done</code> callback prematurely</li>
<li><a href="d2c935a477"><code>d2c935a</code></a> [doc] Fix typo in <code>WebSocketServer</code> description (<a href="https://github-redirect.dependabot.com/websockets/ws/issues/1996">https://github.com/facebook/flipper/issues/1996</a>)</li>
<li><a href="5edf1f4a1b"><code>5edf1f4</code></a> [doc] Clarify interpretation of <code>verifyClient</code> (<a href="https://github-redirect.dependabot.com/websockets/ws/issues/1994">https://github.com/facebook/flipper/issues/1994</a>)</li>
<li>See full diff in <a href="https://github.com/websockets/ws/compare/8.4.0...8.4.2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ws&package-manager=npm_and_yarn&previous-version=8.4.0&new-version=8.4.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3354

Reviewed By: aigoncharov

Differential Revision: D33741798

Pulled By: lblasa

fbshipit-source-id: e8d43d2408118f6b19a2c59603b92c701100f355
 2022-01-24 09:38:27 -08:00
Simek
1c91d28390 improve dev perf canvas readability (#3333) 
Summary:
This PR updates the performance Canvas widgets readability in Dev mode.

Currently, for unknown for me reason, the text was rendered with stroke not fill, which results in blurry text.

Also the color of texts and plot in light mode have not enough contrast in comparison to the background. I have tried to use `theme` in there, but unfortunately the CSS variables are not available in the Canvas context and using those values leads to always black text.

## Changelog

* improve the performance canvas widgets readability in Development mode

Pull Request resolved: https://github.com/facebook/flipper/pull/3333

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

#### Dark Mode
<img width="189" alt="Screenshot 2022-01-23 at 17 46 20" align="left" src="https://user-images.githubusercontent.com/719641/150689046-28895487-d488-440f-9440-f792daeca86f.png">
<img width="189" alt="Screenshot 2022-01-23 at 17 54 59" src="https://user-images.githubusercontent.com/719641/150689179-5ef96ca3-78e0-4995-b60c-317a87082604.png">

#### Light Mode
<img width="189" alt="Screenshot 2022-01-23 at 17 46 27" align="left" src="https://user-images.githubusercontent.com/719641/150689061-a3264961-390a-4182-bd81-ba84b6e4979f.png">
<img width="189" alt="Screenshot 2022-01-23 at 17 55 09" src="https://user-images.githubusercontent.com/719641/150689188-17efc7d9-7add-409e-af3b-befa5fbba0bc.png">

Reviewed By: aigoncharov

Differential Revision: D33738722

Pulled By: lblasa

fbshipit-source-id: b992ecacd31bb6aa2a53885ca6dcc858fa510775
 2022-01-24 08:52:22 -08:00