3 Commits

Author	SHA1	Message	Date
Lawrence Lomax	fbd3212994	Add valid path check for xcode-select'd Xcode ... Summary: We should also check that Xcode exists at the path that the user has `xcode-select`'d Reviewed By: passy Differential Revision: D34168672 fbshipit-source-id: dc7c36bcb2ad1cec99e6ebb4d531417e55402f01	2022-02-11 04:21:05 -08:00
Lawrence Lomax	ef2b03ea95	Specialize error message when no xcode selected ... Summary: We can detect an xcode-select failure earlier on, right now this will be misleading as later healtchecks around `xctrace`/`xcodebuild` will fail and it's not clear why. If you don't have any Xcode selected, then we can detect this and mark it as an error. This can be done by looking out the output of the command. To do this we have to propogate the stdout of the shell-out back, so there's a subtype of the regular healtcheck. This is then inspected for it's path since `xcode-select` returns the same exit code if xcode isn't selected or at it's default state. Reviewed By: passy Differential Revision: D34168673 fbshipit-source-id: c0aa846bb251aaf026beb976a042b727c7cf1c24	2022-02-11 04:21:05 -08:00
Anton Kastritskiy	b4fc108c2e	Rename first batch for '.ts' files to '.tsx' in doctor, static and test-utils ... Summary: Rename first batch for '.ts' files to '.tsx' Reviewed By: nikoant Differential Revision: D33843051 fbshipit-source-id: 68dd2dc6538afce2daaf24c6412dc5db8b38acbc	2022-01-28 08:32:19 -08:00