Summary: It looks a lot better now, but the input is only single line, so entering more than one line would not be good right now.
Reviewed By: danielbuechele
Differential Revision: D17210091
fbshipit-source-id: 9313b6a67731cfa944394962cdc09be915a07720
Summary: To keep it in sync with the JS implementation.
Reviewed By: danielbuechele
Differential Revision: D17208786
fbshipit-source-id: 8d89f33bfef22317266a0ad1e0c5689540d54f9e
Summary:
This isn't ready to release yet, it's still behind a GK so noone will see it.
There has been no styling applied to the popover so it looks bad but is fully functional.
What it also doesn't have yet:
* Get the prompt text from the API (including the predefined selectable comments)
* Check with the server whether it should pop up proactively, it's completely passive at the moment.
Reviewed By: passy
Differential Revision: D17206158
fbshipit-source-id: f1734f3d6bc555c860ebbaad7515d4675e1700cb
Summary:
Yesterday I saw someone try to open the xcode executable with the File > Open function.
This made me realise it's not clear what this is for, and you might think it can open all kinds of things.
Reviewed By: danielbuechele
Differential Revision: D17225496
fbshipit-source-id: 893360a1f450a8db25be34fce6c288e8db8f9626
Summary:
The navigation plugin supports logging of a date and the class name. This addition adds that support.
I have kept the previoius method which I will remove once I update the fb4a navigation plugin integration.
Reviewed By: danielbuechele
Differential Revision: D17202996
fbshipit-source-id: eac95328a6e2278c3a27ca608b9b675c8efe4528
Summary: Migrated all the tests. I've put these in a single diff as there were only a couple of lines that had to be changed in each file.
Reviewed By: danielbuechele
Differential Revision: D17181587
fbshipit-source-id: cdcc20d71a47e786db4cefbebe9ea686d5e235e5
Summary:
Publishing React Dev tools plugin:
- migrate to TS
- move iOS and JS part to public folder (Android was already)
Reviewed By: passy
Differential Revision: D17164782
fbshipit-source-id: 20ccba71d807df2d33fe5348a62c6ee7f78ae8ba
Summary: When clicking a node in the tree, currently it expands or collapses the subtree under it. This adds a chevron button which only handles the expansion functionality, and clicking on the label with the Section name will show info about that Section in the side panel.
Reviewed By: fabiomassimo
Differential Revision: D17165150
fbshipit-source-id: ac6b6c127b68274f53523b3ea62422ff96116e9b
Summary: z-index for titlebar was not high enough to cover the modal sheet
Reviewed By: jknoxville
Differential Revision: D17165223
fbshipit-source-id: 5ae30b6e55a1f69d653db509a08a8aa80a6f10fd
Summary:
I've added in a timeline line. Getting the CSS for this to work perfectly was tricky, but in the end this result looks pretty good. I've opted for the unknown events to have a smaller circle.
Edit:
I have fixed the border radius issue with the img element:
{F206482232}
And Unknown events are better aligned:
{F206482255}
Reviewed By: jknoxville
Differential Revision: D17180819
fbshipit-source-id: c318d2721adde758494267095524961c796f7a54
Summary: You need to use a type guard when narrowing types in a filter.
Reviewed By: danielbuechele
Differential Revision: D17163782
fbshipit-source-id: aa78bdd392653ebf1080a04e62e131b607e5181b
Summary:
This is a UI ovehaul for the Navigation plugin, taking inspiration from the Notifications page in Flipper.
We now display a timestamp, open page and bookmark are more clearly identified, screenshots are organized more neatly, and parameters are displayed in a table.
If the class name of the ViewController is available, that will also be displayed.
Edit:
Adding in some of the requested changes.
Improved UI:
https://pxl.cl/K0h9
Scroll on opening a page:
https://pxl.cl/K0hQ
Reviewed By: danielbuechele
Differential Revision: D17161734
fbshipit-source-id: e5e054bf87f540964e90da3a798fd0c23df86540
Summary:
This makes the implementation of static view generic. Right now the only non-plugin view which is shown is the WelcomeScreen. The implementation it is hardcoded. I want to make it generic, so that we can show the bug request screen too.
This diff sets the default value of the `staticView` to `WelcomeScreen`, which will be set to null when the `selectedDevice` is set. And viceversa, it will be assigned back to `WelcomScreen`, when the `selectedDevice` is set to `null`
Reviewed By: danielbuechele
Differential Revision: D16965734
fbshipit-source-id: 69d700184f44d4e5ab531f5f8fc0e23bafa07e72
Summary: Migrate CPU plugin to use TypeScript
Reviewed By: danielbuechele
Differential Revision: D17072709
fbshipit-source-id: d9acf172af08d764216e7b79b79994199dc83f5c
Summary:
Generics on static methods don't seem to work the way we are using them.
I looked into how react types getDerivedStateFromProps as this is a very similar concept, and they don't seem to type it at all. For that reason I've given up and just type the persistedState passed to our static methods as `Object`.
Reviewed By: passy
Differential Revision: D17152767
fbshipit-source-id: d9c2159be26fa341c5411dd0b40895d4c8ddf71e
