Summary: Mostly exclaming here, but it's a test so ... �
Reviewed By: danielbuechele
Differential Revision: D17314463
fbshipit-source-id: 84a4cb9d5b91865b7f723c883dc4840479db9aa3
Summary:
Icon names including the -outline suffix get stripped out so the local path becomes the filled variant by default.
But it's only observable in release builds, because they are the only ones that use local icons.
This should fix that by keeping the variant in the local icon path as well.
Reviewed By: danielbuechele
Differential Revision: D17314646
fbshipit-source-id: b8402d85b1cc690caef7870194e60f22d17dca05
Summary:
This is an interesting invariant that TS caught here. We
expect `getDevice()` to always return a device but it
cannot because it's set lazily. John Knox suggested we instead
set up a promise in the constructor and resolve it instead of
overriding the stateful promise later.
Reviewed By: jknoxville
Differential Revision: D17313468
fbshipit-source-id: 8fd75f2720546abf67beead23db56216f1a5e0df
Summary: And remove one migration warning that no longer applies.
Reviewed By: danielbuechele
Differential Revision: D17313469
fbshipit-source-id: f29a096a0da7c14735d1d5666a54a3351df54821
Summary: Plugin is moved up as soon as it gets clicked because of the same array reference
Reviewed By: jknoxville
Differential Revision: D17285335
fbshipit-source-id: c4413844fe07a9aed77e4b0e9fb5f5e025d722ca
Summary:
Relies heavily on types (not) defined in other modules,
so right now it's mostly sprinkling more `any`s in.
My type declaration is based on `dts-gen` output and some
manual fixes. This is the same level as the old flow-typed
definition we had.
Reviewed By: jknoxville
Differential Revision: D17282739
fbshipit-source-id: 0e5015d3b61044615a03c50fefade908041310a8
Summary:
Could use a closer look. *Shouldn't* change semantics,
but there are some assumptions baked into the code
which I don't fully grasp.
Reviewed By: jknoxville
Differential Revision: D17282310
fbshipit-source-id: af8e6bcd188bd12180a7b2eeafee7ced4f44d1aa
Summary: Per title. Somehow both typecheck, but importing the module like this doesn't work.
Reviewed By: jknoxville
Differential Revision: D17285507
fbshipit-source-id: 40a38db5dfb52213e0407f8bda83f2ebad5c50c7
Summary:
This has been tripping up the release builds, luckily caught by
Circle: https://circleci.com/gh/facebook/flipper/1480
Reviewed By: jknoxville
Differential Revision: D17282130
fbshipit-source-id: a17adb18bc75e4fa5d645a062343622167785fa6
Summary: Show info about the event which triggered a new changeset generation; in case of a state update, also show the name of the method which triggered the state update.
Reviewed By: pasqualeanatriello
Differential Revision: D17162202
fbshipit-source-id: ebf218f8ce71799e4dd452f54b1621af7f83cc51
Summary: Use the string sent from the client to show which section triggered a state update.
Reviewed By: pasqualeanatriello
Differential Revision: D17162190
fbshipit-source-id: a72eea1c6fc0fba851028aa050f0c6772a590e8d
Summary:
Show the section which triggered the state update in the tree hierarchy.
We can't use the attribution param that was being passed from SectionTree because it contains the key of the section, not the global key.
Reviewed By: pasqualeanatriello
Differential Revision: D17161730
fbshipit-source-id: bae5e509c378ffdf210acac6564212c873c5855b
Summary: These strings be provided by the api.
Reviewed By: passy
Differential Revision: D17282133
fbshipit-source-id: a818f915c0a21f84894a6073d2cc08669647caaa
Summary: The persistedState of the Layout (and potentially other plugins) wasn't updated. It turned out that the updated state value never got passed to `setPluginState`, but accidentally when adding a type declaration, the `Object` constructor was passed as value to the state.
Reviewed By: jknoxville, passy
Differential Revision: D17282822
fbshipit-source-id: 6fc64960ee2405ea5a705504969c36a27ac62f2c
Summary: And also increase the time-to-disappear from 1s to 1.5s.
Reviewed By: passy
Differential Revision: D17281904
fbshipit-source-id: df0f3e1a40949f5a518bf05d89b6ac0ecf92c5bb
Summary: One of the last releases before 6.0 with more deprecation warnings.
Reviewed By: jknoxville
Differential Revision: D17259063
fbshipit-source-id: c31e9dc46071deae601489cc51d9af0d569d270d
Summary:
This one is in TS, so we get types for free.
`promisify` makes it rather awkward to work with overloaded
functions like `spawn`, so there's still value in having
a proper library for this.
Reviewed By: jknoxville
Differential Revision: D17204471
fbshipit-source-id: 3d07edfe2bb8c1e4c4f3134b53a0c4a0d9be383b
