96b99ac23ec680bedf90ed2a65968664c3e6fe1d
1077 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
dependabot[bot]
|
96b99ac23e |
Bump pretty-format from 27.4.2 to 27.4.6 in /desktop (#3262)
Summary: Bumps [pretty-format](https://github.com/facebook/jest/tree/HEAD/packages/pretty-format) from 27.4.2 to 27.4.6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/facebook/jest/releases">pretty-format's releases</a>.</em></p> <blockquote> <h2>v27.4.6</h2> <h3>Fixes</h3> <ul> <li><code>[jest-environment-node]</code> Add <code>AbortSignal</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12157">#12157</a>)</li> <li><code>[jest-environment-node]</code> Add Missing node global <code>performance</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12002">#12002</a>)</li> <li><code>[jest-runtime]</code> Handle missing <code>mocked</code> property (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12213">#12213</a>)</li> <li><code>[jest/transform]</code> Update dependency package <code>pirates</code> to 4.0.4 (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12002">#12002</a>)</li> </ul> <h3>Performance</h3> <ul> <li><code>jest-config</code> perf: only register ts-node once when loading TS config files (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12160">#12160</a>)</li> </ul> <h3>New Contributors</h3> <ul> <li><a href="https://github.com/laozhu"><code>@laozhu</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12136">facebook/jest#12136</a></li> <li><a href="https://github.com/sfiquet"><code>@sfiquet</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12161">facebook/jest#12161</a></li> <li><a href="https://github.com/SimonSiefke"><code>@SimonSiefke</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12002">facebook/jest#12002</a></li> <li><a href="https://github.com/Semigradsky"><code>@Semigradsky</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12190">facebook/jest#12190</a></li> <li><a href="https://github.com/cmpadden"><code>@cmpadden</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12204">facebook/jest#12204</a></li> <li><a href="https://github.com/LitoMore"><code>@LitoMore</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12211">facebook/jest#12211</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/facebook/jest/compare/v27.4.5...v27.4.6">https://github.com/facebook/jest/compare/v27.4.5...v27.4.6</a></p> <h2>v27.4.5</h2> <h2>Fixes</h2> <ul> <li><code>[jest-worker]</code> Stop explicitly passing <code>process.env</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12141">#12141</a>)</li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/4geru"><code>@4geru</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12144">facebook/jest#12144</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/facebook/jest/compare/v27.4.4...v27.4.5">https://github.com/facebook/jest/compare/v27.4.4...v27.4.5</a></p> <h2>v27.4.4</h2> <h2>Fixes</h2> <ul> <li><code>[babel-jest]</code> Add <code>process.version</code> chunk to the cache key (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12122">#12122</a>)</li> <li><code>[jest-environment]</code> Add <code>mocked</code> to <code>jest</code> object (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12133">#12133</a>)</li> <li><code>[jest-worker]</code> Stop explicitly passing <code>execArgv</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12128">#12128</a>)</li> </ul> <h2>Chore & Maintenance</h2> <ul> <li><code>[website]</code> Fix the card front that looks overlapping part of the card back</li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/aghArdeshir"><code>@aghArdeshir</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12109">facebook/jest#12109</a></li> <li><a href="https://github.com/ony3000"><code>@ony3000</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12127">facebook/jest#12127</a></li> <li><a href="https://github.com/liesislukas"><code>@liesislukas</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12135">facebook/jest#12135</a></li> <li><a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12128">facebook/jest#12128</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/facebook/jest/compare/v27.4.3...v27.4.4">https://github.com/facebook/jest/compare/v27.4.3...v27.4.4</a></p> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/facebook/jest/blob/main/CHANGELOG.md">pretty-format's changelog</a>.</em></p> <blockquote> <h2>27.4.6</h2> <h3>Fixes</h3> <ul> <li><code>[jest-environment-node]</code> Add <code>AbortSignal</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12157">#12157</a>)</li> <li><code>[jest-environment-node]</code> Add Missing node global <code>performance</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12002">#12002</a>)</li> <li><code>[jest-runtime]</code> Handle missing <code>mocked</code> property (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12213">#12213</a>)</li> <li><code>[jest/transform]</code> Update dependency package <code>pirates</code> to 4.0.4 (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12002">#12002</a>)</li> </ul> <h3>Performance</h3> <ul> <li><code>jest-config</code> perf: only register ts-node once when loading TS config files (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12160">#12160</a>)</li> </ul> <h2>27.4.5</h2> <h3>Fixes</h3> <ul> <li><code>[jest-worker]</code> Stop explicitly passing <code>process.env</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12141">#12141</a>)</li> </ul> <h2>27.4.4</h2> <h3>Fixes</h3> <ul> <li><code>[babel-jest]</code> Add <code>process.version</code> chunk to the cache key (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12122">#12122</a>)</li> <li><code>[jest-environment]</code> Add <code>mocked</code> to <code>jest</code> object (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12133">#12133</a>)</li> <li><code>[jest-worker]</code> Stop explicitly passing <code>execArgv</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12128">#12128</a>)</li> </ul> <h3>Chore & Maintenance</h3> <ul> <li><code>[website]</code> Fix the card front that looks overlapping part of the card back</li> </ul> <h2>27.4.3</h2> <h3>Fixes</h3> <ul> <li><code>[jest-environment-jsdom]</code> Remove <code>types/jsdom</code> dependency (and make its <code>dom</code> property <code>private</code>) (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12107">#12107</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
Michel Weststrate
|
b6c884f011 |
Make sure flipper server initialization errors are propagated properly
Summary: This diff makes sure that errors are propagated similarly in flipper desktop and browser version, and that they are shown in either case. Since in the browser version, the UI loads after the error happened, we'll store the error so that any client connecting in the future will read and report it. Also added a `--failFast` flag to flipper-server, so that the process exits immediately if misconfigured, which is convenient in CI use cases and such Reviewed By: nikoant Differential Revision: D33348922 fbshipit-source-id: 0f584104f881141fde38da3f0031748415343ea2 |
||
|
Michel Weststrate
|
8259f92983 |
Make sure Flipper server startup errors are propagated for desktop
Summary: If openssl is not available, this would lead to an unhandled rejection exception. That is because a lot initialization logic generates promises that don't get a catch chained on immediately. Changed the flipper server startup flow to be more idiomatically async Fixes https://github.com/facebook/flipper/issues/2766 Changelog: More clearly communicate if flipper server failed to start (e.d. due to port already taken, openssl not being available) This change fixes it only for desktop flipper, will make sure the browser UI will support this as well (the error will fire correctly there, but there are no listeners during startup) Reviewed By: nikoant Differential Revision: D33348923 fbshipit-source-id: f561bb27b18a3041c514b37f7aed11435a49647f |
||
Andres Suarez
|
79023ee190 |
Update copyright headers from Facebook to Meta
Reviewed By: bhamodi Differential Revision: D33331422 fbshipit-source-id: 016e8dcc0c0c7f1fc353a348b54fda0d5e2ddc01 |
||
|
dependabot[bot]
|
bbff1d2fb7 |
Bump pretty-format from 27.3.1 to 27.4.2 in /desktop (#3165)
Summary: Bumps [pretty-format](https://github.com/facebook/jest/tree/HEAD/packages/pretty-format) from 27.3.1 to 27.4.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/facebook/jest/releases">pretty-format's releases</a>.</em></p> <blockquote> <h2>v27.4.2</h2> <h2>27.4.2</h2> <h3>Fixes</h3> <ul> <li><code>[jest-worker]</code> Add additional <code>execArgv</code> to filter (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12103">#12103</a>)</li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/JonWallsten"><code>@JonWallsten</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12103">facebook/jest#12103</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/facebook/jest/compare/v27.4.1...v27.4.2">https://github.com/facebook/jest/compare/v27.4.1...v27.4.2</a></p> <h2>v27.4.1</h2> <h3>Fixes</h3> <ul> <li><code>[jest-worker]</code> Filter <code>execArgv</code> correctly (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12097">#12097</a>)</li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/SuperOleg39"><code>@SuperOleg39</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/12097">facebook/jest#12097</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/facebook/jest/compare/v27.4.0...v27.4.1">https://github.com/facebook/jest/compare/v27.4.0...v27.4.1</a></p> <h2>v27.4.0</h2> <h3>Features</h3> <ul> <li><code>[expect]</code> Enhancing the <code>toHaveProperty</code> matcher to support array selection (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12092">#12092</a>)</li> <li><code>[jest-core]</code> Add support for <code>testResultsProcessor</code> written in ESM (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12006">#12006</a>)</li> <li><code>[jest-diff, pretty-format]</code> Add <code>compareKeys</code> option for custom sorting of object keys (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11992">#11992</a>)</li> <li><code>[jest-mock]</code> Add <code>ts-jest</code> mock util functions (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12089">#12089</a>)</li> </ul> <h3>Fixes</h3> <ul> <li><code>[expect]</code> Allow again <code>expect.Matchers</code> generic with single value (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11986">#11986</a>)</li> <li><code>[jest-circus, jest-jasmine2]</code> Avoid false concurrent test failures due to unhandled promise rejections (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11987">#11987</a>)</li> <li><code>[jest-config]</code> Add missing <code>slash</code> dependency to <code>package.json</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12080">#12080</a>)</li> <li><code>[jest-core]</code> Incorrect detection of open ZLIB handles (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12022">#12022</a>)</li> <li><code>[jest-diff]</code> Break dependency cycle (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/10818">#10818</a>)</li> <li><code>[jest-environment-jsdom]</code> Add <code>types/jsdom</code> dependency (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11999">#11999</a>)</li> <li><code>[jest-environment-jsdom]</code> Do not reset the global.document too early on teardown (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11871">#11871</a>)</li> <li><code>[jest-transform]</code> Improve error and warning messages (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11998">#11998</a>)</li> <li><code>[jest-worker]</code> Pass <code>execArgv</code> correctly to <code>worker_threads</code> worker (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12069">#12069</a>)</li> </ul> <h3>Chore & Maintenance</h3> <ul> <li><code>[docs]</code> CLI options alphabetized (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11586">#11586</a>)</li> <li><code>[jest-runner]</code> Add info regarding timers to forcedExit message(<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12083">#12083</a>)</li> <li><code>[*]</code> Replaced <code>substr</code> method with <code>substring</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12066">#12066</a>)</li> <li><code>[*]</code> Add <code>types</code> entry to all export maps (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12073">#12073</a>)</li> </ul> <h3>New Contributors</h3> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/facebook/jest/blob/main/CHANGELOG.md">pretty-format's changelog</a>.</em></p> <blockquote> <h2>27.4.2</h2> <h3>Fixes</h3> <ul> <li><code>[jest-worker]</code> Add additional <code>execArgv</code> to filter (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12103">#12103</a>)</li> </ul> <h2>27.4.1</h2> <h3>Fixes</h3> <ul> <li><code>[jest-worker]</code> Filter <code>execArgv</code> correctly (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12097">#12097</a>)</li> </ul> <h2>27.4.0</h2> <h3>Features</h3> <ul> <li><code>[expect]</code> Enhancing the <code>toHaveProperty</code> matcher to support array selection (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12092">#12092</a>)</li> <li><code>[jest-core]</code> Add support for <code>testResultsProcessor</code> written in ESM (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12006">#12006</a>)</li> <li><code>[jest-diff, pretty-format]</code> Add <code>compareKeys</code> option for custom sorting of object keys (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11992">#11992</a>)</li> <li><code>[jest-mock]</code> Add <code>ts-jest</code> mock util functions (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12089">#12089</a>)</li> </ul> <h3>Fixes</h3> <ul> <li><code>[expect]</code> Allow again <code>expect.Matchers</code> generic with single value (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11986">#11986</a>)</li> <li><code>[jest-circus, jest-jasmine2]</code> Avoid false concurrent test failures due to unhandled promise rejections (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11987">#11987</a>)</li> <li><code>[jest-config]</code> Add missing <code>slash</code> dependency to <code>package.json</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12080">#12080</a>)</li> <li><code>[jest-core]</code> Incorrect detection of open ZLIB handles (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12022">#12022</a>)</li> <li><code>[jest-diff]</code> Break dependency cycle (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/10818">#10818</a>)</li> <li><code>[jest-environment-jsdom]</code> Add <code>types/jsdom</code> dependency (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11999">#11999</a>)</li> <li><code>[jest-environment-jsdom]</code> Do not reset the global.document too early on teardown (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11871">#11871</a>)</li> <li><code>[jest-transform]</code> Improve error and warning messages (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11998">#11998</a>)</li> <li><code>[jest-worker]</code> Pass <code>execArgv</code> correctly to <code>worker_threads</code> worker (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12069">#12069</a>)</li> </ul> <h3>Chore & Maintenance</h3> <ul> <li><code>[docs]</code> CLI options alphabetized (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11586">#11586</a>)</li> <li><code>[jest-runner]</code> Add info regarding timers to forcedExit message(<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12083">#12083</a>)</li> <li><code>[*]</code> Replaced <code>substr</code> method with <code>substring</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12066">#12066</a>)</li> <li><code>[*]</code> Add <code>types</code> entry to all export maps (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/12073">#12073</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
Andrey Goncharov
|
debf872806 |
Allow to start only one instance of log listener and crash watcher
Summary: Changelog: Allow only a single crash watcher and a single log listener per device. Start log listener and crash watcher for every device upon connection. Remove commands to start/stop them externally. Monitored CPU load for a physical Android device with the log listener on and off. Did not notice any real difference. Resolved crashing adbkit-logcat by forcing the usage of 2.0.1. A proper fix would be to unify babel transforms for browser flipper and electron flipper, but we might re-think how we distribute flipper in the next half, so a simple hot fix might be a better use of time and resources. Reviewed By: mweststrate Differential Revision: D33132506 fbshipit-source-id: 39d422682a10a64830ac516e30f43f32f416819d |
||
|
Michel Weststrate
|
cea7be7fde |
Clean up globals
Summary: This diff is some boyscouting on cleaning up our globals, and stop using them inconsistently icmw global or window Reviewed By: aigoncharov Differential Revision: D33171108 fbshipit-source-id: 400893e5f31523631a7ab6fda428524c751901f1 |
||
|
Michel Weststrate
|
5df34a337c |
Unshare global types
Summary: This diff adds `types` fields on the compiler config for every project. This way we can make sure that for example node types and packages are not available in flipper-ui-core. Without an explicit types field, all types would be shared between all packages, and implicitly included into the compilation of everything. For the same reason `types/index.d.ts` has been removed, we want to be intentional on which types are being used in which package. This diff does most of the work, the next diff will fine tune the globals, and do some further cleanup. As an alternative solution I first tried a `nohoist: **/node_modules/types/**` and make sure every package list explicitly the types used in package json, which works but is much more error prone, as for example two different react types versions in two packages will cause the most unreadable compiler error due to the types not being shared and not literally the same. Reviewed By: lawrencelomax Differential Revision: D33124441 fbshipit-source-id: c2b9d768f845ac28005d8331ef5fa1066c7e4cd7 |
||
|
Michel Weststrate
|
dcfeb4a4d5 |
Clean up packages and types
Summary:
This diff removes most deps from the root package.json, which now only contains electron and shared build / test infra structure: lint, prettier, jest, typescript.
This makes it possible to control much better which packages are used where, as all sub packages now have their deps explicitly in their package.json instead of incidentally shared. This allows for example to disable DOM types for all packages by default (flipper-plugin, ui(-core) and app still request it), and in the next diff I hope to add to this that nodeJS types are no longer shared either, so that UI oriented packages will generate compile errors when using Node built-ins
This diff removes most deps that were currently unused, and dedupes a bunch of other ones, so the build should probably be a bit smaller now as well:
{F686704253}
{F686704295}
Reviewed By: antonk52
Differential Revision: D33062859
fbshipit-source-id: 5afaa4f2103d055188382a3370c1fffa295a298a
|
||
|
Michel Weststrate
|
78413c1ecf |
Register shortcuts on window instead of globally
Summary: Changelog: Register shortcuts only for Flipper application instead of globally. Fixes https://github.com/facebook/flipper/issues/3090 As reported, during decapitation we accidentally started registering shortcuts globally, rather per app as it used to be in the menu's. This diff fixes that and also makes sure shortcuts are supported in the browser version of flipper Reviewed By: lawrencelomax Differential Revision: D33158445 fbshipit-source-id: 8371e5b96e772152eeb93ba990e1f5edb9e67085 |
||
|
Michel Weststrate
|
ef2a86e7a8 |
Sdk path should be used when launching emulator
Summary: Changelog: Fixed issue where a missing ANDROID_SDK_ROOT env var made it impossible to launch emulators Run into an issue where ANDROID_SDK_ROOT wasn't set for my user, causing Flipper not to be able to launch emulator, which was looked up from the path rather than using the flipper settings. Fixes: https://github.com/facebook/flipper/issues/3119 Reviewed By: timur-valiev Differential Revision: D33158280 fbshipit-source-id: ea5616b10265ed43f1012c58da081be275ff1d5b |
||
|
Michel Weststrate
|
ac9080abac |
Remove 'process' usage
Summary: Removed process, adbkit and electron usages that were still remaining. Verified changes by disabling the built-in module stubbing (will be cleaned up further later in this stack). Reviewed By: aigoncharov Differential Revision: D33019083 fbshipit-source-id: 8bfce31f4b5ed349cb4fd86d34c9b41b9b8b8360 |
||
|
Michel Weststrate
|
ad4a55f263 |
move node types, stub node modules
Summary: This diff stubs all node modules when running in the browser, so that, albeit with a lot of errors and without plugins, the UI loads in a browser. To be continued in the rest of this diff Reviewed By: antonk52 Differential Revision: D32665705 fbshipit-source-id: 4632e241f59c5b9712a41d01a26878afb01f69b5 |
||
|
Michel Weststrate
|
d0402d7268 |
Move unloadModule to RenderHost
Summary: Define unload module on RenderHost. Not sure how to do that the browser and not sure how meaning full it is in a browser context. Reviewed By: nikoant Differential Revision: D32827050 fbshipit-source-id: 87025c6f5c2b950880712bff8df1c92a044a222e |
||
|
Michel Weststrate
|
2b2cbb1103 |
Move offline icon storage to app/
Summary: This diff splits Facebook management into a ui-core and electron part: * Cleaned up code and introduces a uniform Icon type to describe a requested icon * Computing icon urls is done in the ui-core * Introduced a RenderHost hook that can transform the request icon into a different url, in this case, a url to load icons from disk in production builds For the browser UI, the urls are currently no rewritten since we have only dev builds (which always used only FB urls already). We could do the same rewrite in the future and download the static assets during build time. But for now this means that in the browser implementation we depend on normal browser caching, with the biggest downside that icons might not appear if the user has no internet connections. With this change we lost our last usage of staticPath computations in ui-core Reviewed By: aigoncharov Differential Revision: D32767426 fbshipit-source-id: d573b6a373e649c7dacd380cf63a50c2dbbd9e70 |
||
|
Michel Weststrate
|
86995e0d11 |
Introduce static resource URLs
Summary: Introduced an API that converts a filepath, relatively to the `desktop/static/` folder in a url that can be resolved by the render environment. This will generate `file://` urls in Electron, and root relative `/` urls in browser envs Reviewed By: aigoncharov Differential Revision: D32767427 fbshipit-source-id: 378da7709bcb19449873358a8703b9c5a5809c57 |
||
|
Michel Weststrate
|
2a4fe77404 |
Extract environment config initialisation to server-core
Summary: This diff makes most stuff that is read from the `os` package, and version info etc available from the `serverConfig` object, so that flipper-ui-core no longer needs the `os` package. Reviewed By: passy Differential Revision: D32694848 fbshipit-source-id: 93af1e95d898da9aaf351a6970b5a7652ee835c8 |
||
|
Michel Weststrate
|
de59bbedd2 |
Make plugin loading async
Summary: This diff makes plugin loading async, which we'd need in a browser env (either because we'd use `import()` or we need to fetch the source and than eval it), and deals with all the fallout of that Reviewed By: timur-valiev Differential Revision: D32669995 fbshipit-source-id: 73babf38a6757c451b8200c3b320409f127b8b5b |
||
|
Michel Weststrate
|
f9b72ac69e |
Move RenderHost initialisation to Jest
Summary: This diff moves RenderHost initialisation to jest, which is thereby treated as just another 'Host' like flipper-ui, the electron app etc. A benefit is that it provides a mocked flipperServer by default that can be used to mock or intercept requests. See LaunchEmulator.spec as example. Also made the jest setup scripts strongly typed by converting them to TS. This change allows the test stub configuration, which was OS dependent, out of flipper-ui-core. Reviewed By: nikoant Differential Revision: D32668632 fbshipit-source-id: fac0c09812b000fd7d1acb75010c35573087c99f |
||
|
Michel Weststrate
|
5d45bd741b |
Initialise flipper-ui-browser with socket connection
Summary: This diff sets up the socket connection between flipper-browser and flipper-server, and verifies that the initial UI initialisation work (e.g. `get-config` command works). The initial RenderHost is initialised as well based on the config and browser APIs. Note that flipper-ui-core itself isn't started yet, as that has still a plethora of node imports, so Metro will correctly refuse to bundle Not in this diff * remove Node usage from flipper-ui-core * implement all RenderHost APIs Reviewed By: aigoncharov Differential Revision: D32644074 fbshipit-source-id: 2c8065caf0191771a3867b69a431ca50eeb7a5a3 |
||
|
Michel Weststrate
|
1308edc790 |
Start FlipperServerImpl as part of flipper-server
Summary: The previous started up a dev / web server for bundling in flipper-server, this diff starts the flipper server itself, so that we can connect the client to it (done in next diffs) Reviewed By: passy, aigoncharov Differential Revision: D32627390 fbshipit-source-id: b48de20f076e1e13842368d16a090708d533b69e |
||
|
Michel Weststrate
|
e742322eb1 |
Move keychain storage to server, some constants cleanup
Summary: This diff moves keychain storage to the server. Figured to leave request logic itself in the UI-core, as basically all use cases happen there, except for streaming download for mobile build plugin, so sending the requests from the backend doesn't really seem to add value, unless we run into some CORS issues later. Reviewed By: passy Differential Revision: D32596715 fbshipit-source-id: f5ab9d794f91a6eb8a8dc07ae723bf2890726771 |
||
|
Michel Weststrate
|
bca169df73 |
Move settings, launcherSettings, GKs to app / flipper-server-core
Summary: This diff moves a lot of stuff from the client to the server. This diff is fairly large, as a lot of concept closely relate, although some things have split off to the earlier diffs in the stack, or are still to follow (like making intern requests). This diff primarily moves reading and storing settings and GKs from client to server (both flipper and launcher settings). This means that settings are no longer persisted by Redux (which only exists on client). Most other changes are fallout from that. For now settings are just one big object, although we might need to separate settings that are only make sense in an Electron context. For example launcher settings. Reviewed By: passy, aigoncharov Differential Revision: D32498649 fbshipit-source-id: d842faf7a7f03774b621c7656e53a9127afc6192 |
||
|
Michel Weststrate
|
eed19b3a3d |
Move FlipperServer initialisation out of flipper-core
Summary: This diff makes sure flipper-ui-core no longer depends on flipper-server-core. Currently server config is still transferred from UI to server, which doesn't really make sense in future scenarios where server might start before client, but will address that separately Reviewed By: timur-valiev, aigoncharov Differential Revision: D32462835 fbshipit-source-id: 498a944256ba1aabbf963b896953e64d11e27214 |
||
|
dependabot[bot]
|
c399e6a8c1 |
Bump react-refresh from 0.10.0 to 0.11.0 in /desktop (#3083)
Summary: Bumps [react-refresh](https://github.com/facebook/react/tree/HEAD/packages/react) from 0.10.0 to 0.11.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/facebook/react/releases">react-refresh's releases</a>.</em></p> <blockquote> <h2>v0.11.0</h2> <h3>React Core</h3> <h4>Breaking Changes</h4> <ul> <li><code>getDefaultProps()</code> is now called once per class and shared across all instances</li> <li><code>MyComponent()</code> now returns a descriptor, not an instance</li> <li><code>React.isValidComponent</code> and <code>React.PropTypes.component</code> validate <em>descriptors</em>, not component instances</li> <li>Custom <code>propType</code> validators should return an <code>Error</code> instead of logging directly</li> </ul> <h4>New Features</h4> <ul> <li>Rendering to <code>null</code></li> <li>Keyboard events include normalized <code>e.key</code> and <code>e.getModifierState()</code> properties</li> <li>New normalized <code>onBeforeInput</code> event</li> <li><code>React.Children.count</code> has been added as a helper for counting the number of children</li> </ul> <h4>Bug Fixes</h4> <ul> <li>Re-renders are batched in more cases</li> <li>Events: <code>e.view</code> properly normalized</li> <li>Added Support for more HTML attributes (<code>coords</code>, <code>crossOrigin</code>, <code>download</code>, <code>hrefLang</code>, <code>mediaGroup</code>, <code>muted</code>, <code>scrolling</code>, <code>shape</code>, <code>srcSet</code>, <code>start</code>, <code>useMap</code>)</li> <li>Improved SVG support <ul> <li>Changing <code>className</code> on a mounted SVG component now works correctly</li> <li>Added support for elements <code>mask</code> and <code>tspan</code></li> <li>Added support for attributes <code>dx</code>, <code>dy</code>, <code>fillOpacity</code>, <code>fontFamily</code>, <code>fontSize</code>, <code>markerEnd</code>, <code>markerMid</code>, <code>markerStart</code>, <code>opacity</code>, <code>patternContentUnits</code>, <code>patternUnits</code>, <code>preserveAspectRatio</code>, <code>strokeDasharray</code>, <code>strokeOpacity</code></li> </ul> </li> <li>CSS property names with vendor prefixes (<code>Webkit</code>, <code>ms</code>, <code>Moz</code>, <code>O</code>) are now handled properly</li> <li>Duplicate keys no longer cause a hard error; now a warning is logged (and only one of the children with the same key is shown)</li> <li><code>img</code> event listeners are now unbound properly, preventing the error "Two valid but unequal nodes with the same <code>data-reactid</code>"</li> <li>Added explicit warning when missing polyfills</li> </ul> <h3>React With Addons</h3> <ul> <li>PureRenderMixin: a mixin which helps optimize "pure" components</li> <li>Perf: a new set of tools to help with performance analysis</li> <li>Update: New <code>$apply</code> command to transform values</li> <li>TransitionGroup bug fixes with null elements, Android</li> </ul> <h3>React NPM Module</h3> <ul> <li>Now includes the pre-built packages under <code>dist/</code>.</li> <li><code>envify</code> is properly listed as a dependency instead of a peer dependency</li> </ul> <h3>JSX</h3> <ul> <li>Added support for namespaces, eg <code><Components.Checkbox /></code></li> <li>JSXTransformer <ul> <li>Enable the same <code>harmony</code> features available in the command line with <code><script type="text/jsx;harmony=true"></code></li> <li>Scripts are downloaded in parallel for more speed. They are still executed in order (as you would expect with normal script tags)</li> <li>Fixed a bug preventing sourcemaps from working in Firefox</li> </ul> </li> </ul> <h3>React Tools Module</h3> <ul> <li>Improved readme with usage and API information</li> <li>Improved ES6 transforms available with <code>--harmony</code> option</li> <li>Added <code>--source-map-inline</code> option to the <code>jsx</code> executable</li> <li>New <code>transformWithDetails</code> API which gives access to the raw sourcemap data</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/facebook/react/blob/main/CHANGELOG.md">react-refresh's changelog</a>.</em></p> <blockquote> <h2>0.11.0 (July 17, 2014)</h2> <h3>React Core</h3> <h4>Breaking Changes</h4> <ul> <li><code>getDefaultProps()</code> is now called once per class and shared across all instances</li> <li><code>MyComponent()</code> now returns a descriptor, not an instance</li> <li><code>React.isValidComponent</code> and <code>React.PropTypes.component</code> validate <em>descriptors</em>, not component instances</li> <li>Custom <code>propType</code> validators should return an <code>Error</code> instead of logging directly</li> </ul> <h4>New Features</h4> <ul> <li>Rendering to <code>null</code></li> <li>Keyboard events include normalized <code>e.key</code> and <code>e.getModifierState()</code> properties</li> <li>New normalized <code>onBeforeInput</code> event</li> <li><code>React.Children.count</code> has been added as a helper for counting the number of children</li> </ul> <h4>Bug Fixes</h4> <ul> <li>Re-renders are batched in more cases</li> <li>Events: <code>e.view</code> properly normalized</li> <li>Added Support for more HTML attributes (<code>coords</code>, <code>crossOrigin</code>, <code>download</code>, <code>hrefLang</code>, <code>mediaGroup</code>, <code>muted</code>, <code>scrolling</code>, <code>shape</code>, <code>srcSet</code>, <code>start</code>, <code>useMap</code>)</li> <li>Improved SVG support <ul> <li>Changing <code>className</code> on a mounted SVG component now works correctly</li> <li>Added support for elements <code>mask</code> and <code>tspan</code></li> <li>Added support for attributes <code>dx</code>, <code>dy</code>, <code>fillOpacity</code>, <code>fontFamily</code>, <code>fontSize</code>, <code>markerEnd</code>, <code>markerMid</code>, <code>markerStart</code>, <code>opacity</code>, <code>patternContentUnits</code>, <code>patternUnits</code>, <code>preserveAspectRatio</code>, <code>strokeDasharray</code>, <code>strokeOpacity</code></li> </ul> </li> <li>CSS property names with vendor prefixes (<code>Webkit</code>, <code>ms</code>, <code>Moz</code>, <code>O</code>) are now handled properly</li> <li>Duplicate keys no longer cause a hard error; now a warning is logged (and only one of the children with the same key is shown)</li> <li><code>img</code> event listeners are now unbound properly, preventing the error "Two valid but unequal nodes with the same <code>data-reactid</code>"</li> <li>Added explicit warning when missing polyfills</li> </ul> <h3>React With Addons</h3> <ul> <li>PureRenderMixin: a mixin which helps optimize "pure" components</li> <li>Perf: a new set of tools to help with performance analysis</li> <li>Update: New <code>$apply</code> command to transform values</li> <li>TransitionGroup bug fixes with null elements, Android</li> </ul> <h3>React NPM Module</h3> <ul> <li>Now includes the pre-built packages under <code>dist/</code>.</li> <li><code>envify</code> is properly listed as a dependency instead of a peer dependency</li> </ul> <h3>JSX</h3> <ul> <li>Added support for namespaces, eg <code><Components.Checkbox /></code></li> <li>JSXTransformer <ul> <li>Enable the same <code>harmony</code> features available in the command line with <code><script type="text/jsx;harmony=true"></code></li> <li>Scripts are downloaded in parallel for more speed. They are still executed in order (as you would expect with normal script tags)</li> <li>Fixed a bug preventing sourcemaps from working in Firefox</li> </ul> </li> </ul> <h3>React Tools Module</h3> <ul> <li>Improved readme with usage and API information</li> <li>Improved ES6 transforms available with <code>--harmony</code> option</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/facebook/react/commits/v0.11.0/packages/react">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/3083 Reviewed By: lblasa Differential Revision: D32674349 Pulled By: passy fbshipit-source-id: 76cf85a26763c82aa732902bf22e5ad1b436b1cd |
||
|
Andrey Goncharov
|
225a2a7e34 |
Refactor Stella plugin
Summary: 1. Replace old FileSelector with the new FileSelector 2. Remove showOpenDialog from FlipperLib Reviewed By: mweststrate Differential Revision: D32667103 fbshipit-source-id: be8da034c2695f83b397b6c7d35bc6aee78d66e5 |
||
|
Andrey Goncharov
|
3491926d17 |
Support importing multiple files and encoding
Summary: 1. Support importing multiple files 2. Support file encoding Reviewed By: mweststrate Differential Revision: D32540132 fbshipit-source-id: 7c2a96ac585f58d01457cb487527940e333da615 |
||
|
Andrey Goncharov
|
a279b9bc43 |
Remove fs.readFile from some plugins
Summary: 1. Remove fs.readFile from some plugins 2. Add "importFile" to FlipperLib and RenderHost See D32492149 for context Followups: 1. Decapitate Stella's sendToPhone 2. Decapitate crash reporter 3. Figure out how to approach navigation 4. Figure out how to approach FileSelector Reviewed By: mweststrate Differential Revision: D32496775 fbshipit-source-id: e150aa56a2c2c1eb12a4c03c801f76cd76485a9d |
||
|
Andrey Goncharov
|
2c7bc0a952 |
Remove fs.write from plugins
Summary: 1. Remove "fs.writeFile" from plugins 2. Remove "showSaveDialog" from "FlipperLib" 3. Add "exportFile" to "FlipperLib" and "RenderHost" As we are going to use Flipper in a browser as well, instead of providing low-level abstraction like "showSaveDialog", we should provide more high-level ones like "exportFile". In browsers it does not make too much sense to expose "showSaveDialog" as there is not way to use the returned file path to write to it. In the end, "exportFile" is going to trigger a file download for browsers and show the save dialog and write to the returned file path for Electron. Reviewed By: mweststrate Differential Revision: D32492149 fbshipit-source-id: 0673119bdb7670a5872f5982c7d82dfc44eb7906 |
||
|
Michel Weststrate
|
7e50c0466a |
Move app/src (mostly) to flipper-ui-core/src
Summary: This diff moves all UI code from app/src to app/flipper-ui-core. That is now slightly too much (e.g. node deps are not removed yet), but from here it should be easier to move things out again, as I don't want this diff to be open for too long to avoid too much merge conflicts. * But at least flipper-ui-core is Electron free :) * Killed all cross module imports as well, as they where now even more in the way * Some unit test needed some changes, most not too big (but emotion hashes got renumbered in the snapshots, feel free to ignore that) * Found some files that were actually meaningless (tsconfig in plugins, WatchTools files, that start generating compile errors, removed those Follow up work: * make flipper-ui-core configurable, and wire up flipper-server-core in Electron instead of here * remove node deps (aigoncharov) * figure out correct place to load GKs, plugins, make intern requests etc., and move to the correct module * clean up deps Reviewed By: aigoncharov Differential Revision: D32427722 fbshipit-source-id: 14fe92e1ceb15b9dcf7bece367c8ab92df927a70 |
||
Pascal Hartig
|
54b7ce9308 |
Add back support for flipper://welcome
Summary: This was removed as part of the deeplink restructuring. Turns out this is actually useful in addition to the `flipper://` as some normalisation algos (notably VSCode's) remove the `//` otherwise. Reviewed By: nikoant Differential Revision: D32428872 fbshipit-source-id: ec89b1ab561504996da5d02521b91562245554a0 |
||
|
Andrey Goncharov
|
eb28fc411b |
Encapsulate electron bar setup
Summary: See D32311662 for details Reviewed By: mweststrate Differential Revision: D32357953 fbshipit-source-id: f951e82761f081876ae8e0409f00e19e87047726 |
||
|
Andrey Goncharov
|
15a59c3aea |
Combine lef nav entries under a single menu
Summary: See D32311662 for details Reviewed By: mweststrate Differential Revision: D32356865 fbshipit-source-id: 065a580f3ce0aacc786c1de2b5fc713a86f0567f |
||
|
Andrey Goncharov
|
ed5c2bd39f |
Add plugin actions menu
Summary: See D32311662 for details Reviewed By: mweststrate Differential Revision: D32329804 fbshipit-source-id: 26670353fdf8580643afcb8bc3493384146f5574 |
||
|
Andrey Goncharov
|
2591d1629e |
Add import/export left rail menu
Summary: See D32311662 for details Reviewed By: mweststrate Differential Revision: D32316987 fbshipit-source-id: c2d173f981cce1b148f463d981977e23258ffc02 |
||
|
Andrey Goncharov
|
32f722264f |
Add changelog button to welcome screen
Summary: ## Overall goal Decouple top menu from electron ## Approach We have two options to solve it: 1. Leave the menu as-is for electron. Add a new menu to the left nav for other target envs. 2. Add a new menu to the left nav for all target envs. Leave only electron-specific options in the electron top menu. This stack of diffs (D32311662, D32316987, D32329804, TDB) implements the second option. The primary reason is to have unified user-experience. If our users on different platforms have the same experience, it is easier for us to propagate knowledge and debug issues. ## Implementation plan 1. Move changelog to the welcome screen (D32311662) 2. Move import/export functionality to a dedicated menu in the left nav (D32316987) 3. Move plugin actions button to the toolbox with screen recording buttons (D32329804) 4. Collapse some left rail items under a single menu (D32356865) 5. Clean up the rest of electron menu items (D32357953) ## Followup Return to re-grouping of the left rail buttons and toggles after decapitation Reviewed By: mweststrate Differential Revision: D32311662 fbshipit-source-id: e2c4bc1a7bd2c167335fcd6d76276ae7c4947859 |
||
|
dependabot[bot]
|
adaa4b544a |
Bump react-redux from 7.2.4 to 7.2.6 in /desktop (#3035)
Summary: Bumps [react-redux](https://github.com/reduxjs/react-redux) from 7.2.4 to 7.2.6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/reduxjs/react-redux/releases">react-redux's releases</a>.</em></p> <blockquote> <h2>v7.2.6</h2> <p><em>Shameless plug: <a href="https://spaceship.run/">I'm working on a new company called Spaceship 🚀</a> It's a tool to launch your code anywhere in one click. Check it out!</em></p> <p>Just a quick fix for a Yarn install warning. Sorry about the noise!</p> <h2><a href="https://github.com/reduxjs/react-redux/compare/v7.2.5...v7.2.6">Changes</a></h2> <ul> <li>Remove <code>workspaces</code> from our package.json to silence a Yarn warning (<a href="https://github.com/timdorr"><code>@timdorr</code></a>)</li> </ul> <h2>v7.2.5</h2> <p>This release shrinks the size of our internal <code>Subscription</code> class, and updates <code>useSelector</code> to avoid an unnecessary selector call on mount.</p> <h2>Changes</h2> <h3>Subscription Size Refactor</h3> <p>Our internal <code>Subscription</code> implementation has been written as a class ever since it was added in v5. By rewriting it as a closure factory, we were able to shave a few bytes off the final bundle size.</p> <h3><code>useSelector</code> Mount Optimization</h3> <p>A user noticed that <code>useSelector</code> had never been given an early "bail out if the root state is the same" check to match how <code>connect</code> works. This resulted in a usually-unnecessary second call to the provided selector on mount. We've added that check.</p> <h3>Entry Point Consolidation</h3> <p>We've consolidated the list of exported public APIs into a single file, and both the <code>index.js</code> and <code>alternate-renderers.js</code> entry points now re-export everything from that file. No meaningful change here, just shuffling lines of code around for consistency.</p> <h2>Other Updates</h2> <h3>React-Redux v8 and React 18 Development</h3> <p>With <a href="https://github.com/reactwg/react-18/discussions/4">the announcement of React 18</a>, we've been working with the React team to plan our migration path to keep React-Redux fully compatible with React's upcoming features.</p> <p>We've already <a href="https://github-redirect.dependabot.com/reduxjs/react-redux/issues/1737">migrated the React-Redux main development branch to TypeScript</a>, and are <a href="https://github-redirect.dependabot.com/reduxjs/react-redux/pull/1808">prototyping compatibility implementation updates</a>. We'd appreciate any assistance from the community in testing out these changes so that we can ensure React-Redux works great for everyone when React 18 is ready!</p> <h3>Internal Tooling Updates</h3> <p>Our <code>master</code> branch now uses Yarn v2 for package management, is built with TypeScript, and we've made CI updates to test against multiple TS versions.</p> <p>The <code>7.x</code> branch has also been updated to use Yarn v2 for consistency.</p> <p>These only affect contributors to the React-Redux package itself.</p> <h2>Changelog</h2> <ul> <li>Port entry point consolidation from 8.x branch (<a href="https://github-redirect.dependabot.com/reduxjs/react-redux/issues/1811">https://github.com/facebook/flipper/issues/1811</a> - <a href="https://github.com/markerikson"><code>@markerikson</code></a>)</li> <li>Update v7 branch to use Yarn v2 and improve CI process (<a href="https://github-redirect.dependabot.com/reduxjs/react-redux/issues/1810">https://github.com/facebook/flipper/issues/1810</a> - <a href="https://github.com/markerikson"><code>@markerikson</code></a>)</li> <li>Reduce unnecessary calls to useSelector selector (<a href="https://github-redirect.dependabot.com/reduxjs/react-redux/issues/1803">https://github.com/facebook/flipper/issues/1803</a> - <a href="https://github.com/sufian-slack"><code>@sufian-slack</code></a> )</li> <li>Port Subscription closure implementation from 8.x to 7.x (<a href="https://github-redirect.dependabot.com/reduxjs/react-redux/issues/1809">https://github.com/facebook/flipper/issues/1809</a> - <a href="https://github.com/mbelsky"><code>@mbelsky</code></a>)</li> </ul> <p><a href="https://github.com/reduxjs/react-redux/compare/v7.2.4...v7.2.5">https://github.com/reduxjs/react-redux/compare/v7.2.4...v7.2.5</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Michel Weststrate
|
8596dd951b |
re-expose redux connect
Summary: Some old and public plugins use `connect` from Flipper. Long deprecated, but alas, not breaking those instances doesn't cost us anything. Reviewed By: lblasa Differential Revision: D32245550 fbshipit-source-id: 01313ded36c042cb75c8e7841046facb3f26ec06 |
||
|
dependabot[bot]
|
07468fdfd1 |
Bump pretty-format from 27.2.5 to 27.3.1 in /desktop (#2991)
Summary: Bumps [pretty-format](https://github.com/facebook/jest/tree/HEAD/packages/pretty-format) from 27.2.5 to 27.3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/facebook/jest/releases">pretty-format's releases</a>.</em></p> <blockquote> <h2>v27.3.1</h2> <h2>Fixes</h2> <ul> <li><code>[expect]</code> Make <code>expect</code> extension properties <code>configurable</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11978">#11978</a>)</li> <li><code>[expect]</code> Fix <code>.any()</code> checks on primitive wrapper classes (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11976">#11976</a>)</li> </ul> <h2>Chore & Maintenance</h2> <ul> <li><code>[expect]</code> <code>BigInt</code> global is always defined, don't check for its existence at runtime (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11979">#11979</a>)</li> <li><code>[jest-config, jest-util]</code> Use <code>ci-info</code> instead of <code>is-ci</code> to detect CI environment (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11973">#11973</a>)</li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/posva"><code>@posva</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/11974">facebook/jest#11974</a></li> <li><a href="https://github.com/blaky"><code>@blaky</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/11978">facebook/jest#11978</a></li> <li><a href="https://github.com/lobsterkatie"><code>@lobsterkatie</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/11976">facebook/jest#11976</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/facebook/jest/compare/v27.3.0...v27.3.1">https://github.com/facebook/jest/compare/v27.3.0...v27.3.1</a></p> <h2>27.3.0</h2> <h2>Features</h2> <ul> <li><code>[jest-config]</code> Add <code>testEnvironmentOptions.html</code> to apply to jsdom input (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11950">#11950</a>)</li> <li><code>[jest-resolver]</code> Support default export (<code>.</code>) in <code>exports</code> field <em>if</em> <code>main</code> is missing (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11919">#11919</a>)</li> </ul> <h2>Fixes</h2> <ul> <li><code>[expect]</code> Tweak and improve types (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11949">#11949</a>)</li> <li><code>[jest-runtime]</code> Ensure absolute paths can be resolved within test modules (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11943">#11943</a>)</li> <li><code>[jest-runtime]</code> Fix <code>instanceof</code> for <code>ModernFakeTimers</code> and <code>LegacyFakeTimers</code> methods (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11946">#11946</a>)</li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/airhorns"><code>@airhorns</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/11943">facebook/jest#11943</a></li> <li><a href="https://github.com/mrienstra"><code>@mrienstra</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/11942">facebook/jest#11942</a></li> <li><a href="https://github.com/minijus"><code>@minijus</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/11946">facebook/jest#11946</a></li> <li><a href="https://github.com/MarvelSQ"><code>@MarvelSQ</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/11950">facebook/jest#11950</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/facebook/jest/compare/v27.2.5...v27.3.0">https://github.com/facebook/jest/compare/v27.2.5...v27.3.0</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/facebook/jest/blob/main/CHANGELOG.md">pretty-format's changelog</a>.</em></p> <blockquote> <h2>27.3.1</h2> <h3>Fixes</h3> <ul> <li><code>[expect]</code> Make <code>expect</code> extension properties <code>configurable</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11978">#11978</a>)</li> <li><code>[expect]</code> Fix <code>.any()</code> checks on primitive wrapper classes (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11976">#11976</a>)</li> </ul> <h3>Chore & Maintenance</h3> <ul> <li><code>[expect]</code> <code>BigInt</code> global is always defined, don't check for its existence at runtime (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11979">#11979</a>)</li> <li><code>[jest-config, jest-util]</code> Use <code>ci-info</code> instead of <code>is-ci</code> to detect CI environment (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11973">#11973</a>)</li> </ul> <h2>27.3.0</h2> <h3>Features</h3> <ul> <li><code>[jest-config]</code> Add <code>testEnvironmentOptions.html</code> to apply to jsdom input (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11950">#11950</a>)</li> <li><code>[jest-resolver]</code> Support default export (<code>.</code>) in <code>exports</code> field <em>if</em> <code>main</code> is missing (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11919">#11919</a>)</li> </ul> <h3>Fixes</h3> <ul> <li><code>[expect]</code> Tweak and improve types (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11949">#11949</a>)</li> <li><code>[jest-runtime]</code> Ensure absolute paths can be resolved within test modules (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11943">#11943</a>)</li> <li><code>[jest-runtime]</code> Fix <code>instanceof</code> for <code>ModernFakeTimers</code> and <code>LegacyFakeTimers</code> methods (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11946">#11946</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
b9e41cc787 |
Bump @emotion/css from 11.1.3 to 11.5.0 in /desktop (#3020)
Summary: Bumps [emotion/css](https://github.com/emotion-js/emotion) from 11.1.3 to 11.5.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/emotion-js/emotion/releases"><code>@emotion/css</code>'s releases</a>.</em></p> <blockquote> <h2><code>@emotion/css</code><a href="https://github.com/11"><code>@11</code></a>.5.0</h2> <h3>Patch Changes</h3> <ul> <li> <p><a href="https://github-redirect.dependabot.com/emotion-js/emotion/pull/2498">https://github.com/facebook/flipper/issues/2498</a> <a href=" |
||
|
dependabot[bot]
|
3a7757e08d |
Bump @testing-library/dom from 8.9.1 to 8.10.1 in /desktop (#3021)
Summary: Bumps [testing-library/dom](https://github.com/testing-library/dom-testing-library) from 8.9.1 to 8.10.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/testing-library/dom-testing-library/releases"><code>@testing-library/dom</code>'s releases</a>.</em></p> <blockquote> <h2>v8.10.1</h2> <h2><a href="https://github.com/testing-library/dom-testing-library/compare/v8.10.0...v8.10.1">8.10.1</a> (2021-10-18)</h2> <h3>Bug Fixes</h3> <ul> <li>Bump dom-accessibility-api (<a href="https://github-redirect.dependabot.com/testing-library/dom-testing-library/issues/1063">https://github.com/facebook/flipper/issues/1063</a>) (<a href=" |
||
|
dependabot[bot]
|
199b14a4eb |
Bump @emotion/react from 11.4.1 to 11.5.0 in /desktop (#3022)
Summary: Bumps [emotion/react](https://github.com/emotion-js/emotion) from 11.4.1 to 11.5.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/emotion-js/emotion/releases"><code>@emotion/react</code>'s releases</a>.</em></p> <blockquote> <h2><code>@emotion/react</code><a href="https://github.com/11"><code>@11</code></a>.5.0</h2> <h3>Patch Changes</h3> <ul> <li> <p><a href="https://github-redirect.dependabot.com/emotion-js/emotion/pull/2498">https://github.com/facebook/flipper/issues/2498</a> <a href=" |
||
|
Pascal Hartig
|
72c886e91f |
Fix reading of launcher settings
Summary: Noticed in a bug report that the read value was `[object Promise]`. This wasn't a huge issue before because the worst case was that when writing settings, it would replace them again with the defaults, but still not great. Reviewed By: mweststrate Differential Revision: D32181718 fbshipit-source-id: cf6cd7aa3bd823845d6657c5466fbcdef6adac28 |
||
|
Pascal Hartig
|
3bc8cbc5c5 |
Add comments for remaining events
Summary: Ugh, VS Code blocked on the formatter and didn't include these in my previous commit. Reviewed By: mweststrate Differential Revision: D32179985 fbshipit-source-id: e8cf178996bc3b468c88023a5c48e69271758e07 |
||
|
Pascal Hartig
|
513c475e3d |
Add comments for interaction events
Summary: Per title Reviewed By: mweststrate Differential Revision: D32171224 fbshipit-source-id: b7610e8c10674d56e75468f46a3fd0664d70b4aa |
||
Abhishek Nandwana
|
2f471cc2b2 |
Visual changes to let the user easily know what release channel they are using
Summary: 1. Added a text label similar to the launch screen that tells user the release channel they are using. 2. Show a different coloured logo when the user is using the "Insiders" channel. I have tried to keep the style as similar to the launch screen as possible for consistency. Reviewed By: passy Differential Revision: D32169268 fbshipit-source-id: f119a379fce983d9df765ede94148a4deaa31c9c |
||
Gerard Delmas
|
6bcb5a435b |
Hide "no application selected" warning when there is no device
Summary: In the left App Inspect sidebar on Flipper there were two warning messages - "no devices found" - "no application selected" As there can be no application selected, while no device is active, this change removes the "no application selected" warning. Resulting in only showing one warning at a time. As I am not familiar with all the states, nor what kind of devices or applications can exist in detail, I have moved up the logic to show the "no device found" message. Then reused it for the "no application selected" visibility. In case the upper device list can show "connecting" without an actual device in the list, the "no application selected" message will be shown. Reviewed By: passy Differential Revision: D32139077 fbshipit-source-id: 06456e81fbe1f86d65f9aba598ee84ed8cd6b043 |
||
|
Michel Weststrate
|
2e7015388c |
Remove remaining Electron imports from product code: paths & env
Summary: This diff removes most remaining Electron imports, by storing env and path constants on the RenderHost. As nice side effect those paths are all cached now as well. To make sure RenderHost is initialised before Flipper itself, forced loading Flipper through a require. Otherwise the setup is super sensitive to circular import statements, since a lot of module initialisation code depends on those paths / env vars. Reviewed By: nikoant Differential Revision: D31992230 fbshipit-source-id: 91beb430902272aaf4b051b35cdf12d2fc993347 |
||
|
Michel Weststrate
|
72ce759e61 |
Remove some unhandled rejections in tests
Summary: Fixed several tests that caused uncaught promise rejects to fire after the tests finished. This caused jest to fail if there are too many of them. Reviewed By: aigoncharov Differential Revision: D32118124 fbshipit-source-id: 50734dab6dee2efec7f056940af72858b27b1707 |
||
|
Michel Weststrate
|
64e791e253 |
Remove usage of Electron context menus
Summary: Removed the usage of electron's native context menus, and replaces it with Antd based context menu's. Reviewed By: passy Differential Revision: D31990756 fbshipit-source-id: 0312cbac5fd20a1a30603ce1058c03f4291b23b1 |