Summary:
Based on issue https://github.com/facebook/flipper/issues/1509 I needed a custom port for the metro server to pass to flipper.
## Changelog
introduce `METRO_SERVER_PORT` env variable to be able to customize default 8081 port on startup.
Pull Request resolved: https://github.com/facebook/flipper/pull/2050
Test Plan:
Tested with a locally built linux desktop app, this seems to work OK pour hermes debugging & RN logging.
React DevTools don't seem to find the running app, maybe there's a mapping to handle there too ?
Reviewed By: jknoxville
Differential Revision: D27339006
Pulled By: passy
fbshipit-source-id: b1700c4fe73f14bf4617e23583b2954012e0a5aa
Summary:
Thought I'd add this to the getting started, since so many people end up downloading the release directly.
## Changelog
Added `brew` instructions for mac
Pull Request resolved: https://github.com/facebook/flipper/pull/2108
Test Plan: Just docs, so no testing needed
Reviewed By: mweststrate
Differential Revision: D27398664
Pulled By: passy
fbshipit-source-id: be9cc7007e7c5dc717aad60ec0591d4ca0d100cb
Summary:
This PR adds missing Objective-C entry to the Docusaurus config, fixes Objective-C code blocks label and adds or replaces several code block labels to improve the currently highlighted blocks.
Prism in Docusaurus by default also includes syntax highlight for `jsx` and `tsx`, which improves the nodes and props highlight, so I have used those syntaxes in few places too.
I have also fixed one typo that I have spotted and my IDE made a cleanup of whitespaces in edited files.
## Changelog
* [website] improve docs code blocks highlighting
Pull Request resolved: https://github.com/facebook/flipper/pull/2049
Test Plan:
The changes have been tested running Flipper website on `localhost`.
## Preview
<img width="650" alt="Screenshot 2021-03-12 150934" src="https://user-images.githubusercontent.com/719641/110951135-fff20d00-8344-11eb-96db-1bdc82c8d5ea.png">
<img width="649" alt="Screenshot 2021-03-12 151022" src="https://user-images.githubusercontent.com/719641/110951268-2ca62480-8345-11eb-9d3b-1a48f1267776.png">
Reviewed By: priteshrnandgaonkar
Differential Revision: D27336599
Pulled By: passy
fbshipit-source-id: c2dfb3d8cad4675da0f5e1270cada1e56a0175c0
Summary: This moves `<DetailSidebar>` component to `flipper-plugin` and documents it. No semantic changes.
Reviewed By: passy
Differential Revision: D27234575
fbshipit-source-id: 74640602d718f84ad999f5dac0420089796ed7fb
Summary:
Update the LeakCanary 2 plugin version in LeakCanary 2 plugin doc
While adding the version as in the doc, the import statements didn't work. Upon checking the maven repo, I found out that the latest version is `0.81.0`. Updating to the latest version helps
## Changelog
Updated LeakCanary 2 plugin docs to include the latest plugin version
Pull Request resolved: https://github.com/facebook/flipper/pull/2085
Test Plan: Not necessary
Reviewed By: mweststrate
Differential Revision: D27265598
Pulled By: passy
fbshipit-source-id: 2f82689c1f075c2f9cff8bae2831c9780a3db697
Summary:
Beyond a search across all columns, it is now possible to specific columns for specific values:
* for a row to be visible, all active column filters need to be matched (e.g. both a filter on time and app has to be satisfied)
* if multiple values within a column are filtered for, these are -or-ed.
* if no value at all within a column is checked, even when they are defined, the column won't take part in filtering
* if there is a general search and column filters, a row has to satisfy both
Filters can be preconfigured, pre-configured filters cannot be removed.
Reseting will reset the filters back to their original
Move `useMemoize` to flipper-plugin
Merged the `ui/utils` and `utils` folder inside `flipper-plugin`
Reviewed By: nikoant
Differential Revision: D26450260
fbshipit-source-id: 11693d5d140cea03cad91c1e0f3438d7b129cf29
Summary:
First rudementary setup of DataTable component that follows a data source. Initially used react-virtuose library, but it performed really badly by doing expensive layout shifts and having troublesome scroll handling. Switched to react-virtual library, which is a bit more level, but much more efficient, and the source code is actually understandable :)
Features:
- hook up to window events of datasource
- high and low prio rendering, based on where the change is happening (should be optimized further)
- sticky scrolling support
- initial column configuration (custom rendering, styling, columns etc will follow in next diffs)
Reviewed By: nikoant
Differential Revision: D26175665
fbshipit-source-id: 224be13b1b32d35e7e01c1dc4198811e2af31102
Summary:
For context see https://fb.workplace.com/notes/470523670998369
This diff introduces the DataSource abstraction, that can store records. If a key is set a key -> record mapping is stored, to make it easy to update existing records using `upsert`, without knowing their exact index.
Internal storage will be slightly altered in upcoming diffs, so don't pay to much attention to that part.
Reviewed By: nikoant
Differential Revision: D25953337
fbshipit-source-id: 1c3b53a2fcf61abaf061946be4af21d2aecc6c6d
Summary:
Noticed this when building the site. Shame it only warns and doesn't fail the build.
Just fixing it while I'm here.
{F479009268}
Reviewed By: nikoant
Differential Revision: D26911725
fbshipit-source-id: 6440a4b8aee4a6bc053ae771a3b148fd70ffc298
Summary:
Not sure if I made this clearer or even more confusing,
but it's a try.
Reviewed By: mweststrate
Differential Revision: D26781610
fbshipit-source-id: d68b30ffe6b24d537473c2d85b2b74f425068a96
Summary: Added some pointers for everyone who is as iOS noobish as me.
Reviewed By: priteshrnandgaonkar
Differential Revision: D26777687
fbshipit-source-id: 1ba3bb08b5a7b3a3ba937176d4c4c9b5e765a977
Summary: `install` is now ambiguous because of some new plugins we've added.
Reviewed By: mweststrate
Differential Revision: D26633940
fbshipit-source-id: 62369ba76cced905350e62b7782619811b7284a0
Summary:
Upgrade the static docs plugin.
You no longer need to import OssOnly and FbInternalOnly in markdown files, so removed those imports too.
Reviewed By: passy
Differential Revision: D26580059
fbshipit-source-id: 2763de2f5fbef41ec2ac7f7bdd147418badb78b6
Summary: Updated docs to mention the new way of specifying device plugins compatibility metadata.
Reviewed By: mweststrate
Differential Revision: D26424203
fbshipit-source-id: 313e15ee54a8877c95850a37a13c5684b3c165f0
Summary:
Tried to give as much context here not just for how it works but also
how to set it up. For other projects and if we need to redo something.
Reviewed By: mweststrate
Differential Revision: D26400452
fbshipit-source-id: 9b41fd1a36c45554c7a7b562b73b4b9753f7ecfe
Summary: Still need to update the actual release doc. That's next.
Reviewed By: mweststrate
Differential Revision: D26399883
fbshipit-source-id: 87c27b254f4def07810a99fd0e1c817b6afb967e
Summary:
Introduced `isConnected` flag on device and plugin client to reflect whether a connection is still available for the plugins, or that they have been disconnected.
Potentially we could expose the (readonly) `connected` state atom for this as well, or an `onDisconnect` event for device pugins, to create a responsive UI, but there might be no need for that, in which case this suffices.
Reviewed By: nikoant
Differential Revision: D26249346
fbshipit-source-id: b8486713fdf2fcd520488ce54f771bd038fd13f8
