flipper

jens/flipper

Fork 0

Commit Graph

Author	SHA1	Message	Date
Michel Weststrate	afa2c6322a	make lint error on missing keys Summary: When exploratory testing Flipper, I generally see quite some React key warnings. So it seems that plugin devs often miss them. This diff will configure linting more aggressively to address that (it's not fool proof, but will find the most common cases). Reviewed By: nikoant Differential Revision: D26722707 fbshipit-source-id: e0d2b56de2422e1147f52c8e9150d00c7ee64bd2	2021-03-02 01:17:13 -08:00
Pascal Hartig	fc9ed65762	prettier 2 Summary: Quick notes: - This looks worse than it is. It adds mandatory parentheses to single argument lambdas. Lots of outrage on Twitter about it, personally I'm {emoji:1f937_200d_2642} about it. - Space before function, e.g. `a = function ()` is now enforced. I like this because both were fine before. - I added `eslint-config-prettier` to the config because otherwise a ton of rules conflict with eslint itself. Close https://github.com/facebook/flipper/pull/915 Reviewed By: jknoxville Differential Revision: D20594929 fbshipit-source-id: ca1c65376b90e009550dd6d1f4e0831d32cbff03	2020-03-24 09:38:11 -07:00
Anton Nikolaev	10d990c32c	Move plugins to "sonar/desktop/plugins" Summary: Plugins moved from "sonar/desktop/src/plugins" to "sonar/desktop/plugins". Fixed all the paths after moving. New "desktop" folder structure: - `src` - Flipper desktop app JS code executing in Electron Renderer (Chrome) process. - `static` - Flipper desktop app JS code executing in Electron Main (Node.js) process. - `plugins` - Flipper desktop JS plugins. - `pkg` - Flipper packaging lib and CLI tool. - `doctor` - Flipper diagnostics lib and CLI tool. - `scripts` - Build scripts for Flipper desktop app. - `headless` - Headless version of Flipper desktop app. - `headless-tests` - Integration tests running agains Flipper headless version. Reviewed By: mweststrate Differential Revision: D20344186 fbshipit-source-id: d020da970b2ea1e001f9061a8782bfeb54e31ba0	2020-03-14 14:35:18 -07:00

Author

SHA1

Message

Date

Michel Weststrate

afa2c6322a

make lint error on missing keys

Summary: When exploratory testing Flipper, I generally see quite some React key warnings. So it seems that plugin devs often miss them. This diff will configure linting more aggressively to address that (it's not fool proof, but will find the most common cases).

Reviewed By: nikoant

Differential Revision: D26722707

fbshipit-source-id: e0d2b56de2422e1147f52c8e9150d00c7ee64bd2

2021-03-02 01:17:13 -08:00

Pascal Hartig

fc9ed65762

prettier 2

Summary:
Quick notes:

- This looks worse than it is. It adds mandatory parentheses to single argument lambdas. Lots of outrage on Twitter about it, personally I'm {emoji:1f937_200d_2642} about it.
- Space before function, e.g. `a = function ()` is now enforced. I like this because both were fine before.
- I added `eslint-config-prettier` to the config because otherwise a ton of rules conflict with eslint itself.

Close https://github.com/facebook/flipper/pull/915

Reviewed By: jknoxville

Differential Revision: D20594929

fbshipit-source-id: ca1c65376b90e009550dd6d1f4e0831d32cbff03

2020-03-24 09:38:11 -07:00

Anton Nikolaev

10d990c32c

Move plugins to "sonar/desktop/plugins"

Summary:
Plugins moved from "sonar/desktop/src/plugins" to "sonar/desktop/plugins".

Fixed all the paths after moving.

New "desktop" folder structure:
- `src` - Flipper desktop app JS code executing in Electron Renderer (Chrome) process.
- `static` - Flipper desktop app JS code executing in Electron Main (Node.js) process.
- `plugins` - Flipper desktop JS plugins.
- `pkg` - Flipper packaging lib and CLI tool.
- `doctor` - Flipper diagnostics lib and CLI tool.
- `scripts` - Build scripts for Flipper desktop app.
- `headless` - Headless version of Flipper desktop app.
- `headless-tests` - Integration tests running agains Flipper headless version.

Reviewed By: mweststrate

Differential Revision: D20344186

fbshipit-source-id: d020da970b2ea1e001f9061a8782bfeb54e31ba0

2020-03-14 14:35:18 -07:00

3 Commits