Summary:
This diff fetches the additional data by calling the hook added in each plugins when the headless tries to export metrics directly out of the store rather than from the trace.
I added `fetchMetadata` function which will be called while exporting the state as well as exporting the metrics. We do not need to fetch metadata in the case when the metrics are exported from the given trace.
Reviewed By: passy
Differential Revision: D15560129
fbshipit-source-id: 9b14340e565ce17d1825bc2d32520d7b0c2b2219
Summary: Actually reduce in the reducer step instead of using mutable state.
Reviewed By: jknoxville
Differential Revision: D15603095
fbshipit-source-id: f603ca548bb760db5423a4c1871d94284ece9521
Summary:
We've got some exit troubles, meaning we have to use process.exit() to stop the headless process. This isn't good because the output isn't necessarily flushed when the process forcefully exits this way.
The tests can check for this, so I've removed the forceExit flag, and fixed the case stopping them from cleanly exiting - the android adb client.
Reviewed By: passy
Differential Revision: D15602919
fbshipit-source-id: b4a9dbabf5d3c874bda6bf938e4acb7b5b7e901b
Summary:
0.100! Just noticed there's a new version and it continues to work.
destruction100
Reviewed By: jknoxville
Differential Revision: D15601865
fbshipit-source-id: 2d9d8a9ffb073468df4b85ed83800bce00ee6cda
Summary: This should buy us some time before Sandcastle kicks us off again. :)
Reviewed By: danielbuechele
Differential Revision: D15449604
fbshipit-source-id: 90d4e8a965d0163de32416b43d9aa24ede104db2
Summary:
There's a mismatch as we don't use the same existential qualification
in the constructor as we do for the class definition. This this
enforced more strictly in newer Flow versions.
Reviewed By: danielbuechele
Differential Revision: D15601548
fbshipit-source-id: 807ef9ba74933fbc653514a617d1008f4f65c631
Summary: Not sure why Flow was okay with this before.
Reviewed By: danielbuechele
Differential Revision: D15601506
fbshipit-source-id: a211bb373061d1481dbc6748d4e061a980cd0278
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/455
Only logging to the console for now, but it's a good start.
Reviewed By: oprisnik
Differential Revision: D15535820
fbshipit-source-id: 8531ec5ef681d01b2428a1f016b2a1d9f1589a34
Summary: Required for the next diff as we make use of the new CloseableReference interface.
Reviewed By: oprisnik
Differential Revision: D15558423
fbshipit-source-id: 98ce5bf3f01a6f0e7ca568544709656c41093505
Summary: This gradle flag is stopping the other tests from passing.
Reviewed By: quanturium
Differential Revision: D15558776
fbshipit-source-id: 54934c73271e1cbb041877fef0dfb2de21733424
Summary:
Refactors `startFlipper` function in headless flipper into three different functions.
`earlyExitActions`: Before the dispatcher is called on the store and will exit if the user arguments are one which are meant to terminate the process.
`exitActions`: This function will be called after the dispatcher is called and will exit if the user arguments are one which are meant to terminate the process.
`storeModifyngActions`: It involves business logic which updates the store based on the user arguments.
Reviewed By: passy
Differential Revision: D15556130
fbshipit-source-id: 9d1b035525e613bb2b75454fa4fd6c193993b530
Summary: Adds an argument to select a device in headless. I will refactor the function the headless function in the next diff
Reviewed By: danielbuechele
Differential Revision: D15536774
fbshipit-source-id: 2e3f01c6bc6094d925aebd20ba0bf15b17168cd1
Summary: requestIdleCallback does not exist in node.js. In this case, we immediately invoke the callback.
Reviewed By: priteshrnandgaonkar
Differential Revision: D15556037
fbshipit-source-id: 62cee8544fabd4528d9df17109e882fa9db6585f
Summary: This is a big dep, and wasn't even used. Removing.
Reviewed By: danielbuechele
Differential Revision: D15555949
fbshipit-source-id: 31a5430819592478b01548469fdbf58637c4de22
Summary: Red error bar at bottom when something goes wrong.
Reviewed By: danielbuechele
Differential Revision: D15536042
fbshipit-source-id: 6a20e22489f9346864b78f9102a0917f94c1c74f
Summary: I've found myself having to extract strings from things that *might* be Errors more than once. Centralising this so it's consistent and correct everywhere.
Reviewed By: danielbuechele
Differential Revision: D15536034
fbshipit-source-id: 8e054dd6122aff10f0aacdfaed65125df0aea99f
Summary: This hadn't been tested on any tables with indexes. It was using the wrong set of columns to index the rows. Fixed by using the right list.
Reviewed By: danielbuechele
Differential Revision: D15535864
fbshipit-source-id: 1842a0695715e947b7e28b59e65dcc1eb5b32695
Summary:
React outputs the following error:
Warning: Use the `defaultValue` or `value` props on <select> instead of setting `selected` on <option>.
This fixes it by using value instead of selected.
Reviewed By: danielbuechele
Differential Revision: D15535717
fbshipit-source-id: eb784ba2cdefe1c6744cc15592cd3e0191d237d0
Summary: React is printing errors saying not to use "Span", and booleans in html properties
Reviewed By: danielbuechele
Differential Revision: D15535593
fbshipit-source-id: e074137c89abfa69625b370087c9c18b579ff279
Summary:
As seen [here](https://fb.workplace.com/groups/230455004101832/permalink/623364598144202/?comment_id=623436418137020&comment_tracking=%7B%22tn%22%3A%22R%22%7D) using the primary key + CTRL to open the context menu, triggers the drag-select mode. This should not be the case. This diff changes the behaviour to:
- Not trigger the drag-select-mode, when openting the context menu using CTRL
- Select the current row, when performing a context click on it.
Reviewed By: jknoxville
Differential Revision: D15538057
fbshipit-source-id: d3d086c3d44618b2801e3a9b0646689c04fa32ff
Summary: This diff adds an option of `--list-devices` which will list the currently active devices on the machine. It will be later used to select a device by passing an `id` as an argument.
Reviewed By: danielbuechele
Differential Revision: D15524250
fbshipit-source-id: 7a79ceb1e431a25adcb4e05bc0cb68407c527806
Summary:
When a color was changed on a litho component, the changes were made, but the display in Flipper's layout sidebar always showed `rgba(0,0,0,0)` as a color. This was because reading the color failed for `ComparableColorDrawable` and it sent `0` as fallback value.
This diff adds an additional check if the value is an instance of `ComparableColorDrawable` and reads the color from it.
Reviewed By: passy
Differential Revision: D15469093
fbshipit-source-id: 7f1aaf1c4981815605aca5ba735fa09e80deaa42
Summary: Previously it only reloaded the current page.
Reviewed By: danielbuechele
Differential Revision: D15535168
fbshipit-source-id: b8252c24ffa74fdf22b2d4b6d5b7f99b40db8e47
Summary:
It was relying on hash keys to be in order, which obviously won't work. Logs plugin, on "copy message" was copying a timestamp instead.
Fixed by using the columnOrder state instead.
Reviewed By: danielbuechele
Differential Revision: D15535281
fbshipit-source-id: 2d7db95c16cc4f75c0d9cf14806fcc80cc8e4bd9
Summary: Tracking the time of onMessage callback
Reviewed By: passy
Differential Revision: D15536546
fbshipit-source-id: 9e93c11555a0a045ef60355ec1d0c6ca7cd49cdd
Summary: Importing the extensions fixes the fact that responds to selector was returned false for `sonar_additionalDataOverride` selector
Reviewed By: priteshrnandgaonkar
Differential Revision: D15535414
fbshipit-source-id: ab465a1aab36cccd2129c5b0c29a7872dfd65015
Summary:
This matches the latest stable Android Studio version which will loudly
complain unless you accept this modification.
Reviewed By: danielbuechele
Differential Revision: D15520117
fbshipit-source-id: 81301722d85cbcb07fc1b17b6ce7418d03103874
Summary:
# Highlights
- Revamped documentation! We redesigned https://fbflipper.com/ and hope you like it. We added new tutorials, feature pages and way too many things to list here.
- `no-op` package for Android makes it easier to (not) ship Flipper with production releases.
- "Copy as cURL" support for the network plugin (https://github.com/facebook/flipper/pull/415)
Reviewed By: danielbuechele
Differential Revision: D15518400
fbshipit-source-id: 041cc546f4bfd70b13d9bb25eaa6eecf5dc1d7f9
Summary:
Adds a plugin for listing the databases, tables and contents of those tables in an android app.
Right now, works with sqlite, but it should be generic enough to work with other db types.
## Changelog
Add initial version of android databases plugin
Creating a PR, I may need to do some cleaning up, but this is to kick off that process.
Pull Request resolved: https://github.com/facebook/flipper/pull/441
Reviewed By: danielbuechele
Differential Revision: D15288831
Pulled By: jknoxville
fbshipit-source-id: 6379ad60d640ea6b0a9473acc03dd6ea81a3a8d4
Summary: Includes the new Drawable getter.
Reviewed By: danielbuechele
Differential Revision: D15517152
fbshipit-source-id: 9977cc788771ec738c2eafc55b725fda4bea5bf0
Summary: People often want to share Flipper's verison number in bug reports, etc. This makes it as easy as a single click to copy the version number.
Reviewed By: jknoxville
Differential Revision: D15516592
fbshipit-source-id: 72582e2acb23113b3a0af062a83d444031f058d6
Summary:
A lot of the failures in the dashboard are due to unsupported android devices.
We can track this individually, but it shouldn't be affecting how reliable we think things are.
This adds an Error type, that when thrown, adds an extra field to log messages to specify that it's a known incompatibility.
Reviewed By: passy
Differential Revision: D15394863
fbshipit-source-id: 9d7948fbb8c94bd7a64434496e10392532a61eed
Summary:
I noticed that during a refactor, plugin success-rate failures started getting reported as successes.
Thankfully it's only the plugin metrics that are affected.
Reviewed By: passy
Differential Revision: D15394864
fbshipit-source-id: d9f44a0dd61f68dcdcbf2eb524821a3eb023231b
Summary: Distinguish between the cases when there's something wrong with listing devices and we don't see any, and when we do see some but none of them match what we're expecting.
Reviewed By: passy
Differential Revision: D15394042
fbshipit-source-id: 02728671d46531aec37da4bcafb85393269bf9cb
Summary: We removed the console already from the client side. So this causes all calls to isConsoleEnabled to fail. This diffs removes these calls.
Reviewed By: passy
Differential Revision: D15449571
fbshipit-source-id: b702a8fbc80af002e1d8b7d37d5acc664ea5be99
Summary: When a node invalidates, all its children need to be updated. This was the case in v1 of Layout Inspector (3141b954bf/src/plugins/layout/index.js (L684-L692)) but got lost when writing v2.
Reviewed By: passy
Differential Revision: D15469096
fbshipit-source-id: 9ef5368387ccbce6e5c71de28c24f5790906cee9
Summary: When receiving a message from the device, the parsing and updating is now handled in an idleCallback, with a timeout of 500ms.
Reviewed By: passy
Differential Revision: D15469094
fbshipit-source-id: c3fc70c2f082930a1a0a01078732cfd45297c391
Summary: Using ObjectTracker to track debug component nodes and creating flipper objects with debug component data
Reviewed By: davidaurelio
Differential Revision: D15462076
fbshipit-source-id: 5d0b28b6aea4729b85cc9de9ab35f2a07edbae1c
Summary:
Fresco plugin on the desktop side used to ask for all the image list along with the metadata when it was mounted. The mobile side never sent the image list and other information if not requested from it. That means, although Fresco plugin is a background plugin, there weren't any messages sent from the mobile side. Thus there was no trace available for Images plugin when the trace was exported. This diff, adds a hook which gets called before the export, where we request all the metadata from the mobile SDK.
BUG:
{F159305887}
Reviewed By: passy
Differential Revision: D15407962
fbshipit-source-id: 0012de2ab29d0f62e92d00f4926b04b1e394b62a
Summary:
This solves the watch tab crash discussed here D15266478, which got reverted.
Bug: [Here](diffusion/FBS/browse/master/xplat/sonar/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutPlugin/FlipperKitLayoutPlugin.mm;57c596a566bec49e343af51b93df65ed1377a2b9$338), when the node is `CKComponentRootView` the `[descriptor childForNode: node atIndex: i]` returns `SKComponentLayoutWrapper`. In the next iteration of the loop, node is `SKComponentLayoutWrapper`, the `[descriptor childForNode: node atIndex: i]` returns `CKComponentRootView`, and hence the infinite recursion
I also tested T44431259, it is not regressed.
Reviewed By: passy
Differential Revision: D15451821
fbshipit-source-id: 25f10112f5f52bb1fa964316a4c7e91a3b29156d
Summary:
Call `exportPersistedState` only for the clients of selectedDevice. This will fasten up our export, we do not need to call `exportPersistedState` for the clients of nonSelectedDevice.
{F159322777}
Reviewed By: passy
Differential Revision: D15440652
fbshipit-source-id: e018603cfeb56fec462b54a6897fb254cc361390
Summary: Exports the `WASTED_BYTES` metric for the Images plugin. Currently its not possible to export the trace for Images Plugin, as all its listeners are setup in the init function of the component. Also it follows "pull" strategy, i.e Flipper asks for the data at component initialization. I will work on asking for the Fresco data when we terminate the headless, just like Layout Plugin.
Reviewed By: oprisnik
Differential Revision: D15393752
fbshipit-source-id: 4f0717ac5fb70a82aab5c803a4f92708d1faa9df
Summary: This resolves a crash related to the contents of certain CKComponents, which was apparently introduced by D15266478
Differential Revision: D15406260
fbshipit-source-id: efd1ad1a1bcb41451c56b74c240ad2dca069deb0
