flipper

jens/flipper

Fork 0

Commit Graph

Author	SHA1	Message	Date
Michel Weststrate	dd111076c9	Only use Flipper in DEBUG builds Summary: as discussed in https://github.com/facebook/flipper/issues/976#issuecomment-634917766, this solves the issue that FlipperKit is accidentally included in production builds ones react-native-flipper is installed, due to it's dependency on Flipper kit This change is safe because the bindings did already have a check to verify that the Flipper bindings are available at all, and silenty skips their absence in production builds: https://www.internalfb.com/intern/diffusion/FBS/browse/master/xplat/sonar/react-native/react-native-flipper/index.js?commit=b7dd7e05b177&lines=128 Reviewed By: passy Differential Revision: D21749213 fbshipit-source-id: 2c4435c7a375fbc24f89159855d3e0297f3aa9a4	2020-05-28 09:59:53 -07:00
Pritesh Nandgaonkar	bd388f73e4	CLANGFORMAT the remaining files of xplat/sonar Summary: As per title. Ran `arc lint -a --take CLANGFORMAT --paths-cmd 'hg files ./'` from xplat/sonar Reviewed By: zertosh Differential Revision: D19943131 fbshipit-source-id: c1dc10b27389fd6f54f055803519dac6bf0e7997	2020-02-18 05:27:56 -08:00
Janic Duplessis	44f5e35675	Implement react-native-flipper on iOS (#795 ) Summary: Implement the react-native-flipper native module on iOS. Uses very similar abstractions as on Android. ## Changelog [react-native-flipper] Support iOS Pull Request resolved: https://github.com/facebook/flipper/pull/795 Test Plan: Tested using the RN TicTacToe example app {F228406333} Reviewed By: mweststrate Differential Revision: D19853017 Pulled By: priteshrnandgaonkar fbshipit-source-id: d93d35ff984b9ba75f812c4c8e3c82e4d550f0c0	2020-02-14 21:17:11 -08:00

Author

SHA1

Message

Date

Michel Weststrate

dd111076c9

Only use Flipper in DEBUG builds

Summary:
as discussed in https://github.com/facebook/flipper/issues/976#issuecomment-634917766,

this solves the issue that FlipperKit is accidentally included in production builds ones react-native-flipper is installed, due to it's dependency on Flipper kit

This change is safe because the bindings did already have a check to verify that the Flipper bindings are available at all, and silenty skips their absence in production builds: https://www.internalfb.com/intern/diffusion/FBS/browse/master/xplat/sonar/react-native/react-native-flipper/index.js?commit=b7dd7e05b177&lines=128

Reviewed By: passy

Differential Revision: D21749213

fbshipit-source-id: 2c4435c7a375fbc24f89159855d3e0297f3aa9a4

2020-05-28 09:59:53 -07:00

Pritesh Nandgaonkar

bd388f73e4

CLANGFORMAT the remaining files of xplat/sonar

Summary:
As per title.
Ran `arc lint -a --take CLANGFORMAT --paths-cmd 'hg files ./'` from xplat/sonar

Reviewed By: zertosh

Differential Revision: D19943131

fbshipit-source-id: c1dc10b27389fd6f54f055803519dac6bf0e7997

2020-02-18 05:27:56 -08:00

Janic Duplessis

44f5e35675

Implement react-native-flipper on iOS (#795 )

Summary:
Implement the react-native-flipper native module on iOS. Uses very similar abstractions as on Android.

## Changelog

[react-native-flipper] Support iOS
Pull Request resolved: https://github.com/facebook/flipper/pull/795

Test Plan:
Tested using the RN TicTacToe example app

{F228406333}

Reviewed By: mweststrate

Differential Revision: D19853017

Pulled By: priteshrnandgaonkar

fbshipit-source-id: d93d35ff984b9ba75f812c4c8e3c82e4d550f0c0

2020-02-14 21:17:11 -08:00

3 Commits