Commit Graph

9 Commits

Author SHA1 Message Date
Simek
903476bdad use centered prop for variable height modals (#3334)
Summary:
Currently all of the modals are displayed using default positioning, which works fine for small modals and large app windows, but it cause small UI/UX issues (double scroll bars) when app window is quite small.

Adding [`centered` prop](https://ant.design/components/modal/#API) for variable height modals improves this situation a bit, but it also changes a bit the modal position when using maximised window, but I think this is bearable looking at improvements gained when window size is reduced.

## Changelog

* use `centered` prop for variable height modals to improve UI in small app window

Pull Request resolved: https://github.com/facebook/flipper/pull/3334

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

#### Small App Window
<img width="390" alt="Screenshot 2022-01-24 at 11 58 40" align="left" src="https://user-images.githubusercontent.com/719641/150771900-cb25d110-82c7-4ba9-8ee5-07a093c4f702.png">
<img width="390" alt="Screenshot 2022-01-24 at 11 58 37" src="https://user-images.githubusercontent.com/719641/150771911-c81592ac-1eba-4112-86ad-9549e6248239.png">

<img width="390" alt="Screenshot 2022-01-24 at 12 00 13" align="left" src="https://user-images.githubusercontent.com/719641/150772045-de37c432-4381-4207-8476-5f142dfb6fa5.png">
<img width="390" alt="Screenshot 2022-01-24 at 12 00 10" src="https://user-images.githubusercontent.com/719641/150772057-574cf6cd-6f1a-4ca2-a343-b8fd6342eddb.png">

#### Maximised App Window
<img width="390" alt="Screenshot 2022-01-24 at 12 12 12" align="left" src="https://user-images.githubusercontent.com/719641/150772777-8ac3cb59-3b41-4dcb-9554-137e95857af8.png">
<img width="390" alt="Screenshot 2022-01-24 at 12 12 29" src="https://user-images.githubusercontent.com/719641/150772758-ca9f8c20-d6d0-412d-9067-7e756da0b56c.png">

Reviewed By: mweststrate

Differential Revision: D33741484

Pulled By: lblasa

fbshipit-source-id: 0c3ca883d051cf4fcce9f9c1b6688974b66fd0d8
2022-01-26 04:23:05 -08:00
Simek
4b0091df0f fix Plugins table UI glitch in dark mode, add column name (#3332)
Summary:
Same as Settings modal, the Plugin Manager table used in Plugins modal includes the UI glitch in dark mode due to overflow setting. This PR fixes that and also adds missing column caption in "Install Plugins" table.

I have chosen `Action` as a title but this can be altered, I have no strong preference in there. The goal was to improve the clarity and also improve the context menu content (where user can show/hide columns).

## Changelog

* fix Plugins table UI glitch in dark mode, add column name

Pull Request resolved: https://github.com/facebook/flipper/pull/3332

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)
<img width="396" alt="Screenshot 2022-01-23 at 16 19 02" align="left" src="https://user-images.githubusercontent.com/719641/150685739-e2047e70-de14-4801-ac5a-0fc45a6ea476.png">
<img width="396" alt="Screenshot 2022-01-23 at 16 19 31" src="https://user-images.githubusercontent.com/719641/150685735-3de8b7a2-ea3f-489a-b1f8-7af73f0a5225.png">

Reviewed By: aigoncharov

Differential Revision: D33738705

Pulled By: lblasa

fbshipit-source-id: 704fe40f26d424c62a9bbc3e73132a0026f2e8b8
2022-01-24 03:56:59 -08:00
dependabot[bot]
4e11458655 Bump antd from 4.16.8 to 4.18.0 in /desktop (#3222)
Summary:
Bumps [antd](https://github.com/ant-design/ant-design) from 4.16.8 to 4.18.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p>
<blockquote>
<h2>4.18.0</h2>
<ul>
<li>🐞 Fix Skeleton missing <code>style</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33405">#33405</a></li>
<li>🐞 Fix Descriptions overflow style cause other components being cut. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33392">#33392</a></li>
<li>🆕 Unique Select-like component generic as OptionType to support FieldNames type. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33364">#33364</a></li>
<li>🐞 Fix Slider rail hover color when it is disabled. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33369">#33369</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Table
<ul>
<li>🆕 Table <code>colSpan</code> &amp; <code>rowSpan</code> move to <code>onCell</code> function to optimize performance. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33114">#33114</a></li>
<li>🆕 Table support Table.EXPAND_COLUMN &amp; Table.SELECTION_COLUMN to customize column order. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33026">#33026</a></li>
</ul>
</li>
<li>Form
<ul>
<li>🔥 Form.List nest Form.Item no longer need pass <code>fieldKey</code> anymore. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32689">#32689</a></li>
<li>🆕 Form <code>label</code> can wrap via setting <code>labelWrap</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33048">#33048</a></li>
</ul>
</li>
<li>🆕 ConfigProvider support Form <code>colon</code>. <a href="https://github.com/ant-design/ant-design/commit/9bc148a">9bc148a</a> <a href="https://github.com/seaSuper"><code>@​seaSuper</code></a></li>
<li>🆕 add <code>prefix</code> to <code>InputNumber</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32600">#32600</a> <a href="https://github.com/Austaras"><code>@​Austaras</code></a></li>
<li>🆕 Modal static function support <code>wrapClassName</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32676">#32676</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Popconfirm add <code>showCancel</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32620">#32620</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Dropdown.Button supports <code>loading</code> property now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32467">#32467</a> <a href="https://github.com/kaysonwu"><code>@​kaysonwu</code></a></li>
<li>🆕 Input adds <code>showCount</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32522">#32522</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Alert supports <code>closeIcon</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32345">#32345</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Typography
<ul>
<li>🆕 for editable Paragraph, edit can be triggered by clicking the icon or the value itself (or both) with <code>triggerType</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32219">#32219</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
<li>🆕 Typography support <code>enterIcon</code> to config confirm icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32220">#32220</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
</ul>
</li>
<li>🆕 Divider added <code>orientationMargin</code> APIs for customizing <code>margin-left/right</code> of title. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32084">#32084</a> <a href="https://github.com/neotan"><code>@​neotan</code></a></li>
<li>🆕 Avatar add <code>maxPopoverTrigger</code> to support configuration of popover trigger. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32197">#32197</a> <a href="https://github.com/RiteshMakan"><code>@​RiteshMakan</code></a></li>
<li>🆕 Upload supports <code>showUploadList.previewIcon</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32059">#32059</a> <a href="https://github.com/1040961807"><code>@​1040961807</code></a></li>
<li>🏴󠁥󠁳󠁣󠁴󠁿 Fix Catalan (ca_ES) missing translation key with <code>Form</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33377">#33377</a> <a href="https://github.com/ZzGGitter"><code>@​ZzGGitter</code></a></li>
<li>🇫🇮 Fix Finland (fi_FI) missing translation key with <code>Table</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33372">#33372</a> <a href="https://github.com/ZakarFin"><code>@​ZakarFin</code></a></li>
<li>🇰🇭 Added locales for Khmer (km_KH) translation. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32853">#32853</a> <a href="https://github.com/vireakkeosokvibol"><code>@​vireakkeosokvibol</code></a></li>
<li>TypeScript
<ul>
<li>� Add Upload <code>capture</code> definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33370">#33370</a> <a href="https://github.com/MichalPodeszwa"><code>@​MichalPodeszwa</code></a></li>
</ul>
</li>
</ul>
<hr />
<ul>
<li>🐞 修复 Skeleton 不支持 <code>style</code> 的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33405">#33405</a></li>
<li>🐞 修复 Descriptions 内使用其他组件会被切割的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33392">#33392</a></li>
<li>🆕 统一类 Select 组件泛型定义为 OptionType 以支持自定义 FieldNames 匹配。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33364">#33364</a></li>
<li>🐞 修复 Slider 禁用时 <code>hover</code> 色彩的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33369">#33369</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Table
<ul>
<li>🆕 Table <code>colSpan</code> 与 <code>rowSpan</code> 迁移至 <code>onCell</code> 方法中,以优化渲染性能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33114">#33114</a></li>
<li>🆕 Table 支持 Table.EXPAND_COLUMN 和 Table.SELECTION_COLUMN 以实现自定义列排序。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33026">#33026</a></li>
</ul>
</li>
<li>Form
<ul>
<li>🔥 Form.List 嵌套使用 Form.Item 时不再需要手工指定 <code>fieldKey</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32689">#32689</a></li>
<li>🆕 Form 现在支持通过 <code>labelWrap</code> 开启标签可换行。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33048">#33048</a></li>
</ul>
</li>
<li>🆕 ConfigProvider 支持 Form 的 colon 配置。<a href="https://github.com/ant-design/ant-design/commit/9bc148a">9bc148a</a> <a href="https://github.com/seaSuper"><code>@​seaSuper</code></a></li>
<li>🆕 <code>InputNumber</code> 增加 <code>prefix</code> 属性支持。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32600">#32600</a> <a href="https://github.com/Austaras"><code>@​Austaras</code></a></li>
<li>🆕 Modal 静态方法支持 <code>wrapClassName</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32676">#32676</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Popconfirm 新增是否显示取消按钮。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32620">#32620</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Dropdown.Button 新增 <code>loading</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32467">#32467</a> <a href="https://github.com/kaysonwu"><code>@​kaysonwu</code></a></li>
<li>🆕 Input 新增 <code>showCount</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32522">#32522</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Alert 支持 <code>closeIcon</code> 自定义关闭图标。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32345">#32345</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Typography
<ul>
<li>🆕 对于可编辑段落,可以通过配置 <code>triggerType</code> 配置触发编辑状态。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32219">#32219</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
<li>🆕 Typography 支持 <code>enterIcon</code> 以设置编辑确认图标。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32220">#32220</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
</ul>
</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p>
<blockquote>
<h2>4.18.0</h2>
<p><code>2021-12-27</code></p>
<ul>
<li>🐞 Fix Skeleton missing <code>style</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33405">#33405</a></li>
<li>🐞 Fix Descriptions overflow style cause other components being cut. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33392">#33392</a></li>
<li>🆕 Unique Select-like component generic as OptionType to support FieldNames type. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33364">#33364</a></li>
<li>🐞 Fix Slider rail hover color when it is disabled. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33369">#33369</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Table
<ul>
<li>🆕 Table <code>colSpan</code> &amp; <code>rowSpan</code> move to <code>onCell</code> function to optimize performance. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33114">#33114</a></li>
<li>🆕 Table support Table.EXPAND_COLUMN &amp; Table.SELECTION_COLUMN to customize column order. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33026">#33026</a></li>
</ul>
</li>
<li>Form
<ul>
<li>🔥 Form.List nest Form.Item no longer need pass <code>fieldKey</code> anymore. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32689">#32689</a></li>
<li>🆕 Form <code>label</code> can wrap via setting <code>labelWrap</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33048">#33048</a></li>
</ul>
</li>
<li>🆕 ConfigProvider support Form <code>colon</code>. <a href="https://github.com/ant-design/ant-design/commit/9bc148a">9bc148a</a> <a href="https://github.com/seaSuper"><code>@​seaSuper</code></a></li>
<li>🆕 add <code>prefix</code> to <code>InputNumber</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32600">#32600</a> <a href="https://github.com/Austaras"><code>@​Austaras</code></a></li>
<li>🆕 Modal static function support <code>wrapClassName</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32676">#32676</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Popconfirm add <code>showCancel</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32620">#32620</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Dropdown.Button supports <code>loading</code> property now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32467">#32467</a> <a href="https://github.com/kaysonwu"><code>@​kaysonwu</code></a></li>
<li>🆕 Input adds <code>showCount</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32522">#32522</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Alert supports <code>closeIcon</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32345">#32345</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Typography
<ul>
<li>🆕 for editable Paragraph, edit can be triggered by clicking the icon or the value itself (or both) with <code>triggerType</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32219">#32219</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
<li>🆕 Typography support <code>enterIcon</code> to config confirm icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32220">#32220</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
</ul>
</li>
<li>🆕 Divider added <code>orientationMargin</code> APIs for customizing <code>margin-left/right</code> of title. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32084">#32084</a> <a href="https://github.com/neotan"><code>@​neotan</code></a></li>
<li>🆕 Avatar add <code>maxPopoverTrigger</code> to support configuration of popover trigger. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32197">#32197</a> <a href="https://github.com/RiteshMakan"><code>@​RiteshMakan</code></a></li>
<li>🆕 Upload supports <code>showUploadList.previewIcon</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32059">#32059</a> <a href="https://github.com/1040961807"><code>@​1040961807</code></a></li>
<li>🏴󠁥󠁳󠁣󠁴󠁿 Fix Catalan (ca_ES) missing translation key with <code>Form</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33377">#33377</a> <a href="https://github.com/ZzGGitter"><code>@​ZzGGitter</code></a></li>
<li>🇫🇮 Fix Finland (fi_FI) missing translation key with <code>Table</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33372">#33372</a> <a href="https://github.com/ZakarFin"><code>@​ZakarFin</code></a></li>
<li>🇰🇭 Added locales for Khmer (km_KH) translation. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32853">#32853</a> <a href="https://github.com/vireakkeosokvibol"><code>@​vireakkeosokvibol</code></a></li>
<li>TypeScript
<ul>
<li>� Add Upload <code>capture</code> definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33370">#33370</a> <a href="https://github.com/MichalPodeszwa"><code>@​MichalPodeszwa</code></a></li>
</ul>
</li>
</ul>
<h2>4.17.4</h2>
<p><code>2021-12-19</code></p>
<ul>
<li>🐞 Fix a bug that Form.Item name is &quot;parentNode&quot; casue endless loop and memory leak. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31846">#31846</a> <a href="https://github.com/DaoxingHuang"><code>@​DaoxingHuang</code></a></li>
<li>🐞 Revert <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32448">#32448</a> to fix emoji input at Input.TextArea. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33312">#33312</a></li>
</ul>
<h2>4.17.3</h2>
<p><code>2021-12-08</code></p>
<ul>
<li>🐞 Fix Drawer broken style caused by title width. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33205">#33205</a></li>
<li>🐞 Fix Badge flash style when switch from <code>display:none</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33083">#33083</a> <a href="https://github.com/songlinn"><code>@​songlinn</code></a></li>
<li>💄 Change Anchor className form <code>.fixed</code> to <code>.ant-anchor-fixed</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33085">#33085</a> <a href="https://github.com/tangjinzhou"><code>@​tangjinzhou</code></a></li>
<li>💄 Fix Button loading style missing in Firefox. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33199">#33199</a></li>
<li>Select
<ul>
<li>🐞 Fix Select width became small when searching. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32988">#32988</a></li>
</ul>
</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="41ac1f0c1a"><code>41ac1f0</code></a> chore: 4.18.0 changelog (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33424">#33424</a>)</li>
<li><a href="24458eb54e"><code>24458eb</code></a> chore: auto merge branchs (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33423">#33423</a>)</li>
<li><a href="b3cc1e5276"><code>b3cc1e5</code></a> chore: auto merge branchs (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33422">#33422</a>)</li>
<li><a href="7ae451729f"><code>7ae4517</code></a> test: update snapshot</li>
<li><a href="6ed4d855b1"><code>6ed4d85</code></a> Merge remote-tracking branch 'origin/master' into feature-merge-master</li>
<li><a href="73ac1b1aaa"><code>73ac1b1</code></a> docs: Update practical-projects.zh-CN.md (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33419">#33419</a>)</li>
<li><a href="7f09f0a604"><code>7f09f0a</code></a> chore(deps): update dependency scrollama to v3 (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33418">#33418</a>)</li>
<li><a href="9c086c5328"><code>9c086c5</code></a> fix: Skeleton missing style (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33405">#33405</a>)</li>
<li><a href="f1e0c9c1d2"><code>f1e0c9c</code></a> chore: Internal Menu interface for ProLayout usage (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33399">#33399</a>)</li>
<li><a href="0edf04253e"><code>0edf042</code></a> fix: Descriptions default overflow value (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33392">#33392</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/ant-design/ant-design/compare/4.16.8...4.18.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=antd&package-manager=npm_and_yarn&previous-version=4.16.8&new-version=4.18.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3222

Reviewed By: timur-valiev

Differential Revision: D33348265

Pulled By: nikoant

fbshipit-source-id: e219049791c8341b4795fc8b742edaa61ee7559d
2022-01-01 20:28:45 -08:00
Andres Suarez
79023ee190 Update copyright headers from Facebook to Meta
Reviewed By: bhamodi

Differential Revision: D33331422

fbshipit-source-id: 016e8dcc0c0c7f1fc353a348b54fda0d5e2ddc01
2021-12-27 14:31:45 -08:00
Michel Weststrate
5df34a337c Unshare global types
Summary:
This diff adds `types` fields on the compiler config for every project. This way we can make sure that for example node types and packages are not available in flipper-ui-core. Without an explicit types field, all types would be shared between all packages, and implicitly included into the compilation of everything. For the same reason `types/index.d.ts` has been removed, we want to be intentional on which types are being used in which package.

This diff does most of the work, the next diff will fine tune the globals, and do some further cleanup.

As an alternative solution I first tried a `nohoist: **/node_modules/types/**` and make sure every package list explicitly the types used in package json, which works but is much more error prone, as for example two different react types versions in two packages will cause the most unreadable compiler error due to the types not being shared and not literally the same.

Reviewed By: lawrencelomax

Differential Revision: D33124441

fbshipit-source-id: c2b9d768f845ac28005d8331ef5fa1066c7e4cd7
2021-12-17 07:36:07 -08:00
Michel Weststrate
64747dc417 move plugin management from ui-core to server-core
Summary:
Follow up of D32665064, this diff moves all plugin management logic from flipper-ui to flipper-server. Things like downloading, installing, querying new plugins.

Loading plugins is handled separately in the next diff.

Reviewed By: nikoant

Differential Revision: D32666537

fbshipit-source-id: 9786b82987f00180bb26200e38735b334dc4d5c3
2021-12-08 04:30:56 -08:00
Michel Weststrate
e7f841b6d2 Move flipper plugin from flipper-lib types to flipper-common
Summary: Moved all types related to plugin descriptions from plugin-lib (which handles downloads and such) to flipper-common. The goal of that is to remove all plugin-lib usage from ui-core to server-core, so that the UI itself doesn't do any file operations anymore related to plugins. That will be done in next diffs, this just moves types but no code.

Reviewed By: nikoant, aigoncharov

Differential Revision: D32665064

fbshipit-source-id: 86d908e7264569b0229b09290a891171876c8e00
2021-12-08 04:30:55 -08:00
Andrey Goncharov
225a2a7e34 Refactor Stella plugin
Summary:
1. Replace old FileSelector with the new FileSelector
2. Remove showOpenDialog from FlipperLib

Reviewed By: mweststrate

Differential Revision: D32667103

fbshipit-source-id: be8da034c2695f83b397b6c7d35bc6aee78d66e5
2021-11-26 08:30:13 -08:00
Michel Weststrate
7e50c0466a Move app/src (mostly) to flipper-ui-core/src
Summary:
This diff moves all UI code from app/src to app/flipper-ui-core. That is now slightly too much (e.g. node deps are not removed yet), but from here it should be easier to move things out again, as I don't want this diff to be open for too long to avoid too much merge conflicts.

* But at least flipper-ui-core is Electron free :)
* Killed all cross module imports as well, as they where now even more in the way
* Some unit test needed some changes, most not too big (but emotion hashes got renumbered in the snapshots, feel free to ignore that)
* Found some files that were actually meaningless (tsconfig in plugins, WatchTools files, that start generating compile errors, removed those

Follow up work:
* make flipper-ui-core configurable, and wire up flipper-server-core in Electron instead of here
* remove node deps (aigoncharov)
* figure out correct place to load GKs, plugins, make intern requests etc., and move to the correct module
* clean up deps

Reviewed By: aigoncharov

Differential Revision: D32427722

fbshipit-source-id: 14fe92e1ceb15b9dcf7bece367c8ab92df927a70
2021-11-16 05:29:21 -08:00