Summary:
Instead of our ad-hoc mechanism. There's quite a bit
of trickery involved to make this work reliably on Windows
so I'd rather take an off-the-shelf solution than reimplement this
myself.
Reviewed By: jknoxville
Differential Revision: D17628949
fbshipit-source-id: 98806b60a107231d9ee07b721ebb70f2cbd8aec1
Summary:
**Highlights**
- Android: Leakcanary is no longer part of the core distribution but a separate artifact: `com.facebook.flipper:flipper-leakcanary-plugin`.
Reviewed By: priteshrnandgaonkar
Differential Revision: D17601074
fbshipit-source-id: 862fc44d45b4ddc95059deb3959476af162b1cb0
Summary:
In the previous implementation plugins were downloaded from npm, but dependencies weren't. This diff uses the `live-plugin-manager` which does mostly what we want. It install a package from NPM with all its dependencies.
live-plugin-manager puts the plugin and its dependencies in the same folder. We expect the plugins to be in `node_modules`. For this reason, we are installing the plugin into `$pluginName/node_modules` and move the plugin after the installation out of the `node_modules` folder.
* Fixed plugin loading path for thirdparty plugins.
* Disabled hot reloading for plugins in the flipper folder to prevent reloads when moving around files and installing dependencies here.
* an empty `.watchmanconfig` is created, because metro requires it
* tsx files are added to the list of supported extensions for metro
Reviewed By: passy
Differential Revision: D17570413
fbshipit-source-id: ecbedc60841b36188fec9c83da41ef1f27e5e155
Summary: Fix for p-map error at startup and `fbjni` dependency on Android.
Reviewed By: danielbuechele
Differential Revision: D17528600
fbshipit-source-id: db0fd2e99bd35645ceef63500312b3ad16c04d57
Summary:
# Highlights
- Android: Separate artifacts for the Litho, Fresco and Network plugins.
This does not yet include updates to the docs as the publishing process requires manual approval by Bintray first.
Reviewed By: danielbuechele
Differential Revision: D17480406
fbshipit-source-id: 92cd54e708bc1718e40e9ea95ca62f8c73b11fdc
Summary:
My MBP just crashed again during startup. I would like to
understand why every plugin compilation appears to start
up a new electron process, but until that's understood
and hopefully fixed, it's probably best to limit the number
of processes we spawn by setting an upper bound here.
N.B. My Linux box doesn't mind this at all.
Reviewed By: jknoxville, danielbuechele
Differential Revision: D17419289
fbshipit-source-id: a11562a21a984059dc35e826eb20d869df218546
Summary: Setting up a sheet to list plugins that can be installed from NPM
Reviewed By: jknoxville
Differential Revision: D17394824
fbshipit-source-id: 26c6ffea9de9cf3fe8488ea1a757eae7b7aaa7ef
Summary:
**Highlights**
- Changed to the upstream `adbkit` instead of the Facebook-specific fork of it.
- Migrate the rest of Flipper core from Flow to (strict) TypeScript.
- UI docs use the TypeScript code as basis.
Reviewed By: danielbuechele
Differential Revision: D17368399
fbshipit-source-id: 5ba92c4f0d4ca627ffac58052ef6e4d9fd07bd95
Summary: Finally we are able to switch back from our adbkit-fb fork to the original `adbkit`. Replacing all imports
Reviewed By: jknoxville
Differential Revision: D17343236
fbshipit-source-id: e6dd328f1a956544e8be2ab768aa270972463c6b
Summary:
This one is in TS, so we get types for free.
`promisify` makes it rather awkward to work with overloaded
functions like `spawn`, so there's still value in having
a proper library for this.
Reviewed By: jknoxville
Differential Revision: D17204471
fbshipit-source-id: 3d07edfe2bb8c1e4c4f3134b53a0c4a0d9be383b
Summary:
**Highlights**
1. Windows builds should publish on the release page now.
2. We have x86_64 support on Android.
3. React DevTools are now publicly available.
Reviewed By: danielbuechele
Differential Revision: D17204023
fbshipit-source-id: 41aaa1c884e1f251216423a8b08cec6e8802fd80
Summary:
This Diff is being posted for discussion purposes. It will not be ready to land until React DevTools v4 has been published to NPM.
Update React Native to be compatible with the [new version 4 React DevTools extension](https://github.com/bvaughn/react-devtools-experimental).
**Note that this is a breaking change**, as the version 3 and version 4 backends are **not compatible**. Once this update ships (in React Native) users will be required to update their version of the [`react-devtools` NPM package](https://www.npmjs.com/package/react-devtools). The same will be true for IDEs like Nuclide as well as other developer tools like Flipper and [React Native Debugger](https://github.com/jhen0409/react-native-debugger).
Related changes also included in this diff are:
* Pass an explicit whitelist of style props for the React Native style editor (to improve developer experience when adding new styles).
* Update `YellowBox` console patching to coordinate with DevTools own console patching.
* Also improved formatting slightly by not calling `stringifySafe` for strings (since this adds visible quotation marks).
Regarding the console patching- component stacks will be appended by default when there's no DevTools frontend open. The frontend will provide an option to turn this behavior off though:
{F168852162}
React DevTools will detect if the new version is used with an older version of React Native, and offer inline upgrade instructions:
{F169306863}
**Note that the change to the `RCTEnableTurboModule` will not be included in this Diff**. I've just turned those off temporarily so I can use v8+Chrome for debugging.
Reviewed By: rickhanlonii
Differential Revision: D15973709
fbshipit-source-id: bb9d83fc829af4693e7a10a622acc95a411a48e4
Summary:
This converts the index file to TypeScript which is used as an export for all plugins. Alongside, I had to fix a couple of errors in various files to make sure everything works correctly.
For plugins using flow, we define an interface which uses the type definition for FlipperPlugin and types all UI components as `any`.
Reviewed By: passy
Differential Revision: D16936890
fbshipit-source-id: dacd9a63a82b9f0bbb530b06072186874cba7b6f
Summary: We need this as part of the migration for react-dom types.
Reviewed By: jknoxville
Differential Revision: D16668683
fbshipit-source-id: c50be446ada5539961c89da9f3bd3f240db4ec4c
Summary:
This is the result of a `yarn upgrade`. While this *shouldn't* break
anything, it easily can just as this broke the babel transform
because a previously transitively depended upon library was no
longer included.
It seems like a good idea to stay as close as possible to the upstream of all
the dependencies we have and with the release yesterday we now have one week to
check if the rest works as expected.
allow-large-files
Reviewed By: danielbuechele
Differential Revision: D16579807
fbshipit-source-id: f26d4536abd80f428e94b71e0fa98df612cbd809
Summary:
# New Features
- Select plugins to include in your exports.
# Fixes and chores
- Run TSC in Travis.
- Restore Android build in Travis.
[Full Changelog](https://github.com/facebook/flipper/compare/v0.23.3...v0.23.4)
Reviewed By: jknoxville, danielbuechele
Differential Revision: D16559674
fbshipit-source-id: 919f758f8750d26d9e49b6721d05264880d0abc5
Summary: Run TSC in Sandcastle to make sure everything is typed nicely.
Reviewed By: jknoxville
Differential Revision: D16202412
fbshipit-source-id: 23064d5a0b327c32d0b633f9234882a46f88270e
Summary: This is required to properly run eslint in Atom/VSCode on TypeScript files
Reviewed By: jknoxville
Differential Revision: D16201418
fbshipit-source-id: 31da04c2d313e9147e0f868c1af15bf3115e6d6a
Summary:
It appears that Electron (or the version of Chromium it uses) has a bug that causes a `webview` process to crash if `URL.createObjectURL` is used.
Before releasing `react-devtools-core` 3.5.0, we updated Webpack and the loaders we used. Apparently the version of `style-loader` we now use makes use of the `URL.createObjectURL` API for CSS source maps. This triggers the `webview` crash I mentioned above.
The fix for this is to disable CSS source maps, in which case the loader just uses a `<style>` tag. This diff updates Nuclide to pull in this fixed version.
Reviewed By: bestander
Differential Revision: D16518772
fbshipit-source-id: a779b7d310f869793fa05988d138ce6a46840d8c
Summary:
Original commit changeset: bdbd61bce1bc
That change appears to be causing some issues for open source users: https://github.com/facebook/flipper/issues/498
To mitigate the issue I'm reverting it, the change turns out to be unnecessary anyway.
Reviewed By: passy
Differential Revision: D16486136
fbshipit-source-id: 70decca6e017a6a2903cc484641fb2e736dc5d7c
Summary:
Split this up into a separate review because the file is actually
sorta hand-written and just adds noise to the things I was
actually doing.
Reviewed By: jknoxville
Differential Revision: D16441548
fbshipit-source-id: 93366d38908bbec347fd837f5dc90b11329ebf8e
Summary:
Migrating tables' row collection to Immutable.js List:
1. Сopy ManagedTable code, no changes
2. Add deps to Immutable.js
-----
Current implementation of tables forces to copy arrays on new data arrival which causes O(N^2) complexity ->
tables can't handle a lot of new rows in short period of time -> tables freeze and become unresponsive for a few seconds.
Immutable data structures will bring us to O(N) complexity
Reviewed By: jknoxville
Differential Revision: D16416870
fbshipit-source-id: d3e1a9571ea08fa7ccaedc5ad3eca863d22a79a4
Summary:
## Export Data
- Add close button to the export sheet.
- Show status updates while exporting Flipper data.
- Fix Fresco data export (0c0f0d4a90).
## Headless
- `select-plugins` cli argument added for the headless flipper
## Miscellaneous
- Generate TLS certificates in the past to allow for clock skew. (9a97b3b45b)
- Speed up Redux dev tools (ce93ecfcca)
- Add stricter ESLint rules.
- Speed up `yarn start` (10559a188f).
Reviewed By: passy
Differential Revision: D16418562
fbshipit-source-id: 8ab9c3264c2a367125f8235dd07129e67441a0e4
Summary:
Update to the latest React DevTools v3 release, which adds the ability to detect when the (v3) frontend is connected with a v4 backend and shows update instructions to the user.
## Changelog:
[General] [Added] - Updated embedded react-devtools-core package to the latest version in preparation for the upcoming v4 DevTools release.
Reviewed By: rickhanlonii
Differential Revision: D16419553
fbshipit-source-id: a36b0ba5bf6992a490f1234b9a92b8abd4c9b3e6
Summary: This is in order to gain access to hooks. This is useful for testing functional components in isolation without connecting to the redux store. For instance, testing a toggle button toggles on and off.
Reviewed By: passy
Differential Revision: D16376723
fbshipit-source-id: d6be463330dbc5deef1a0513e07fd567adf58287
Summary: Per title. Let's be more consistent, especially for plugins where authors may not know which one to use.
Reviewed By: jknoxville
Differential Revision: D16340189
fbshipit-source-id: ffe49e509f744279e32fc9fc3f1d59efc1328d80
Summary:
This changes the start date of all generated certificates to be 1h in the past.
Why? To allow for clock skew, and allow clock manipulation in tests.
To do this, I had to switch from `openssl x509 req`, to `openssl ca` for generating them, because it has the startdate parameter.
This variant is a bit more complicated to use, so I've added an openssl.conf and some extra files.
I also changed the org from Sonar to Flipper because it now needs to match the CSRs coming from the mobile apps, and they use Flipper.
Reviewed By: passy
Differential Revision: D16223722
fbshipit-source-id: bdbd61bce1bc1b54d7b0b3cc6741675aa68d2cf6
Summary:
- New Litho Sections APIs.
- New version of Metro.
- Hardened eslint rules.
- Flipper Headless now offers a `--no-plugins` build mode to speed up compilation.
Reviewed By: jknoxville
Differential Revision: D16221050
fbshipit-source-id: 5eb7a0e8caaf11188ece94a149003daa36eb0a30
