jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
4,521 Commits 1 Branch 0 Tags
8c3abf7450f0b655c41f31701770a6d3d75a74ea
Commit Graph

7 Commits

Author SHA1 Message Date
Michel Weststrate
d836b80273 Fix network plugin not working in example 
Summary: Two diffs ago network plugin didn't seem to work correctly, fixed it by explicitly bumping / verifying that the latest SDK is used

Reviewed By: passy

Differential Revision: D25755993

fbshipit-source-id: 7cc0def113a84b0a66c728b479247f5c18ce79b8
 2021-01-04 12:17:56 -08:00
Michel Weststrate
5471b844bc Apply react-native migration 0.62.2 -> 0.63.4 
Summary:
In D25244631 (92bd68a371) we bumped the react-native dep of Flipper but we didn't apply the migration guide (sorry for missing that in the review), so the ReactNativeExample fell apart when trying to build for iOS. This diff applies the migration guide which nicely fixes that:

https://react-native-community.github.io/upgrade-helper/?from=0.62.2&to=0.63.4

Recreating the Podfile.lock and running `./gradlew clean` fixed all build problems after that.

Verified that `yarn ios` and `yarn android`, and building from XCode all work.

Found (probably unrelated / existing) issues:
* custom plugins only show up after initial app start after refreshing the plugin list by navigating to another diffs first, so this seems to be a UI staleness bug
* Network plugin doesn't seem to work ion iOS (either not showing traffic or not showing data at all)

Reviewed By: passy

Differential Revision: D25755490

fbshipit-source-id: baea8b152fb252deda04291ec197ab87c2fbe3eb
 2021-01-04 12:17:56 -08:00
Chaiwat Ekkaewnumchai
b81724b7b0 Update Podfile for ReactNativeFlipperExample 
Summary:
Encountered while trying to install the sample React Native app. Try the suggestion and the files changed.

This files are modified from `pod deintegrate` and `pod install` commands

Reviewed By: passy

Differential Revision: D21905958

fbshipit-source-id: 8b391acf5001c764bcfc0dd08b7ac5294ec9f5df
 2020-06-08 09:00:03 -07:00
Michel Weststrate
dd111076c9 Only use Flipper in DEBUG builds 
Summary:
as discussed in https://github.com/facebook/flipper/issues/976#issuecomment-634917766,

this solves the issue that FlipperKit is accidentally included in production builds ones react-native-flipper is installed, due to it's dependency on Flipper kit

This change is safe because the bindings did already have a check to verify that the Flipper bindings are available at all, and silenty skips their absence in production builds: https://www.internalfb.com/intern/diffusion/FBS/browse/master/xplat/sonar/react-native/react-native-flipper/index.js?commit=b7dd7e05b177&lines=128

Reviewed By: passy

Differential Revision: D21749213

fbshipit-source-id: 2c4435c7a375fbc24f89159855d3e0297f3aa9a4
 2020-05-28 09:59:53 -07:00
Michel Weststrate
febb3deed9 Some dep bumps 
Summary: Some dependency updates, mostly to prepare for next diff and update the podfile with the newest RN template

Reviewed By: passy

Differential Revision: D21749214

fbshipit-source-id: 0af10e404901a7522253136dc8c03020e7c813f8
 2020-05-28 09:59:53 -07:00
Pascal Hartig
b56e89f7ca Update podfile 
Summary: I think that's a good thing to keep up-to-date?

Reviewed By: mweststrate

Differential Revision: D20890360

fbshipit-source-id: a9c95d4afb2f6b6f0b32f595c53f3799b9ffaa73
 2020-04-07 05:54:41 -07:00
Michel Weststrate
8a7e0578ff Update to rc.5 
Summary:
* Followed plan of D20221558
* Manually bumped Flipper version on iOS to 0.33.1, which contains https://github.com/facebook/flipper/pull/874/files (make Flipper compatible with iOS 9).
* Will submit a PR on RN to bump the iOS template

Reviewed By: passy

Differential Revision: D20361824

fbshipit-source-id: 4f013b731b40e2d4f941742f9201bf2bb4382ec3
 2020-03-10 09:02:30 -07:00