Commit Graph

16 Commits

Author SHA1 Message Date
Pritesh Nandgaonkar
0ebe3956a4 Update OpenSSL pod and remove exclude arch setting (#1892)
Summary:
This PR updates the OpenSSL pod and thus updates the corresponding Folly and RSocket pods. The new OpenSSL pod has a support of arm64 artifact for iPhomeSimulators.This PR also updates the replaces the libevent pod which didn't work with arm64 arch for iPhoneSimulator.

## Changelog

- Update OpenSSL pod
- Update Folly dep
- Update RSocket dep
- Replace Libevent pod.

Pull Request resolved: https://github.com/facebook/flipper/pull/1892

Test Plan: CI

Reviewed By: mweststrate

Differential Revision: D26229304

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 46256d9cd3e0cf5aab6e477e612c3bcb77e31627
2021-02-04 08:50:14 -08:00
Pritesh Nandgaonkar
140ff8861e Add github actions for dependency pod validations (#1834)
Summary:
This PR adds github actions to validate the pods, so that the changes which breaks the validation is not made. This PR also downgrades the version update of OpenSSL, as it doesn't validate the Folly podspec. I have [raised](https://github.com/krzyzanowskim/OpenSSL/issues/113) an issue on the repository which manages the openssl dependency.
## Changelog

- Added githubaction for dependent pod validation
- Downgraded the openssl version, as with upgraded version the folly pod didn't validate.

Pull Request resolved: https://github.com/facebook/flipper/pull/1834

Test Plan: CI

Reviewed By: passy

Differential Revision: D25939525

Pulled By: priteshrnandgaonkar

fbshipit-source-id: f70d043f1f6b2c79028212d8f56c6b8632092e33
2021-01-19 14:20:50 -08:00
Daohan Chong
9b5680599e Upgrade OpenSSL-Universal to 1.1.180 (#1774)
Summary:
As it is stated in `OpenSSL-Universal`'s release notes: 1.1.180 has "macOS Catalyst support".

In order to use Flipper for Mac Catalyst apps, we need to remove dependency blockers.

## Changelog

- Upgrade OpenSSL-Universal to 1.1.180

Pull Request resolved: https://github.com/facebook/flipper/pull/1774

Test Plan:
Build this project using iOS target.

In order to test Mac Catalyst, other blockers `CocoaLibEvent` need to be fixed.

Reviewed By: cekkaewnumchai

Differential Revision: D25681881

Pulled By: passy

fbshipit-source-id: 1e45e875b943fd0bcffb541f58ed87ce3584e593
2021-01-04 07:55:25 -08:00
Pavel Zarecky
031cec299b Bump OpenSSL-Universal pod dependency to 1.1.171 (#1735)
Summary:
This should fix the react-native issue with building on Xcode 12: https://github.com/facebook/react-native/issues/29984

## Changelog

Upgrade OpenSSL-Universal dependency on the one that includes arm for iPhone Simulator: https://github.com/krzyzanowskim/OpenSSL/releases

Pull Request resolved: https://github.com/facebook/flipper/pull/1735

Test Plan: This PR is not intended to be merged directly, as more version bumping and propagation through the other pods will be needed.

Reviewed By: mweststrate

Differential Revision: D25302713

Pulled By: passy

fbshipit-source-id: ac8e7e4652800ab00255398fe227e58af3ad0c5c
2020-12-07 09:21:47 -08:00
Pritesh Nandgaonkar
abc0ae2b17 Update OpenSSL dependency
Summary: Updates the OpenSSL dependency. Enabling bitcode as the latest version of OpenSSL has bitcode support.

Reviewed By: mweststrate

Differential Revision: D24276537

fbshipit-source-id: 6f135659d64e8849dcf68266458a8f24ef795be7
2020-10-20 04:46:13 -07:00
Pritesh Nandgaonkar
7c6f8e9147 Make the sample app build for generic iOS Device (#992)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/992

Right now our sample app's fail to build when built against "Generic iOS Device", but it built successfully when built against simulator. Reason being all the simulators are 64 bit's, but when built against generic iOS device type, it didn't work for all the architecture as our Flipper and Flipper-Folly pod had 64bit architecture in their settings. But as soon as you build Flipper-Folly for standard architecture, RCU.cpp fails to build as that file is incompatible for lower standard architecture. Got the following error

{F233400670}

But, we do not need that file of Folly to build Flipper and RSocket. Thus in the podfile I have excluded it from its source. Also along with it I upgraded both Folly and RSocket to the latest releases.

Even with this changes i got one more problem, our openssl static library is not bitcode enabled for arm architecture, this error popped up when built against "Generic iOS Device". Right now I have disabled bitcode, the proper fix of this would be to find a dependency of openssl which is bitcode enabled. Its really hard to find the proper cocoapod dependency of openssl which is bitcode enabled. But disabling bitcode is not a big ask, also people will face this error only when they try to publish flipper in their release.

I discovered this problem from an issue posted in [RN](https://github.com/react-native-community/upgrade-support/issues/35), it also takes care of this issue.

Reviewed By: passy

Differential Revision: D20897590

fbshipit-source-id: 8c79d239572bb7efe2d65b2a7f1cfe8c608c1df4
2020-04-08 05:03:19 -07:00
Pritesh Nandgaonkar
4530eb9235 Release glog and DoubleConversion with different names
Summary: This releases glog and DoubleConversion under "Flipper" preappended name as it solves the issues with Flipper integration with RN under use_frameworks!  keyword.

Reviewed By: passy

Differential Revision: D19392941

fbshipit-source-id: ebdcdc23fcce45cec9bfc6d4f18c14a734caf24f
2020-01-14 10:55:16 -08:00
Pritesh Nandgaonkar
c1d5e8699b Update Flipper-Folly dependency
Summary: I have made a new release for Flipper-Folly with the changes in the base diff

Reviewed By: jknoxville

Differential Revision: D18449493

fbshipit-source-id: bdb60d2a5b16cd0e3fc8d2e135d6d52b97c61fd0
2019-11-12 09:52:48 -08:00
Janic Duplessis
ef06f6d546 Cleanup Flipper-Folly.podspec included headers (#518)
Summary:
- This removes `folly/**/*.h` in `source_files` which causes all headers to be included. Instead we include only the headers needed to build. In my case this caused a conflict with folly's "Zlib.h" getting included instead of the system "zlib.h" (apparently paths are not case sensitive).
- Remove duplicates in `public_header_files`, we can just keep `"folly/**/*.h"` to make all headers public.
- Remove `preserve_paths`, this is not be needed anymore.

## Changelog

Cleanup Flipper-Folly.podspec included headers
Pull Request resolved: https://github.com/facebook/flipper/pull/518

Test Plan: Tested in an app that everything build using the modified podspec.

Reviewed By: jknoxville

Differential Revision: D16918216

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 81cc9891c67bcb019580eb21d1b8e6d7318a4e03
2019-11-12 09:52:48 -08:00
Andres Suarez
54ebb44dda Tidy up Flipper license headers [2/2]
Reviewed By: passy

Differential Revision: D17863710

fbshipit-source-id: 5b249bdd1c06d3a526b250b035b797d0c8e796eb
2019-10-11 13:46:45 -07:00
Pritesh Nandgaonkar
ab121f9d96 Updated the OpenSSL dependency (#577)
Summary:
This PR updates the openssl dependency with OpenSSL-Universal, which ships a fat-binary of libssl and libcrypto with all the architecture.

This PR also updates the travis to cache cocoapods checkout directory.

## Changelog

Updated Flipper-Folly deps
Pull Request resolved: https://github.com/facebook/flipper/pull/577

Test Plan: CI

Reviewed By: jknoxville

Differential Revision: D17877304

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 9d13308108b6665d4bf5dd6145fcaafa2a2a8a13
2019-10-11 07:54:28 -07:00
Pritesh Nandgaonkar
aebca6bb57 Update OpenSSL dependency
Summary: Updated the OpenSSL dependency and released the new versions of Folly and RSocket.

Reviewed By: jknoxville

Differential Revision: D16222388

fbshipit-source-id: e894650a8c3ac764bc489e843e9a3ccf33688659
2019-07-12 09:35:52 -07:00
Pritesh Nandgaonkar
07f327f46b Automate iOS release (#445)
Summary:
This PR sets up Circle CI to publish pods when github release is made. This PR also updates the Flipper-Folly pod as it didn't build on 32 bit architecture, because `thread_local` was not supported.

Automated publish of cocoapods through Circle CI.
Pull Request resolved: https://github.com/facebook/flipper/pull/445

Reviewed By: danielbuechele

Differential Revision: D15333975

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 7db68efeeebbe344213917f10f9f3ce4132e8cbc
2019-05-14 07:24:10 -07:00
Pritesh Nandgaonkar
2dacea8541 Published Flipper-PeerTalk dependency on Cocoapods (#395)
Summary:
I have published the new tag of Peertalk on my [fork](https://github.com/priteshrnandgaonkar/peertalk) and published a [Flipper-PeerTalk](80e4cd9a05/Specs/d/6/6/Flipper-PeerTalk/0.0.4/Flipper-PeerTalk.podspec.json) pod on cocoapods. There was no reply on the [request](https://github.com/rsms/peertalk/issues/48) to publish the new version of the peertalk on their repository and it was blocking us to publish Flipper and FlipperKit pods to Cocoapods. For more context follow the issue #132. With this PR we would have all our dependencies on cocoapods and thus we can now publish Flipper and FlipperKit pods on the cocoapods master repository.

I have also added the Flipper-PeerTalk podspec file for future updates.
Pull Request resolved: https://github.com/facebook/flipper/pull/395

Reviewed By: passy

Differential Revision: D14642440

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 7847c19cddea358ffb62d2c6f16fc06d1afa1ea1
2019-04-01 08:49:16 -07:00
Pritesh Nandgaonkar
d044ae991f Fix the broken iOS OSS job
Summary:
Fixes the iOS OSS job which was failing. The root cause of the problem is as follows:

- RSocket was referring the master branch of rsocket/rsocket-cpp, fixed it by forking it and making its own release, unfortunately they don't make a release.
- Folly referred to the January's release. The current master branch of RSocket doesn't build with the latest release of the Folly, [this commit](b51dc569eb) is responsible for the breakage. Thus I made a Rsocket release, right before this [commit](b51dc569eb), so that it builds.Although, the current master branch of Folly builds with the current master branch of rsocket, but we will have to wait on Folly team to make a release. Once they do that I will update bit RSocket and Folly releases.

Reviewed By: jknoxville

Differential Revision: D14668686

fbshipit-source-id: 6b0362632c26355a69a3f33a031b71c88e7dd45b
2019-03-29 05:31:16 -07:00
Pritesh Nandgaonkar
f8bd473828 Use Folly and RSocket from cocoapods (#379)
Summary:
I have released pods for Folly and RSocket on cocoapods. Thus we won't need to host different versions of these pods on our repository. I haven't removed those pods from `Specs` folder, as the current users of `0.16.2` would still be referring the Specs folder on the master branch. I will remove the specs folder once, all our pods are on cocoapods and we no longer need to host any pods.
Pull Request resolved: https://github.com/facebook/flipper/pull/379

Reviewed By: jknoxville

Differential Revision: D14185931

Pulled By: priteshrnandgaonkar

fbshipit-source-id: ea285024123e41c2d110827e26f79a72ef22c008
2019-02-26 04:18:00 -08:00