Summary:
Reported in [the Workplace group](https://fb.workplace.com/groups/flippersupport/permalink/1002324710248187/), the empty array and object in network plugin wasn't shown and left blank. This happened because data component checked for expandability and decided empty object is not expandable. Thus, it uses different path to render components.
This diff fixes that by rendering empty array and object as `[]` and `{}`
Reviewed By: jknoxville
Differential Revision: D24726219
fbshipit-source-id: 9b22e1011c39c363b73f759477f44f08520734a7
Summary:
We've been using "booted" as a shortcut to select a device in `xcrun` but that will only refer to the *first* booted simulator. If you have multiple ones, that causes screenshots, videos and logs to always be pulled from the first.
Of course, this isn't documented anywhere, because Apple, but you can instead of `booted` pass in the "UDID" and refer to a specific device in all cases.
Reviewed By: nikoant
Differential Revision: D24627077
fbshipit-source-id: 2a52a8a17776746af4b3f6ca821dcce37bb0f7c2
Summary:
This diff makes the plugin manager and support form accessible from Sandy.
Actually converting them is TODO in T78698507 / T78698498
Reviewed By: cekkaewnumchai
Differential Revision: D24620558
fbshipit-source-id: c689d95b638b77ad504915a117e909cf0d88b841
Summary:
Make sure archived are displayed as such in the UI, and normal device functions aren't available:
* taking screenshots
* bookmarks
* metro device plugins
* disabling plugins
* disabled and unavailable plugins
* mobile builds
Also moved starting an emulator to the left rail, since it isn't a function related to the current selected thing
Reviewed By: cekkaewnumchai
Differential Revision: D24620247
fbshipit-source-id: f1f469e2fc5167fd90ccb35d583988873a9bc787
Summary:
This diffs adds support for the activeSheets mechanism in Sandy. It should be removed in the future (see T78696648) since open a dialog and keeping dialog state locally results in much more straight forward code, but supporting this for now makes sure that old flows are still supported.
With this change the plugin selection during a Flipper export for example wouldn't become visible
Reviewed By: cekkaewnumchai
Differential Revision: D24620074
fbshipit-source-id: f0558f5738e86a84a5cd0b9d574a3cfd0a3bf424
Summary: See test plan, if there is little space, 'tags' tended to overflow the search box. After this change the searchbox will grow were needed.
Reviewed By: cekkaewnumchai
Differential Revision: D24563826
fbshipit-source-id: 616173db7c080561ff51a76ab0e8938c58f87820
Summary:
Bumps [console-feed](https://github.com/samdenty99/console-feed) from 3.1.8 to 3.1.10.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/samdenty99/console-feed/commits">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1627
Reviewed By: cekkaewnumchai
Differential Revision: D24590105
Pulled By: passy
fbshipit-source-id: 490dc7bec5f231fa3c689abfb00aea33bb27fe0e
Summary: Added the Metro buttons to AppInspect
Reviewed By: cekkaewnumchai
Differential Revision: D24544760
fbshipit-source-id: 1eb6face14a7950d654c95b1a8fca31b8efed99b
Summary: Added Sandy styling to `CaptureButtons`, and converted to hooks while at it
Reviewed By: cekkaewnumchai
Differential Revision: D24538953
fbshipit-source-id: cfb9a9b856ada40eb96b77d2e5e6ea780971d0ce
Summary: This blesses the `Layout` and `theme` components and exposes them from `flipper-plugin`, so that they can be used in (public) Sandy plugins. Also marked old abstractions as going to be deprecated.
Reviewed By: cekkaewnumchai
Differential Revision: D24503560
fbshipit-source-id: a8f384667b8f66e3b9f00771a123fe5c9d755eb3
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1612
* Use the QPL-managed QPLCore and PigeonClient.
**Facebook:**
js-shared/qpl and js-shared/pigeon-client are maintained by QPL in xplat/js-shared. I've updated the Metro config and tsconfig to allow the packages to be imported without breaking the open-source version.
Reviewed By: passy
Differential Revision: D24358369
fbshipit-source-id: 7f13d6c99d8ca6ebcd0e66bf0e5f25069370cce7
Summary:
Split container had a convenient property `scrollable`, that automatically applies a Scroll container to the main content.
But I noticed it leads to bad design choices because it is so convenient. So sometimes scrolling would be unnecessarily in two directions because of this.
Or, since the scroll container wraps around the whole content, toolbars would scroll out of view. By forcing scrolling to be put explicitly in the component tree, we encourage plugin developers to think about where they actually want to have that scroll, and in which direction.
Also added options to use the Container padding properties on ScrollContainer, which is great since we can keep the scrollbars outside the padding, and apply it to the content only, to prevent an accidental mistake where people would put a scroll container in a padded container, that would put the scrollbar inside the padding.
Reviewed By: cekkaewnumchai
Differential Revision: D24502546
fbshipit-source-id: 524004a1c5f33a185f9b959251b72875dd623cb3
Summary:
So far we distinguished `Layout.Container` from `Layout.Vertical`, but they did almost exactly the same, so figured to unify them, so smaller API ftw :) Normal containers put children vertical, and if you want to use horizontal, use Layout.Horzontal
Also simplified code in Layout file a little bit.
Fixed issue I split container where the main container didn't go "underneath" the fixed container
Reviewed By: cekkaewnumchai
Differential Revision: D24502547
fbshipit-source-id: 517db3692749e670cda8f0cd7cb1c807df818b4d
Summary:
This stack tries to migrate notification system to Sandy.
This diff contains on the view; other functionalities aren't working. Also, some of the views will be implemented as functionalities are added.
Reviewed By: mweststrate
Differential Revision: D24390370
fbshipit-source-id: 8e11a01d9462934ff1fadf411e7e8f57ca7ef078
Summary: export filterRowsFact so we can reuse it. it's needed in diffs above
Reviewed By: SimoneCasagranda
Differential Revision: D24445819
fbshipit-source-id: 1c9ca363419c7e34f53e65b77764a49235e259e2
Summary: Currently we load all the plugins even if they are not required in dev mode, e.g. when you are developing a specific plugin. This diff adds an env var and command-line option to specify exact list of plugins to load. This makes dev mode startup faster and consume less memory.
Reviewed By: passy
Differential Revision: D24394146
fbshipit-source-id: 42a78c1ffb2632e657c2411e34e9c80fff18df3a
Summary:
Some exploratory testing on all iOS and Android plugins, to see how they behave inside Sandy, and fixed some layout glitches (some were also present without Sandy)
General fixes:
* Introduced some niceties like searchbox resizing properly, and toolbars wrapping automatically in Sandy, rather than buttons becoming invisible
* Containers don't grow anymore by default, but take size of contents
* ScrollContainer child is now a Layout.Vertical. Layout.Vertical should be used as default container everywhere (e.g. Tabs, Panels) in the future
* Fixed layout issue if a split container had only 1 visible child
* DetailsSidebar now scrolls vertically by default
* Details sidebar would sometimes render content in-place rather than in the reserved area
* AppSelector dropdown and Plugin list will now properly ellipse (...) if there is not enough space
Plugin fixes:
* Long database / table names in Database plugin would break layout
Also fixes https://github.com/facebook/flipper/issues/1611
Reviewed By: passy
Differential Revision: D24454188
fbshipit-source-id: c60c867270900a1d4f28587d47067c6ec1072ede
Summary: Tests to verify the more complex selection logic resulting from the Metro device exception. Also verifies the logic that computes the available plugins
Reviewed By: nikoant
Differential Revision: D24445555
fbshipit-source-id: 70110c4470e6aa1356e814aa40744b65c21cad89
Summary:
I love useMemo, and the memoized functions are in principle easy to testable since deps are known
But in practice they aren't as they close over their deps, preventing hoisting. So I now use a small `useMemoize` utility that encourages me to write them in a testable manner.
Applied this to the PluginList, and it makes it imho cleaner to read. Also, testing is now much easier as demonstrated in the next diff.
Reviewed By: nikoant
Differential Revision: D24445556
fbshipit-source-id: e156dbd4b8623eb1b90650e174b69a0ec868d2da
Summary:
This adds the ability in AppInspect to work with Metro and plugins.
Metro remains a weird and hardcoded edge case, as we show it as part of another device. So a few things to notice:
- Metro does not have it's own entry in the device/app dropdown
- When selecting a metro plugin, the surrounding context (selected main device / app) remains, but you will notice that the device dropdown switches to 'React Native'. This is intentional to reflect that we are talking to React Native in general, and not necessarily to the device / app shown in the context.
Reviewed By: nikoant
Differential Revision: D24422267
fbshipit-source-id: 239aa71b5c01e19bdda53a930ad9fa8af13b8d4a
Summary:
This diff adds the rough navigation to open pugins, there are some rough egdes still, and tests will be added later, but wanted to keep diffs small, and land the feature early to get some initial dogfooding going on early.
Note that we now also show all disabled plugins to help people with trouble shooting.
Reviewed By: nikoant
Differential Revision: D24418411
fbshipit-source-id: 1402d69efe2e52bc2c81336cfb4f4c9928ea4d80
Summary:
This diff implement few things:
* Logs tab for plugin
* Sending new state for each action is expensive, that is why flipper side receive only diffs and uses `getStateFromLogItem` to calculate new state
* fixed `keys` in `DataInspector.tsx` which caused `DataInspector` become unresponsive
{F340648998}
Differential Revision: D23021619
fbshipit-source-id: 17490c25f7b86faf9e574a612996563aac18525e
Summary: Disables the picker if the selection isn't editable
Differential Revision: D24419005
fbshipit-source-id: 433229a23db7fac947f574110326f5bf0dc51bc3
Summary:
Removes the "Set current" button if the timeline isn't editable
Note that the styling does weird stuff to colors when a field is set as not editable
Differential Revision: D24419006
fbshipit-source-id: 84dcee2e04d5ed7ebb3dc0255e99d1756f195284
Summary:
Bumps [metro](https://github.com/facebook/metro) from 0.60.0 to 0.63.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/metro/releases">metro's releases</a>.</em></p>
<blockquote>
<h2>Release v0.63.0</h2>
<ul>
<li>[fix] Change initialisation logo and text from RN to Metro</li>
</ul>
<h2>Release v0.62.0</h2>
<ul>
<li>[feature] Add onBundleBuilt to ServerOptions</li>
</ul>
<h2>Release v0.61.0</h2>
<p>Contains all changes since 0.60.0:</p>
<ul>
<li>[Feature]: Add support for blockList and array of regexs</li>
<li>[Fix]: Change order of imports to be the same as in source files</li>
<li>[Feature]: Add new secureServerOptions option to runServer</li>
<li>[Feature]: Add inline-requires option</li>
<li>[PetPeeve]: Metro server => Metro</li>
</ul>
<p>See <a href="https://github.com/facebook/metro/compare/0.60.0...0.61.0">0.59.0...0.60.0</a> for a full list of changes.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b9bacd51d0"><code>b9bacd5</code></a> Metro release v0.63.0</li>
<li><a href="c106b6540e"><code>c106b65</code></a> Change initialisation logo and text</li>
<li><a href="be719b29c0"><code>be719b2</code></a> remove redundant deprecated-utility setting from flow configs</li>
<li><a href="9236feba99"><code>9236feb</code></a> Turn off template literal and shorthand properties transform for hermes-canary</li>
<li><a href="6b82e8443c"><code>6b82e84</code></a> Create a <code>metro-runtime</code> module</li>
<li><a href="18883f6caa"><code>18883f6</code></a> Fix up package.json files.</li>
<li><a href="921b73e4d0"><code>921b73e</code></a> Remove autogenerated table of contents (deprecated in docusaurus v2)</li>
<li><a href="eb9b02572b"><code>eb9b025</code></a> Update configuration page with examples</li>
<li><a href="00a5a6d8d6"><code>00a5a6d</code></a> Fix troubleshooting and help pages</li>
<li><a href="c73eaf88f8"><code>c73eaf8</code></a> Update docusaurus version</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/metro/compare/v0.60.0...v0.63.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1606
Reviewed By: passy
Differential Revision: D24392103
Pulled By: nikoant
fbshipit-source-id: 6d816629f55e04852d6737f9960fa61d7e83cee8
Summary: Added `axis` property to scroll container, to make scroll work in one direction, and fill out the other one.
Reviewed By: cekkaewnumchai
Differential Revision: D24390943
fbshipit-source-id: 5767e753edfb947f43b3998e10d6cebf57f9b53b
Summary:
Restore sidebar functionality for Sandy plugins
Also needed to fix some circular dependency issues as fallout.
Reviewed By: cekkaewnumchai
Differential Revision: D24362215
fbshipit-source-id: 0a09ac35ba981322ae0793edc3aa79ffddf2ce73
Summary: When trying to refactor some components, did once again run into circular imports that cause the flipper startup sequence to fail. Added linting rules to make sure this is much less likely to happen in the future, and fixed all resulting errors
Reviewed By: nikoant
Differential Revision: D24390583
fbshipit-source-id: 9b20cf6a4d3555dc68f0069c2950dd7162b17e67
Summary:
Render a plugin list
Will add tests once the entire feature is complete
Reviewed By: cekkaewnumchai
Differential Revision: D24079897
fbshipit-source-id: db7250ff612b67ab18dfcacdcb9c44dab596933d
Summary: This diff adds the device switcher, filling the switcher with apps and devices.
Reviewed By: cekkaewnumchai
Differential Revision: D24053787
fbshipit-source-id: 4f69835a12eec90a0e5704f71c8ceed5509f61ce
Summary:
Add a GUI for the timeline of a Component based off MarkerTimeline.
It enables selecting points on the timeline, which will display their properties (arbitrary KVS). A button allows the user to select the current point of the timeline for the tree. This triggers unselection of the tree as per D24254002.
Solving re-selection isn't trivial, which is why the tree collapses on redraw too, and I believe we can live with this UX for this v1.
Reviewed By: astreet
Differential Revision: D23865369
fbshipit-source-id: 026562e71aa04b4e5e1e7cf1392d8ef140cdf43c
Summary: Recreation of D22118786, which was so old rebasing died on some lacking meta data. Lands https://github.com/facebook/flipper/pull/1256
Reviewed By: passy
Differential Revision: D24331424
fbshipit-source-id: 65fc5d8bf0242d4266e269716a319d71ce2e2826
Summary: These tests are testing the logic of building the main components in Actions tab and Sagas tab.
Reviewed By: zaxy78
Differential Revision: D24078307
fbshipit-source-id: 2929832e18f4ccbf2cf46e94c8ef08f4f947cc85
Summary:
Bumps [console-feed](https://github.com/samdenty99/console-feed) from 3.1.0 to 3.1.7.
<details>
<summary>Commits</summary>
<ul>
<li><a href="07a720b795"><code>07a720b</code></a> v3.1.7</li>
<li><a href="3ba0e2facd"><code>3ba0e2f</code></a> feat: display caught errors on properties</li>
<li><a href="e447954462"><code>e447954</code></a> Fixing the regeneratorRuntime error and React.memo error (<a href="https://github-redirect.dependabot.com/samdenty99/console-feed/issues/54">https://github.com/facebook/flipper/issues/54</a>)</li>
<li><a href="2fca873a16"><code>2fca873</code></a> update README.md</li>
<li>See full diff in <a href="https://github.com/samdenty99/console-feed/compare/v3.1.0...v3.1.7">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1587
Reviewed By: mweststrate
Differential Revision: D24250090
Pulled By: nikoant
fbshipit-source-id: 007908667af7f440787af371ae83a84f7a5488ff
Summary: In D24138822 I basically bumped all desktop deps. That was a bit too much as it affected our build infra and broke it. The problem wasn't easy to bisect so choose a smaller set of deps instead to update; everything transpile & lint related + a few well tested runtime deps.
Reviewed By: cekkaewnumchai
Differential Revision: D24161841
fbshipit-source-id: 67162efeccd05a344b229ce976102cfafe6d1099
Summary:
As designed by Vince [here](https://www.figma.com/file/4e6BMdm2SuZ1L7FSuOPQVC/Flipper?node-id=585%3A127550), this diff adds Flipper Doctor into Sandy
Note:
- The dot on Doctor icon will act similarly to `DoctorBar`
- add type to `count` for `LeftRailButton` to act like dot badge
- Get rid of padding in `antd` modal
Reviewed By: nikoant, mweststrate
Differential Revision: D24137349
fbshipit-source-id: 8ce441e0ed96083eba09d98dfd3a45ff9b5be027
Summary:
Fixes layout issue that was caused by ANT line-heights leaking into the old design.
Introduced a `.flipperlegacy_design ` class at the `root` element of Flipper, so that it is easier in the future to bail out / add overrides for certain features in the old design.
Reviewed By: priteshrnandgaonkar
Differential Revision: D24135482
fbshipit-source-id: 40091ebbde71662f2ebea66577f7b727009ca9c6
Summary:
Bumps [query-string](https://github.com/sindresorhus/query-string) from 6.13.1 to 6.13.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/sindresorhus/query-string/releases">query-string's releases</a>.</em></p>
<blockquote>
<h2>v6.13.3</h2>
<ul>
<li>Fix the TypeScript type for the <code>.stringifyUrl()</code> method b15f945</li>
</ul>
<p><a href="https://github.com/sindresorhus/query-string/compare/v6.13.2...v6.13.3">https://github.com/sindresorhus/query-string/compare/v6.13.2...v6.13.3</a></p>
<h2>v6.13.2</h2>
<ul>
<li>Fix the <code>ParsedQuery</code> TypeScript typ 56d2923</li>
</ul>
<p><a href="https://github.com/sindresorhus/query-string/compare/v6.13.1...v6.13.2">https://github.com/sindresorhus/query-string/compare/v6.13.1...v6.13.2</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="eb769d201d"><code>eb769d2</code></a> 6.13.3</li>
<li><a href="b15f945fc1"><code>b15f945</code></a> Fix the TypeScript type for the <code>.stringifyUrl()</code> method</li>
<li><a href="60802a7697"><code>60802a7</code></a> 6.13.2</li>
<li><a href="56d29234a2"><code>56d2923</code></a> Fix the <code>ParsedQuery</code> TypeScript typ</li>
<li>See full diff in <a href="https://github.com/sindresorhus/query-string/compare/v6.13.1...v6.13.3">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1554
Reviewed By: cekkaewnumchai
Differential Revision: D24112939
Pulled By: mweststrate
fbshipit-source-id: 466b391e021369cd5b1e9180e1fd967baef16bca
