Commit Graph

8 Commits

Author SHA1 Message Date
Pranav Yadav
a6ab663c32 iOS-pod-lint - Bump actions/checkout@v3.5.3 & nick-fields/retry@v2.8.3 (#4877)
Summary:
This diff bumps `actions/checkout@v3.5.3`, and `nick-fields/retry@v2.8.3`

### Ref.:
- `actions/checkout@v3.5.3` changelog: https://github.com/actions/checkout/releases/tag/v3.5.3
- `nick-fields/retry@v2.8.3` changelog: https://github.com/nick-fields/retry/releases/tag/v2.8.3

## Changelog:

[GENERAL] [SECURITY] - [Actions] `iOS-pod-lint` - Bump `actions/checkout@v3.5.3` & `nick-fields/retry@v2.8.3`

Pull Request resolved: https://github.com/facebook/flipper/pull/4877

Test Plan: - Workflow should run and work as usual.

Reviewed By: lblasa

Differential Revision: D47056989

Pulled By: passy

fbshipit-source-id: cc80115ab0757f028f018c185f724915488e6ea3
2023-06-28 03:07:46 -07:00
Michel Weststrate
efdf9d2d64 Upgrade GH retry action so that stdout/ stderr is captures (#3211)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/3211

The GH retry action did ate all the stdout / stderr, so if the retry fails, it was completely unclear why. This was fixed in a newer version of the action

Reviewed By: antonk52

Differential Revision: D33308437

fbshipit-source-id: a599161e0c72b95b35e6ecab8cd84c6fa7027cd3
2021-12-24 07:15:23 -08:00
Pritesh Nandgaonkar
3f04577548 Pod lib lint subspecs in a concurrent manner (#2540)
Summary:
This PR splits the linting of the flipperkit pods into different subspecs. This will fasten the overall validation time. Before, all the pods were validated in a serialised fashion, but now its done in a parallel way.

This brings down the total validation time from 2+ hrs to ~ 25mins

## Changelog

- Split the validation of the FlipperKit pod into parallelised subspecs

Pull Request resolved: https://github.com/facebook/flipper/pull/2540

Test Plan: https://github.com/facebook/flipper/actions/runs/986790548

Reviewed By: passy

Differential Revision: D29489716

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 55557c581d56ee01796ca64405cf78b647d2a68b
2021-06-30 09:52:19 -07:00
Pritesh Nandgaonkar
526d985d15 Run iOS jobs on podspec changes (#2136)
Summary:
Updates the run conditions of iOS jobs so that it is triggered when we change "Flipper.podspec" and "FlipperKit.podspec"
## Changelog

- Update the run conditions

Pull Request resolved: https://github.com/facebook/flipper/pull/2136

Test Plan: CI

Reviewed By: passy

Differential Revision: D27402914

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 3b687612f26a0e22773c48540b76a7660bb29ed6
2021-03-29 11:41:34 -07:00
Pritesh Nandgaonkar
d22e893169 Update the run logic of iOS jobs (#2118)
Summary:
This PR updates the logic when these iOS jobs should be run. This change just makes it run for pushes to iOS folders and xplat c++ folders.

## Changelog

- Update the GH action.

Pull Request resolved: https://github.com/facebook/flipper/pull/2118

Test Plan: Note that no iOS job is run.

Reviewed By: mweststrate

Differential Revision: D27395681

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 37a7c2fb9b3fdfa22307ac5e7403364bfeb0a384
2021-03-29 06:57:10 -07:00
Pritesh Nandgaonkar
0ebe3956a4 Update OpenSSL pod and remove exclude arch setting (#1892)
Summary:
This PR updates the OpenSSL pod and thus updates the corresponding Folly and RSocket pods. The new OpenSSL pod has a support of arm64 artifact for iPhomeSimulators.This PR also updates the replaces the libevent pod which didn't work with arm64 arch for iPhoneSimulator.

## Changelog

- Update OpenSSL pod
- Update Folly dep
- Update RSocket dep
- Replace Libevent pod.

Pull Request resolved: https://github.com/facebook/flipper/pull/1892

Test Plan: CI

Reviewed By: mweststrate

Differential Revision: D26229304

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 46256d9cd3e0cf5aab6e477e612c3bcb77e31627
2021-02-04 08:50:14 -08:00
Pritesh Nandgaonkar
140ff8861e Add github actions for dependency pod validations (#1834)
Summary:
This PR adds github actions to validate the pods, so that the changes which breaks the validation is not made. This PR also downgrades the version update of OpenSSL, as it doesn't validate the Folly podspec. I have [raised](https://github.com/krzyzanowskim/OpenSSL/issues/113) an issue on the repository which manages the openssl dependency.
## Changelog

- Added githubaction for dependent pod validation
- Downgraded the openssl version, as with upgraded version the folly pod didn't validate.

Pull Request resolved: https://github.com/facebook/flipper/pull/1834

Test Plan: CI

Reviewed By: passy

Differential Revision: D25939525

Pulled By: priteshrnandgaonkar

fbshipit-source-id: f70d043f1f6b2c79028212d8f56c6b8632092e33
2021-01-19 14:20:50 -08:00
Pritesh Nandgaonkar
c0a9150dd8 Github action to validate Flipper and FlipperKit pod (#1026)
Summary:
This PR adds Github Action to validate the podspec file. Validation is crucial, if it podspecs don't validate then we won't be able publish pods to the trunk.
## Changelog

Add Github Action to validate FlipperKit and Flipper pod
Pull Request resolved: https://github.com/facebook/flipper/pull/1026

Test Plan: Github Action passes.

Reviewed By: mweststrate

Differential Revision: D21130523

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 0116120b9bbb073516798d4d7f08b347ed9755a3
2020-04-21 04:52:33 -07:00