Summary:
This is pretty dumb but hopefully good enough to prevent accidental regressions. We simply check if there are "enough" `libevent_core.so`s in the bundle. This is obviously not future-proof but it's super cheap to run and if it causes problems at some point, we can always remove it.
Apologies for the formatting spam. Didn't notice until I submitted this that my editor got a little passive-aggressive.
Pull Request resolved: https://github.com/facebook/flipper/pull/3436
Test Plan: CI here.
Reviewed By: lblasa
Differential Revision: D34210743
Pulled By: passy
fbshipit-source-id: a57c397e39456fae33af9f3ceed08b6944eac79e
Summary:
This includes a bunch of different things which I wanted to do separately, but it's all a massive Jenga Tower and you cannot remove a single piece.
- Litho upgrade
- Gradle plugin upgrade
- Remove storage permission as it apparently doesn't do anything above Android 10
- Upgraded build target to Android 12 because the new support lib/Kotlin stdlib required this which then caused the issue below to pop up
- Added "export=true" everywhere as this is now a blocking issue if you don't have it
- Upgraded to the LeakCanary2 plugin as version one no longer builds with an Android 12 target for the export reason
- Make CI run on JRE 11 because that's required by the new Gradle plugin
- Update internal CI to no longer define the SDK twice and use Java 11
Pull Request resolved: https://github.com/facebook/flipper/pull/3095
Test Plan: Built Android Sample and Tutorial app, connected to Flipper.
Reviewed By: lblasa
Differential Revision: D32644410
Pulled By: passy
fbshipit-source-id: 8978f158d9c642b3bbd9dbbd7321eb20098a7a53
Summary:
I've been really sweating about this one. It looks like Google now removed NDK 21 as it's too old. However, we've been struggling with the upgrade because OpenSSL was built against an old version of the NDK/glibc/LLVM/some other stuff.
I've now managed to create an OpenSSL distribution for 1.1.1k (we had 1.1.0h before) that seems to build with this after some small modifications.
This seems to do the trick, but I wouldn't be shocked if we found some more incompatibilities further down the line.
Pull Request resolved: https://github.com/facebook/flipper/pull/2836
Test Plan:
- Locally: `./gradlew :tutorial:installDebug`. Builds, starts up. Cool.
- Public GitHub CI: Happy.
- Circle CI: Only triggers post-land. We'll see. But the setup is simple, so hopefully it should work there, too.
- Internal CI: Waiting for signal.
Reviewed By: fabiomassimo
Differential Revision: D30839209
Pulled By: passy
fbshipit-source-id: efe599f28cc0edfdf2149f905c3483555239edc0
Summary:
This should take care of the build issue. It's an annoying caching issue that's been around for ages. Also why it didn't happen locally.
Pull Request resolved: https://github.com/facebook/flipper/pull/2432
Test Plan: GitHub CI
Reviewed By: mweststrate
Differential Revision: D28958707
Pulled By: passy
fbshipit-source-id: 8538f6616dec934d924c04713af93e7a6b89e617
Summary:
We missed that D28795384 (09951d505e) broke the Kotlin plugin until we got to
our Snapshot job. This makes sure we build all artifacts and get
signal on PRs.
Pull Request resolved: https://github.com/facebook/flipper/pull/2404
Test Plan:
CI
`./gradlew assembleDebug` failed correctly when applying the change.
Reviewed By: nikoant
Differential Revision: D28801494
Pulled By: passy
fbshipit-source-id: 704047ea17af632091c6597024ddacc9247255a9
Summary:
Builds up a file with checksums of all `build.gradle` files. Deliberately excludes the `gradle.properties` which changes all the time. The cache shouldn't require nuking except in some rare circumstances.
Pull Request resolved: https://github.com/facebook/flipper/pull/1922
Test Plan: From 41 minutes down to 17: https://github.com/passy/flipper-1/actions/runs/561501374
Reviewed By: mweststrate
Differential Revision: D26427242
Pulled By: passy
fbshipit-source-id: ff1d7370d477c9d7b57c62082ec985108a5ba698
Summary:
I honestly don't know how the resolution works but it seems that we need
more than just one NDK.
Pull Request resolved: https://github.com/facebook/flipper/pull/1715
Test Plan: Let's hope this turns green.
Reviewed By: mweststrate
Differential Revision: D25170962
Pulled By: passy
fbshipit-source-id: dcdf25b5c77f08bdeceef50d924727cb0c9dcca9
Summary:
Honestly not sure what's causing the new NDK to be pulled in
but at least locally installing it fixes the failure we see here:
https://github.com/facebook/flipper/runs/1424681947
Pull Request resolved: https://github.com/facebook/flipper/pull/1693
Test Plan: Wait for the Actions on the PR
Reviewed By: nikoant
Differential Revision: D25093335
Pulled By: passy
fbshipit-source-id: e7af63fcf3c5270c869acc3d094234d15968aeda
Summary:
This is in line with the most recent stable Android Studio Release.
Pull Request resolved: https://github.com/facebook/flipper/pull/958
Test Plan:
Used it myself.
Open Source CI required a higher NDK, so let's first check what CI says to that internally now.
Reviewed By: jknoxville
Differential Revision: D20794634
Pulled By: passy
fbshipit-source-id: c32f934634b036ad3c1cad9fc49541e585d64329
Summary:
This workflow is currently building the android app and then trying to upload the mac app (which isn't built) which is failing.
I think it should be uploading the android app instead.
Pull Request resolved: https://github.com/facebook/flipper/pull/820
Reviewed By: passy
Differential Revision: D20035055
Pulled By: jknoxville
fbshipit-source-id: 08367d464a045b47cf1b8b5395fd2151793a23cf
Summary:
Getting really pissed off with Travis and this has significantly shorter queue times.
Mind that this probably won't work until the Folly PR is merged.
Pull Request resolved: https://github.com/facebook/flipper/pull/810
Test Plan: CI
Reviewed By: mweststrate
Differential Revision: D19951126
Pulled By: passy
fbshipit-source-id: ed51ad5ec6d4df3a59784dbd31e7c1667593d04f
