Commit Graph

3012 Commits

Author SHA1 Message Date
greenkeeper[bot]
f44d2e4560 @allow-large-files [flipper][PR] Update flow-bin to the latest version (#829)
Summary:
## The devDependency [flow-bin](https://github.com/flowtype/flow-bin) was updated from `0.118.0` to `0.119.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

 ---

**Publisher:** [jbrown215](https://www.npmjs.com/~jbrown215)
**License:** MIT

[Find out more about this release](https://github.com/flowtype/flow-bin).

 ---

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

 ---

Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/829

Reviewed By: nikoant

Differential Revision: D20139183

Pulled By: passy

fbshipit-source-id: fca3711e4299e02cc138e370ade8376c374a6f40
2020-02-27 12:40:48 -08:00
Hilal Alsibai
68bc277c6c Add theme data for components in the layout inspector
Summary: Adds the theme information relating to a Litho component in the layout inspector

Reviewed By: sjkirby

Differential Revision: D20133889

fbshipit-source-id: 93acb745f47c1ff9ce37be35a05b4a6269193a47
2020-02-27 12:36:30 -08:00
Pascal Hartig
887a8721c5 Upload dmg artifact on tag (#836)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/836

^

Reviewed By: nikoant

Differential Revision: D20139272

fbshipit-source-id: 0246b571399744b57aa8a222bbcad7238f52fe96
2020-02-27 12:28:13 -08:00
Anton Nikolaev
6eb027a9ee Upgrade Electron to 8.0.1 (#837)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/837

Another attempt to upgrade Electron

Reviewed By: passy

Differential Revision: D20098881

fbshipit-source-id: 5bed38ab84d1d42336c5845b7f4aec8edba70daf
2020-02-27 10:07:40 -08:00
Pascal Hartig
2ed6230013 Flipper Bump: v0.32.2-SNAPSHOT
Summary: Back to snapshots.

Reviewed By: cekkaewnumchai

Differential Revision: D20115910

fbshipit-source-id: d9e452f544edeb4f3506757b108c6273cc4ca99a
2020-02-27 09:50:55 -08:00
Pascal Hartig
959fcee827 Flipper Release: v0.32.1
Summary: Bugfix release with previous Electron version.

Reviewed By: cekkaewnumchai

Differential Revision: D20115911

fbshipit-source-id: 5f84c72f7e4b33d7661e7e6a4db64c51daa38851
2020-02-27 09:50:55 -08:00
Lucas Bento
be360157f6 Add DMG target to mac distribution (#833)
Summary:
Fixes https://github.com/facebook/flipper/issues/807 by adding a DMG target to distribute the application for mac.

The `.dmg` file is `97.2 MB` while the `.zip` is `101.5 MB`. 😄

![image](https://user-images.githubusercontent.com/6207220/75275890-7c32b480-5805-11ea-9d05-9a4f47d03562.png)

## Changelog

Add DMG target for mac distribution
Pull Request resolved: https://github.com/facebook/flipper/pull/833

Test Plan:
1. `yarn build --mac`;
1. Check `flipper-mac.dmg` inside of `dist`.

 ---

**The background is completely discussable, I borrowed it [from an old project](https://github.com/lucasbento/react-native-actions/tree/feature/electron/packages/electron-react-native-actions) of mine and it's [totally not inspired by WebStorm `.dmg` file](https://user-images.githubusercontent.com/6207220/75276024-b3a16100-5805-11ea-8c69-063fe28316c1.png).**

Reviewed By: nikoant

Differential Revision: D20139188

Pulled By: passy

fbshipit-source-id: 1aaaabd7c6ac51d12865388bf962d164f80a7a14
2020-02-27 09:40:31 -08:00
Anton Nikolaev
ab0078a13f Typescriptify the main process code (14/N)
Summary: Converted scripts/yarn-install.js to typescript

Reviewed By: passy

Differential Revision: D20098071

fbshipit-source-id: be56a95a11089cd857efb00e62866213a88b739c
2020-02-27 05:45:24 -08:00
Anton Nikolaev
2bd61bca87 Typescriptify the main process code (13/N)
Summary: Converted src/utils/icons.js to typescript

Reviewed By: passy

Differential Revision: D20076060

fbshipit-source-id: fa6309033f5de7183de7f85ac8318eec36b6bb69
2020-02-27 05:45:24 -08:00
Anton Nikolaev
8d66c3aba7 Typescriptify the main process code (12/N)
Summary: Converted static/watchman.js to typescript

Reviewed By: passy

Differential Revision: D20071220

fbshipit-source-id: 7d86ffa8dd728246eeac8a01e2573564e8fd6bbe
2020-02-27 05:45:24 -08:00
Anton Nikolaev
aff433c8ad Typescriptify the main process code (11/N)
Summary: Converted static/compilePlugins.js to typescript

Reviewed By: passy

Differential Revision: D20070227

fbshipit-source-id: ba360b944440babedef94af0d0bc577711165ff6
2020-02-27 05:45:23 -08:00
Anton Nikolaev
2d551f6b4a Typecscriptify the main process code (10/N)
Summary: Converted scripts/build-utils.js to typescript

Reviewed By: passy

Differential Revision: D20067220

fbshipit-source-id: 29c1a4aed11b9d682290daf57db5507736ad8c69
2020-02-27 05:45:23 -08:00
Anton Nikolaev
caf04e4e4a Typescriptify the main process code (9/N)
Summary: Converted scripts/build-release.js and scripts/build-headless.js to typescript

Reviewed By: passy

Differential Revision: D20066504

fbshipit-source-id: 25f336062361e1211b581f96979978a6bf4fe6d4
2020-02-27 05:45:23 -08:00
Pascal Hartig
09d0b4c841 Update tslint rules
Summary:
Make sure that we can pass with the combinations of eslint/tslint
rules.

Reviewed By: nikoant

Differential Revision: D20067199

fbshipit-source-id: 40e208f75f09a1eff584f111fbb9bc1be87dba01
2020-02-27 04:42:04 -08:00
Moti Zilberman
1e00966a4a Correctly capitalise "React DevTools"
Summary: TSIA

Reviewed By: rickhanlonii, jknoxville

Differential Revision: D20069072

fbshipit-source-id: 56ca37c8354b2dcbe2756bfe0f48f139ea44e32d
2020-02-26 00:24:14 -08:00
Sim Sun
4a2349c42d refactor(asan): remove asan checker
Summary: Remove asan checker, we can use `BuildConfig.IS_ASAN_BUILD` to check whether it's a asan build to instead of invoking a JNI api.

Differential Revision: D20088093

fbshipit-source-id: f26d367430a983fbe7b630919a4131fdf2e2d510
2020-02-25 21:48:28 -08:00
Pascal Hartig
4c82d3f4d3 Back out "Upgrade electron" (#831)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/831

Original commit changeset: a2282c2f4062

Reviewed By: cekkaewnumchai

Differential Revision: D20077962

fbshipit-source-id: 6387a3e765cd284ed819e84103abab67589ce256
2020-02-25 16:47:18 -08:00
Michel Weststrate
7c2fd4d5e5 Track memory usage
Summary: ^

Reviewed By: passy

Differential Revision: D20035089

fbshipit-source-id: 5df97847e442c626af8445e0909ea5e07311cc7e
2020-02-25 14:59:49 -08:00
Michel Weststrate
74004b6338 Improve unit test robustness
Summary: When running tests locally, some are quite flaky, and there is a lot of error logging noise. This diff doesn't remove all of it, but does reduce it significantly.

Reviewed By: nikoant

Differential Revision: D20034619

fbshipit-source-id: 183f74475b644f803b2f92b1b1301f4d0f6e193a
2020-02-25 14:59:48 -08:00
Pritesh Nandgaonkar
abb2dc72ee Fix the broken notification click
Summary:
This diff fixes the broken deeplink to the notifications hub when one clicks on the macos native notification. See the bug reported [here](https://fb.workplace.com/groups/220760072184928/permalink/532998544294411/)

This [post](https://fb.workplace.com/groups/220760072184928/permalink/532998544294411/) reports the bug.

Reviewed By: passy

Differential Revision: D20089749

fbshipit-source-id: 8061ae07c450fd674795af4c5be53ce77402c063
2020-02-25 08:09:59 -08:00
Pascal Hartig
2ee9778a8e Bundle command scaffolding
Summary:
This sets up a basic UI for a bundling command. It checks for the source, creates an output directory if necessary and automatically creates an output name, so it should hopefully be as intuitive as possible.

There are plenty of potential error case that I don't directly handle. That's something we may want to consider in the future.

Reviewed By: nikoant

Differential Revision: D19973889

fbshipit-source-id: 5638ed0e45187c5ad567b9e2559c8befe52c6085
2020-02-25 06:07:02 -08:00
greenkeeper[bot]
d22530fff3 Update uuid in group main to the latest version � (#827)
Summary:
## The dependency [uuid](https://github.com/uuidjs/uuid) was updated from `3.4.0` to `7.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

 ---

**Publisher:** [ctavan](https://www.npmjs.com/~ctavan)
**License:** MIT

[Find out more about this release](https://github.com/uuidjs/uuid).

 ---

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

 ---

Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/827

Reviewed By: jknoxville

Differential Revision: D20067749

Pulled By: passy

fbshipit-source-id: 045c94cc1c28f0854680340f56bb35b854a37c51
2020-02-24 19:49:24 -08:00
John Knox
b3a6bf3dba Use named args for ArchivedDevice constructor
Summary: The constructor is getting quite a few args now, so to avoid string, string mistakes I'm making sure you pass objects with named params.

Reviewed By: passy, mweststrate

Differential Revision: D20034012

fbshipit-source-id: 4e0d23eeaa9100c6c19d3e36fee62649659ad261
2020-02-24 19:43:22 -08:00
Anton Nikolaev
609ca27eae Typescriptify the main process code (8/N)
Summary:
- Enabled typescript in "scripts" folder
- Converted start-dev-server.js to typescript

Reviewed By: passy

Differential Revision: D20066501

fbshipit-source-id: 23550cf3774e07fad0a8783831e3d574baee977f
2020-02-24 19:07:08 -08:00
Anton Nikolaev
64e85f226c Typescriptify the main process code (7/N)
Summary: Typescriptified static/launcher.js

Reviewed By: passy

Differential Revision: D20066497

fbshipit-source-id: 64fc47086fc599f36f2313406e2c72a76c481fb0
2020-02-24 19:07:08 -08:00
Anton Nikolaev
8e7ca24e72 Typescriptify the main process code (6/N)
Summary: Enabled TypeScript compiler checks for "static" folder

Reviewed By: passy

Differential Revision: D20066491

fbshipit-source-id: e797c734718561c63571ca71fc0dc3f0c99cbcbb
2020-02-24 19:07:07 -08:00
Pascal Hartig
a1260a9789 Set up oclif
Summary:
Provides some really nice helpers and generators for
multi command CLIs, including test helpers and all
sorts of output niceties. This should make it quite
easy for us to add additional sub-commands for
bundling, publishing and keeping docs for all of it.

Heroku maintains this and provides some excellent
docs, too: https://oclif.io/

My only complaint is that it's class-based but that's
effectively only the way to declare new commands and
enforces a set of required/static properties on it.

Reviewed By: nikoant

Differential Revision: D19970293

fbshipit-source-id: 4228e502198c6fd376854a90ed2f01da29e96bc2
2020-02-24 14:04:42 -08:00
Hilal Alsibai
33bbeadfe9 Add theme information for Application, Activity and View descriptors
Summary: This will query for and display all of the associated theme information for each of the descriptors.

Reviewed By: passy

Differential Revision: D20008056

fbshipit-source-id: 720d224144b0822528ca8e23cdbec9fe9dd25e6b
2020-02-24 11:33:01 -08:00
Pascal Hartig
16a24d82c8 Update jest config
Summary:
We don't want to test again against the compiled JS output.
Also, we *do* want to fail if we break the config and don't
actually run any tests.

Reviewed By: nikoant

Differential Revision: D20068114

fbshipit-source-id: c46e5a25fcd155d160f717a9db8f088787913a28
2020-02-24 07:22:49 -08:00
greenkeeper[bot]
d949123831 Update uuid in group website to the latest version � (#828)
Summary:
## The dependency [uuid](https://github.com/uuidjs/uuid) was updated from `3.4.0` to `7.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

 ---

**Publisher:** [ctavan](https://www.npmjs.com/~ctavan)
**License:** MIT

[Find out more about this release](https://github.com/uuidjs/uuid).

 ---

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

 ---

Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/828

Reviewed By: cekkaewnumchai

Differential Revision: D20067757

Pulled By: passy

fbshipit-source-id: ac9e7f6aaff86e30c320c427323627ac732ddb73
2020-02-24 07:04:09 -08:00
Pascal Hartig
fee93e6cff Flipper Bump: v0.32.1-SNAPSHOT
Summary: oh_snaptu

Reviewed By: nikoant

Differential Revision: D20067793

fbshipit-source-id: d097603a3efc822b276dd6de07cb3fa108853409
2020-02-24 06:53:42 -08:00
Pascal Hartig
6c72fa3dbb Flipper Release: v0.32.0
Summary:
== Highlights ==

- Android: Theme information for Application, Activity and View descriptors are now visible in the Layout plugin. (6f4de969fb)
- App Visualiser: When importing an archived device, you can now see and inspect the last screen of the app. (20db85adf4)

== Fixes ==

- Fix `FlipperKit` warnings in XCode. (972277b031)
- Upgrade Folly to v2020.02.17.00 (GH809)
- Several performance improvements, originally caused by unnecessary rerenders.
- Crash reports weren't scrollable. (e1e8bb841c)
- Kill orhpaned instruments processes. (GH819)

Reviewed By: nikoant

Differential Revision: D20067792

fbshipit-source-id: 3f0ebcb03881373fd909f513e5d82e23a5f9f1f1
2020-02-24 06:53:42 -08:00
Anton Nikolaev
f6cc7c93ef Typescriptify the main process code (5/N)
Summary: Use dev bundling for "yarn start"

Reviewed By: jknoxville

Differential Revision: D20034300

fbshipit-source-id: a46c75074c969f5a4958f498c5c0e15aab808552
2020-02-24 05:23:47 -08:00
Anton Nikolaev
bd0c7bb58f Typescriptify the main process code (4/N)
Summary: Skip the main process code bundling when nothing changed

Reviewed By: mweststrate

Differential Revision: D20030261

fbshipit-source-id: 78de87377afe7e768627059425c51081239687dd
2020-02-24 05:23:47 -08:00
Anton Nikolaev
89180d0b07 Typescriptify the main process code (3/N)
Summary: Fixed yarn commands "lint" and "reset" considering the new static folder structure

Reviewed By: mweststrate

Differential Revision: D19972963

fbshipit-source-id: 323cc87598e14ccea30aa7dc5fc8c10a2e0c2db7
2020-02-24 05:23:46 -08:00
Anton Nikolaev
0c778af679 Typescriptify the main process code (2/N)
Summary: Converted main.js and setup.js to typescript

Reviewed By: mweststrate

Differential Revision: D19972273

fbshipit-source-id: f777be737da4233de4d7df3d549206efabfeeadf
2020-02-24 05:23:46 -08:00
Anton Nikolaev
18c259dc22 Typescriptify the main process code (1/N)
Summary:
As a first step I've configured bundling for the main process code using Metro. For now I haven't converted anything to ts, just made that possible.

The bundle is just produced into the "static" directory. To avoid too many changes I kept the "static" folder as it is, but probably non-static code should be moved from there.

Also installed modules from "node_modules" for the main process are not bundled to avoid potential issues with node native modules.

Reviewed By: mweststrate

Differential Revision: D19960982

fbshipit-source-id: efbd426254e2b37c913c5f5f75f042c50ccee2f3
2020-02-24 05:23:45 -08:00
Chaiwat Ekkaewnumchai
b5256abd0c Upgrade electron
Summary:
Tried to upgrade both electron and electron-builder but failed due to Windows binary build stuck.

Upgraded only electron for now. electron-builder will be upgraded separately

Reviewed By: nikoant

Differential Revision: D19877865

fbshipit-source-id: a2282c2f4062e6b470cdcba2e9e693419bfeaec4
2020-02-24 03:24:59 -08:00
Chaiwat Ekkaewnumchai
e5f8b93426 Add Icon
Reviewed By: nikoant

Differential Revision: D20035269

fbshipit-source-id: 902479068b2ecf9731bc90dd91222d5765120d6c
2020-02-24 03:22:35 -08:00
John Knox
51f62ff602 Fix artifact path in android-sample.yml (#820)
Summary:
This workflow is currently building the android app and then trying to upload the mac app (which isn't built) which is failing.

I think it should be uploading the android app instead.
Pull Request resolved: https://github.com/facebook/flipper/pull/820

Reviewed By: passy

Differential Revision: D20035055

Pulled By: jknoxville

fbshipit-source-id: 08367d464a045b47cf1b8b5395fd2151793a23cf
2020-02-24 02:16:59 -08:00
John Knox
20db85adf4 Add archived device visualizer
Summary:
Adds a visual indicator of layout nodes when using an archived device.

The "device" window isn't movable for some reason. I've tried the movable and draggable attributes but with no luck. It would obviously be good to fix that but I think its probably shippable as is, and I don't have any more ideas about how to do it.

Reviewed By: passy

Differential Revision: D19885719

fbshipit-source-id: 186ba38c85afee18ce111e30187bdccd9b919025
2020-02-21 07:19:13 -08:00
John Knox
c2dfa6ca6b Kill orphaned instruments processes (#819)
Summary:
Fix https://github.com/facebook/flipper/issues/808
Kills any orphaned Instruments processes belonging to the user.

In some cases, we've seen interactions between Instruments and the iOS
simulator that cause hung instruments and DTServiceHub processes. If
enough instances pile up, the host machine eventually becomes
unresponsive. Until the underlying issue is resolved, manually kill any
orphaned instances (where the parent process has died and PPID is 1)
before launching another instruments run.

Taking the same approach as done by flutter here.

Reviewed By: passy

Differential Revision: D20030005

Pulled By: jknoxville

fbshipit-source-id: aa80be78c80f7797e88bf29b15f90d4aad0c66e4
2020-02-21 06:53:44 -08:00
Michel Weststrate
4aec81b059 Fix issue where messages where not queued for non-selected apps
Summary: When determing whether to queue a message, the logic checked if the plugin is enabled on the currently selected app, rather than checking if it is enabled for the receiving app. This diff fixes that.

Reviewed By: passy

Differential Revision: D20000055

fbshipit-source-id: 665f0a650dcee8f7f46aa56f399a4f7d0d0aa1e0
2020-02-21 04:46:23 -08:00
Andrey Mishanin
adce24d343 Displaying identifier for root views
Summary: Adding the new "Identity" section to CK root views' description.

Reviewed By: cuva

Differential Revision: D19948784

fbshipit-source-id: f5e7fe51afd387a476f6500db32b8b5149594007
2020-02-21 04:25:16 -08:00
Pritesh Nandgaonkar
233b6d6a4e Update getting started guide
Summary:
Updated documentation for RN.

This fixes the documentation issue posted here https://github.com/facebook/flipper/issues/816

Reviewed By: mweststrate

Differential Revision: D20007620

fbshipit-source-id: 118e62450ad0c99346277d5205d637b7ecbae5c6
2020-02-21 04:23:22 -08:00
Anton Nikolaev
e1e8bb841c Cannot scroll with crash report
Summary: Fixed scroll for crash reported plugin

Reviewed By: mweststrate

Differential Revision: D19975593

fbshipit-source-id: 756c017e8a6e5e5e1309be5787bc88dd2ac97bca
2020-02-21 03:51:19 -08:00
Pascal Hartig
05a1c70bc7 Set up separate cli tool
Summary:
Discussed that we want this to be both a library and a CLI
tool. Also added a README stub.

Reviewed By: nikoant

Differential Revision: D19969788

fbshipit-source-id: 2c54935ce5953d2053c7bdf601debe0e5e911647
2020-02-21 03:51:19 -08:00
Pascal Hartig
eaf253e60f Enable greenkeeper (#813)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/813

^

Reviewed By: nikoant

Differential Revision: D19969789

fbshipit-source-id: 6bc10acc12707fcbea618580e57bf15e5fe7987e
2020-02-21 03:51:19 -08:00
Pascal Hartig
e54b8f06f8 Bump all packages
Summary: Enabling greenkeeper in the next diff.

Reviewed By: nikoant

Differential Revision: D19969790

fbshipit-source-id: 9a81c0505429512dc2e70523ab0b87eb0c6a2050
2020-02-21 03:51:18 -08:00
Michel Weststrate
64b06ba6f6 Fixed some issues with too many devices showing up in the sidebar
Summary:
Device management was inconsistent so far, this diff addresses the following issues

* pending a subtle timing issue, a physical android device might also show up as emulator, so effectively the device would be shown twice, but with the same content
* Metro devices now behave more like the android devices: offline devices are replaced if it comes online again
* Generalized this logic; the reducer now forces serials to be unique
* Fixed issue where a Metro device that disconnected due to a connection failure would be archived twice
* Use the metro connection url as serial, to have a slightly more future proof serial

Reviewed By: jknoxville

Differential Revision: D19996385

fbshipit-source-id: 0f6e3ddc6444542553d25cc3b592591652d688f2
2020-02-20 12:56:24 -08:00