Summary: When running tests locally, some are quite flaky, and there is a lot of error logging noise. This diff doesn't remove all of it, but does reduce it significantly.
Reviewed By: nikoant
Differential Revision: D20034619
fbshipit-source-id: 183f74475b644f803b2f92b1b1301f4d0f6e193a
Summary:
We were losing the first argument of every console.error call during tests.
This happens to be useful stuff, like react telling you how to do better testing etc, and explains the weird looking error output from the ConfigField tests.
Reviewed By: passy
Differential Revision: D17931532
fbshipit-source-id: cfeb834a4646ef68ac55f81a269bcfef7a25ea31
Summary: Taking another stab at adding some lint rules to make it harder to shoot yourself in the foot. Hopefully nothing too controversial. Preferring spread and rest should lead is more readable and there's no downside when using ES6. The "useless" rules are just things like renaming imports to the original name which should only happen during refactors.
Reviewed By: jknoxville
Differential Revision: D16180453
fbshipit-source-id: 1cf6851b7726c0aee953ec7cf7dd6fa0aca32253
Summary: Per title. Required as Scribe is now being used for device tests.
Reviewed By: jknoxville, danielbuechele
Differential Revision: D13971892
fbshipit-source-id: 2df36d44d4e45a579cc9cca0d4cad9105ba8a383
Summary:
It's a bit hacky but apparently the recommended solution:
https://stackoverflow.com/questions/28615293/is-there-a-jest-config-that-will-fail-tests-on-console-warn
This will bail when a call to `console.error` is used in a test.
If you *need to* use console.error in a test, then mock it.
This will likely not pass yet, but let's fix all failures and then land it.
Reviewed By: danielbuechele
Differential Revision: D13898383
fbshipit-source-id: 0ca222a07433a9a311dc6bdf0d264342a59208be
