Summary:
In D25244631 (92bd68a371) we bumped the react-native dep of Flipper but we didn't apply the migration guide (sorry for missing that in the review), so the ReactNativeExample fell apart when trying to build for iOS. This diff applies the migration guide which nicely fixes that:
https://react-native-community.github.io/upgrade-helper/?from=0.62.2&to=0.63.4
Recreating the Podfile.lock and running `./gradlew clean` fixed all build problems after that.
Verified that `yarn ios` and `yarn android`, and building from XCode all work.
Found (probably unrelated / existing) issues:
* custom plugins only show up after initial app start after refreshing the plugin list by navigating to another diffs first, so this seems to be a UI staleness bug
* Network plugin doesn't seem to work ion iOS (either not showing traffic or not showing data at all)
Reviewed By: passy
Differential Revision: D25755490
fbshipit-source-id: baea8b152fb252deda04291ec197ab87c2fbe3eb
Summary:
After `react-native-flipper` 0.48.0 I cannot build releases on android (I think that passed on CI tests because the example was running an older version of this package, 0.47.0).
So I moved all the `android/src/main` content to `android/src/debug` because we will not use Flipper in another Build Variant
## Changelog
I moved all content from `react-native-flipper/android/src/main` to `react-native-flipper/android/src/debug`.
Probably solves https://github.com/facebook/flipper/issues/1303
Pull Request resolved: https://github.com/facebook/flipper/pull/1325
Test Plan: Maybe create a custom CI script to verify if Flipper deps are present on Release Builds, [something like this](https://github.com/facebook/flipper/issues/1274#issue-641197153)
Reviewed By: cekkaewnumchai
Differential Revision: D22333432
Pulled By: passy
fbshipit-source-id: 4abbab5ecbe08d44752b2138569ff60d25724087
Summary:
This should fix https://github.com/facebook/flipper/issues/1274
I had some cleaning up to do to get to this point.
Changelog:
Fix `react-native-flipper` dependency pulling in debug-only artifacts into release builds.
Reviewed By: mweststrate
Differential Revision: D22160304
fbshipit-source-id: 0ebc0ed942427f2966bccd721bf01aafa38ba400
Summary: Added some UI so that we can manually verify that logging and network inspection is working in RN + Flipper.
Reviewed By: jknoxville
Differential Revision: D20668428
fbshipit-source-id: 4271595583e055b2b0324b3da7ac216c39717093
Summary: We won't use them so this is just dead weight that's going to break at some point.
Reviewed By: jknoxville
Differential Revision: D19470548
fbshipit-source-id: 3def22e6f5db2923d5551d7b6a3472cb4364186c
Summary:
This diff creates a sample React Native project (based on the 0.62-rc.0 template).
This example is created like:
(Documenting this here as in the future this might be easier than upgrading the project itself)
1. Run `npx react-native init ReactNativeFlipperExample --version 0.62.0-rc.0`
2. Follow the installation steps to enable Flipper, that is, call `initializeFlipper(this, getReactNativeHost().getReactInstanceManager());` at the end of the `onCreate` method in `MainApplication.java`
3. Put `FlipperTicTacToe` in the root of the project, and call it from `App.js` as a component
4. install `react-native-flipper` as dependency
5. install `relative-deps` as dev dependency, and set it up as shown in `package.json`. This tool make sure that we build and test this project against the version of react-native-flipper in this repository, rather than against the one on NPM.
6. removed some stuff, like tests and linting, which is just in the way in this repo
This PR does not support iOS, as Flipper + RN iOS is still broken in 0.62.0-rc.0, and the current version of react-native-flipper doesn't support iOS yet either.
Documentation on how to set up Flipper in general is not part of this Diff
_N.B. since this is a **public** project, to be visible and runnable by our OSS community, the build setup is kept plain, vanilla, react-native, and **not** wired up to our normal / internal build processes. This is also the reason that lint suggestions beyond the license headers have been ignored. If any others should be applied, it is probably the official react native template that requires updating_
Reviewed By: passy
Differential Revision: D19449295
fbshipit-source-id: 2aeb6044f8dd01f09a95350c84fff2419d685a65
