Commit Graph

6 Commits

Author SHA1 Message Date
Lorenzo Blasa
aed7e7e6f2 UI preview of selected element
Summary:
This is a prototype for view preview within Flipper for iOS (Android next).

If enabled, a preview of the selected element is rendered in the attribute inspector.

Changelog: Add view preview/snapshot for the Layout plugin on iOS.

Reviewed By: antonk52

Differential Revision: D34990372

fbshipit-source-id: 1984514fbf59041ad236008a8db10569c5fc5f94
2022-03-28 05:17:23 -07:00
Andres Suarez
79023ee190 Update copyright headers from Facebook to Meta
Reviewed By: bhamodi

Differential Revision: D33331422

fbshipit-source-id: 016e8dcc0c0c7f1fc353a348b54fda0d5e2ddc01
2021-12-27 14:31:45 -08:00
Pritesh Nandgaonkar
966a027c5b Add dependencies to layouthelper and ios descriptor pods (#2140)
Summary:
This diff makes sure that pod lib lint succeeds and the CI is green for iOS.

It got broken when I landed my changes for the refactoring of FlipperKitLayoutPlugin. It wasn't picked up by flipper-oss-ios-job as it builds sample app and sample app had all the paths to the header search path which individually FlipperKitLayoutHelpers and FlipperKitIOSDescriptors were missing.

I will add the validation of pods as a job in sandcastle when one touches FlipperKit pods, this will avoid such cases in future.

## Changelog

Pull Request resolved: https://github.com/facebook/flipper/pull/2140

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

iOS jobs are green on CI in GH.

Reviewed By: passy

Differential Revision: D27417743

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 17aa4b04bf9954c4bd138261103751a245409568
2021-03-31 04:30:03 -07:00
Xiangxin Sun
a783c0d691 Revert D27328277: add macOS deps to shared libraries
Differential Revision:
D27328277 (7c44d4d4f0)

Original commit changeset: f22d1e9f6a54

fbshipit-source-id: bc893df5ba5a0bd9d47eeab4ff345e7c5047da9b
2021-03-29 20:11:37 -07:00
Kyle Cui
7c44d4d4f0 add macOS deps to shared libraries
Summary: Add macOS dependencies and alternative classes to the libraries that FlipperKitLayoutPlugin needs to function.

Reviewed By: priteshrnandgaonkar

Differential Revision: D27328277

fbshipit-source-id: f22d1e9f6a5415cee0bae8eaada653be5f5467b3
2021-03-29 16:13:24 -07:00
Pritesh Nandgaonkar
790f23301e Refactor Layout Plugin
Summary:
This diff moves the iOS descriptors and other layout helpers into its own buck target. Earlier everything was part of the FlipperKitLayoutPlugin target. When kcui, tried to add macos descriptors, we realised that FlipperKitLayoutPlugin doesn't have macos platform in it and thus he had to put #if TARGET_OS_SIMULATOR check in iOS descriptors and at some other places.

In order to make the integration easier I decided to split the Layout Plugin in following way.

```
FlipperKitLayoutPlugin
  -> FlipperKitLayoutIOSDescriptors (platform set as IOS)
  -> FlipperKitLayoutHelpers (used in iOS Descriptors and usefule for Macos too)
  -> FlipperKitLayoutMacOSDescriptors(coming soon by kcui)(platform set as MacOS)

```

Reviewed By: kcui

Differential Revision: D27127587

fbshipit-source-id: f108ef81914297e93c886fe53dabf0a4bf11ebc1
2021-03-25 16:00:28 -07:00