Commit Graph

486 Commits

Author SHA1 Message Date
Anton Kastritskiy
4439411d29 bump or ignore types packages
Reviewed By: LukeDefeo

Differential Revision: D48782825

fbshipit-source-id: 00c46fa609847272b48f8f4476291666e9251c95
2023-09-04 14:52:34 -07:00
Andrey Goncharov
d80a7a45b6 Fix growing tab height
Reviewed By: antonk52

Differential Revision: D48908996

fbshipit-source-id: 6eb0a53f32d0130661c3e2c161063e87ab3ff884
2023-09-01 10:08:04 -07:00
Andrey Goncharov
93e19aba40 Fix growing Tabs
Reviewed By: antonk52

Differential Revision: D48908704

fbshipit-source-id: b5f761ef2c3b81f0c7e4a36a8122a10957a96ebd
2023-09-01 10:08:04 -07:00
Andrey Goncharov
0ce8fe6625 Fix Tabs
Reviewed By: lblasa

Differential Revision: D48908416

fbshipit-source-id: 1e8b0d84b313fe10629d6ff16162294fa5cb395c
2023-09-01 10:08:04 -07:00
Andrey Goncharov
caf55f5b12 Support STRING_SET operator type
Summary:
Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Data table integration comes later

Reviewed By: lblasa

Differential Revision: D48648822

fbshipit-source-id: 74f92c0e818c4507fd6575f6a122d107373cfe0c
2023-08-30 07:26:35 -07:00
Andrey Goncharov
2affcbdfb1 Support ENUM_SET operator type
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48648499

fbshipit-source-id: ee24ae15c1e6533398db0af79597388e473f97e7
2023-08-30 07:26:35 -07:00
Andrey Goncharov
e5147784a9 Polish spacing
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48644764

fbshipit-source-id: 1da41635f349da1d320c25175dd9a8d2b82d3c73
2023-08-30 07:26:35 -07:00
Andrey Goncharov
cb6dd36dc1 Support absolute date operator type
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48644510

fbshipit-source-id: 0a1a382f3052c0e1e1f78ad6e8c51211fb78f9ce
2023-08-30 07:26:35 -07:00
Andrey Goncharov
7b9ddb617f Remove last search term on backspace press when term finder is empty
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48637890

fbshipit-source-id: fb952ffe1ab1a94d2bc465b89be6c62a71be9b9f
2023-08-30 07:26:35 -07:00
Andrey Goncharov
52a4051b15 Refine NO_VALUE renderer
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48637454

fbshipit-source-id: acc1926036e981c28ad678c2a3c1b7f0d5b9f992
2023-08-30 07:26:35 -07:00
Andrey Goncharov
857e2d2ead Support enum operator type
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48605906

fbshipit-source-id: d81243fbc8b33e366e9207f282ba42808cfab533
2023-08-30 07:26:35 -07:00
Andrey Goncharov
f9d5d713ef Support no_value operator type
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48605550

fbshipit-source-id: 3c555c5cf2928e2a87686dff4c68516338203197
2023-08-30 07:26:35 -07:00
Andrey Goncharov
f16ff8ade4 Remove extra operators
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48605289

fbshipit-source-id: f3168a8db4532ddd368a96f013749e4abc627e0f
2023-08-30 07:26:35 -07:00
Andrey Goncharov
9bca358ab2 Support float operator type
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48605219

fbshipit-source-id: 9b919fe59278f77cdbbc036948eb04d585b25baa
2023-08-30 07:26:35 -07:00
Andrey Goncharov
143dce85f1 Support integer operator type
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48605154

fbshipit-source-id: 4662b61b217568e593f6b65c8b4dd1d99ea5606a
2023-08-30 07:26:35 -07:00
Andrey Goncharov
a9fb5d9863 Extract PowerSearchStringTerm
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48601912

fbshipit-source-id: 90f67f1ea19ef6ae8b5d92f26894af2ab20fa821
2023-08-30 07:26:35 -07:00
Andrey Goncharov
380e99400f Simplify config
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48600255

fbshipit-source-id: a57504519000fce4544f6875b2933cd5bcaedba3
2023-08-30 07:26:35 -07:00
Andrey Goncharov
e87ec62552 Remove ordering support for mvp
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48600046

fbshipit-source-id: 9ded79616a822759f0c74dd1e5c6ce6c120b8350
2023-08-30 07:26:35 -07:00
Andrey Goncharov
bee42f442e Expose external API
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48599785

fbshipit-source-id: ae5835ece1299d26dcaeb3cb66668aa919900a85
2023-08-30 07:26:35 -07:00
Andrey Goncharov
a492b32bd3 Extract PowerSearchTermFinder
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48599226

fbshipit-source-id: 29c5a8182312e5f8c09d78d5cc223ef65cfc841d
2023-08-30 07:26:35 -07:00
Andrey Goncharov
c9ab951e84 Extract PowerSearchTerm
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48599166

fbshipit-source-id: 13b447b55408a8673928489312c4d22cf864c232
2023-08-30 07:26:35 -07:00
Andrey Goncharov
2c5bcb373d Extract container
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: LukeDefeo

Differential Revision: D48560381

fbshipit-source-id: ecdc6bb95514faf913b23239bbd40113b8e0f57b
2023-08-30 07:26:35 -07:00
Andrey Goncharov
729c60f711 Shift focus to entering next search term when finish editing the curretn one
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48559678

fbshipit-source-id: 88075c473f8296a6d734116e9f2b02e941b3d7c7
2023-08-30 07:26:35 -07:00
Andrey Goncharov
194c08a12c Support keyboard
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48559580

fbshipit-source-id: 683969879c213b869faadc60c6caab8f716b8688
2023-08-30 07:26:35 -07:00
Andrey Goncharov
0633658cee Filter power search term options
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48558180

fbshipit-source-id: 311d5ed1859d0a31f85942772a956c46f58be46e
2023-08-30 07:26:35 -07:00
Andrey Goncharov
44c3f53905 Support removing search terms
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48557277

fbshipit-source-id: edaa5e8806538fa308d43c364e4f68967c1bf2ac
2023-08-30 07:26:35 -07:00
Andrey Goncharov
7061de44fe Support entering freeform search values
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48556764

fbshipit-source-id: aa2d77ce111e33ebe5d936c30d23ed78ca0e2c2e
2023-08-30 07:26:35 -07:00
Andrey Goncharov
c091067902 Update antd
Summary:
Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Required to get `Space.Compact`

allow-large-files

Reviewed By: passy

Differential Revision: D48520383

fbshipit-source-id: 000a5c16c00541455dc4a31c4fddb2c4c252a89e
2023-08-30 07:26:35 -07:00
Andrey Goncharov
795d02d00c Separate search term parts
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48520106

fbshipit-source-id: 2a544230f182bd82023310ea88742fab44e2df9b
2023-08-30 07:26:35 -07:00
Andrey Goncharov
c746a11dc6 Allow multiple search terms
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48519758

fbshipit-source-id: d691a26ebed9f7797516386b8fb9d4457b870a3e
2023-08-30 07:26:35 -07:00
Andrey Goncharov
9cdf944716 Compute Autocomplete options from config
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48518324

fbshipit-source-id: 5abee77cca10f03b2d9fa5b62802a5000152248e
2023-08-30 07:26:35 -07:00
Andrey Goncharov
b780dc0598 Add basic Autocomplete
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48517919

fbshipit-source-id: ec6e723a595862b61722db9c5afd96138264dfdc
2023-08-30 07:26:35 -07:00
Andrey Goncharov
839653c8fa Add PowerSearch example config
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48468962

fbshipit-source-id: e86be373be324b44656f2ed0d9f66bf969d47a6b
2023-08-30 07:26:35 -07:00
Andrey Goncharov
d54bd8938a Add PowerSearch basic types
Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48467956

fbshipit-source-id: 7f5303d981831c261bf5e4fe0027883fd1e7d873
2023-08-30 07:26:35 -07:00
Pascal Hartig
7ce86869e4 Build plugins with ES2021
Summary:
Starting small as this will unblock D48642120.

If it works without causing any issues, I'll update the remaining ones.

We're on Node v18 everywhere now, so this should be compatible. According to https://node.green/ that should cover nearly everything.

Reviewed By: lblasa

Differential Revision: D48683680

fbshipit-source-id: 26d2788468b673793b70b6339d1845c1dcf7e05d
2023-08-25 09:43:01 -07:00
Luke De Feo
3ff0c301c8 Use exact mode when user explicitly filters on a column
Summary: Using substring doesnt make sense for these actions. As you say I want to filer on this cell but it includes many others

Reviewed By: aigoncharov

Differential Revision: D48515476

fbshipit-source-id: b7a77c022052bb33e2ce2a3f656dabab114d8a78
2023-08-21 05:59:44 -07:00
Luke De Feo
f5bc03c263 Add framework event node level event filtering
Summary: Lets you filter a nodes events by thread or type

Reviewed By: lblasa

Differential Revision: D48346955

fbshipit-source-id: 455d65ad21c54c5ad26782ac6a446f7ae15a4356
2023-08-21 04:24:16 -07:00
Luke De Feo
2d217575bb improve marker timeline
Summary:
1. removed background hover
2. made can select actually work
3. disable user selection
4. remove decimal points from ms

Reviewed By: lblasa

Differential Revision: D48270181

fbshipit-source-id: 724efedb5cad7f93c80ed5dd7f49efe4c434c324
2023-08-21 04:24:16 -07:00
Lorenzo Blasa
ff6f98fc0d Import File implementation
Summary: Implementation was missing for the browser. This provides a default implementation.

Reviewed By: aigoncharov

Differential Revision: D48311198

fbshipit-source-id: fd067600f571234e0fbccfb90853b62f175ff8fb
2023-08-14 11:33:06 -07:00
Andrey Goncharov
2834d3300a Track filtering and searching for data table
Reviewed By: mweststrate

Differential Revision: D48116067

fbshipit-source-id: 2dee2cfd68a23e1153b3f10ff229009777e936da
2023-08-09 08:01:44 -07:00
Hamdullah Shah
0fdd901297 DataDescriptor BigInt
Summary: The `DataDescriptionType` accepts the `BigInt` type but it doesn't render. Added the `case` for that and reuse the `NumberValue` tag for it.

Reviewed By: aigoncharov

Differential Revision: D48152012

fbshipit-source-id: 32ebc8a37df34d57b40c7ecdad331c547415b335
2023-08-08 09:50:08 -07:00
Luke De Feo
3282417663 Fix bug where if events come in the creation of a new tab throws exception
Summary:
See title. The issue occurs because this tabs component derives a key by essentially serializing the children. Since its possible for different elements in the UIDebugger to have different number of tabs, due to framework events not always being present this was never anticipated.

Solution is to just let the callee supply a storage key which does not depend on the exact number of tabs

Reviewed By: lblasa

Differential Revision: D47520033

fbshipit-source-id: 67e57db5110fde52451d30496c25a25b0eb4a6f7
2023-07-19 08:58:20 -07:00
Lorenzo Blasa
532f6ff1ee App Inspect rounded container
Summary: ^

Reviewed By: antonk52

Differential Revision: D47591057

fbshipit-source-id: 5f3f308fb252245ebe510dd98b4cbd7ea7c6e27e
2023-07-19 06:12:07 -07:00
Andrey Goncharov
b55d730dd7 Integrate filter exceptions with DataTable
Summary: See previous diff for context

Reviewed By: LukeDefeo

Differential Revision: D47472005

fbshipit-source-id: 6e7d8873d275f826c38fab16c72e1621fd2784e1
2023-07-18 05:25:59 -07:00
Anton Kastritskiy
bdd502d54f navbar placeholder
Reviewed By: elboman

Differential Revision: D47398098

fbshipit-source-id: 6e9518b47292b351153015da233574f7abfd0396
2023-07-18 03:52:34 -07:00
Michel Weststrate
c8776175c3 Added support for secondary indices for fast lookups
Summary:
Add support for secondary indices, to allow for cheap lookups, like a set of events for a specific UI element in the events table:

```

#### getAllRecordsByIndex

Usage: `getAllRecordsByIndex({ indexedAttribute: value, indexAttribute2: value2, .... })`

This method allows fast lookups for objects that match specific attributes exactly.
Returns all items matching the specified index query.
Note that the results are unordered, unless
records have not been updated using upsert / update, in that case
insertion order is maintained.
If no index has been specified for this exact keyset in the indexQuery (see options.indices), this method will throw.

Example:
```

```
const ds = createDataSource([eatCookie, drinkCoffee, submitBug], {
  key: 'id',
  indices: [
    ['title']
    ['id', 'title'],
    ['title', 'done'],
  ],
});

// Find first element with title === cookie (or undefined)
const todo = ds.getFirstRecordByIndex({
    title: 'cookie',
})

// Find all elements where title === cookie, and done === false
const todos = ds.getAllRecordsByIndex({
  title: 'cookie',
  done: false,
})
```

Reviewed By: antonk52

Differential Revision: D47396435

fbshipit-source-id: 20c4527be83532863b9b07ab20ebf20a80c3c35d
2023-07-14 07:46:52 -07:00
Andrey Goncharov
1c532095ab Expose suggestNewPlugin as a shared util
Reviewed By: antonk52, ivanmisuno

Differential Revision: D46798839

fbshipit-source-id: f2b942a138a998f167b60c04c32c634545bbfe96
2023-06-16 08:29:54 -07:00
Andrey Goncharov
16b4d58ac3 Support filtering by exact match
Summary: Project: https://docs.google.com/document/d/1SbFrpvfIShX5npANNa1AkgHliR1M-VMLW5Q9RhREt94/edit

Reviewed By: antonk52

Differential Revision: D46642517

fbshipit-source-id: e23eead18189adb9aaacb7eab3244cfce289203e
2023-06-12 07:29:55 -07:00
Andrey Goncharov
b9322247e6 Make assert stable ref error more explicit
Reviewed By: ivanmisuno

Differential Revision: D46359534

fbshipit-source-id: 002e4e8ae9168cf2cf3b652fc853416de825861f
2023-06-06 03:44:48 -07:00
Anton Kastritskiy
12734d6b7e allow column filter to be loose
Summary:
Until now when we filter by a column value we only get the items that match this value exactly.

Release: we can add loose filters that match value or `undefined`

Reviewed By: lblasa, ivanmisuno

Differential Revision: D46318631

fbshipit-source-id: 94ecb3f074674d4b0ce3a480f4f3b9ddc058ceef
2023-06-01 06:51:41 -07:00