Michel Weststrate
1a8566c988
Make sure images are rendered
...
Summary: iOS counterpart for D23370743
Reviewed By: jknoxville
Differential Revision: D23397044
fbshipit-source-id: b38113615ef8c14b26700ec638b173061c75cd7e
2020-09-02 05:13:07 -07:00
Mark Tolmacs
e44c7f4062
Fix IOS crash in Network Plugin due to incorrect processing of data U… ( #978 )
...
Summary:
Fix IOS crash in Network Plugin due to incorrect processing of data URLs (https://github.com/facebook/flipper/issues/974 )
Fix https://github.com/facebook/flipper/issues/974 by skipping response processing in FlipperKitNetworkPlugin.mm if the response is not an instance of NSHTTPURLResponse, which data URLs are not. My assumption is that data URLs are not the ones Flipper Network Plugin users are interested in, given the type of information being extracted in the didObserveResponse method which are only present in NSHTTPURLReponse types.
## Changelog
Fix IOS crash in Network Plugin due to unchecked casting of data URLs
Pull Request resolved: https://github.com/facebook/flipper/pull/978
Test Plan:
1. `npx react-native init issue974 --version react-native@0.62 .1`
2. `cd issue974/ios/Pods/FlipperKit/iOS/Plugins/`
3. `curl -L https://patch-diff.githubusercontent.com/raw/facebook/flipper/pull/978.patch | git apply -v -p3`
4. `cd ../../../../../`
5. `curl -L https://github.com/facebook/flipper/files/4434063/rn-data-uri-test.patch.txt | git apply -v
react-native run-ios`
6. Verify that the app does not crash the IOS app with
```
Terminating app due to uncaught exception 'NSInvalidArgumentException', reason:
'-[NSURLResponse allHeaderFields]: unrecognized selector sent to instance <memaddr>'
```
#### The React Native app patch used to verify the PR working and resolving the issue https://github.com/facebook/flipper/issues/974
[rn-data-uri-test.patch.txt](https://github.com/facebook/flipper/files/4434063/rn-data-uri-test.patch.txt )
Reviewed By: mweststrate
Differential Revision: D20861168
Pulled By: cekkaewnumchai
fbshipit-source-id: bae960650ecc0efbb8ae4641aba4c62c74f06bf0
2020-04-08 03:08:58 -07:00
Pritesh Nandgaonkar
e8b20d5b15
Run CLANGFORMAT on plugins
...
Summary:
This diff runs CLANGFORMAT lint on plugins. I have added CLANGFORMAT as the lint engined for objc files in xplat/sonar. Right now the iOS folder is not formatted according to CLANGFORMAT.
Ran `arc lint -a --paths-cmd "find ./iOS/Plugins -type f" --verbose`
Reviewed By: passy
Differential Revision: D19942173
fbshipit-source-id: 8b975b0a344df073b02d69cd1f9ee5629af2799d
2020-02-17 10:49:18 -08:00
Andres Suarez
0675dd924d
Tidy up Flipper license headers [1/2]
...
Reviewed By: passy
Differential Revision: D17863711
fbshipit-source-id: 259dc77826fb803ff1b88c88529d7f679d3b74d8
2019-10-11 13:46:45 -07:00
Andres Suarez
c4c5d453c2
Fix license headers
...
Reviewed By: scottrice
Differential Revision: D17673481
fbshipit-source-id: 1794e0a6e92e6894b5634b24c6e7910847616261
2019-09-30 15:10:17 -07:00
Pascal Hartig
bbee7a3357
Update iOS license headers (and more)
...
Summary: Add the affiliates bit that the linter is checking for.
Reviewed By: jknoxville
Differential Revision: D15164826
fbshipit-source-id: 500ffe89ec0c2fd3acfbc374408d16a337cecfa4
2019-05-02 03:28:07 -07:00
Pritesh Nandgaonkar
02ac3ff9cd
Rename SonarKitNetworkPlugin
...
Summary: Renames SonarKitNetworkPlugin
Reviewed By: passy
Differential Revision: D9968092
fbshipit-source-id: 6d5b7761405be9b47e679510ce6fc7f2a84c308b
2018-09-21 03:45:54 -07:00
