Commit Graph

5 Commits

Author SHA1 Message Date
Scott Wolchok
6cfdf1a8a9 Delete second argument to FB_LINK_REQUIRE_
Summary: It is now always NAME.

Reviewed By: adamjernst

Differential Revision: D13577665

fbshipit-source-id: 9d9330fd17b7e214ef807760d0314c34bd06ebd5
2019-01-08 16:53:05 -08:00
Scott Wolchok
864327c9e5 Delete FB_LINK_REQUIRE_EXT
Summary: It is unused per ibgs

Reviewed By: adamjernst

Differential Revision: D13577666

fbshipit-source-id: e8ba16bf8aacfee178d2fdaea367903107cd3b62
2019-01-08 16:53:05 -08:00
Pritesh Nandgaonkar
a5585aa7e7 Add FBMacros file (#198)
Summary:
It was deleted in one of the previous commit and it broke the build
Pull Request resolved: https://github.com/facebook/flipper/pull/198

Reviewed By: passy

Differential Revision: D9117234

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 72d9d58a11683b8a51732b3f735ef1326ce56794
2018-08-01 06:55:58 -07:00
Noah Gilmore
68789e7c96 Fix Obj-C and Swift builds which are broken in v0.6.13 (#192)
Summary:
9f807c introduced a new subspec in SonarKit.podspec, which caused Cpp header files to be included in `SonarKit-umbrella.h`, causing all non-ObjC++ project integrations to fail to build (see #190 for more info). SirArkimedes and I investigated this today and found the fix:

1. Make the `CppBridge` subspec's header files private
2. Add a hack to make Cocoapods copy `FBMacros.h` into `{PODS_ROOT}/Headers/Public/SonarKit`, since otherwise `#import "FBMacros.h"` in `SonarKit-umbrella.h` will fail to resolve in out-of-the-box projects.

I've put up a branch [here](https://github.com/noahsark769/sonar-testing-example-projects/tree/working_reference) which pulls the pod from this branch and verifies that the fix works.

Fixes #190
Pull Request resolved: https://github.com/facebook/Sonar/pull/192

Reviewed By: passy

Differential Revision: D9049420

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 9383016975607e897085323d64ad44a068199918
2018-07-31 09:56:15 -07:00
Pritesh Nandgaonkar
89d28d1188 Moved FBDefines to xplat
Summary: Moved FBDefines to xplat

Reviewed By: passy

Differential Revision: D8895202

fbshipit-source-id: 3edfcecade7c67a0ddfc5c64bb4454df65cbcc93
2018-07-19 04:31:00 -07:00